Summary:
go binaries with -c opt have their debug symbols stripped by the go_binary rules.

One way to prevent this is to pass the --strip=never flag.

Right now this applies globally, so C++ fastbuild targets are affected too.

When we upgrade io_bazel_rules_go, there's a better way to do this.

If someone knows a better way in the meantime, I'm all ears.

Test Plan: Jenkins

Reviewers: zasgar, yzhao, #engineering

Reviewed By: zasgar, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D4853

GitOrigin-RevId: 2eaa8b97a82421087b39a1baca13346d7d627014

Summary: This allows to run bpf test without needing to set the --strategy flag.

Test Plan: Jenkins

Reviewers: oazizi, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D3630

GitOrigin-RevId: b9a9bd8cbbf901cf3562c0f4cfd0a0a2d303cf1b

Summary: Abort on errors is causing issues.

Test Plan: tested using skaffold..

Reviewers: michelle, #engineering, oazizi

Reviewed By: michelle, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D3408

GitOrigin-RevId: bd39867346263ba22b67df40c729364a84d4539c

Summary: This gets rid of a bazel warning.

Test Plan: N/A

Reviewers: michelle, philkuz, #engineering, oazizi

Reviewed By: #engineering, oazizi

Differential Revision: https://phab.corp.pixielabs.ai/D3407

GitOrigin-RevId: 9e7d03cbf6bb0cf5bdc552013ae19205a952e1ce

Summary:
Tag should build on Jenkins, but not run the test.

In contrast, marking a target as manual will prevent it from both building and running.

Test Plan: Jenkins

Reviewers: yzhao, zasgar, #engineering

Reviewed By: yzhao, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D3228

GitOrigin-RevId: af2036406e7528fa2c73574aa0bc186c36afbd13

Summary: Container test needs to be run in exclusive mode, else it will conflict with other tests also deploying probes.

Test Plan: Enabling a test.

Reviewers: yzhao, #engineering

Reviewed By: yzhao, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D3214

GitOrigin-RevId: fbb309a00786250a20cfc31bac0fae215d35bc33

Summary:
In D3178, I accidently landed from the wrong machine and submitted the stale change.
This is the patch to get it to the correct version.

Test Plan:
  `bazel test --config=libc++ --keep_going //...`
  `bazel test --config=clang --keep_going //...`
  `bazel test --config=gcc --keep_going //...`

Reviewers: #engineering, michelle, oazizi, philkuz

Reviewed By: #engineering, oazizi

Differential Revision: https://phab.corp.pixielabs.ai/D3192

GitOrigin-RevId: e9092fdf0754c157778f8edafd98acca2393c2cb

Summary: Still has two failing tests, but will visit those after this diff is checked in.

Test Plan:
  `bazel test --config=libc++ --keep_going //...`
  `bazel test --config=clang --keep_going //...`
  `bazel test --config=gcc --keep_going //...`

Reviewers: michelle, oazizi, philkuz, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D3178

GitOrigin-RevId: 1d08f95bf9e7b10eea946b2b324fc1f3af85a976

Summary:
requires_root is defined but not actually supported in any way, so it is misleading. Remove it.

Note that D3148 is dependent on this.

Test Plan: Jenkins

Reviewers: zasgar, #engineering, yzhao

Reviewed By: zasgar, #engineering, yzhao

Differential Revision: https://phab.corp.pixielabs.ai/D3150

GitOrigin-RevId: 413b3608c23b17322cbbed384d76ef6acfa7ed0a

Summary: msan vs asan typo

Test Plan: Jenkins

Reviewers: zasgar, #engineering

Reviewed By: zasgar, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D3149

GitOrigin-RevId: cdf92d691483a42fd1c21c52afba25f7e17569dd

Summary: This updates to clang-9 and also updates our llvm build to use 9.0

Test Plan: `bazel test //...` and jenkins.

Reviewers: oazizi, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D2235

GitOrigin-RevId: 1bfc34c0d46fadca0a1c3f53f2ac9a675e9795c4

Summary: TSIA

Test Plan: Jenkins

Reviewers: michelle, philkuz, #engineering, oazizi

Reviewed By: #engineering, oazizi

Differential Revision: https://phab.corp.pixielabs.ai/D2772

GitOrigin-RevId: 12ad7b3fc7be20bb87d4e824bc760ff2ee4d8a1b

Summary: This should unbreak master.

Test Plan: Jenkins

Reviewers: philkuz, oazizi, #engineering

Reviewed By: philkuz, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D2764

GitOrigin-RevId: 3be0cd6e0c120c779bf23a97667a61aba0326588

Summary:
Recent updates to bazel render cc_configure unnecessary. This also fixes
static libstdc++ builds.

Change gcc/clang to be config based. `bazel build --config=gcc` to get gcc. Clang is default.

Test Plan: Jenkins

Reviewers: michelle, oazizi, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D2745

GitOrigin-RevId: 5c32408363f5d76c87d74fee1a0e700d6bb202f1

Summary: This adds a job that runs on Jenkins to build the release CLI when tags are pushed. It also adds the infromation to the artifact DB.

Test Plan: Tested on Jenkins.

Reviewers: michelle, #engineering

Reviewed By: michelle, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D2335

GitOrigin-RevId: 45eb917d3cecb58b1084942f226117d71555efa9

Summary: This is needed for the docker plugins to actually work.

Test Plan: Tested push

Reviewers: michelle, #engineering

Reviewed By: michelle, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D2317

GitOrigin-RevId: 8995e0bad9be3edf9eff336b7abfcebdd9edd7b1

Summary: No longer need the hacks :) Removed the TODOs.

Test Plan: jenkins

Reviewers: michelle, oazizi, #engineering, nserrino

Reviewed By: #engineering, nserrino

Differential Revision: https://phab.corp.pixielabs.ai/D2307

GitOrigin-RevId: a4eed59fe5817cac5f9d74a454134de1507902cf

Summary: TSIA

Test Plan: `bazel test //...`

Reviewers: oazizi, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D2147

GitOrigin-RevId: 21716a6133b564b53b4a15854e5c5b334a4e3150

Summary:
This is currently breaking master, likely because of the Go 1.13 upgrade. With this upgrade it
seems that we need to explicitly pass in gcov flags.

Test Plan: bazel test //... and bazel coverage //src/...

Reviewers: oazizi, philkuz, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D1916

GitOrigin-RevId: 83631e5bf6c51fdc78e6068f42635ee05991c4ba

Summary: This should make linking faster and enable easier support for LTO in the future.

Test Plan: Jenkins

Reviewers: oazizi, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D1414

GitOrigin-RevId: 0a3e9b09d36b3107fc8ee7ae5ad1f62a1ff3dfbd

Summary: Learned from last time using a .0 release, this time it's a .1 release :)

Test Plan: Jenkins

Reviewers: oazizi, #engineering, yzhao

Reviewed By: #engineering, yzhao

Differential Revision: https://phab.corp.pixielabs.ai/D1329

GitOrigin-RevId: 85ffc743fa18f5c35e190bc65f5fa3b2a66a674b

Summary: Looks like we are sometimes getting failures: https://jenkins.pixielabs.ai/blue/organizations/jenkins/pixielabs-master-nightly-test-regression/detail/pixielabs-master-nightly-test-regression/1/pipeline

Test Plan: Jenkins

Reviewers: oazizi, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D1330

GitOrigin-RevId: cd343b7d71964b27d2be6ca062c4d723636e0fb4

Summary: Filter out manual targets in ASAN/MSAN/TSAN.

Test Plan: Jenkins

Reviewers: oazizi, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D1307

GitOrigin-RevId: 034426c7e8b5a59e16cc33f508f2f32d1519d0f4

Summary:
Improve test coverage. Also these are essential to C++ code.

Fixed one asan bug where misaligned pointer access.

Test Plan: Jenkins test.

Reviewers: #engineering, oazizi, zasgar, chengruizhe

Reviewed By: #engineering, zasgar

Differential Revision: https://phab.corp.pixielabs.ai/D1024

GitOrigin-RevId: ed640ca0724ddc5e3ac1845fd7be7b61c2928240

Summary: Some flags added to make the build work, will try to remove them after updating our deps.

Test Plan: Build, jenkins.

Reviewers: oazizi, michelle, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D1028

GitOrigin-RevId: ba9c1f93b5d14ce4c98ed378a3c4ee5112ea9a34

Summary:
Moving to a newer bazel.
   TODO: Need to remove compatibility flag

Test Plan: jenkins

Reviewers: michelle, philkuz, oazizi, #engineering

Reviewed By: michelle, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D891

GitOrigin-RevId: 75b1afab6d821790d5351f5a4874a04dd54ccd24

Summary: This will allow the build on // to work without defining a tag.

Test Plan: bazel build //...

Reviewers: philkuz, chengruizhe, #engineering, michelle

Reviewed By: #engineering, michelle

Differential Revision: https://phab.corp.pixielabs.ai/D885

GitOrigin-RevId: 324beca770c73c675c6f62aafea5f2e7d49f1c57

Summary:
These tests run inside a container with root privilege, and bazel tests them directly not
inside any sandbox.

Test Plan: Jenkins

Reviewers: kgandhi, zasgar, oazizi, #engineering

Reviewed By: zasgar, #engineering

Subscribers: philkuz

Differential Revision: https://phab.corp.pixielabs.ai/D743

GitOrigin-RevId: d5ac6f7048d2398cfda1feaddc5690041a625cd4

Summary: TSIA

Test Plan: tested manually by editing some code locally.

Reviewers: oazizi, michelle, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D566

GitOrigin-RevId: 10297a93ee21b32a9e4f73fa2cd2a9b0cbbe37cc

Summary: Currently only works for CC code.

Test Plan: manually tested by running vizier/agent

Reviewers: oazizi, michelle, #engineering, kgandhi

Reviewed By: oazizi, #engineering, kgandhi

Differential Revision: https://phab.corp.pixielabs.ai/D565

GitOrigin-RevId: 01641a792ce3d8ef9045e2328454b2dbb94dd8b4

Summary: Does not seem to have to much impact on run time (but uses a lot less memory)

Test Plan: CI

Reviewers: oazizi, michelle, #engineering

Reviewed By: oazizi, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D556

GitOrigin-RevId: ee561144c810c2fb93a639bfd9dfc3f2b29dc7ce

Summary: A generic BPFTraceConnector class, plus a specific Derived class for grabbing CPU stats.

Test Plan: Currently using stirling_wrapper. Will look into whether a stand-alone test is possible.

Reviewers: kgandhi, zasgar, #engineering

Reviewed By: kgandhi, zasgar, #engineering

Subscribers: philkuz

Differential Revision: https://phab.corp.pixielabs.ai/D318

GitOrigin-RevId: 86bcd899e759df607eed7c199fae7716316ea595

Summary:
This adds code coverage with both html output
and tracking/visualization on codecov.io.

Test Plan:
Tested on Jenkins by using a remote branch,

  Sample output:
  https://codecov.io/gh/pixie-labs/pixielabs/tree/9206c22a8cfa8b675a675ae82a1a109e36e9f91e
  You will need to login with github (and grant access).

Reviewers: #engineering, michelle, oazizi

Reviewed By: #engineering, michelle, oazizi

Subscribers: kgandhi

Differential Revision: https://phab.corp.pixielabs.ai/D309

GitOrigin-RevId: 2f1c0d83891c3e8d1f653a6712110ca3a4104283

Summary:
This should remove the placeholder in the prior change.
Also, buildifier ran and reformatted the build files.

Test Plan: Jenkins

Reviewers: #engineering, philkuz

Reviewed By: #engineering, philkuz

Differential Revision: https://phab.corp.pixielabs.ai/D277

GitOrigin-RevId: beb04f150827c0399adc0c6b5443ce36ac3ad096

Summary: The RC version has fixes for cache hangs.

Test Plan: jenkins

Reviewers: #engineering, oazizi, michelle, philkuz

Reviewed By: #engineering, michelle, philkuz

Differential Revision: https://phab.corp.pixielabs.ai/D276

GitOrigin-RevId: 5bdb8e07c549921b66546d71b833613b57f22995

Summary: Always pick up user.bazelrc from workspace root

Test Plan: None

Reviewers: zasgar

Reviewed By: zasgar

Differential Revision: https://phab.corp.pixielabs.ai/D204

GitOrigin-RevId: 0c0a85dc5a6eab9737a9729f1f63f001b7c998f7

Summary: Small fixes for running dev-env-start

Test Plan: None

Reviewers: zasgar

Reviewed By: zasgar

Differential Revision: https://phab.corp.pixielabs.ai/D190

GitOrigin-RevId: c689991977e63b6f94cc6eb57d134a8f4408d249

Summary: Added MSAN and ASAN builds. MSAN is not on Jenkins yet because it needs a custom libc++ (we can defer this to later).

Test Plan: Jenkins build.

Reviewers: michelle, #engineering

Reviewed By: michelle, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D139

GitOrigin-RevId: 749f238eaa672406dfc52cba80f4a7a3bac765e2

Summary: TSIA

Test Plan: Jenkins

Reviewers: #engineering, kgandhi, michelle

Reviewed By: #engineering, michelle

Differential Revision: https://phab.corp.pixielabs.ai/D134

GitOrigin-RevId: 00e9a4ab5c93df974839fbef0fe27fe7df33e72e

Summary: Adding an option for load generation to run for a specified amount of time. The data collection script already takes an argument for how long it should collect data.

Test Plan: Tested on a GKE cluster

Reviewers: #engineering, michelle

Reviewed By: #engineering, michelle

Subscribers: philkuz, michelle

Differential Revision: https://phab.corp.pixielabs.ai/D129

GitOrigin-RevId: 31e30fbb96085a89e5886a78815564743321db19