Fix create_cloud_secrets for MacOS.

Summary:
This should be more robust across MacOS and Linux.
Closes #388
Fixes #306

Test Plan: Ran the scripts, ensured that the generated secrets look correct.

Reviewers: zasgar, michelle

Reviewed By: michelle
Signed-off-by: Frederick Ryckbosch <fryckbosch@newrelic.com>

Differential Revision: https://phab.corp.pixielabs.ai/D10474

GitOrigin-RevId: 846d451eb0e70b9d4478bd389fbdab8925c5f00e

scripts/create_cloud_secrets.sh

@@ -22,23 +22,23 @@ namespace="plc"
 
 kubectl create secret generic -n "${namespace}" \
   cloud-auth-secrets \
-  --from-literal=jwt-signing-key="$(LANG=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)"
+  --from-literal=jwt-signing-key="$(LC_ALL=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)"
 
 kubectl create secret generic -n "${namespace}" \
   pl-hydra-secrets \
-  --from-literal=SECRETS_SYSTEM="$(LANG=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)" \
-  --from-literal=OIDC_SUBJECT_IDENTIFIERS_PAIRWISE_SALT="$(LANG=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)" \
-  --from-literal=CLIENT_SECRET="$(LANG=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)"
+  --from-literal=SECRETS_SYSTEM="$(LC_ALL=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)" \
+  --from-literal=OIDC_SUBJECT_IDENTIFIERS_PAIRWISE_SALT="$(LC_ALL=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)" \
+  --from-literal=CLIENT_SECRET="$(LC_ALL=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 64 | head -n 1)"
 
 kubectl create secret generic -n "${namespace}" \
   pl-db-secrets \
   --from-literal=PL_POSTGRES_USERNAME="pl" \
   --from-literal=PL_POSTGRES_PASSWORD="pl" \
-  --from-literal=database-key="$(LANG=C; < /dev/urandom tr -dc 'a-zA-Z0-9#$%&().' | fold -w 24 | head -n 1)"
+  --from-literal=database-key="$(LC_ALL=C; < /dev/urandom tr -dc 'a-zA-Z0-9#$%&().' | fold -w 24 | head -n 1)"
 
 kubectl create secret generic -n "${namespace}" \
   cloud-session-secrets \
-  --from-literal=session-key="$(LANG=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 24 | head -n 1)"
+  --from-literal=session-key="$(LC_ALL=C; < /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w 24 | head -n 1)"
 
 SERVICE_TLS_CERTS="$(mktemp -d)"
 pushd "${SERVICE_TLS_CERTS}" || exit 1