This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 14 Jan, 2022 12 commits
-
-
Michelle Nguyen authored
Summary: These logs, although trace, will impact performance since we are printing out the string of the whole message Test Plan: These are just removing logs Reviewers: zasgar, vihang Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10503 GitOrigin-RevId: 4f8ead15d761f6e215707cd71ad923edabd07d84
-
Zain Asgar authored
Summary: Add information about vizier, shard, message kind to the vzshard. Test Plan: N/A Reviewers: michelle, vihang Reviewed By: vihang Signed-off-by:
Zain Asgar <zasgar@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10501 GitOrigin-RevId: 99181c968272fad29613507cd371fbbda45eda93
-
Natalie Serrino authored
Summary: VizierWatcher is responsible for watching for Viziers and calling onVizier handlers that are specified by the consuemr of the VizierWatcher. VizierWatcher reads from a NATS channel and currently calls these handlers in a blocking way. However, the handlers themselves might be doing non-trivial work, and we shouldn't block reading from the NATS subscription on those functions. This diff ensures that we wrap onVizier calls in a go routine so that this work does not block the reading from the NATS channel. Test Plan: n/a Reviewers: zasgar, vihang, michelle Reviewed By: vihang Signed-off-by:
Natalie Serrino <nserrino@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10497 GitOrigin-RevId: a7f1d973840ad4f9a9fca943b62b420bf06bb199
-
Zain Asgar authored
Summary: This adds metrics to track the number of messages by kind on the cloud conenctor. Test Plan: N/A Reviewers: michelle, vihang Reviewed By: michelle Signed-off-by:
-
Zain Asgar authored
Summary: Register needs to be called to make sure the metrics are exported to the collector. Test Plan: N/A Reviewers: michelle, vihang Reviewed By: vihang Signed-off-by:
-
Vihang Mehta authored
Summary: We format this as three blocks - stdlib, third_party, local. Test Plan: N/A stylistic change only Reviewers: michelle, zasgar Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10496 GitOrigin-RevId: b6994eb54ff47b0b46497937489833f5b954d04f
-
Vihang Mehta authored
Summary: We have a node pool with larger machines that we are migrating to. These patches will ensure that the new pods will schedule on the new nodes. Test Plan: skaffold the rendered yamls. Reviewers: zasgar, michelle, nserrino Reviewed By: michelle Signed-off-by:
-
Vihang Mehta authored
Summary: The changes in D10440 mean that the indexer isn't ready until after all the STAN subscribes are done. So the indexer take longer to get ready. Increase the threshold for the probe accordingly. Test Plan: Deploy indexer to a cluster, make sure it doesn't fail readiness. Reviewers: michelle, nserrino, zasgar Reviewed By: nserrino Signed-off-by:
-
Zain Asgar authored
Summary: Some refactor should probably done here as a next step to reduce code duplication. Test Plan: N/A Reviewers: michelle, nserrino, vihang Reviewed By: nserrino Signed-off-by:
-
Omid Azizi authored
Summary: We are running up against the BPF instruction limit in older kernels, and the protocol inference is becoming unscalable. This is a temporary measure to enable inference of only certain protocols, so that our probes fit within the BPF instruction limit. Longer term, to support kernels less than 5.2 (which have the 4096 instruction count limit), we need to push protocol inference into user-space. Test Plan: No public facing changes, so rely on existing tests for now. Reviewers: #stirling, jps Reviewed By: #stirling, jps Subscribers: rcheng, jps Signed-off-by:
Omid Azizi <oazizi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10484 GitOrigin-RevId: 1ccbfea9d090911d897a77319462966830ba7938
-
Natalie Serrino authored
Summary: We are currently buffering our NATS messages that we read from the channel. As we are currently receiving some slow NATS consumer errors, we would like to increase the buffer size to take som eof the load off of NATS. In a subsequent diff, we will provide a more holistic fix for the slow consumer issue. Test Plan: n/a Reviewers: michelle, vihang, zasgar Reviewed By: michelle Signed-off-by:
-
Michelle Nguyen authored
Summary: This error message is unclear, so we added more details Test Plan: Unit test Reviewers: vihang, philkuz Reviewed By: vihang JIRA Issues: PC-1367 Signed-off-by:
-
- 13 Jan, 2022 8 commits
-
-
Omid Azizi authored
Summary: Start following the pattern used in Go TLS tracing. This will pave the way to Go 1.17 tracing support for GRPC. Test Plan: Existing tests for now. No functional changes expected by these changes. Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Signed-off-by:
-
Omid Azizi authored
Summary: For converting our HTTP2 probes to use the regs, we can run out of eBPF stack space, so move the regs register onto the eBPF heap. Test Plan: Existing tests (no functional changes). Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Signed-off-by:
-
Omid Azizi authored
Summary: With this change Go TLS tracing should work for both the old Go ABI and the new register-based Go ABI. Test Plan: Test case for Go 1.17 added. Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Signed-off-by:
-
Michelle Nguyen authored
Summary: This is an temporary fix to increase the amount of messages that we can hold in our NATS channel. Test Plan: n/a Reviewers: zasgar, nserrino, vihang Reviewed By: zasgar, nserrino Signed-off-by:
-
Pete Stevenson authored
Summary: TSIA Test Plan: existing. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Signed-off-by:
Pete Stevenson <jps@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10478 GitOrigin-RevId: e5553be4d5915f503e3191195190da4be20f4603
-
Pete Stevenson authored
Summary: TSIA Test Plan: None. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
-
James Bartlett authored
Summary: The table test was failing every so often because in the threaded test the reader would get ahead of the data and then fail. Instead now the reader will wait for the writer to write more data instead of failing. I also added some comments to make the logic of the test clearer, and added a RAII wrapper around absl::Notification to make sure that the test fails immediately if the writer fails for some reason. Test Plan: Ran the test 1000 times without a failure. Also checked that if the writer fails for some reason the reader doesn't hang. Reviewers: zasgar Reviewed By: zasgar Signed-off-by:
James Bartlett <jamesbartlett@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10482 GitOrigin-RevId: 8d51cad6d77ca90066cb30a777fc74902817a7a5
-
Zain Asgar authored
Summary: This fixes bazel issues related to the use of the version file. We still need to do some cleanup where version information is pulled. Test Plan: Jenkins Reviewers: vihang, michelle, oazizi Reviewed By: vihang Signed-off-by:
-
- 12 Jan, 2022 9 commits
-
-
smcavallo authored
Summary: update nodeSelector identifier Signed-off-by: smcavallo <smcavallo@hotmail.com> Additionally updated the generated files + lint Closes #362 Test Plan: Deployed an operator release Reviewers: vihang Reviewed By: vihang Signed-off-by:
smcavallo <smcavallo@hotmail.com> Differential Revision: https://phab.corp.pixielabs.ai/D10477 GitOrigin-RevId: 6b981387e2df7a17d6561ec898c768dacaa024d6
-
Michelle Nguyen authored
Summary: We recently updated our metadata service to send node updates via NATS. We only use these updates in our cloud for autocomplete, but they still get sent to the PEMs. Because the PEMs don't handle these messages, they unnecessarily log per node update. This diff updates the PEM to handle the Node update, but currently doesn't do anything with it yet. We can update that when we have plans to do something with the node updates. Test Plan: Deployed PEM on skaffold, with logs in HandleNodeUpdate to ensure that function is getting called Reviewers: nserrino, jamesbartlett, vihang Reviewed By: vihang Signed-off-by:
-
Yaxiong Zhao authored
Summary: This avoids the extra noise when measuring CPU usage. Test Plan: Manual testing Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
Yaxiong Zhao <yzhao@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10442 GitOrigin-RevId: f7283970c9dde46b06400d311ada7ff0dac5f48f
-
Pete Stevenson authored
perf_profile_connector.h|cc: make the table push period a run time knob, for https://github.com/pixie-io/pixie/issues/380. Summary: perf_profile_connector.h|cc: make the table push period a run time knob, for https://github.com/pixie-io/pixie/issues/380 . Test Plan: Existing tests. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
-
Frederick Ryckbosch authored
Summary: This should be more robust across MacOS and Linux. Closes #388 Fixes #306 Test Plan: Ran the scripts, ensured that the generated secrets look correct. Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
Frederick Ryckbosch <fryckbosch@newrelic.com> Differential Revision: https://phab.corp.pixielabs.ai/D10474 GitOrigin-RevId: 846d451eb0e70b9d4478bd389fbdab8925c5f00e
-
Zain Asgar authored
Summary: gperftools autogen.sh stage was creating files that were not hermetic. This lead to caching issues. This change should result in a much faster build. Test Plan: Jenkins Reviewers: vihang, michelle, oazizi, #third_party_approvers Reviewed By: vihang, #third_party_approvers Signed-off-by:
-
Nick Lanam authored
Summary: Achieved by rewriting the quantiles component. It was using a Vega chart before, which was like using a missile to cook a casserole. The features were/are: - Render a whisker chart without the left whisker (only p50, p90, and p99). - Color the percentile bars based on how "bad" they are (defined by the column using the chart) - Hover color and tooltip for percentile bars - Clicking a bar tells the data table to switch which percentile bar is selected and used for sorting. - Use a nonlinear (square root) scale. - Resize when the column does (this was not working before). This doesn't take a lot of code, and the component is used for a table cell that can appear dozens of times at once. Writing a more performant version made sense. Test Plan: - Run `px/cluster`. - Mess around with the latency column in the Services table: - The percentile bars in each cell have tooltips - The bars have hover states - The selected percentile (title of the column) is already highlighted - The color of the bars is green, orange, or red depending on how high the latency at that bar is - Resizing the column resizes the charts too - Clicking a percentile bar selects it (makes that the shown value to the right of the chart and changes the column title; changes which bar is highlighted in every row) - The chart should be much less performance intensive than before. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1344 Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10456 GitOrigin-RevId: aaea843c1b4422343a28b48cc04af8cff9f43ef5
-
Nick Lanam authored
Summary: Shows a little helper message under the autocomplete results when there were more hits than are shown. Uses the new `hasAdditionalMatches` property of the suggestions API. {F175940} Test Plan: Use the breadcrumbs, especially on `px/pod` args. When there are more than about five results - which happens in the `pod` arg - this implementation suggests that results aren't complete. The message doesn't appear when results are already comprehensive. Reviewers: michelle, vihang, philkuz Reviewed By: michelle JIRA Issues: PC-1293 Signed-off-by: -
Nick Lanam authored
Summary: TSIA. Test Plan: - Run `px/cluster`. - Sort the Services table by latency (the quantiles column) - Hide some columns - Resize some remaining columns - Click on a row to open it in the sidebar - Change which quantile is selected by clicking a pip in that column (if p50 is selected, try p90, etc) - Sorting and the latency column's header should update to use the selected percentile. Hidden columns, resized columns, and which row is selected should be preserved. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1355 Signed-off-by:
-
- 11 Jan, 2022 11 commits
-
-
Vihang Mehta authored
Summary: If the redirectGet succeeds, then we redirect to `/auth/cli-auth-complete` In this scenario, we don't want to actually render the CodeBox, so don't set loading to false. Test Plan: yarn dev Reviewers: michelle, philkuz Reviewed By: michelle JIRA Issues: PC-1357 Signed-off-by:
-
Vihang Mehta authored
Summary: This couldn't be auto fetched. Test Plan: Ran the license generator Reviewers: michelle Reviewed By: michelle Signed-off-by:
-
Ryan Cheng authored
Summary: This diff adds the PxL script to visualize Kafka consumer rebalancing events, including an overview of the consumer groups and the stop-the-world delay. {F175655} Test Plan: Manually tested in the UI. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:Ryan Cheng <rcheng@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10437 GitOrigin-RevId: 5de8e6f63e32ba7b6b9719e630a09060f5bd7f33
-
Phillip Kuznetsov authored
Summary: We're tracking invite users requests, we should track reset invite links as well. Test Plan: tested on yarn dev, found data for it. Reviewers: nlanam, michelle, vihang Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10466 GitOrigin-RevId: 06872e6fd906491e354fa93d9b1928f2f5196f6e
-
Vihang Mehta authored
Summary: Our CLI auth callbacks used the just pass the auth access token to the CLI without checking anything. However the CLI doesn't like org less users. So now auth callbacks on the UI will always signup/login (previously we skipped UI login in cli mode), then check the org from the user creds, and redirect to the org setup page if the user doesn't have an org. The org setup page is told to rediect back to a CLI login complete page that renders the token or sends it to the cli server as appropriate. Test Plan: `px auth login` and `px auth login --manual` with an org less user now correctly send you to org setup and after org setup send the token to the cli. Checking the org from the cli auth.json ensures that the CLI successfully exchanged the access token for a valid user token. Reviewers: michelle, nserrino Reviewed By: michelle Subscribers: nlanam, philkuz Signed-off-by:
-
Phillip Kuznetsov authored
Summary: Adding a simple analytics event for whenever a user clicks on the invite users button. I don't track extra data since there is none. Test Plan: Tested on yarn dev, didn't break when I opened up the modal. Reviewers: michelle, nlanam, vihang Reviewed By: nlanam JIRA Issues: PC-1350 Signed-off-by:
-
Phillip Kuznetsov authored
Summary: When you render the invite modal, React doesn't like that the text is null before the gql is done. Changing to an empty string to avoid that error and we get the same values. Got the following errors before: ``` Warning: `value` prop on `input` should not be null. Consider using an empty string to clear the component or `undefined` for uncontrolled components. ``` ``` Warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components ``` Test Plan: yarn dev. before change, opening the modal threw a console error. After change, opening the modal worked without throwing errors. Reviewers: nlanam, michelle, vihang Reviewed By: nlanam Signed-off-by:
-
Natalie Serrino authored
Summary: We've noticed that certain clusters fail to send any indexer data to Elastic on Pixie Cloud. This persists even in the case where we restart the indexer in cloud or restart Vizier fon that cluster. We've also seen logs about stan subscription timeouts in the indexer. In addition, there are repeated errors of Viziers trying to reconnect to the indexer, even though the indexer supposedly already started listening to those Viziers. It seems the following might be happening, 1. Vizier tries to connect to the indexer to send over metadata 2. The metadata subscription fails due to timeout 3. Future attempts by that Vizier to connect to the indexer are blocked, because the indexer believes that the connection with that Vizier is already being handled (even though it's not because it failed to subscribe to stan). In this diff, the error from the stan subscription should now be propagated up and attributed to a particular Vizier so it's easier to diagnose if that's happening. In addition, if the indexer fails to establish a stan connection for a given Vizier, it will now allow subsequent retries for that Vizier rather than blocking them. This alone won't fix the full issue but it should hopefully address some of it and give us better insight into the cases of Viziers that seem unable to send metadata to the indexer. Test Plan: will want to run this in testing. Reviewers: michelle, philkuz, vihang Reviewed By: vihang JIRA Issues: PC-1354 Signed-off-by:
-
Michelle Nguyen authored
Summary: Currently, our autocomplete results return matches that are too fuzzy. After some investigation, it is because we are using the ngram analyzer for our search results. For ngrams, elastic typically recommends that the analyzer should only be used in the indexing phase. For the search phase, results will be less fuzzy if we use the standard analyzer. Also updated the index to clean up the un-used NS field, and removed some un-used tokenizers/analyzers/etc. This diff also revs the index. Test Plan: Deployed to testing cluster, and tested various inputs to see if they return reasonable results. Reviewers: vihang, nserrino Reviewed By: vihang JIRA Issues: PC-1348 Signed-off-by:
-
Michelle Nguyen authored
Summary: We currently don't deduplicate results in autocomplete, so if there is statefulset which has restarted with a different UID, it will show up twice. instead, we only want to show the most recent statefulset. this diff uses elastic's collapse functionality to deduplicate results, and ranks the resource with the most recent updateVersion at the top. Test Plan: updated the suggester test to include two resources with the same name. ensure that the resource with the later updateVersion is returned in the results. Reviewers: nserrino, vihang Reviewed By: vihang JIRA Issues: PC-1308 Signed-off-by:
-
Michelle Nguyen authored
Summary: We recently updated cloudConn to add the clusterID to the pod annotations. However, this can be a nil map if the pod has no annotations, and we need to handle that case. Test Plan: deployed using Skaffold, with a cloudConnector without any preexisting annotations Reviewers: vihang Reviewed By: vihang Signed-off-by:
-
