Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 14 Apr, 2022 17 commits
  3. 13 Apr, 2022 5 commits
    • yzhao1012's avatar
      Fix typo · 88e716de
      yzhao1012 authored 
      
Test Plan: Existing tests

Reviewers: #stirling, rcheng

Reviewed By: #stirling, rcheng
Signed-off-by: default avataryzhao1012 <yzhao@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11213

GitOrigin-RevId: 7caef5c849dfdbe5d0a5d41c780e50d8f36e3ae4
      88e716de
    • Natalie Serrino's avatar
      PP-3356: Allow users to specify memory request in addition to memory limit for PEMs · 6d038ffe
      Natalie Serrino authored 
      
Summary: Users want to be able to specify both the memory request and the memory limit for PEMs. Perhaps they only have 2Gi of memory available at deploy time per PEM, but they want to allow for a limit of up to 3Gi before OOMkilling the PEM. This diff updates the CLI, cloud, and operator in order to support that. Additionally, the table store was previously sized at 60% of the total memory limit. Now, the table store will be sized at 60% of the total memory request, to prevent OOMKills that could arise when the two values are different. By default the request will be the same as the limit. These aren't breaking changes, but the request will be the same as the limit in all cases until the user is running the latest release of the CLI, operator, and cloud.

Test Plan: ran skaffold versions

Reviewers: michelle, oazizi, vihang

Reviewed By: michelle

JIRA Issues: PP-3356
Signed-off-by: default avatarNatalie Serrino <nserrino@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11198

GitOrigin-RevId: 763248a88d824fa6fd53db8e5cb8bb342f793697
      6d038ffe
    • yzhao1012's avatar
      [CLEANUP] Move src/common/base/test_util.h code to src/common/testing/status.h · 58c06cf7
      yzhao1012 authored 
      
Summary: Testing code for Status should belong to status.h

Test Plan: Changing include header, existing tests should cover any problem

Reviewers: #stirling, oazizi

Reviewed By: #stirling, oazizi
Signed-off-by: default avataryzhao1012 <yzhao@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11173

GitOrigin-RevId: 1b7be8fd5e7926d1653aaf9548bcbb2eadd5dd77
      58c06cf7
    • yzhao1012's avatar
      Check if docker run subprocess already exited before checking for running · 1689946f
      yzhao1012 authored 
      
Summary:
Flaky tests usually claim that docker run failed, but still shows the correct stdout.
Confirmed offline by running the docker run command.

And checking the IsRunning(), it actually will correctly returns false if the container already
exited by the time the checking is being performed.

So add this check.

Test Plan: Existing tests

Reviewers: #stirling, rcheng

Reviewed By: #stirling, rcheng

Subscribers: oazizi
Signed-off-by: default avataryzhao1012 <yzhao@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11200

GitOrigin-RevId: 59d5517eb57d1071ca1c2055d0cde8386b7b8f5e
      1689946f
    • James Bartlett's avatar
      [table/internal] Add StoreWithRowTimeAccounting. · a992df0c
      James Bartlett authored 
      
Summary: Adds a wrapper around a std::deque that keeps track of time and unique row ID's for each batch in the store. Templated by `StoreType` which allows the very similar logic between hot/cold stores to be deduplicated, and only the batch access logic to be duplicated.

Test Plan: No changes to production code in this diff. But this new wrapper has a new test added, and it was tested integrated as part of a future diff.

Reviewers: nserrino, philkuz, vihang, zasgar

Reviewed By: nserrino
Signed-off-by: default avatarJames Bartlett <jamesbartlett@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11195

GitOrigin-RevId: a758b3b75cca510c1f7c0ef09228d3eedd9f8850
      a992df0c
  5. 12 Apr, 2022 11 commits
    • Hannah Troisi's avatar
      Add datatable docstring processing. · 11dda5c6
      Hannah Troisi authored 
      
Summary: This code generates our datatable docstrings using the pxapi.

Test Plan: bazel run //src/carnot/docstring/tables:datatables -- --cluster_id <CLUSTER_ID> --api_key <API_KEY> --output_json $(pwd)/datatable_documentation.json

Reviewers: philkuz

Reviewed By: philkuz
Signed-off-by: default avatarHannah Troisi <htroisi@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11194

GitOrigin-RevId: a43ef870e29028ed07962e803ea977dc1050c278
      11dda5c6
    • Vihang Mehta's avatar
      Some more cleanup for OSS cloud run · 0ab6bc43
      Vihang Mehta authored 
      
Summary:
The run currently runs pre-build but it doesn't need to. This
addresses the same.

Test Plan: To be tested on Jenkins

Reviewers: michelle, zasgar

Reviewed By: michelle
Signed-off-by: default avatarVihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11212

GitOrigin-RevId: 18bfae43f4730e50bd15d97ec3d8e56580170416
      0ab6bc43
    • Phillip Kuznetsov's avatar
      Clean up the docstring generator to remove the shell script · e4fa77b0
      Phillip Kuznetsov authored 
      
Summary:
docstring generator was super messy and not necessary. This changes it to collapse the
shell script into the golang file. I kept the shell test around because it's an easy way to verify
the docstrings are formatted correctly.

Test Plan: Tests pass, made sure that hte output documentation is identical from before the change.

Reviewers: vihang, htroisi, michelle

Reviewed By: vihang, htroisi
Signed-off-by: default avatarPhillip Kuznetsov <pkuznetsov@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11196

GitOrigin-RevId: d6501e8c8cb798b4d85d81190a1e228b9e9a3935
      e4fa77b0
    • Nick Lanam's avatar
      [PC-1493]: Warn user what disabling a plugin will do · f298842e
      Nick Lanam authored 
      
Summary:
Adds a tooltip to the switch in `/admin/plugins` when it will disable a plugin.
It links to the retention script list so the user can see details about the possible effects.

Test Plan:
- Enable a plugin in `/admin/plugins`
- Hover the disable switch - it should mention preset scripts and the config, and link to them
- Go add a couple of custom scripts that use that plugin
- Check `/admin/plugins` again, now the custom scripts are mentioned too
- Disable the plugin and enable it again. The tooltip should now reflect that the custom scripts were indeed deleted

Reviewers: michelle, vihang

Reviewed By: michelle

JIRA Issues: PC-1493
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11209

GitOrigin-RevId: f46bee912141393fadc26bed90fb48c8a7a77826
      f298842e
    • Michelle Nguyen's avatar
      Bump vizier and operator versions in public artifact YAML · 1f8b6edd
      Michelle Nguyen authored 
      
Summary: We recently released these with some important changes/updates that would be useful for the plugin.

Test Plan: These versions have all been tested and have been rolled out

Reviewers: vihang, nserrino

Reviewed By: vihang
Signed-off-by: default avatarMichelle Nguyen <michellenguyen@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11210

GitOrigin-RevId: 426904604bb38588f2672a836cad1cb2d67ea6f4
      1f8b6edd
    • Michelle Nguyen's avatar
      Fix cloud build · b0d8896d
      Michelle Nguyen authored 
      
Summary: There's an extra period which causes the build to fail

Test Plan: run staging cloud build

Reviewers: vihang

Reviewed By: vihang
Signed-off-by: default avatarMichelle Nguyen <michellenguyen@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11208

GitOrigin-RevId: fe1e92342a26c2aa270c2ce05c954183a955b7c3
      b0d8896d
    • Vihang Mehta's avatar
      Remove certmgr from vizier · 8f47965b
      Vihang Mehta authored 
      
Summary: As direct mode is now being removed vizier no longer need a certmgr service. Remove certmgr.

Test Plan: Test vizier RC with an operator RC

Reviewers: michelle, philkuz

Reviewed By: michelle

JIRA Issues: PP-3334
Signed-off-by: default avatarVihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11204

GitOrigin-RevId: 90b0053e0ee6cedbdb619a5d3b5fb2e88ff1d958
      8f47965b
    • Hannah Troisi's avatar
      Add IntToString UDF · 894c8c9e
      Hannah Troisi authored 
      
Summary:
Test PxL script:

```
import px
df = px.DataFrame(table='process_stats', start_time='-5m')
df.pod = df.ctx['pod_name']
df.namespace = df.ctx['namespace']
df = df.groupby(['namespace']).agg(
    pod_count=('pod', px.count)
)
df.pod_count_string = px.itoa(df.pod_count)
px.display(df)
```

Test Plan: Added test, deployed vizier and tested with PxL script in summary.

Reviewers: nserrino, vihang

Reviewed By: vihang
Signed-off-by: default avatarHannah Troisi <htroisi@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11203

GitOrigin-RevId: ecc84501280eaea6be89948e0189e76761940a90
      894c8c9e
    • Vihang Mehta's avatar
      Update operator to detect and delete stale vizier proxy resources · 09818e2e
      Vihang Mehta authored 
      
Summary:
If a future version of vizier no longer includes proxy related
resources, the operator should now detect and delete those resources.

Test Plan:
skaffold an operator and make sure it detects the resources properly.
Also tested with an operator RC and a vizier RC.

Reviewers: michelle, philkuz

Reviewed By: michelle

JIRA Issues: PP-3354
Signed-off-by: default avatarVihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11207

GitOrigin-RevId: 6ae5153f81d067529e439b0d5315f56e9a0ada89
      09818e2e
    • Nick Lanam's avatar
      [PC-1471]: Fix copying api/deploy keys twice · a9ccc005
      Nick Lanam authored 
      
Summary:
Due to a bug in Apollo, `useLazyQuery` wasn't calling `onCompleted` in this situation after the first time a lazy query executed, even though it was still invoking the network request again.

The bug seems to only trigger when the fetch policy skips cache (like this case does - to avoid ever caching secrets).
Setting `notifyOnNetworkStatusChange` makes Apollo check again on refetches and call `onCompleted` correctly.
This diff also shows a snackbar on copy like we already do elsewhere.

Test Plan: Try to copy the same API or Deployment key twice in `/admin/api-keys` and `/admin/deployment-keys`. It should show a snackbar now, and it should copy the key on every attempt instead of just the first.

Reviewers: michelle, vihang

Reviewed By: michelle

JIRA Issues: PC-1471
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11205

GitOrigin-RevId: 03081a61d7fcc18e553e4c91e2d906214e72a498
      a9ccc005
    • Vihang Mehta's avatar
      Update operator to detect and delete stale certmgr resources · 15221fc3
      Vihang Mehta authored 
      
Summary:
If a future version of vizier no longer includes certmgr related
resources, the operator should now detect and delete those resources.

Test Plan:
skaffold an operator and make sure it detects the resources properly.
Also needs to be testing with an operator RC and a vizier RC.

Reviewers: michelle, philkuz

Reviewed By: michelle

JIRA Issues: PP-3354
Signed-off-by: default avatarVihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11202

GitOrigin-RevId: 9f5d781094b242422dfb08608908f60651e8e482
      15221fc3
  7. 11 Apr, 2022 7 commits

免费DevSecOps平台，让您的项目体验完整的DevSecOps流程，让项目更安全