This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 28 Jun, 2022 8 commits
-
-
Michelle Nguyen authored
Summary: Currently when a user upgrades a plugin to a new version, the preset scripts are deleted and recreated. This leads to a poor user experience, as a user may have set custom configurations to the preset scripts. This diff updates the plugin upgrade process: 1. Fetch preset scripts from the new plugin version 2. Fetch existing preset scripts the org has configured for the (now) old plugin version 3. Assume if two preset scripts have the same name, they are the same script. Update the contents of an existing preset script with the new version. 4. Create any new preset scripts that don't exist in the old plugin version. 5. Delete any preset scripts from the old version that are not in the new plugin version. Test Plan: unit test Reviewers: vihang, philkuz Reviewed By: philkuz Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11683 GitOrigin-RevId: 252755a2097993a6be7daeb1110292af761d8278
-
Vihang Mehta authored
Summary: At some point the url-loaders started exporting esModules by default instead of commonjs. This broke the stars background. This diff fixes the same. Test Plan: yarn dev, go to a login page, see the background again. Reviewers: michelle, nlanam Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11693 GitOrigin-RevId: 7e3d954f1df105f80c827e52ae99371c49da341d
-
yzhao1012 authored
Test Plan: Added comments, no tests needed Reviewers: #stirling, rcheng Reviewed By: #stirling, rcheng Signed-off-by:
yzhao1012 <yzhao@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11688 GitOrigin-RevId: fd5a1a140a54d6152694b5d6e8971edd405219a7
-
Michelle Nguyen authored
Summary: Currently when a user disables a plugin, we delete all preset and custom scripts. This can be particularly annoying for custom scripts if a user has spent some time writing it. This diff updates the plugin disabling process so that custom scripts are not deleted, just disabled. Note that these scripts are not listed in the UI until the plugin is re-enabled. We can show them so that users may still view their scripts, however this will require some more UI work. For example, to not let the user reenable the script if the plugin is disabled Test Plan: Unit test, deploy to testing cloud and disable/renable a plugin. Reviewers: philkuz, vihang Reviewed By: vihang Signed-off-by:
-
Vihang Mehta authored
Summary: TSIA Test Plan: Ran yarn build_prod and examined the bundle Reviewers: michelle, nlanam Reviewed By: michelle, nlanam Signed-off-by:
-
Vihang Mehta authored
Summary: TSIA Test Plan: git grep finds no use of these, UI build still works. Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
-
Phillip Kuznetsov authored
Summary: Ran into an issue while trying to add pxlLib that IR graph changes in the compiler cause some tests to fail because IDs change. We've had this issue for a while and haven't addressed it satsifactorily. This approach is meant to remove the need for accurate IDs in these types of tests and now just verifies that the graphs match structurily. Test Plan: Added tests for this component and update the bad tests to use this. Reviewers: jamesbartlett, nserrino, vihang Reviewed By: jamesbartlett Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11660 GitOrigin-RevId: c360ec52aa81b64f28e7a134c48fcfd6c490a527
-
Michelle Nguyen authored
Summary: There is a new link to the OTel tutorial now. Test Plan: This is a simple URL change, nothing to test Reviewers: nlanam, philkuz Reviewed By: nlanam, philkuz JIRA Issues: PC-1546 Signed-off-by:
-
- 27 Jun, 2022 9 commits
-
-
Vikranth Srivatsa authored
Summary: Adds extra types in type gen template. This can be used to try fully generating the constants/types file Test Plan: This will be tested in a later pr by checking if actual packets decoded correctly. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
Vikranth Srivatsa <vsrivatsa@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11669 GitOrigin-RevId: 84d0770209ccd0d2ae49b213252740de74c67031
-
Michelle Nguyen authored
Summary: PodSecurityPolicies have been deprecated as of k8s 1.21, and will be removed in K8s 1.25. We currently include the podSecurityPolicy by default. Most of the time it is ignored, as people need to enable the admission controller. When the admission controller is enabled, the current podSecurityPolicy isn't correct anyway, as we would also need podSecurityPolicies for the operator. In most cases, users have needed some customization around the podSecurityPolicy to best fit their configurations anyway. Fixes #371 Test Plan: built Vizier YAMLs Reviewers: philkuz, vihang Reviewed By: vihang Signed-off-by:
-
Omid Azizi authored
Summary: Remove flakiness in pgsql_trace_bpf_test by removing a dependence on an external docker image. Instead use the existing postgres container for the client that we need for the tes. Test Plan: This is a test update. Reviewers: #stirling, zasgar Reviewed By: zasgar Signed-off-by:
Omid Azizi <oazizi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11675 GitOrigin-RevId: ec560ecfbcb2fe0d944939d119fc7c95b0d40a75
-
Phillip Kuznetsov authored
Summary: Updated the pxapi pypi page with more links, removing old links, and changing Authors -> Maintainers. Test Plan: uploaded to test pypi Reviewers: vihang, htroisi Reviewed By: htroisi JIRA Issues: PXC-221 Signed-off-by:
-
Nick Lanam authored
Summary: We were detecting embed state by checking the URL. This is clumsy, and breaks when one embedded view links to another without remembering to check that first. Sorry for the semantic satiation in the following text... With this change: - Embed state is checked by testing if Pixie appears to be in an iframe - Most links and buttons that accounted for embed state don't bother anymore, because... - A top-level conditional redirect now automatically fixes the URL if it doesn't line up (puts `/embed` at the front of the path if embedded, and removes it otherwise) - Routes for embeddable views still need to exist, so those stay. - Trying to reach a route that doesn't have an embedded variant defined while embedded will now go to the 404 page instead of breaking out of embedded mode - If Pixie is incorrectly embedded or if an embed link is accessed directly, it will fix itself before continuing Test Plan: Try a wide variety of links throughout the app: - Access live views normally. Click entity links. Visit credits. Visit admin. Visit `/configure-data-export`. - Try bouncing between plugin page and data export overview and data export details and data export history. - Do the same when Pixie is embedded. - Try embedding without `/embed` in the URL, or going to a `/embed` link in a new tab. Both should correct themselves. - It should no longer be possible to, while embedded, "break out" of this mode - Trying to embed a path that doesn't have a `/embed` version should now 404 instead of loading like it wasn't embedded. For example, try to embed `/credits`. It should try to change that to `/embed/credits`, which will 404. Reviewers: michelle, vihang Reviewed By: michelle Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11650 GitOrigin-RevId: c9033f4e4f8b5b6d9188acbb0a05af16db72b28c
-
Nick Lanam authored
Summary: Scrollbars are not consistent between browsers, operating systems, and settings for either. Customizing scrollbars I even more complex, and makes detection of their dimensions somehow even less consistent. This diff guarantees that `useScrollbarSize` will detect the actual dimensions of the scrollbar (and if it's overlay vs inlay) in Safari, Chrome, and Firefox on macOS, Linux, and Windows, and especially for macOS users who change their system settings for scrollbars (General -> Show scroll bars -> defaults to "When scrolling"). Result is that data tables should no longer fail to reserve space for scrollbars when they should. This diff also deletes a long-unused file that was still laying around. Test Plan: Run any PxL script with tables in Chrome on macOS with system preference of "When scrolling". Do the same in Firefox and also try changing the system setting (reload between changes). Try Firefox and Chrome on Ubuntu as well. In all cases, there should not be any _unexpected_ horizontal scrollbars (tables with too many columns for the space available will still show one). Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1542 Signed-off-by:
-
Nick Lanam authored
Summary: The error column already has this information, but now there's an icon on the left to make it easier to notice. This involved adding a new feature to the data tables. {F188519} {F188520} Test Plan: Visit cron history for any given script. Try those with successful runs and those with unsuccessful runs to see both versions. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PP-3426 Signed-off-by: -
Phillip Kuznetsov authored
Summary: The styleguide was missing some linked files. We had an internal document with some styles so I figured I would just publish that as the cc and go style guides. I did a brief run through to make sure everything makes sense. Test Plan: Made sure links work and the guide renders correctly. Reviewers: michelle, vihang, zasgar, nserrino, oazizi, yzhao Reviewed By: zasgar Subscribers: htroisi JIRA Issues: PXC-205 Signed-off-by:
-
Tharindu Wijewardane authored
Summary: Track pod labels and adds a UDF to get pod labels given IDs. Fixes #449 Closes #468 Test Plan: Added unit tests Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
Tharindu Wijewardane <tharindu.moratuwa@gmail.com> Differential Revision: https://phab.corp.pixielabs.ai/D11678 GitOrigin-RevId: fd84b4dfbe9bfce8da853232cee604417bdf07a7
-
- 25 Jun, 2022 2 commits
-
-
Zain Asgar authored
Summary: Also enables bpf tests when -b flag is passed to the bazel deps script. Configure BPF tests to make them faster and more stable. Test Plan: Nightly Regressions. Reviewers: oazizi, yzhao, jamesbartlett, vihang Reviewed By: vihang Signed-off-by:
Zain Asgar <zasgar@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11616 GitOrigin-RevId: 5d03e3c912ef3992167359c473060e3e3207bb77
-
Vihang Mehta authored
Summary: This signs our CLI releases with a GPG key and publishes the released binaries and signatures to github. Test Plan: Test on Jenkins? Unfortunately these changes are difficult to test without pushing to main since Jenkins uses the config at tip of tree. Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
-
- 24 Jun, 2022 3 commits
-
-
Phillip Kuznetsov authored
Summary: Error message used %s which isn't valid for the function. Instead replaced with $0. Test Plan: Ran test and saw the correct error out. No functionaltity change other than formatter. Reviewers: nserrino, michelle, vihang, jamesbartlett Reviewed By: jamesbartlett JIRA Issues: PP-3160 Signed-off-by:
-
Vikranth Srivatsa authored
Summary: Add constant and enum generation to create types.h in AMQP. These constants will be used to quickly select/find the relevant class/method involved. The next pr will add the selection code Sample image of type generation: {F188507} Test Plan: The code generation tests will come later in another pr. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: rcheng, jps Signed-off-by: -
Vihang Mehta authored
Summary: os.UserHomeDir respects the system specific env vars that indicate where HOME is. The user object doesn't do the same. A user might want to override their home dir so this allows them to do so when using the CLI. Also reconcile the use between config and auth. Test Plan: Set $HOME and ran the bazel built CLI. Saw the `.pixie` folder in the overriden location. Reviewers: zasgar, michelle Reviewed By: zasgar Signed-off-by:
-
- 23 Jun, 2022 5 commits
-
-
Vikranth Srivatsa authored
Summary: Generates the AMQP method extraction and struct declarations while code generating. Test Plan: Tests will be added later in the code generation process. This will be done by checking with recorded traffic. Reviewers: #stirling, rcheng Reviewed By: #stirling, rcheng Subscribers: jps, rcheng Signed-off-by:
-
Pete Stevenson authored
Summary: TSIA Test Plan: This is a test. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
Pete Stevenson <jps@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11642 GitOrigin-RevId: 776229b9518b525b93244aa45b007d92b3d2b9a6
-
Vikranth Srivatsa authored
Summary: Simplify the decoding of all AMQP methods and types via code generation. This pr is all the python types and xml required to generate Test Plan: This pr doesn't add any code generation. Another pr will add the actual generation and can be tested by testing with actual amqp data. Reviewers: #stirling, yzhao, #third_party_approvers, oazizi Reviewed By: #stirling, yzhao, #third_party_approvers, oazizi Subscribers: vihang, oazizi, rcheng, yzhao, jps Signed-off-by:
-
Michelle Nguyen authored
Summary: When specified, the configmanager service reaches out to LaunchDarkly to fetch feature flag values. This diff updates the YAML so that the configmanager reads the SDK key if present in a configmap. Test Plan: testing cluster Reviewers: nserrino, vihang Reviewed By: vihang Signed-off-by:
-
Pete Stevenson authored
Summary: TSIA Test Plan: This is not production code, it is used by devs when testing locally. Reviewers: #stirling, rcheng Reviewed By: #stirling, rcheng Signed-off-by:
-
- 22 Jun, 2022 5 commits
-
-
Vihang Mehta authored
Summary: Using `--remote_download_toplevel` to override `--remote_download_minimal` causes bazel to warn us since those are both expansions. Instead use `--remote_download_outputs=all` to override when we need it. Test Plan: All the modified scripts continue to work. Reviewers: zasgar, michelle, jamesbartlett Reviewed By: jamesbartlett Signed-off-by:
-
Ryan Cheng authored
Summary: Enable mux tracing. If the kernel version is too old, turn it off due to instruction limits. Enable mux_trace_bpf_test. Test Plan: Existing tests Reviewers: #stirling, jps Reviewed By: #stirling, jps Subscribers: jps Signed-off-by:
Ryan Cheng <rcheng@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11652 GitOrigin-RevId: 604e9bf68a6fb0ef48944ae814d2e314a326bb70
-
Vihang Mehta authored
Summary: The underlying tooling seems to be sensitive to order. This works around their bugs. See also: https://github.com/protobufjs/protobuf.js/issues/1042#issuecomment-929370111 Test Plan: Ran the script. Reviewers: philkuz, jamesbartlett, nlanam Reviewed By: jamesbartlett Signed-off-by:
-
Vihang Mehta authored
Summary: Coverage runs were getting `nobuild_runfile_links` from a expansion of `remote_download_minimal`. This happens to cause issues. So explicitly set `build_runfile_links` for coverage runs. See https://github.com/bazelbuild/bazel/issues/4685#issuecomment-1145338038 Test Plan: Ran the coverage build, most of the failures go away. Reviewers: zasgar, michelle, jamesbartlett Reviewed By: jamesbartlett Signed-off-by:
-
Copybara authored
Summary: Currently tags are copied after a copybara trigger, which only happens on pushes. Instead add a multibranch pipeline to Jenkins that also triggers copybara. This will ensure that tags get copied over even without a commit being pushed to the repo. Test Plan: Run it in Jenkins Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
Copybara <copybara@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11649 GitOrigin-RevId: 15ba5c7abe473c64356451f47d16320c2a8c61fd
-
- 21 Jun, 2022 8 commits
-
-
Nick Lanam authored
Summary: For a peculiar use case. Test Plan: Try overriding `hidePresetsForPlugin` in the `data-export` configurable. Whatever logic you put there should be reflected by hiding preset scripts from `/configure-data-export` based on your conditions. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1545 Signed-off-by:
-
Nick Lanam authored
Summary: When Pixie is embedded and there are no enabled plugins while on `/configure-data-export`, the reason may vary. This lets the embedder provide a more specific error message. Test Plan: Embed Pixie at `/embed/configure-data-export` like usual. Have no plugins enabled. Error message should be the same for a build without private configuration, but private configuration can now override it. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1544 Signed-off-by:
-
Nick Lanam authored
Summary: Viewing cron history and then trying the back link was escaping the embed. Now it's a relative link. Test Plan: Visit `/configure-data-export`. View a script's history, then click the icon in the top left to go back. It should still do so. Embed the same view (`/embed/configure-data-export`). Do the same thing. It should work and not break out of the embedded mode. Reviewers: michelle, vihang Reviewed By: vihang Signed-off-by:
-
Phillip Kuznetsov authored
Summary: This diff improves the px/cluster process_stats scripts to reduce computation and re-use a table value. I discovered these opportunities writing the export script for px/cluster. The difference is large, from exectime running against staging. *Before:* ``` +------------+-------------------+----------------------+----------------------+---------------------+------------+ | NAME | COMPILATION TIME | EXEC TIME: EXTERNAL | EXEC TIME: INTERNAL | NUM BYTES | NUM ERRORS | +------------+-------------------+----------------------+----------------------+---------------------+------------+ | px/cluster | 37.55ms +/- 2.9ms | 899.09ms +/- 24.11ms | 801.11ms +/- 24.15ms | 77654.80 +/- 435.48 | 0 | +------------+-------------------+----------------------+----------------------+---------------------+------------+ ``` *After:* ``` +------------+--------------------+----------------------+---------------------+---------------------+------------+ | NAME | COMPILATION TIME | EXEC TIME: EXTERNAL | EXEC TIME: INTERNAL | NUM BYTES | NUM ERRORS | +------------+--------------------+----------------------+---------------------+---------------------+------------+ | px/cluster | 51.12ms +/- 3.32ms | 395.75ms +/- 10.26ms | 284.5ms +/- 8.52ms | 78756.50 +/- 325.19 | 0 | +------------+--------------------+----------------------+---------------------+---------------------+------------+ ``` Test Plan: Ran the changed functions and compared them to the old results to confirm they lined up results Reviewers: vihang, michelle, jamesbartlett Reviewed By: jamesbartlett Signed-off-by:
-
Nick Lanam authored
Summary: They were previously only showing if the text wasn't already fully visible. This was slightly more confusing than showing them anyway. Test Plan: Run any script or look at data export history or the script drawer (anywhere with a `<DataTable>`). Tooltips should appear on hover of any header cell, even if it's wide enough to already show the full text. Previously, it would only appear if the text wasn't already fully visible. Reviewers: michelle, vihang, zasgar Reviewed By: vihang JIRA Issues: PC-1543 Signed-off-by:
-
Ryan Cheng authored
Summary: We moved to a deterministic containerized build previously and `PL_COVERAGE` ifdefs were removed in D10602. In D11586, container build was removed. This diff adds back some of the `PL_COVERAGE` to make sure the tests still pass when built with gcc. Test Plan: Updated tests Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
-
Nick Lanam authored
Summary: Adds a new view for export scripts to show their recent run history. {F188001} Test Plan: Visit `/configure-data-export`. For various scripts: - Click the new history icon next to the edit icon to veiw logs - Try clicking several clusters in the dropdown to see their history - Loading state should be visible - Error states should present clearly - If a cluster has never run the selected script, a message explaining such appears - If a cluster HAS run the selected script, you get a full data table with the details - The top left corner of the page has a back button to return to the script list - The center of the top of the page shows the plugin name and icon as weell as the script that you're viewing Reviewers: michelle, vihang, philkuz Reviewed By: philkuz Subscribers: philkuz JIRA Issues: PP-3380 Signed-off-by: -
Pete Stevenson authored
Summary: We enable Java symbolization by default, and switch the skaffold profile from 'jsyms' to 'no-jsyms'. Test Plan: Tested one-off on dev. cluster. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Signed-off-by:
-
