This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 16 Nov, 2021 12 commits
-
-
Vihang Mehta authored
Summary: TSIA, no one sets this to true. Test Plan: N/A Reviewers: philkuz, michelle Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10197 GitOrigin-RevId: 86635492608a2e6c598aa055c4636fbf5bde885e
-
Ryan Cheng authored
Summary: This diff adds full body tracing of JoinGroup, which will be necessary to visualize consumer rebalance. Test Plan: Unit tests and updated kafka_trace_bpf_test Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Signed-off-by:
Ryan Cheng <rcheng@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10122 GitOrigin-RevId: 81d01ee64a497d35c44e5525a5ce222fbeff9d4d
-
Phillip Kuznetsov authored
Summary: For new User/Password logins, we need to be able to login and create users who don't belong to an org. This diff comes from an investigation of what happens when a user tries to login without an OrgID. After this diff, we need to detect users who are in this state in the UI, then transfer them to a CreateOrg page that we can then use to submit CreateOrg requests. Test Plan: Tested on skaffold and authenticated. Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10188 GitOrigin-RevId: b1175bc904c7ef1b36969c914dfcf6248c7c70f0
-
Vihang Mehta authored
Summary: Renders a more friendly message when a user needs to verify their email. Test Plan: yarn dev Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
-
Vihang Mehta authored
Summary: Accidentally misconfigured this. Test Plan: skaffold dev Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
-
Nick Lanam authored
Summary: TSIA. Login before: {F173059} Login after: {F173054} Signup before: {F173058} Signup after: {F173055} Test Plan: In `webpack.config.js`, set `authEmailPasswordConnection` to `https://foo.bar` , then look at the login page and the signup page. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1275 Signed-off-by:Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10191 GitOrigin-RevId: f7e47cc2c5919039d58cac9cf99b5a122e1b5610
-
Vihang Mehta authored
Summary: The hints on whether to render login or signup changed. Test Plan: skaffold dev Reviewers: michelle, philkuz Reviewed By: philkuz Signed-off-by:
-
Michelle Nguyen authored
Summary: These tests have been flaky 3% of the time. After some investigation, it looks like there is some difference between using `Queryx` and `Exec` and when transactions are committed. Test Plan: ran test 1000 times Reviewers: philkuz, vihang Reviewed By: philkuz, vihang JIRA Issues: PC-1272 Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10189 GitOrigin-RevId: 7dfd4887562e638b4b1ee1c45d230c1b72d81009
-
Vihang Mehta authored
Test Plan: skaffold dev cloud Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
-
Vihang Mehta authored
Summary: D10183 didn't quite work. This fixes the issues. Test Plan: Fixed tests Reviewers: philkuz, michelle Reviewed By: philkuz JIRA Issues: PC-1259 Signed-off-by:
-
Michelle Nguyen authored
Summary: previous diffs added the tableStoreTableSizeLimit flag to the CRD + vizier templates. this diff allows you to specify your value for tableStoreTableSizeLimit in the CLI. Test Plan: n/a Reviewers: jamesbartlett, vihang, rcheng Reviewed By: vihang, rcheng Signed-off-by:
-
Michelle Nguyen authored
Summary: previous diff added the field to the CRD. this diff propagates it through the vizier tmpl pipeline. Test Plan: n/a Reviewers: jamesbartlett, vihang, rcheng Reviewed By: vihang Signed-off-by:
-
- 15 Nov, 2021 7 commits
-
-
Michelle Nguyen authored
Summary: there are cases where users may want to patch all of their deployments (for example, apply nodeselectors to all deployments). this currently does not work since the svc names match the exact resource names of the deployments themselves. since we do patches by matching resource names, this leads to invalid YAMLs. instead, we should rename our services so that each resource can be patched Test Plan: built vizier rc, deployed with patches Reviewers: vihang Reviewed By: vihang Signed-off-by:
-
Michelle Nguyen authored
Summary: We also want to make the table store's table size limit configurable via the CRD. this diff adds the field to the CRD. a followup diff will make sure that this is wired into the vizier tmpl pipeline. Test Plan: n/a Reviewers: jamesbartlett, vihang, rcheng Reviewed By: vihang Signed-off-by:
-
Phillip Kuznetsov authored
Summary: Users who would tried to call GetAugmentedToken but lacked an org would receive an error. This call is made as part of the GRPC middleware in the api_server. We will need to call GetUser/ GetOrg() from the UI in these cases so probably just allow users to login without an org. This diff is part of a series to enable user/password signup flows. We will need to allow users to exist in the database without an OrgID and make sure that the data is accessible to users. Risk - we are creating a new opening for users to log in without an org ID. We might provide more access than we intend. However, most features are org-gated anyways - meaning we restrict info so that only the org members can view clusters, org members, so those risks will be limited. Test Plan: Updated the test. No chance to do an integration because we don't support orgless users yet. Reviewers: vihang, michelle, nserrino Reviewed By: vihang Signed-off-by:
-
Vihang Mehta authored
Summary: For the Username/Password based auth, user creation and org creation are going to be split out and users will be created first without any associated orgs. Test Plan: Added tests Reviewers: michelle, philkuz Reviewed By: philkuz JIRA Issues: PC-1259 Signed-off-by:
-
Phillip Kuznetsov authored
Summary: We pass around this userID variable in login.go, but this has been available in UserInfo struct for quite a while now as the same value. To reduce confusion, we now just use the userInfo.AuthProviderID value in place of the userID. Evidence this was confusing shows up in the tests as well -we would use the PL User ID and authProviderID interchangably. This fixes that issue in the test. Test Plan: Tests still pass, can still login with skaffold Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
-
Vihang Mehta authored
Summary: We mainly use `UserService` and `OrgService`. This is redundant. Test Plan: Existing tests Reviewers: michelle, zasgar Reviewed By: zasgar Signed-off-by:
-
Vihang Mehta authored
Summary: TSIA, this should help split up our `CreateUserAndOrg` methods and also will be useful for the create org flows later. Test Plan: Added tests. Reviewers: michelle, philkuz Reviewed By: michelle, philkuz JIRA Issues: PC-1258 Signed-off-by:
-
- 14 Nov, 2021 2 commits
-
-
Vihang Mehta authored
Summary: This moves all consumers to use OrgService or ProfileService as appropriate and removed the deprecated methods in ProfileService. Test Plan: Existing tests Reviewers: michelle, philkuz, zasgar Reviewed By: philkuz Signed-off-by:
-
Vihang Mehta authored
Summary: This will help populate the HD information faster. Test Plan: skaffold dev Reviewers: michelle, philkuz Reviewed By: michelle JIRA Issues: PC-1263 Signed-off-by:
-
- 13 Nov, 2021 3 commits
-
-
Vihang Mehta authored
Summary: TSIA, ProfileService seems unused otherwise and should be deprecated. Test Plan: Ran `px auth login` with bazel built CLI. Reviewers: michelle, zasgar Reviewed By: michelle Signed-off-by:
-
Omid Azizi authored
Summary: Bazel lint Test Plan: Jenkins Reviewers: zasgar, vihang, #third_party_approvers Reviewed By: vihang, #third_party_approvers Signed-off-by:
Omid Azizi <oazizi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10172 GitOrigin-RevId: 4eef82439527c061f5a3b4f45ae7c32f036c5dd2
-
Omid Azizi authored
Summary: `generate_crosstool_file` is True by default, so no need to be explicit. A few other small clean-up items. Test Plan: Jenkins Reviewers: zasgar, #third_party_approvers, vihang Reviewed By: #third_party_approvers, vihang Signed-off-by:
-
- 12 Nov, 2021 14 commits
-
-
Omid Azizi authored
Summary: The flag is also in run_docker.sh, causing the script to fail. Apparently, docker doesn't like duplicate flags. Test Plan: Manual Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Signed-off-by:
-
Omid Azizi authored
Summary: D10162 included a few pieces that were not meant for it. Revert those. Test Plan: Jenkins Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Signed-off-by:
-
Omid Azizi authored
Summary: The second parameter is not often used, so give it a default empty parameter. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Signed-off-by:
-
Omid Azizi authored
Summary: Tidying up a few things Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Signed-off-by:
-
Omid Azizi authored
Summary: Cereal is a header-only C++ library for serialization. It is used by newer versions of BPFTrace, which will be upgraded soon. Reference: https://github.com/USCiLab/cereal/ Test Plan: N/A Reviewers: #stirling, zasgar, #third_party_approvers, vihang Reviewed By: #third_party_approvers, vihang Subscribers: vihang Signed-off-by:
-
Omid Azizi authored
Summary: Fix a seg-fault. Test Plan: Manual Reviewers: #stirling, zasgar Reviewed By: zasgar Signed-off-by:
-
Omid Azizi authored
Summary: Fix include order Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Signed-off-by:
-
Vihang Mehta authored
Summary: We want to track the domain name from the auth provider so let's use the domain name in the org table. Test Plan: skaffold Reviewers: michelle, philkuz Reviewed By: michelle Subscribers: philkuz Signed-off-by:
-
Nick Lanam authored
Summary: No breaking changes. Yet another thing that was tried in efforts to fix the slow tests. Test Plan: `yarn test`. Smoke test the UI. Reviewers: #third_party_approvers, michelle, vihang Reviewed By: #third_party_approvers, vihang Signed-off-by:
-
Nick Lanam authored
Summary: This seems to be the real fix for our tests taking five minutes instead of thirty seconds. As such, basing this on top of D10167 to revert that change simultaneously. Test Plan: Watch this diff not fail tests due to timeout. `yarn test`. Smoke test UI. Seems whatever went wrong was somehow related to esbuild overhead. Reviewers: #third_party_approvers, michelle, vihang Reviewed By: #third_party_approvers, vihang Signed-off-by:
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
Yaxiong Zhao <yzhao@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10151 GitOrigin-RevId: 1ece34ceb3d93d7fc6a46f2787d824e65f1043cb
-
Michelle Nguyen authored
Summary: Previous diff added leaderElectionParams to our CRD (D10159) This diff actually passes the CRD through the operator + configmanager to fill out the vizier templates with the users config. one thing I realized when updating the vizier yamls: the name for vizier-metadata + vizier-cloud-connector match the resource name for their respective services. as a result, the resourceNameMatcher wasa also adding the template to the svc YAMLs, which is incorrect. to address this, I also updated the services names to include `svc` at the end. alternatively, we can update the `resourceNameMatcher` to also take a `resourceType` arg. However, our `patches` config does a similar resourceName matching and will be difficult to add `resourceType`, so I am leaning towards just making sure we have different resource names. Test Plan: built vizier rc, deployed rc and make sure everything starts up as expected Reviewers: vihang, jamesbartlett Reviewed By: vihang Signed-off-by:
-
Michelle Nguyen authored
Summary: we are seeing some users with very slow K8s clusters, whose leader elections keep failing. the solution is to increase the K8s leaderelection renew period (PL_RENEW_PERIOD env var in metaadata + cloudconn). this means that we need to expose this in the CRD. Since there are other leadership election env vars, i figured we should just make this a struct for cleanliness, in case we allow configuration for the other fields in the future. Test Plan: n/a Reviewers: jamesbartlett, vihang, philkuz Reviewed By: vihang, philkuz Signed-off-by:
-
Nick Lanam authored
Summary: There were a couple of breaking changes. - `jest.config.js`: `globals` no longer works the same way - The default test environment changed from `jsdom` to `node`. We use `jsdom`, so the config needs to specify that manually now. - The `spyOn` global doesn't exist anymore, as Jest has started separating from the Jasmine API slightly. Just a slight adjustment. - `babel-jest` is a fake ES Module now, so its import changed slightly. - Updated relevant types and plugins to match. - `jest-canvas-mock` hasn't been published in long enough that it's not compatible anymore; the `canvas` module serves as a suitable drop-in replacement. This was originally an attempt to find the cause of the now-very-slow tests, but it didn't end up affecting that. One more variable eliminated and one more chore complete as a side effect, either way. Test Plan: `yarn test`. No appreciable difference. The freakishly long test setup times are still present. Reviewers: #third_party_...
-
- 11 Nov, 2021 2 commits
-
-
Vihang Mehta authored
Summary: `browserlist` was complaining about an outdatted db. Test Plan: Ran `yarn test` no more messages about outdated `cauniuse` Reviewers: michelle, nlanam, #third_party_approvers Reviewed By: michelle, nlanam, #third_party_approvers Signed-off-by:
-
James Bartlett authored
Summary: Changes compiler implementation of Data access levels to support PIIRestricted, Restricted, and Full levels in a single compiler rule. The new PIIRestricted level injects px.redact_pii_best_effort after any memory sources with sensitive columns. Test Plan: Tried in skaffold. Reviewers: philkuz, nserrino Reviewed By: philkuz JIRA Issues: PP-3104 Signed-off-by:
James Bartlett <jamesbartlett@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10128 GitOrigin-RevId: 4d4dfaafd3b05ff3e6c80b3e114654d0054a1e03
-
