Unverified Commit 8c1660b7 authored by Michelle Nguyen's avatar Michelle Nguyen Committed by Copybara
Browse files

Add tableStoreTableSizeLimit flag to CLI


Summary:
previous diffs added the tableStoreTableSizeLimit flag to the CRD + vizier templates.
this diff allows you to specify your value for tableStoreTableSizeLimit in the CLI.

Test Plan: n/a

Reviewers: jamesbartlett, vihang, rcheng

Reviewed By: vihang, rcheng
Signed-off-by: default avatarMichelle Nguyen <michellenguyen@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10181

GitOrigin-RevId: 79ddaf3b94f685bcacde9aa9e6473dc2128db20c
parent 9924ac6a
Showing with 5 additions and 0 deletions
+5 -0
......@@ -184,6 +184,9 @@ func init() {
DeployCmd.Flags().Uint32("datastream_buffer_spike_size", 500*1024*1024, "Internal data collector parameters: the maximum temporary size of a data stream buffer before processing.")
viper.BindPFlag("datastream_buffer_spike_size", DeployCmd.Flags().Lookup("datastream_buffer_spike_size"))
DeployCmd.Flags().Int32("table_store_table_size", 64*1024*1024, "TableStoreTableSizeLimit is the maximum allowed size for a table in the table store. When the size grows beyond this limit, old data will be discarded.")
viper.BindPFlag("table_store_table_size", DeployCmd.Flags().Lookup("table_store_table_size"))
// Super secret flags for Pixies.
DeployCmd.Flags().MarkHidden("namespace")
}
......@@ -253,6 +256,7 @@ func runDeployCmd(cmd *cobra.Command, args []string) {
dataAccess, _ := cmd.Flags().GetString("data_access")
datastreamBufferSize, _ := cmd.Flags().GetUint32("datastream_buffer_size")
datastreamBufferSpikeSize, _ := cmd.Flags().GetUint32("datastream_buffer_spike_size")
tableStoreTableSize, _ := cmd.Flags().GetInt32("table_store_table_size")
labelMap := make(map[string]string)
if customLabels != "" {
......@@ -428,6 +432,7 @@ func runDeployCmd(cmd *cobra.Command, args []string) {
"dataCollectorParams": &map[string]interface{}{
"datastreamBufferSize": datastreamBufferSize,
"datastreamBufferSpikeSize": datastreamBufferSpikeSize,
"tableStoreTableSize": tableStoreTableSize,
},
},
Release: &map[string]interface{}{
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment