Unverified Commit 97182f94 authored by yzhao1012's avatar yzhao1012 Committed by Copybara
Browse files

Add loggings of statistics of socket tracer data event sizes


Test Plan: Tested manually and see the printed logs

Reviewers: #stirling, oazizi

Reviewed By: #stirling, oazizi
Signed-off-by: default avataryzhao1012 <yzhao@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10835

GitOrigin-RevId: b0055efd43ed692a28d42b95501c52c462b6b534
parent 518c9e11
release/vizier/v0.11.7 release/vizier/v0.11.6 release/vizier/v0.11.5 release/vizier/v0.11.4 release/vizier/v0.11.3 release/vizier/v0.11.2 release/vizier/v0.11.1 release/vizier/v0.11.0 release/vizier/v0.10.22 release/vizier/v0.10.21 release/vizier/v0.10.20 release/vizier/v0.10.19 release/vizier/v0.10.18 release/vizier/v0.10.17 release/vizier/v0.10.16 release/vizier/v0.10.15 release/vizier/v0.10.14 release/vizier/v0.10.13 release/operator/v0.0.30 release/operator/v0.0.29 release/operator/v0.0.28 release/operator/v0.0.27 release/operator/v0.0.26 release/operator/v0.0.25 release/operator/v0.0.24 release/operator/v0.0.23 release/operator/v0.0.22 release/operator/v0.0.21 release/operator/v0.0.20 release/cloud/prod/1658198111 release/cloud/prod/1658185818 release/cloud/prod/1658183222 release/cloud/prod/1657740688 release/cloud/prod/1657049209 release/cloud/prod/1656629056 release/cloud/prod/1656527373 release/cloud/prod/1656452950 release/cloud/prod/1655997138 release/cloud/prod/1655226092 release/cloud/prod/1654806360 release/cloud/prod/1654144074 release/cloud/prod/1654133791 release/cloud/prod/1652313416 release/cloud/prod/1652304483 release/cloud/prod/1652214656 release/cloud/prod/1651864223 release/cloud/prod/1651799821 release/cloud/prod/1651704659 release/cloud/prod/1651616922 release/cloud/prod/1650645384 release/cloud/prod/1650480744 release/cloud/prod/1650306041 release/cloud/prod/1650056868 release/cloud/prod/1650039340 release/cloud/prod/1649978499 release/cloud/prod/1649797942 release/cloud/prod/1649787581 release/cloud/prod/1649269698 release/cloud/prod/1649107437 release/cloud/prod/1648586238 release/cloud/prod/1647992139 release/cloud/prod/1647379907 release/cloud/prod/1646182041 release/cli/v0.7.16 release/cli/v0.7.15 release/cli/v0.7.14 release/cli/v0.7.13 release/cli/v0.7.12 release/cli/v0.7.11 release/cli/v0.7.10 release/cli/v0.7.9 release/cli/v0.7.8 release/cli/v0.7.7 release/cli/v0.7.6 release/cli/v0.7.5
No related merge requests found
Showing with 11 additions and 1 deletion
+11 -1
......@@ -666,10 +666,11 @@ Status SocketTraceConnector::DisableSelfTracing() {
// Perf Buffer Polling and Callback functions.
//-----------------------------------------------------------------------------
void SocketTraceConnector::HandleDataEvent(void* cb_cookie, void* data, int /*data_size*/) {
void SocketTraceConnector::HandleDataEvent(void* cb_cookie, void* data, int data_size) {
DCHECK(cb_cookie != nullptr) << "Perf buffer callback not set-up properly. Missing cb_cookie.";
auto* connector = static_cast<SocketTraceConnector*>(cb_cookie);
auto data_event_ptr = std::make_unique<SocketDataEvent>(data);
connector->stats_.Increment(StatKey::kPollSocketDataEventSize, data_size);
connector->AcceptDataEvent(std::move(data_event_ptr));
}
......@@ -775,6 +776,10 @@ void SocketTraceConnector::AcceptDataEvent(std::unique_ptr<SocketDataEvent> even
WriteDataEvent(*event);
}
stats_.Increment(StatKey::kPollSocketDataEventCount);
stats_.Increment(StatKey::kPollSocketDataEventAttrSize, sizeof(event->attr));
stats_.Increment(StatKey::kPollSocketDataEventDataSize, event->msg.size());
ConnTracker& tracker = GetOrCreateConnTracker(event->attr.conn_id);
tracker.AddDataEvent(std::move(event));
}
......
......@@ -251,6 +251,11 @@ class SocketTraceConnector : public SourceConnector, public bpf_tools::BCCWrappe
kLossConnStatsEvent,
kLossMMapEvent,
kLossHTTP2Event,
kPollSocketDataEventCount,
kPollSocketDataEventAttrSize,
kPollSocketDataEventDataSize,
kPollSocketDataEventSize,
};
utils::StatCounter<StatKey> stats_;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment