* sly.el (sly-macroexpansion-minor-mode-map): Use defvar.
(sly-show-notes): Use `sly-button-flash'.

* contrib/sly-mrepl.el (sly-mrepl-mode-map): Define more interesting
bindings for M-p and M-n, also C-M-p, C-M-n.
(sly-mrepl--make-result-button): Assign `sly-button-search-id' to
new button.
(sly-mrepl-previous-input-or-button)
(sly-mrepl-next-input-or-button): New functions.

* contrib/sly-stickers.el (sly-stickers--echo-sticker): Use new `sly-button-flash'
(sly-stickers--flash-sticker): Removed.
(sly-stickers-fetch): Use new `sly-button-flash'

* lib/sly-buttons.el (sly-button-at): Use `button-type-subtype-p'
(sly-button): Set a basic `sly-button-search-id' here.
(sly-button-flash): New function.
(sly-button-echo-part): Flash buttons by default.
(sly-button--overlays-starting-at): Renamed to
`sly-button--searchable-buttons-starting-at'
(sly-button--searchable-buttons-at): Consider text buttons.
(sly-button-search): Use `sly-button--searchable-buttons-at'
(sly-button-search): Error instead of message.

* test/sly-mrepl-tests.el (sly-mrepl-tests--assert-prompt): More
interesting search for prompt.
(sly-mrepl-tests--with-basic-repl-setup): New macro.
(repl-values-and-button-navigation): New test.

* sly.el (sly-macroexpansion-minor-mode-map): Use defvar.

* contrib/sly-mrepl.el (sly-mrepl-shortcut-key): Move down to "comma shortcut" section.
(sly-mrepl-reset-shortcut-key): Check for `sly-mrepl-shortcut-key' with boundp.

* sly-mrepl.el (sly-mrepl-shortcut-key): Add a `:set'
specification, otherwise the variable's useless.
(sly-mrepl-reset-shortcut-key): New function.
(sly-mrepl--shortcut-location-p): Only attempt to search for "`"
if the shortcut key is ","

* contrib/sly-mrepl.el (sly-mrepl--eval-for-repl): Use `after-prompt'.
(sly-mrepl--eval-for-repl): Accept `before-prompt' and
`after-prompt' callbacks.
(sly-mrepl--copy-objects-to-repl): Pass `callback' as an
`after-prompt' callback.
(sly-mrepl--insert-call): Fix off-by-one.

* contrib/sly-mrepl.el (sly-mrepl--copy-to-repl-after): Removed
hackish variable.
(sly-mrepl-mode): Ditto.
(:copy-to-repl): Delete channel method.
(sly-mrepl--insert-prompt): `condition' arg is optional.
(sly-mrepl--eval-for-repl): New function (little relation to the
old function with the same name.)
(sly-mrepl--copy-objects-to-repl): Use `sly-mrepl--eval-for-mrepl'
(sly-mrepl--save-and-copy-for-repl): Renamed from
`sly-mrepl--eval-for-mrepl'.
(sly-inspector-copy-part-to-repl, sly-db-copy-part-to-repl)
(sly-apropos-copy-symbol-to-repl)
(sly-trace-dialog-copy-part-to-repl, sly-db-copy-call-to-repl)
(sly-trace-dialog-copy-call-to-repl, sly-mrepl-set-directory): Use
`sly-mrepl--save-and-copy-for-repl'.
(sly-mrepl-set-package): Use `sly-mrepl--eval-for-repl'.

* contrib/slynk-mrepl.lisp (copy-values-to-repl): Deleted.
(prompt-arguments): New helper.
(send-prompt): Use PROMPT-ARGUMENTS.
(:copy-to-repl): Removed channel method.
(:sync-package-and-default-directory): Removed channel method.
(guess-and-set-package): Moved slyfun down.
(eval-for-mrepl): Add docstring and clarify behaviour.
(copy-to-repl, sync-package-and-default-directory): New "slave" slyfuns.

* contrib/sly-mrepl.el (sly-mrepl-shortcut-key): New variable.
(sly-mrepl-mode-map): New entry for `sly-mrepl-shortcut-key'
(sly-mrepl--shortcut-location-p): New helper.
(sly-mrepl-shortcut-alist): New variable.
(sly-mrepl-set-package, sly-mrepl-set-directory): New functions.
(sly-mrepl-shortcut): New interactive command.

* contrib/slynk-mrepl.lisp (:sync-package-and-default-directory):
Use new GUESS-AND-SET-PACKAGE.
(guess-and-set-package): New slyfun.
(with-eval-for-repl): Accept an extra MREPL-SYM arg
(eval-for-mrepl): Send prompt after evaluating slave slyfun.

* Makefile (check-%): Accept extra SELECTOR arg
(check-fancy): `debug-on-error' is useless.

* contrib/sly-mrepl.el (sly-mrepl--teardown): Cleanup `sly-mrepl--channel'
property in dedicated stream process.
(sly-mrepl--dedicated-stream-output-filter): Protect against
killed buffers.

* test/sly-stickers-tests.el (sly-stickers--call-with-fixture):
Reorganize macro helper.
(sly-stickers--face-p): Make logic explicit.
(stickers-record-stuff): Remove useless "coiso" sticker.
(stickers-record-stuff): Add extra check and sync.

Actually leave one in contrib/sly-cl-indent.el that I have to analyse.

* sly.el: Replace functions from 'cl with their cl-lib
counterparts.
(require): Don't require 'cl, not even when compiling.
(sly-read-symbol-name): Move down to avoid compiler warning.
(sly-def-connection-var): Use gv-define-setter, not defsetf.
(sly--this-inspector-name): Move up to avoid compiler warning.

* contrib/sly-mrepl.el: Replace functions from 'cl with their cl-lib
counterparts.

* contrib/sly-stickers.el: Replace functions from 'cl with their cl-lib
counterparts.

* contrib/sly-mrepl.el (sly-mrepl-part): New "describe" and "inspect" actions.
(listener): Set result-counter to -1.

* contrib/swank-mrepl.lisp (with-eval-for-repl): New macro.
(eval-for-mrepl): Use it.
(inspect-entry): Use it.
(describe-entry, pprint-entry): New functions.

* sly-mrepl.el (sly-mrepl): Bind "C-c C-z" to `sly-mrepl'
in SLY's editing mode map. Thanks to Javier Olaechea for idea.

* sly-mrepl.el (sly-mrepl-mode-hook): Explicitly declare
hook.
(sly-mrepl--ensure-no-font-lock): Add it.
(sly-mrepl--send-input-sexp): Add `save-excursion' hack.

* sly-mrepl.el (sly-mrepl-mode): Make sure
`inhibit-field-text-motion' is nil for mrepl's.

* sly.el (sly--when-let): Renamed from `when-let'.

* contrib/sly-mrepl.el (sly-mrepl--insert-prompt)
(sly-mrepl--open-dedicated-stream): Use `sly--when-let'

* contrib/sly-package-fu.el (sly-goto-package-source-definition): Use
`sly--when-let'

Also cleanup whitespace

* sly-mrepl.el (sly-mrepl-return, sly-mrepl--insert-prompt): Don't
use `sly-mrepl--recenter'.
(sly-mrepl--recenter): Removed.
(sly-mrepl-mode): Set three comint scrolling-related vars to nil.

* contrib/sly-mrepl.el (sly-mrepl-new): tweak sylvester insertion.
(sly-mrepl-random-sylvester): Don't add "art by"

* contrib/sylvesters.txt: Restore original signatures.

* sly-mrepl.el (sly-mrepl-mode): Set
`parse-sexp-ignore-comments' to t

* contrib/sly-mrepl.el (sly-mrepl): Add `sly-mrepl-on-connection' to `sly-connected-hook'
(sly-mrepl-pop-sylvester): New variable.
(sly-mrepl-on-connection): Renamed from `sly-mrepl-pop-to-mrepl'. Use `sly-mrepl-pop-sylvester'
(sly-mrepl-new): Pop a sylvester sometimes.
(sly-mrepl--sylvesters): New variable.
(sly-mrepl-random-sylvester): New function.

* sly.el (sly-dispatch-event): Must be %s, not %d.

* contrib/sly-mrepl.el (sly-mrepl--with-repl-for)
(sly-mrepl--call-with-repl): New macro and helper function.
(sly-mrepl--eval-for-repl)
(sly-mrepl-sync-package-and-default-directory): Use
`sly-mrepl--with-repl-for' macro.

* sly-mrepl.el
(sly-mrepl-sync-package-and-default-directory): Actually switch to
the directory.

* sly.el (sly-read-from-minibuffer): Don't allow empty strings
unless `allow-empty' is passed.
(sly-read-from-minibuffer-for-swank): Pass `allow-empty' to
`sly-read-from-minibuffer'.
(sly-thread-control-mode): Ensure `sly-mode' is enterer.
(sly-show-description, sly-thread-control-mode): Ensure
popup-buffer is read-only
* lib/lisp/swank.lisp (istate>elisp): Don't transmit :SERIAL while
we don't know what to do with it.

* contrib/sly-mrepl.el (sly-mrepl): Allow returning apropos
symbols to REPL.
(sly-mrepl-return): Shoosh warning.
(sly-apropos-copy-symbol-to-repl): New function.

* sly-mrepl.el (sly-mrepl-return): Go to end before
submitting input to read, and don't save it in history.

* contrib/sly-mrepl.el (sly-mrepl--accept-process-output): New function.
(sly-mrepl--insert-prompt, :set-read-mode): Use it.
(sly-mrepl--read-mode): Renamed from
`sly-mrepl--expect-sexp-mode'
(:set-read-mode): Unset then reset read-only when reading from
user. Call `sly-mrepl--catch-up'.
(sly-mrepl--insert-output, sly-mrepl-return): use
`sly-mrepl--read-mode'

Also organize code in contrib/swank-mrepl.lisp

* contrib/sly-mrepl.el (:inspect-object): Removed, replaced by
usage of a slyfun.
(sly-mrepl-part): Use `sly-eval-for-inspector'

* contrib/swank-mrepl.lisp (eval-for-mrepl): New SLYFUN. Replaces
`eval-in-mrepl'.
(inspect-entry): New SLYFUN. Replaces the :inspect-object channel
method.
(:inspect-object): Deleted channel method.

* contrib/sly-mrepl.el (sly-mrepl--copy-objects-to-repl): Issue
warning instead of error.

* sly-mrepl.el (sly-mrepl--teardown): Slightly cleaner teardown.

* NEWS.md: Update.

* sly.el (sly-complete-symbol-function): "Compound style" option
points to `sly-c-p-c-complete-symbol'

* contrib/sly-fuzzy.el (sly-c-p-c-symbol-completions)
(sly-c-p-c-char-name-completions, sly-c-p-c-complete-symbol): New function.

* contrib/sly-mrepl.el (sly-mrepl-mode): Pass 1 to `sly-mode'

* sly.el (sly-buffer-name): New implementation.
(sly-compose): New function.
(sly-process-available-input, sly-net-send): Pass process to
`sly-log-event'
(sly-handle-net-read-error): Pass process to `sly-buffer-name'
(sly-set-connection-info): Commit the final events buffer name
here.
(sly-dispatch-event): Pass connection to `sly-buffer-name'
(sly-log-event): Pass process to `sly-events-buffer'
(sly-events-buffer): Store the buffer as a process property.
(sly-list-threads, sly-with-xref-buffer, sly-show-apropos): Pass
connection to `sly-buffer-name'
(sldb-get-buffer): Use `sly-buffer-name'
(sly-update-threads-buffer): Takes new arg `buffer'
(sly--display-threads): Renamed from `sly-display-threads'
(sly-inspector-buffer): Pass connectino to `sly-buffer-name'
(sly-open-inspector): No need to set `sly-buffer-connection' here

* contrib/sly-autodoc.el (sly-autodoc--fontify-string): Adapt to new `sly-buffer-name'

* contrib/sly-mrepl.el (sly-mrepl--buffer-name): Use `sly-buffer-name'
(sly-mrepl--find-buffer): Find shortest named REPL.
(sly-mrepl): Pass connection to `sly-mrepl--find-create'
(sly-mrepl-pop-to-mrepl): No need to call `pop-to-buffer'
(sly-mrepl-new): Take `connection' and `handle' args. Prompt user
for REPL nickname.

* contrib/sly-trace-dialog.el (sly-trace-dialog--buffer-name): Use `sly-buffer-name'

* lib/sly-tests.el (sly-inspector-visible-p): Pass connection to `sly-buffer-name'

* sly.el (sly-inspector-mode-map, sldb-mode-map)
(sly-xref-mode-map): Use `set-keymap-parent' and set
`button-buffer-map' as the parent.

* contrib/sly-trace-dialog.el (sly-trace-dialog-mode-map): Use
`set-keymap-parent' and set `button-buffer-map' as the parent.
(sly-trace-dialog-part, sly-trace-dialog-spec): Don't skip these buttons.
(sly-trace-dialog--insert-trace): Skip just the "id string" button
* contrib/swank-trace-dialog.lisp: Reorganized functions.
(trace-part-or-lose, trace-or-lose): Renamed and reworked from
FIND-TRACE-PART-OR-LOSE and FIND-TRACE

* contrib/sly-mrepl.el (:clear-repl-history):  New channel method.
(sly-mrepl--insert-output): Propertize with field.
(sly-mrepl--assert-mrepl): New helper.
(sly-mrepl-insert-input): Use `sly-mrepl--assert-mrepl'
(sly-mrepl-clear-repl, sly-mrepl-clear-recent-output): New
interactive commands.
(sly-mrepl--menu): Add new commands to menu.

* contrib/swank-mrepl.lisp (:clear-repl-history): New channel method.

Need unit tests badly.

* sly-mrepl.el (sly-mrepl--insert-output): Don't check for
`sly-mrepl--busy-p'. Take optional `face' parameter. Use
`sly-mrepl--break-output-p'
(sly-mrepl--break-output-p): New function.
(sly-mrepl--dedicated-stream-output-filter, :write-string): Insert
output in `sly-mrepl-output-face'

This fixes an apparently buggy `accept-process-output' on Windows
which sometimes leads to mixed output and return values in the mREPL.

* sly-autoloads.el (sly-contribs): Default this variable to a list
with `sly-fancy' as the sole argument.

* sly.el (sly-inspectable-value-face): Removed.
(define-sldb-faces): Removed unused faces
(sly-mode-line): Better face inheritance.
(sly--mode-line-format): Switch connection and package information.
(sly-message): Protect against message bodies with format
constructs.
(sly-minibuffer-respecting-message): Resurrect. Needed by
sly-fuzzy and sly-c-p-c contribs.
(sly-apropos-symbol): Better face.
(sly-apropos-insert-symbol): Better face.
(sly-xref-face): Removed.
(sly-xref): Use a proper `sly-part-button'
(sly-insert-xrefs): Pass more args to `make-text-button'
(sly-inspector-topline-face, sly-inspector-label-face)
(sly-inspector-action-face, sly-inspector-type-face): Removed.

* contrib/sly-c-p-c.el (sly-complete-symbol*): Don't call
`sly-maybe-complete-as-filename'. It has been removed.

* contrib/sly-fuzzy.el (sly-fuzzy): Insinuate into
`sly-complete-symbol-function' on load.

* contrib/sly-fuzzy.el (sly-fuzzy-insert): Don't error here, it's
annoying.

* contrib/sly-mrepl.el (sly-mrepl--insert-output): Use a face.
(sly-mrepl--insert-prompt): Include "> " in the propertized prompt.
(sly-mrepl-output-face): New face.
(sly-mrepl-prompt-face): Better face.

* contrib/sly-trace-dialog.el (sly-trace-dialog-part-button): Use a better
label.
(sly-trace-dialog--insert-trace): Use the normal face for
`sly-part' buttons.

* lib/sly-buttons.el (sly-action-face, sly-part-button-face): New faces.
(sly-action): Use `sly-action-face'

* sly.el (sly-warning): Renamed from `sly-display-warning'

* contrib/sly-fontifying-fu.el (sly-search-suppressed-forms)
(sly-extend-region-for-font-lock): Use new `sly-warning'

* contrib/sly-mrepl.el (sly-mrepl--commit-buffer-name): Use new
`sly-warning'.

* contrib/sly-autodoc.el (sly-autodoc): Check for live connection.

* contrib/sly-mrepl.el (sly-mrepl-inside-string-or-comment-p): Check for
live mrepl process.

* sly.el (sly-modeline-string): Removed.
(sly-mode-line): New face
(sly-mode-line-format): New variable
(sly--mode-line-format): New function
(sly-modeline-state-string): Removed.
(sly-cycle-connections): Handle more cases.
(sly-dispatch-event): Update modeline more often.
(sly-selector-methods, sly-selector-other-window, sly-selector)
(def-sly-selector-method, etc): get rid of sly-selector.

* contrib/sly-autodoc.el (sly-autodoc-mode): Don't clutter
modeline with "Autodoc"

* contrib/sly-mrepl.el (sly-mrepl-mode): Don't clutter modeline
with dummy process status.
(def-sly-selector-method ?m): Removed.

* contrib/sly-scratch.el (sly-scratch): No :on-load section.

* doc/slime.texi (Top): Remove `sly-selector' node.
(Key bindings): Come up with another example.
(sly-selector): Delete.
(Multiple connections): Don't mention `sly-selector'

Other uses of the minibuffer always prefix the message with
"[sly]"

* sly.el (sly-message): Redone.
(sly-message-function, sly-background-message-function)
(sly-background-message): Removed.
(sly-error): New function.