This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 18 Nov, 2021 6 commits
-
-
Vihang Mehta authored
Summary: Add a signup complete handler that will try to refetch the token from the existing session. Test Plan: yarn dev Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10221 GitOrigin-RevId: c73ffa67766b4b50c865115ff1c65407cdf11e6e
-
Phillip Kuznetsov authored
Summary: Part of a series of diffs to make CreateOrg work. This one wires up the frontend with the gql calls necessary. Also makes a post request to the backend after the call succeeds to refresh the claims on the auth token so that the user will be properly authorized. Test Plan: Tested against skaffold backend and able to login. Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10220 GitOrigin-RevId: ba9bc293c17d05467b91d7fc9eac4fcf9a8a7851
-
Phillip Kuznetsov authored
Summary: Create a refresh endpoint in the api that allows users with valid tokens to get updated claims. Mainly used so that we can get refreshed claims after a user Creates an org, can be used more generally in the future if we must update claims regularly. Test Plan: Tested on skaffold Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10219 GitOrigin-RevId: 0b51a0660daede3fbc8f430d15bdf95bd98347dc
-
Vihang Mehta authored
Summary: Login heavily relies on PLOrgID for a lot of things. However with the new email password based users, org creation happens later. So switch to fetching the user using the AuthProviderID and then looking at the orgID from our database instead. Ensure that this orgID is also included in the JWT from the login response. Test Plan: Existing tests Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10218 GitOrigin-RevId: 5f394d5afb206491ed337d74645e7ea84be0ae8f
-
Omid Azizi authored
Summary: Macro cleanup in preparation for further changes. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Signed-off-by:
Omid Azizi <oazizi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10198 GitOrigin-RevId: 507d219c70a406991cd579fe8c0c9f98a2b9649b
-
Omid Azizi authored
Summary: To address cases where /proc/version and uname are giving the wrong kernel version, use the vDSO .note section to try and extract the kernel version. This should be the most reliable version yet, if the .notes section exists. Test Plan: Tests adapted. Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao, jps Signed-off-by:
Omid Azizi <oazizi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10215 GitOrigin-RevId: 69d22103fde9a0e2522f4560c9023a152400e6b8
-
- 17 Nov, 2021 14 commits
-
-
Vihang Mehta authored
Summary: Org data should be fetched from the OrgService Test Plan: N/A Reviewers: michelle, philkuz Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10213 GitOrigin-RevId: 027a69b20912d723bc288af8a74030db0e783ea6
-
Phillip Kuznetsov authored
Summary: UI makes a request to GetOrg for a user via the org_resolver. For the new org-less users this would cause a panic. Now we want to not throw a panic and continue onwards. Test Plan: Tested on skaffold with a cluster that would detect such a state. Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10211 GitOrigin-RevId: 381db6f4bef0e3cdb609fd5efb6e45cc74b21fc5
-
Vihang Mehta authored
Summary: Adds graphql support for CreateOrg and wires it up to the cloud API. Test Plan: Added test Reviewers: michelle, philkuz Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10210 GitOrigin-RevId: c087239d232a199d5bc31a6761f42fc838cfe374
-
Vihang Mehta authored
Summary: Adds a CreateOrg method which will validate the given OrgName, create the org and then add the current user to said org. Test Plan: Added tests Reviewers: michelle, philkuz Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10201 GitOrigin-RevId: c0c52a010294913532e0517758148e23c1f33c84
-
Vihang Mehta authored
Summary: Checks to make sure User isn't already in an org and org is empty and if so, let's the user update their own org. This will be used by the create org flow. Test Plan: Added tests Reviewers: michelle, philkuz Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10209 GitOrigin-RevId: 0c5899952e1489ebbf36df0b235fe8b9d110a34c
-
Vihang Mehta authored
Summary: Allow `UpdateUser` to set org, add a helper to check if an org is empty. Test Plan: Added tests Reviewers: michelle, philkuz Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10207 GitOrigin-RevId: 20c1fb41616ee71ee90de3fa4131758ac9ec1f23
-
Michelle Nguyen authored
Summary: These are github issues that will be filed by developers working on Pixie. Other github issue templates (for ex: feature requests), are filed by the broader community. Test Plan: n/a Reviewers: vihang, htroisi, nserrino, zasgar Reviewed By: vihang, htroisi JIRA Issues: PP-3119 Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10208 GitOrigin-RevId: c575317619eb11586bdeaaff2f0c089064569a04
-
Michelle Nguyen authored
Summary: The toplevel field was missing from the vizier template Test Plan: n/a Reviewers: vihang, jamesbartlett Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10206 GitOrigin-RevId: 5bc5144965052d879153646bb392bad70ba0a071
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
Yaxiong Zhao <yzhao@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10203 GitOrigin-RevId: d89636add0aabe846ed9fecb95c1259d71520e9c
-
Michelle Nguyen authored
Summary: this column was preemptively created during table creation, but is unused. it would actually contain the same information as the `created_at` col that also exists in the table. since we're not using it, we might as well remove it for cleanliness Test Plan: stuff still builds. there is no use of this anywhere in the code Reviewers: nserrino, vihang, zasgar Reviewed By: nserrino, vihang JIRA Issues: PC-1248 Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10199 GitOrigin-RevId: 38a9608c1a053b6ca775b73dbd2f5749b54f5c0f
-
Yaxiong Zhao authored
Summary: Also added test for alpine image. Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: jps, oazizi Signed-off-by:
Yaxiong Zhao <yzhao@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10170 GitOrigin-RevId: 93812ad1279b1f9d6088202bc9840b73e6853c77
-
Nick Lanam authored
Summary: Creates a `/setup` route, that intercepts other routes when the user logs in but still has to set up their organization. This diff leaves stubs for the following behavior. There is a TODO at each site to explain what to change. - Deciding if setup is complete: currently assumes it is. - Validation of org name: just checks that it's at least three characters long. - Actually creating the org: pretends that it did, then redirects a moment later. Seeing the page: {F173137} Invalid input: {F173138} Valid input: {F173143} Test Plan: To see the setup page, go to `containers/App/live.tsx` and force `setupComplete` to be false. When the page refreshes, all non-auth-related requests should force their way to the new `/setup` route, with a valid `redirect_uri`. The button labeled `Create` becomes enabled when the org name is typed in and has at least two characters. Clicking the button shows a message, then tries to redirect to the place you started. When the se...
-
Phillip Kuznetsov authored
Summary: Remove extra comments Test Plan: n/a Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10196 GitOrigin-RevId: 69b3185cbdf205b9765db0e67283effe29ab5d26
-
Phillip Kuznetsov authored
Summary: Among the grpc requests we make, org_grpc is the only one that allows users to pass in an org_id. We dont' want to allow users to get info about other orgs via the interface, but the interface implies that they can. The implementations currently block any such requests. That eventually might change so this is an important step to prevent users from a future potential leak. This diff just adds a comparison to make sure the claimsID matches the requested ID. Test Plan: Added test set that check whether the functions will be blocked when the user make requests for other orgs and allowed when the user requests for their own org. Reviewers: michelle, vihang Reviewed By: michelle Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10202 GitOrigin-RevId: 59d6e4e6c47b63eab9d8cf442bfaf9d89b38f335
-
- 16 Nov, 2021 12 commits
-
-
Vihang Mehta authored
Summary: TSIA, no one sets this to true. Test Plan: N/A Reviewers: philkuz, michelle Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10197 GitOrigin-RevId: 86635492608a2e6c598aa055c4636fbf5bde885e
-
Ryan Cheng authored
Summary: This diff adds full body tracing of JoinGroup, which will be necessary to visualize consumer rebalance. Test Plan: Unit tests and updated kafka_trace_bpf_test Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Signed-off-by:
Ryan Cheng <rcheng@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10122 GitOrigin-RevId: 81d01ee64a497d35c44e5525a5ce222fbeff9d4d
-
Phillip Kuznetsov authored
Summary: For new User/Password logins, we need to be able to login and create users who don't belong to an org. This diff comes from an investigation of what happens when a user tries to login without an OrgID. After this diff, we need to detect users who are in this state in the UI, then transfer them to a CreateOrg page that we can then use to submit CreateOrg requests. Test Plan: Tested on skaffold and authenticated. Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10188 GitOrigin-RevId: b1175bc904c7ef1b36969c914dfcf6248c7c70f0
-
Vihang Mehta authored
Summary: Renders a more friendly message when a user needs to verify their email. Test Plan: yarn dev Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10195 GitOrigin-RevId: 20c65d98a35be00119c1fa2928b48537f66768cd
-
Vihang Mehta authored
Summary: Accidentally misconfigured this. Test Plan: skaffold dev Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10194 GitOrigin-RevId: 0576ba4488bd304ff4501a42f1e1261f4e9662fe
-
Nick Lanam authored
Summary: TSIA. Login before: {F173059} Login after: {F173054} Signup before: {F173058} Signup after: {F173055} Test Plan: In `webpack.config.js`, set `authEmailPasswordConnection` to `https://foo.bar` , then look at the login page and the signup page. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1275 Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10191 GitOrigin-RevId: f7e47cc2c5919039d58cac9cf99b5a122e1b5610
-
Vihang Mehta authored
Summary: The hints on whether to render login or signup changed. Test Plan: skaffold dev Reviewers: michelle, philkuz Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10190 GitOrigin-RevId: 8b18be4eff32f594e9fef71aa4498570c494aefb
-
Michelle Nguyen authored
Summary: These tests have been flaky 3% of the time. After some investigation, it looks like there is some difference between using `Queryx` and `Exec` and when transactions are committed. Test Plan: ran test 1000 times Reviewers: philkuz, vihang Reviewed By: philkuz, vihang JIRA Issues: PC-1272 Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10189 GitOrigin-RevId: 7dfd4887562e638b4b1ee1c45d230c1b72d81009
-
Vihang Mehta authored
Test Plan: skaffold dev cloud Reviewers: michelle, philkuz Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10185 GitOrigin-RevId: a1cbc718939955103ed9551d0715ed261a997b0f
-
Vihang Mehta authored
Summary: D10183 didn't quite work. This fixes the issues. Test Plan: Fixed tests Reviewers: philkuz, michelle Reviewed By: philkuz JIRA Issues: PC-1259 Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10187 GitOrigin-RevId: b50f8b50eb800391e1a566a1e962ac309643337e
-
Michelle Nguyen authored
Summary: previous diffs added the tableStoreTableSizeLimit flag to the CRD + vizier templates. this diff allows you to specify your value for tableStoreTableSizeLimit in the CLI. Test Plan: n/a Reviewers: jamesbartlett, vihang, rcheng Reviewed By: vihang, rcheng Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10181 GitOrigin-RevId: 79ddaf3b94f685bcacde9aa9e6473dc2128db20c
-
Michelle Nguyen authored
Summary: previous diff added the field to the CRD. this diff propagates it through the vizier tmpl pipeline. Test Plan: n/a Reviewers: jamesbartlett, vihang, rcheng Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10180 GitOrigin-RevId: 14b53b101aa78e9bd7551fdaf0d153a4bdbbfba0
-
- 15 Nov, 2021 7 commits
-
-
Michelle Nguyen authored
Summary: there are cases where users may want to patch all of their deployments (for example, apply nodeselectors to all deployments). this currently does not work since the svc names match the exact resource names of the deployments themselves. since we do patches by matching resource names, this leads to invalid YAMLs. instead, we should rename our services so that each resource can be patched Test Plan: built vizier rc, deployed with patches Reviewers: vihang Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10182 GitOrigin-RevId: 464cdaab236285ee8b92886b52622f834666c2ed
-
Michelle Nguyen authored
Summary: We also want to make the table store's table size limit configurable via the CRD. this diff adds the field to the CRD. a followup diff will make sure that this is wired into the vizier tmpl pipeline. Test Plan: n/a Reviewers: jamesbartlett, vihang, rcheng Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10179 GitOrigin-RevId: d8a85e888ddc63bd7b01b404b168449128b761ae
-
Phillip Kuznetsov authored
Summary: Users who would tried to call GetAugmentedToken but lacked an org would receive an error. This call is made as part of the GRPC middleware in the api_server. We will need to call GetUser/ GetOrg() from the UI in these cases so probably just allow users to login without an org. This diff is part of a series to enable user/password signup flows. We will need to allow users to exist in the database without an OrgID and make sure that the data is accessible to users. Risk - we are creating a new opening for users to log in without an org ID. We might provide more access than we intend. However, most features are org-gated anyways - meaning we restrict info so that only the org members can view clusters, org members, so those risks will be limited. Test Plan: Updated the test. No chance to do an integration because we don't support orgless users yet. Reviewers: vihang, michelle, nserrino Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10184 GitOrigin-RevId: b199c233d18d840e224b567a9c21cccaa971a0dc
-
Vihang Mehta authored
Summary: For the Username/Password based auth, user creation and org creation are going to be split out and users will be created first without any associated orgs. Test Plan: Added tests Reviewers: michelle, philkuz Reviewed By: philkuz JIRA Issues: PC-1259 Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10183 GitOrigin-RevId: f90a68da2e19a4e00e048cbedc61d5f02b7e1224
-
Phillip Kuznetsov authored
Summary: We pass around this userID variable in login.go, but this has been available in UserInfo struct for quite a while now as the same value. To reduce confusion, we now just use the userInfo.AuthProviderID value in place of the userID. Evidence this was confusing shows up in the tests as well -we would use the PL User ID and authProviderID interchangably. This fixes that issue in the test. Test Plan: Tests still pass, can still login with skaffold Reviewers: vihang, michelle Reviewed By: vihang Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10154 GitOrigin-RevId: 05e2e3ad7e5514b4a3271efa47cde8f6c9ca4f60
-
Vihang Mehta authored
Summary: We mainly use `UserService` and `OrgService`. This is redundant. Test Plan: Existing tests Reviewers: michelle, zasgar Reviewed By: zasgar Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10174 GitOrigin-RevId: 6b701aee0a68d8c388c535cdef904d900c2a249e
-
Vihang Mehta authored
Summary: TSIA, this should help split up our `CreateUserAndOrg` methods and also will be useful for the create org flows later. Test Plan: Added tests. Reviewers: michelle, philkuz Reviewed By: michelle, philkuz JIRA Issues: PC-1258 Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10178 GitOrigin-RevId: 0888d7120759bdc4f9f5c9671b872e3020a16da6
-
- 14 Nov, 2021 1 commit
-
-
Vihang Mehta authored
Summary: This moves all consumers to use OrgService or ProfileService as appropriate and removed the deprecated methods in ProfileService. Test Plan: Existing tests Reviewers: michelle, philkuz, zasgar Reviewed By: philkuz Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D10175 GitOrigin-RevId: bf8766a43ed9dac264f8b95d1c7b7797ca40e153
-