This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 18 Nov, 2020 1 commit
-
-
Nick Lanam authored
Summary: Displays the Pixienaut being chased by an octopus instead of a big red triangle + exclamation point. Also adds an option to render with the Pixienaut on the toilet, in an "oh no" pose. Messaging for sign in, log in, and general auth errors made more friendly and given a call to action (navigating) button. The toilet pose is not in use yet. The goal going forward is to use the octopus for recoverable errors and the toilet for fatal errors. The octopus box: {F104225} The toilet box (not in use at this time, but fatal errors are welcome to use it going forward): {F104226} Test Plan: To trigger the log in error, try to log in with a Google account that isn't registered with us. To trigger the sign up error, try to register an account that is already registered. Reviewers: nserrino, michelle, #engineering, vihang Reviewed By: #engineering, vihang Subscribers: vihang JIRA Issues: PC-575 Differential Revision: https://phab.corp.pixielabs.ai/D6769 GitOrigin-RevId: 8c4e9cd3163f10e53a3ebafd82dd389ed0930cdc
-
- 21 Oct, 2020 1 commit
-
-
Nick Lanam authored
Summary: Currently only opens from a new button in the sidebar. A future change can make it appear once automatically per user. The button does not appear on mobile (viewport widths under 960px) as the tour does not fit there and the layout is different anyway. When it's open: {F103838} Test Plan: Open the profile/admin menu in the bottom left in the sidebar. It should contain a `Tour` item that should open the tour. Reviewers: nserrino, michelle, zasgar, #engineering Reviewed By: michelle, #engineering Subscribers: htroisi JIRA Issues: PC-426 Differential Revision: https://phab.corp.pixielabs.ai/D6557 GitOrigin-RevId: a8a8670fc811314ff2fc82478d0a2a00295ca2ee
-
- 18 Nov, 2020 3 commits
-
-
Vihang Mehta authored
Summary: `storybook` + `html-webpack-plugin` seem to not play nicely with webpack4. https://github.com/storybookjs/storybook/issues/9216 Force resolving `html-webpack-plugin` to a new alpha version seems to work. `babel` modules need to be upgraded to address `.mjs` files. https://github.com/babel/babel/issues/8462 `favicons-webpack-plugin` needs to be upgraded to handle API changes for webpack plugins https://github.com/jantimon/favicons-webpack-plugin/issues/222 Upgrading to the new alpha version seems to work. A handful of other plugins also don't work due to API changes in webpack but upgrading them to their latest stable versions works. Test Plan: Build time perf for Webpack4: ``` === PHASE SUMMARY INFORMATION === Total launch phase time 1.200 s 0.59% Total init phase time 0.342 s 0.17% Total target pattern evaluation phase time 1.228 s 0.61% Total interleaved loading-and-analysis phase time 1.807 s 0.89% Total preparation phase time 0.058 s 0.03% Total execution phase time 197.507 s 97.70% Total finish phase time 0.013 s 0.01% ------------------------------------------------ Total run time 202.157 s 100.00% Critical path (197.212 s): Time Percentage Description 91.785 s 46.54% action 'Generating webpack deps src/ui/ui-deps.tar.gz' 10.071 s 5.11% action 'Generating licenses src/ui/npm_licenses.json' 40.3 ms 0.02% action 'Executing genrule //tools/licenses all_licenses' 95.316 s 48.33% action 'Generating webpack bundle src/ui/ui-bundle.tar.gz' ``` Build time perf for Webpack5: ``` === PHASE SUMMARY INFORMATION === Total launch phase time 0.020 s 0.01% Total init phase time 0.180 s 0.09% Total target pattern evaluation phase time 0.118 s 0.06% Total interleaved loading-and-analysis phase time 0.145 s 0.07% Total preparation phase time 0.007 s 0.00% Total execution phase time 207.184 s 99.77% Total finish phase time 0.004 s 0.00% ------------------------------------------------ Total run time 207.660 s 100.00% Critical path (207.116 s): Time Percentage Description 93.509 s 45.15% action 'Generating webpack deps src/ui/ui-deps.tar.gz' 10.430 s 5.04% action 'Generating licenses src/ui/npm_licenses.json' 30.0 ms 0.01% action 'Executing genrule //tools/licenses all_licenses' 103.148 s 49.80% action 'Generating webpack bundle src/ui/ui-bundle.tar.gz' ``` Reviewers: #engineering, michelle, nick Reviewed By: #engineering, michelle, nick Subscribers: nick Differential Revision: https://phab.corp.pixielabs.ai/D6761 GitOrigin-RevId: 6584b9806e6c35138b721af6e522b6da7a60b36b
-
Vihang Mehta authored
Summary: storybook addons do not behave well when hoisted so use nohoist to ensure they are all located within the components folder. As a bonus, now storybook should only be generated when components are changed. Test Plan: `yarn workspace pixie-compoents storybook` + jenkins Reviewers: zasgar, nick, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6760 GitOrigin-RevId: 6cf4f3b4154a8342c6bef04da4c57b38dbc82a86
-
Vihang Mehta authored
Summary: This plugin uses deprecated webpack hooks and prevents us from upgrading to webpack 5 Test Plan: UI build + test on jenkins should work Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6758 GitOrigin-RevId: 0faf44042b6d93564c313c6112279d1a8ce24ba3
-
- 13 Nov, 2020 2 commits
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6730 GitOrigin-RevId: 6b66dc48e603f1e571e8361f9b1ff5a566f5f264
-
Vihang Mehta authored
Summary: This sets up a pixie-components subpackage and moves the drawer compoenents into it. TODO: Fix styling. It looks like the styles for the drawer components gets overriden when used by the pixie app. Should we be exporting unstyled components and let the pixie app call the styling hooks? TODO: Setup linting for components. The top level eslint + tsconfig doesn't play nicely with a component with it's own eslint + tsconfig. This linter setup needs some help. Stories are still in top level pixie to make it easier to debug whether the packaging is working, to be moved into subcomponents eventually. Test Plan: Check `yarn storybook` and `yarn dev` Reviewers: zasgar, michelle, nick, philkuz, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-1680 Differential Revision: https://phab.corp.pixielabs.ai/D6710 GitOrigin-RevId: cc65338599b74809a5d23ccb1cb12145bea63418
-
- 12 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: Add `react-is` to satisfy peer dependency for @storybook/addon-essentials Upgrade `eslint-plugin-enzyme` to be compatible with our version of `eslint` Test Plan: Jenkins + yarn build Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6719 GitOrigin-RevId: ee50ed5da7353044064a7c2ed2ecee5a25143bc5
-
- 11 Nov, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: we want to use react-cookie-banner to match what we will eventually use for our marketing site. most of the code here is just styling, which we dont have a set mockup for, so feel free to nitpick the CSS Test Plan: screenshots: {F101557} {F101558} updated zindex: {F101792} Reviewers: nick, zasgar, nserrino, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6704 GitOrigin-RevId: f46804369136e3ae923a470aa56d700ea6bf81ac
-
- 10 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: `ts-jest` updated to resolve https://www.npmjs.com/advisories/1500 Update other `jest` deps to keep them in line an using the samer version of jest. Test Plan: `yarn test` and `yarn coverage` should still work Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6701 GitOrigin-RevId: f87cfafcc72df20088b03499c5d2a5dd5bab34dc
-
- 09 Nov, 2020 5 commits
-
-
Vihang Mehta authored
Summary: This upgrades storybook and relevant addons to v6. This fixes the security issues from storybook's deps. Also fixes the DataTable component for storybook by removing the `react-docgen-typescript-webpack-plugin` which was creating invalid js. TODO: v6 also seems to break the story source. We should figure out how to fix this. NOTE: v6 breaks addons-notes but our notes weren't really useful. Test Plan: `yarn storybook` Reviewers: zasgar, michelle, nick, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6699 GitOrigin-RevId: 3c9de82729f2798bb4b32253a56c57d4530fef11
-
Vihang Mehta authored
Summary: `jimp` is used by `favicons-webpack-plugin` via two different paths. Upgrading `favicons-webpack-plugin` upgrades one of the dependent `jimp`s Force resolve `jimp` to the same version so that the other dep also uses the same one. (`jimp` itself seems to have a fairly stable api, except for one somewhat breaking change in `v0.10.4`) This addresses https://www.npmjs.com/advisories/1550 and https://www.npmjs.com/advisories/1179 Test Plan: UI still runs Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6692 GitOrigin-RevId: b7c0613ad396e6293e54134d769918025fd37858
-
Vihang Mehta authored
Summary: TSIA Test Plan: N/A Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6689 GitOrigin-RevId: 1e98ca9944a7fd8831a7babca77d758691e4bf01
-
Vihang Mehta authored
Summary: All consumers of `selfsigned` ask for semver `^1.*` so we don't need to force pin to `1.0.8`, just upgrading the lockfile is enough. Test Plan: UI still builds. Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6688 GitOrigin-RevId: 049a47b9085739e396454cae9a4353dc8d7e9379
-
Vihang Mehta authored
Summary: Fixes security issues. Thankfully `bl` backported security fixes back to the `^1.0.0` version which is used by `decompress-tar` which in turn hasn't benn updated in 3+ years! Test Plan: UI should still work Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6685 GitOrigin-RevId: c08412f015c459b4b0ead988ee50d76e47f3dfe8
-
- 07 Nov, 2020 3 commits
-
-
Vihang Mehta authored
Summary: This seemed easier than shaving the yak that is `react-scripts-ts`. (Addresses security vuln in `dot-prop`). Once we are ready to spend some serious efforts into creating and maintaining a component lib, we can recreate (hopefully with some saner deps). Test Plan: N/A Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6681 GitOrigin-RevId: 9bf0dcddf71357f21a1ab59b0676eae0a48225ae
-
Vihang Mehta authored
Summary: `webpack-dev-server` depends on `http-proxy-middleware` which depends on a version of `http-proxy` with a security bug. This forces an upgrade on `http-proxy-middleware` to patch the vuln. Test Plan: Running the UI still works. Reviewers: zasgar, michelle, nick, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6679 GitOrigin-RevId: ecee9082e13cb1e11378ac5a47d0fb7f7a9765ea
-
Vihang Mehta authored
Summary: `webpack-dev-server` depends on `selfsigned` which depends on a version of `node-forge` with a security bug. This forces an upgrade on `selfsigned` to patch the vuln. Test Plan: Running the UI still works. Reviewers: zasgar, michelle, nick, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6680 GitOrigin-RevId: 0ac05856379fbc23ef8505d602449b69eb2b89c0
-
- 06 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: Reads `go.sum` to check all golang deps. Tries to fetch license from `github.com` and if it fails, tries `pkg.go.dev`. Reads `.gitmodules` for submodules and tries to fetch licenses from `github.com`. Uses the npm `license-checker` package to fetch licenses for npm deps. Reads `repositories.bzl` for other deps and tries to fetch licenses from `github.com`. Falls back to reading a manual JSON input for deps that we couldn't automatically fetch licenses for. Test Plan: Run the license fetcher script. Reviewers: zasgar, philkuz, #engineering, michelle Reviewed By: philkuz, #engineering, michelle Subscribers: michelle Differential Revision: https://phab.corp.pixielabs.ai/D6652 GitOrigin-RevId: a7afed22cc3d65c4a87fd161f0fb1ce5ef619e60
-
- 29 Oct, 2020 1 commit
-
-
Vihang Mehta authored
Summary: Fixes issues with go license generation. Brings back js license generation. TODO: Still need to handle go packages that are from https://pkg.go.dev/ and not https://github.com TODO: CPP license generation should probably include a SPDX ID for the license instead of just the raw license text. Test Plan: Run the tools to collect js, go, cpp licenses. Reviewers: zasgar, michelle, philkuz, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6642 GitOrigin-RevId: 5b59eb01c198b4d835d4034fbed8c0bff1028fa3
-
- 18 Aug, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: Found this library awhile back that is supposed to help determine why a react component is re-rendering: https://github.com/welldone-software/why-did-you-render Didn't get a chance to try it out until now, and found it pretty helpful, so thought it was worthwhile to just include the setup for other people to use. It should only get imported in dev mode. We have too many components, so tracking the renders for all of them will just spam the console. instead, what you should do if you want to track the renders for a component is: - go to the file that the component is defined in. - if the component name is Autocomplete, add this line at the bottom of the page: `Autocomplete.whyDidYouRender = true`. - reload the page and interact with the component - look at the console for any renders Test Plan: tried it with one of my autocomplete components: {F92113} Here, I clearly need to memoize the function that's passed to my component, because it shouldn't be a reason for re-rendering Reviewers: zasgar, philkuz, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5997 GitOrigin-RevId: 449f6e679db0f9862c195324801b601da3ff1f04
-
- 19 Aug, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: tsia Test Plan: screenshots: {F92027} {F92028} {F92029} New Icon: {F92162} Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5991 GitOrigin-RevId: 1c639dfc5868af553810da7d81bd4e453e544267
-
- 11 Aug, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: we want to use launchdarkly to control feature flags. this diff adds it to our UI Test Plan: ran webpack + dev cloud to make sure correct Client ID is used and that my user shows up in the LD UI Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5948 GitOrigin-RevId: 2876e77fe9e05cfe093494cb44b423dabd9a78a1
-
- 15 Jul, 2020 2 commits
-
-
Zain Asgar authored
Summary: We used to random sample different records each time the table was rendered. This lead to jank whenever we clicked on a quantile since the column would rerender. We don't actually need it to be that random so just introduced a seeded random number generator. Test Plan: Click around on quantiles. much better ... Reviewers: nserrino, michelle, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5609 GitOrigin-RevId: ef784ef71c758187be478e965b09df6f136c2219
-
Zain Asgar authored
Summary: This is much faster than using the hosted google fonts. This still has the FOUT issue, but it's not as apparent in most cases. Test Plan: Tested on staging. Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5603 GitOrigin-RevId: d7c515fc6a556a478d0e2dcd46e1aa24cc7a896b
-
- 14 Jul, 2020 2 commits
-
-
Zain Asgar authored
Summary: We use JSS now and this remove support for SASS from our code base. Test Plan: Tested with webpack. Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5594 GitOrigin-RevId: da506d65d569f845a2335432973b1b6d23e00058
-
Zain Asgar authored
Summary: This pipeline will try to optimize and png/svg/etc. images. It will also inline any images less than 10KB. Test Plan: N/A Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5591 GitOrigin-RevId: 09314ccf7adc95410b3e7a6598c65de571f6aaf8
-
- 13 Jul, 2020 1 commit
-
-
Zain Asgar authored
Summary: This is the implementation of the new login flow as designed in figma. It also deprecates all of the old login code and significantly simplifies the login. Test Plan: Tested on login with CLI/UI, etc. Still needs more testing around signup. Reviewers: michelle, philkuz, nserrino, #engineering Reviewed By: michelle, #engineering JIRA Issues: PC-444 Differential Revision: https://phab.corp.pixielabs.ai/D5552 GitOrigin-RevId: 104444d0a4b32c4c711c0e91f9eb8ed36ecf8f65
-
- 07 Jul, 2020 1 commit
-
-
James Bartlett authored
Summary: Patches vega's event handling for Canvas' in order to support firing events on multiple marks simultaneously. This fixes a bug where the hover time wouldn't update if you stayed hovered over a line, since before only the hover line hit box would receive the mouseover event. Note, I used patch-package to do the vega patching. I'm not familiar enough with how the UI gets deployed in prod/staging to know if this will work, maybe @zasgar knows? Test Plan: Tested in Dev Reviewers: zasgar, philkuz, nserrino, michelle, #engineering Reviewed By: philkuz, #engineering Subscribers: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D5499 GitOrigin-RevId: d64d828faae511fac7d65aa40d6f8dfa0085fcbe
-
- 30 Jun, 2020 1 commit
-
-
James Bartlett authored
Summary: In preparation for removing vega-lite, I changed the tests to test the vega heavy spec. In the process, I removed the property where the tests had the full spec enumerated so they could easily be placed in the online vega editor. Instead, I added a cli tool to reproduce this functionality. Test Plan: Modified tests, tests pass. Reviewers: nserrino, philkuz, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5435 GitOrigin-RevId: 57170875b2d90c71ad0057b04fd6181896f4beba
-
- 01 Jul, 2020 1 commit
-
-
Natalie Serrino authored
Summary: This is to support rendering latency quantiles as a box whisker. I went back and forth on this a few times but decided to make it a generic quantiles component, not latency-specific. It does take a level low/med/high to decide the color, which is a bit latency-specific where high=red. however, this is a minor change if we want to use other colors for other values down the line (also the use of a level to cause a certain color text to show up is not required). Test Plan: ran it, tests will go around the logic itself Reviewers: philkuz, jamesbartlett, michelle, zasgar, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PC-422 Differential Revision: https://phab.corp.pixielabs.ai/D5441 GitOrigin-RevId: cf64ee88044cfa31eb165ed7616a4c501f1a2728
-
- 30 Jun, 2020 3 commits
-
-
Zain Asgar authored
Summary: Apparently we have a bunch of files that have no tests at all. Make sure to report this so we get a better view of our test coverage. Test Plan: N/A Reviewers: michelle, nserrino, philkuz, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5432 GitOrigin-RevId: cc2cf0acbaa1390991e55c57aee3d7fad6e71317
-
Zain Asgar authored
Summary: Switches away from using dagre for all graphs. Test Plan: Tested on webpack Reviewers: michelle, nserrino, philkuz, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5425 GitOrigin-RevId: 86ba84f80c7b53315f171fa9900e293170d4d28f
-
Zain Asgar authored
Summary: This also fixes the offline_package cache. The lint has actually not been fixes. We can fix it as we refactor the code. Test Plan: N/A Reviewers: michelle, nserrino, philkuz, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5420 GitOrigin-RevId: e0131b0678a11262212cdd9bc046d7cfb4eab39c
-
- 29 Jun, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: this component is a wrapper around the autocomplete input component (previous diff) and the completions list component (already used in the current autocomplete). it handles keyboard actions, such as backspace, entering characters, or moving the cursor left/right. it also handles which autocomplete suggestions to show depending on the users cursor position. Test Plan: jest test Reviewers: nserrino, zasgar, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5405 GitOrigin-RevId: 7ae31c7e64cff08ea51790babe063d23a538d503
-
- 26 Jun, 2020 4 commits
-
-
Zain Asgar authored
Summary: TSIA Test Plan: N/A Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5400 GitOrigin-RevId: 0bc2012e7d6d5d809451dd3e38ee647d47d3f3bc
-
Zain Asgar authored
Summary: Apparently we were not even enforcing missing semicolons in our typescript code. This adds the lint rules and fixes some of them. Added some ignores and disabled that we can address later. Test Plan: Tested on webpack and existing tests. Reviewers: michelle, nserrino, philkuz, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5396 GitOrigin-RevId: fbfacf0c1406270fdf8afd54475f59e34d5aee1a
-
Zain Asgar authored
Summary: TSIA Test Plan: N/A Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5395 GitOrigin-RevId: a8a32f2c0672281a188607887b927fbb8bb8506a
-
Zain Asgar authored
Summary: Don't really like the idea of having components refer to containers. Cointainers should be composed of components, so we should not have back references. There is some oppurtunity to refactor some of the shared code into another directory. Need to consider that. Test Plan: N/A Reviewers: michelle, nserrino, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5392 GitOrigin-RevId: 07fa93f3e704141abb8bd30dd868d6ea4e926aa9
-
- 25 Jun, 2020 1 commit
-
-
Zain Asgar authored
Summary: tsia Test Plan: ran webpack Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5375 GitOrigin-RevId: 2a984c6ad6c0f6efeb5423a23afcbdf104049692
-