This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 11 Aug, 2020 1 commit
-
-
Natalie Serrino authored
Summary: Some more changes to TransferResultChunk message, that were discovered as I started to implement the query broker side of things. 1. grpc_source_id and table_name only apply to the case where TransferResultChunk is sending a row batch, so update the message structure so that they only occur alongside a row batch. 2. Add a field for schema, since there was no field for result schema before. 3. The naming of ExecutionAndTimingInfo message alongside the execution_and_timing_info field was producing a confusing collision of names in the resulting go proto. I renamed the message to QueryExecutionAndTimingInfo so that wouldn't occur anymore. Test Plan: updated unit tests Reviewers: philkuz, michelle, zasgar, #engineering Reviewed By: zasgar, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D5952 GitOrigin-RevId: b3e5c09d9ca57b80069eead05a6f6fef3c3489a5
-
- 12 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: Required for C++ tracing. Test Plan: Tests modified. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5946 GitOrigin-RevId: 629dec9d256754232394cd3bf24426c3581287ae
-
- 11 Aug, 2020 2 commits
-
-
Yaxiong Zhao authored
Summary: This is used to determine whether or not to index overloaded functions, which reads parameter types in addition to function names (diffs are coming). Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5937 GitOrigin-RevId: 83db183bd72c36d75b452e96ce485561a012d715
-
Zain Asgar authored
Summary: Added proto message to serialize documentation of UDFs from C++. Test Plan: N/A Reviewers: philkuz, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5947 GitOrigin-RevId: 0e5aa24910d38af1d18a9e1bb0d9ede5760bd91b
-
- 12 Aug, 2020 2 commits
-
-
Omid Azizi authored
Summary: The prototool excludes needed updating after files were moved. Now just exclude the physicalpb, since that one is a private protobuf. Rest are now public, so enforce them. Test Plan: None Reviewers: michelle, yzhao, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5953 GitOrigin-RevId: 9a3f32ab7c35756340cea09a6393b5cf55fc6bbf
-
Omid Azizi authored
Summary: Organize related tests, and refactor repetitive code into functions. Test Plan: Jenkins Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5933 GitOrigin-RevId: de4276999e1f0214e0f1c2e9656385519fa685ae
-
- 11 Aug, 2020 5 commits
-
-
Omid Azizi authored
Summary: This diff adds support for tracing struct types in C/C++. Test Plan: End-to-end test added in stirling_bpf_test Reviewers: #engineering, yzhao Reviewed By: #engineering, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D5929 GitOrigin-RevId: f2dee17f2a9c2f1b7d431768e1af54606560883a
-
Yaxiong Zhao authored
Summary: A function is considered utility if it's entirely operate on DWARF concept, and does not consider any language-specific, or things relevant to our intention. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5935 GitOrigin-RevId: 66a33a2cf7fd908275c3044ef5ec50fe7b40b374
-
Michelle Nguyen authored
Summary: when the user selects an entity, we automatically create a new, empty tabstop that we move their cursor to. however, this tabstop is not populated with any suggestions, so the interaction seems a bit weird until the user starts typing again. updated the backend so that if we do create new, empty tabstop, we also make a call to elastic to get a set of suggestions. Test Plan: unit test, ran in cloud dev and checked that it did the right thing Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5941 GitOrigin-RevId: 5233d830c8a98362e3ef4da478220bd945a15a5b
-
Michelle Nguyen authored
Summary: until we have the script indexer up and ready, we've been matching scripts using the sahilm fuzzy search golang module. this fuzzy search doesn't match any words when given an empty input string. in our case, we want it to match all scripts. these scripts will be filtered down further depending on the type of the input arguments already specified. i updated the suggester code so that this is the case. again, all of this script matching is just temporary until we have the script indexer... which probably won't be for a while Test Plan: tried in cloud dev Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5945 GitOrigin-RevId: 7a7f8fecf4f5bbe0a8cb78ea8bd40c0da6cb2364
-
Michelle Nguyen authored
Summary: We should show some indication for whether the user has created a valid/invalid command. to follow what we do in the CLI, I added a green/red border. another option is to color the "px" icon in the command box, for something more subtle. Test Plan: screenshots: {F91513} {F91514} Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5942 GitOrigin-RevId: 1e71e2a0ba82d49a09439374bd8ef7769a437325
-
- 10 Aug, 2020 1 commit
-
-
Natalie Serrino authored
Summary: Will be used for testing changes to the query broker, specifically the implementation of the API TransferResultChunk. Test Plan: n/a Reviewers: michelle, zasgar, philkuz, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D5940 GitOrigin-RevId: 73a7c91abf5e17314db948014b43f55c4bbf2a72
-
- 11 Aug, 2020 1 commit
-
-
Phillip Kuznetsov authored
Summary: proto serializer for blocking agg relies on relations being right, that wasn't the case here. Hack that fixese it for now but need clarification on usage before providing something better. Also fixed the way we load aggregate expressions so that we load the functions correctly instead of trying to evaluate the children. Test Plan: passes previously broken test and also fails in execution rather than in compilation for partial aggregates (which is expected, we want to update the aggregation operator). Reviewers: zasgar, #engineering, nserrino Reviewed By: #engineering, nserrino Subscribers: nserrino Differential Revision: https://phab.corp.pixielabs.ai/D5921 GitOrigin-RevId: 1555dc1375116203070ddc4d23201741b9d1006f
-
- 10 Aug, 2020 3 commits
-
-
Michelle Nguyen authored
Summary: when the command input loads up for the first time, we should make an API call to the backend to get a list of initial suggestions for the empty input. there is also some cleanup for the debouncing Test Plan: tried it in webpack Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5939 GitOrigin-RevId: 26572009d34f93030de623cf4dfee41aa1f22076
-
Michelle Nguyen authored
Summary: spaces weren't showing up properly in some cases in the autocomplete UI. this is because the span containing the empty space was rendering with a width of 0. instead, if we use a non-breaking space, the span should render with the proper width Test Plan: ran webpack Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5938 GitOrigin-RevId: 3e2dcdc3de03f5b90deea9223426308f232d4c89
-
Michelle Nguyen authored
Summary: we want to update the UDATester to automatically test for a few more things: - serialization/deserialization. when Expect() is called, we should test that deserializing a serialized value produces the correct result. - Merging, in a random order to test that our operations are commutative + associative. Test Plan: ran math_ops test Reviewers: zasgar, philkuz, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5932 GitOrigin-RevId: 6f6820236b70980116d0f5d705a5929801ab39f6
-
- 08 Aug, 2020 3 commits
-
-
Michelle Nguyen authored
Summary: we recently updated the build so that it pushes the images to a public repo for official releases... unfortunately, there was a hard-coded path for the updater image hidden in our files. this broke 0.4.0, but i put out a temporary fix by uploading the correct image to the pl-dev-infra registry for now. this diff takes the image path from the cloudconnector image and uses that image path for the updater image. Test Plan: ran skaffold Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5926 GitOrigin-RevId: 23b3641dec96ec69440f388c14729a9a314c0e6c
-
Natalie Serrino authored
Summary: Depends on D5927. This protobuf api breaking change should also still be ok because these services are only used internally in Vizier and we don't yet have rolling upgrades. KelvinService isn't accurate anymore, it is more accurate to call it ResultSinkService because it is the api for any service that implements the apis necessary to receive a result chunk (aka row batch or exec stats). This group will include both Kelvin and Query broker in the near term. Test Plan: existing Reviewers: zasgar, michelle, philkuz, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D5928 GitOrigin-RevId: dcfa43436f928daea8c9e0620a9ec9c0f056e3d5
-
Natalie Serrino authored
Summary: TransferResultChunk is the new API for streaming row batches to their recipients. It supports sending query stats as well as sending result data to non-Carnot sources, such as the query broker. This change will allow GRPCSinks to send directly to the query broker, which will support streaming mode and also remove the need for Kelvins to buffer up the data before sending it to the query broker (even in batch mode, this will be good because it will allow results to show up as they are available). Changed the field names on some protobufs so that the terminology and naming would be more consistent and less confusing going forward. This should be an ok set of changes because it is all internal to Vizier. Test Plan: existing tests Reviewers: zasgar, michelle, philkuz, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D5927 GitOrigin-RevId: acf29b492312a0f9780453b58d3e2b661011513d
-
- 07 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: This diff adds support for tracing base types in C/C++. Tracing structs and expression is coming in a separate diff. Test Plan: End-to-end test added in stirling_bpf_test Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5901 GitOrigin-RevId: 0fbfd112638175fb54f21cb95169b3354fda7d6b
-
- 10 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: Follow-up to added types Test Plan: None. This is mostly just type definitions. We get coverage through end-to-end tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5912 GitOrigin-RevId: 27bcedee1e39230938e9f681eb78a940d950e9db
-
- 07 Aug, 2020 2 commits
-
-
Omid Azizi authored
Summary: Needed for C++ tracing Test Plan: Coming in future diff Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering JIRA Issues: PP-2122 Differential Revision: https://phab.corp.pixielabs.ai/D5903 GitOrigin-RevId: d5263475fc616120896a717a39df52cdda3b9fb3
-
Omid Azizi authored
Summary: Setting the foundation to trace C++ code. To trace arguments and return values, we need access to certain registers used in the System V AMD64 ABI. This adds that support. Test Plan: Added a few cases. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5923 GitOrigin-RevId: adabf2ae4c784cacc1f5c0e35560f7238f8eaf26
-
- 10 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: Trying to keep things uniform. Use genrule to always ensure dummy_exe is compiled with clang. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5934 GitOrigin-RevId: e2d76d5919d55c7cf426c971a47df515f75217e8
-
- 07 Aug, 2020 2 commits
-
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: oazizi, philkuz, #engineering Reviewed By: oazizi, #engineering JIRA Issues: PP-2107 Differential Revision: https://phab.corp.pixielabs.ai/D5900 GitOrigin-RevId: 2091e2c8fc8aaab0f6129672706322585d7cbd29
-
Michelle Nguyen authored
Summary: the indexer service should put together the VizierIndexer and VizierWatcher so that we actually start indexing our updates to elastic. Test Plan: ran skaffold, verified that updates get sent through the pipeline and make it to elastic. Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5915 GitOrigin-RevId: 0bc28e1a94451f3d8e761c19639e1145a8dfafd9
-
- 06 Aug, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: a previous diff just added clusterUID to the proto. we need to actually use it in the autocomplete code. Test Plan: update unit tests Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5916 GitOrigin-RevId: 6d44c7c21156ece67e4937719db5f4577fdc8413
-
- 10 Aug, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: this adds the code that actually writes the resourceupdates to elastic. this is not yet hooked up to the indexer server, because that needs the vzwatcher. Test Plan: unit tests Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5152 GitOrigin-RevId: 6df341904e79e493e3fb75b1d892bfa0bb829412
-
Natalie Serrino authored
Summary: tsia, see screenshot. Test Plan: ran it Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5930 GitOrigin-RevId: 7cf2135bc59f9e20410d4849f03dff4dd835c52b
-
- 07 Aug, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: the center-align looks kind of weird with a single tracepoint Test Plan: looekd at it in webpack {F91304} Reviewers: zasgar, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5925 GitOrigin-RevId: 0be78861d90a7c3e0e3cb481907ff1826f15bf87
-
- 06 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: Matches the class name better, and also avoid confusion between dwarf_info and dwarf_tools. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5905 GitOrigin-RevId: f5d362834953e6ffbe10886412a11a9804f9bf62
-
- 07 Aug, 2020 1 commit
-
-
Yaxiong Zhao authored
Summary: This is part of a larger naming and restructuring change we want to get done before release. It's possible that some of the names in the source code are now inconsistent. We can change them as part of future refactors. Test Plan: Jenkins Reviewers: #engineering, oazizi, philkuz, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D5918 GitOrigin-RevId: 5cd1b4860c4bae56cb5ff86f75b3e8c408d16016
-
- 06 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: Just renaming because it was annoying me that it was no longer a Pair. Test Plan: Jenkins Reviewers: yzhao, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D5913 GitOrigin-RevId: eaf10394f4f9dd77d803fa79a6a35bad237c15c1
-
- 07 Aug, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: some time ago we updated execution so that setScript must be called before execute. this was updated in the old command-input that we have, but not in the new one which uses autocomplete. Test Plan: ran cloud dev and verified it works Reviewers: nserrino, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5920 GitOrigin-RevId: 1f8f4bfffee2e61133bde0d10c2a32f5e61161e8
-
- 06 Aug, 2020 4 commits
-
-
Natalie Serrino authored
Summary: This is just the skeleton of the API to make sure we are all on board with the api before I implement the changes. We want to use the same message to stream data from PEMs->Kelvins as from Kelvins->Query brokers. This message should include the ability to send execution stats for the query, since those will be streamed periodically for the streaming queries. This API will subsume the old API, the difference with batch queries will be that they terminate and send end of stream, where as streaming queries will go on until they are cancelled. Next up will be to refactor GRPCSink/Source and GRPC router to use this new API. After that point, a GRPC router will be implemented in go (highly based off of the c++ version we already have) in order to receive streamed query results from Kelvin nodes. Test Plan: n/a Reviewers: zasgar, philkuz, #engineering Reviewed By: zasgar, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D5919 GitOrigin-RevId: 7b06ac56d5397bd56f7d20cacbd03435e0ae1e6c
-
Michelle Nguyen authored
Summary: the autocomplete gql calls now take a clusterUID. Test Plan: ran webpack, checked that the clusterUID is included in the requests Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5917 GitOrigin-RevId: 4c27cdf6bb3a70d0bc1072c79e889504d585c83f
-
Natalie Serrino authored
Summary: This may be causing instability in a customer cluster, when the client side of the stream is cancelled or broken and then the agent side of the query fails. Test Plan: n/a Reviewers: michelle, zasgar, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5906 GitOrigin-RevId: f02534071e0996adf99067505392f930eb5cf707
-
Zain Asgar authored
Summary: Allow UDAs to be serialized so that we can do partial aggregations. Test Plan: Updated tests, @michelle will update UDA tester to automatically tests serializable UDAs to ensure they are actually serializable Reviewers: michelle, philkuz, nserrino, #engineering Reviewed By: philkuz, #engineering Subscribers: michelle JIRA Issues: PP-2111 Differential Revision: https://phab.corp.pixielabs.ai/D5914 GitOrigin-RevId: 33f3b201b10fd8b73d608e0b54353c8adfde242b
-
- 30 Jul, 2020 1 commit
-
-
James Bartlett authored
Summary: Semantic Types defined in Stirling weren't properly reach the relation_info. Test Plan: Checked that remote_port, remote_addr, now have sem_types associated in UI. Reviewers: nserrino, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5858 GitOrigin-RevId: db12a66fbdbcd844abeadcf996254fc8d1cf392f
-
- 06 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: There is an out_of_range exception in the http parser. This seems like the only place it could be coming from. Change std::stoi to absl::SimpleAtoi, and log the occurrence. Test Plan: Existing tests. Reviewers: yzhao, michelle, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D5911 GitOrigin-RevId: 83f2ff5feb24adb03b0ad08aaebcb00f36bf35a0
-