Commit b7d7f2cd authored by Natalie Serrino's avatar Natalie Serrino
Browse files

Convert error on stream->Finish() in GRPC Sink to a log, rather than returning an error.

Summary: This may be causing instability in a customer cluster, when the client side of the stream is cancelled or broken and then the agent side of the query fails.

Test Plan: n/a

Reviewers: michelle, zasgar, #engineering

Reviewed By: michelle, #engineering

Differential Revision: https://phab.corp.pixielabs.ai/D5906

GitOrigin-RevId: f02534071e0996adf99067505392f930eb5cf707
parent 3884db0a
No related merge requests found
Showing with 2 additions and 2 deletions
+2 -2
......@@ -49,8 +49,8 @@ Status GRPCSinkNode::CloseWriter() {
writer_->WritesDone();
auto s = writer_->Finish();
if (!s.ok()) {
return error::Internal(absl::Substitute(
"GRPCSink node: Error calling Finish on stream, message: $0", s.error_message()));
LOG(ERROR) << absl::Substitute("GRPCSink node: Error calling Finish on stream, message: $0",
s.error_message());
}
return Status::OK();
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment