Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 20 Nov, 2021 1 commit
  3. 26 Oct, 2021 3 commits
  5. 19 Oct, 2021 1 commit
  7. 30 Sep, 2021 1 commit
  9. 22 Sep, 2021 1 commit
    • Zain Asgar's avatar
      Fix license headers on eBPF code · 52043bb5
      Zain Asgar authored 
      Summary: BPF code runs in the Linux kernel and needs to be GPL. The rest of the code remains licensed as is, since BPF code runs in a separate environment.

Test Plan: N/A

Reviewers: oazizi, michelle

Reviewed By: oazizi, michelle

Differential Revision: https://phab.corp.pixielabs.ai/D9814

GitOrigin-RevId: 8d5bb75f3af70f9a0567b196a6aa8c56c1ac4ddd
      52043bb5
  11. 15 Sep, 2021 3 commits
    • Vihang Mehta's avatar
      Add and enable text linter · 46effc58
      Vihang Mehta authored 
      Summary:
Fork the existing text linter to disable stuff we don't care about.
(It's not configurable).
This should keep trailing whitespace in check.

Test Plan: Ran `arc lint --everything` with only the text linter.

Reviewers: zasgar, michelle

Reviewed By: zasgar

Differential Revision: https://phab.corp.pixielabs.ai/D9764

GitOrigin-RevId: 307782be21da31a439b949ac87963420a261a9f8
      46effc58
    • Vihang Mehta's avatar
      Apply text linter fixes to stirling dir · 717995b6
      Vihang Mehta authored 
      Summary:
Cleans up trailing whitespaces and newlines at end of file.
Linter will be enabled in a followup

Test Plan: N/A

Reviewers: zasgar, michelle, oazizi, #third_party_approvers

Reviewed By: zasgar, oazizi, #third_party_approvers

Differential Revision: https://phab.corp.pixielabs.ai/D9751

GitOrigin-RevId: 804363597ea2d968615e14c72db4f8a8b51d0865
      717995b6
    • Vihang Mehta's avatar
      Apply text linter fixes to files · 9bac93a1
      Vihang Mehta authored 
      Summary:
Cleans up trailing whitespaces and newlines at end of file.
Linter will be enabled in a followup

Test Plan: N/A

Reviewers: zasgar, michelle, #third_party_approvers

Reviewed By: michelle, #third_party_approvers

Differential Revision: https://phab.corp.pixielabs.ai/D9750

GitOrigin-RevId: 085c3bbbb3f97bc1b61c1009c7895b49b8e61012
      9bac93a1
  13. 13 Sep, 2021 1 commit
    • Vihang Mehta's avatar
      Vendor types for etcd and NATS CRDs and generate clients for them · c5079278
      Vihang Mehta authored 
      Summary:
TSIA, the clients from the etcd and NATS repos are too old and
incompatible with our k8s api package. So generate clients instead.
We can then use these to modify the etcd/NATS resources.

Test Plan:
Added some manual fetching and logging of etcdcluster and natscluster
resources in the operator using the generated clients.

Reviewers: michelle, philkuz

Reviewed By: michelle

Differential Revision: https://phab.corp.pixielabs.ai/D9733

GitOrigin-RevId: 4e9bad8b86e0c7464e8f0ae711018ef7ac193834
      c5079278
  15. 07 Sep, 2021 1 commit
  17. 29 Jul, 2021 2 commits
  19. 06 Jul, 2021 1 commit
    • Vihang Mehta's avatar
      Speed up arcanist eslint invocation · 9c6196ce
      Vihang Mehta authored 
      Summary:
arcanist runs eslint once per file which causes us to incur the cost
of bringing up the js runtime over and over again. Instead hook into willLint
and didLint to run eslint once with all the paths passed in and then parse
the combined output. This should significantly speed up `arc lint` on js files.

Test Plan:
Run `arc lint` on js files.

Before:
```
time arc lint src/ui/src/components/auth/auth-box.tsx src/ui/src/components/auth/auth-error.tsx src/ui/src/components/auth/google-button.tsx src/ui/src/components/auth/message.tsx src/ui/src/components/auth/pixienaut-balloon.tsx src/ui/src/components/auth/pixienaut-box.tsx src/ui/src/components/auth/pixienaut-octopus.tsx src/ui/src/components/auth/pixienaut-toilet.tsx src/ui/src/components/auth/signup-marcom.tsx src/ui/src/components/auth/username-password-button.tsx
 OKAY  No lint messages.
 arc lint src/ui/src/components/auth/auth-box.tsx           117.52s user 4.33s system 704% cpu 17.285 total
```

After:
```
time arc lint src/ui/src/components/auth/auth-box.tsx src/ui/src/components/auth/auth-error.tsx src/ui/src/components/auth/google-button.tsx src/ui/src/components/auth/message.tsx src/ui/src/components/auth/pixienaut-balloon.tsx src/ui/src/components/auth/pixienaut-box.tsx src/ui/src/components/auth/pixienaut-octopus.tsx src/ui/src/components/auth/pixienaut-toilet.tsx src/ui/src/components/auth/signup-marcom.tsx src/ui/src/components/auth/username-password-button.tsx
 OKAY  No lint messages.
 arc lint src/ui/src/components/auth/auth-box.tsx           16.31s user 0.93s system 158% cpu 10.884 total
 ```

Reviewers: michelle, zasgar, nlanam

Reviewed By: nlanam

Differential Revision: https://phab.corp.pixielabs.ai/D9057

GitOrigin-RevId: 6f9151c50f7cc1853dfe5fb55dd48923eb7620fc
      9c6196ce
  21. 14 Jun, 2021 1 commit
    • Nick Lanam's avatar
      [PC-1020] Enable Yarn Plug n' Play installation · cd4f6ded
      Nick Lanam authored 
      Summary:
This is a [complicated topic](https://yarnpkg.com/getting-started/migration#switching-to-plugnplay). In short, Yarn can now replace `node_modules` with a virtual filesystem introspecting `.zip` files. This has many benefits, but it takes some work to enable.

Prerequisites:
- D8919: Namespaced absolute imports
- Changed `node_modules` references out for `require.resolve` and `yarn run ...`
- Made other references more explicit / less ambiguous
- Made some dependencies explicit instead of transitive

Enabling Plug n' Play (PnP):
- `.yarnrc.yml` was updated to actually turn PnP on.
- `yarn install`
- This created `.pnp.js` and deleted `node_modules` (in favor of `.yarn/cache`).

Supporting the change:
- Updated ignore files, lint files, Bazel files, etc.
- Enabled [Yarn's SDK](https://yarnpkg.com/getting-started/editor-sdks) to support VS Code go-to-definition
- Rewrote the Python license checker to be in JS, so that `yarn pnpify` could trick it into ...
      cd4f6ded
  23. 10 Jun, 2021 1 commit
    • Nick Lanam's avatar
      [PC-828] Update to Yarn2 (no PnP yet) · 2c39ba84
      Nick Lanam authored 
      Summary:
Upgrades Yarn to version 2 following [these instructions](https://yarnpkg.com/getting-started/migration). Doesn't add PnP just yet since that's big enough for its own diff.
Results: a noticeably faster but not lightning-fast install; slightly faster build; bundle runs a bit smoother in the browser too (this is partly due to dropping `@pixie-labs/components` earlier).

Test Plan: `yarn install && yarn dev`. `yarn test`. Everything should work as it did before, but a bit faster and smoother.

Reviewers: michelle, vihang, #third_party_approvers

Reviewed By: michelle, #third_party_approvers

JIRA Issues: PC-828

Differential Revision: https://phab.corp.pixielabs.ai/D8897

GitOrigin-RevId: 0ba438cdd31f30bba871da860cf00e26670e766e
      2c39ba84
  25. 05 Jun, 2021 1 commit
    • Nick Lanam's avatar
      [PC-980] Delete `@pixie-labs/api`; move its parts to `ui` · e9bbd34e
      Nick Lanam authored 
      Summary:
This one wasn't quite so trivial as `@pixie-labs/api-react`, but still pretty straightforward:
- Moves the source files over to `@pixie-labs/ui`
- Deletes no-longer-applicable support files
- Updates import paths everywhere
- Updates scripts for regenerating GQL schema and TS protos
- Removes all references to the package's former existence
- Re-runs Yarn (yes, more lock updates)
This diff only moves the code back and fixes its usage; it doesn't touch PC-981 or PC-982.

Test Plan: Smoke test. Run unit tests. Don't forget you'll need to re-run `yarn install && yarn build_deps` on this one since an entire package ceased to exist.

Reviewers: michelle, vihang, philkuz, #third_party_approvers

Reviewed By: vihang, #third_party_approvers

JIRA Issues: PC-979, PC-980

Differential Revision: https://phab.corp.pixielabs.ai/D8873

GitOrigin-RevId: 2de4793932939ece01655d77f5f6a3a904ebb61b
      e9bbd34e
  27. 03 Jun, 2021 1 commit
  29. 27 May, 2021 1 commit
  31. 14 May, 2021 1 commit
  33. 20 Apr, 2021 3 commits
  35. 19 Apr, 2021 4 commits
  37. 18 Apr, 2021 2 commits
  39. 17 Apr, 2021 1 commit
  41. 18 Apr, 2021 2 commits
  43. 14 Apr, 2021 1 commit
    • Vihang Mehta's avatar
      Move linters into tools · 4c1888fd
      Vihang Mehta authored 
      Summary: Move linters and arc plugins for linters into tools

Test Plan: N/A

Reviewers: zasgar, michelle, #third_party_approvers

Reviewed By: zasgar, #third_party_approvers

Differential Revision: https://phab.corp.pixielabs.ai/D8154

GitOrigin-RevId: 76a7af8f71dd27a5fdbbbb992cb0876e389b7dbd
      4c1888fd
  45. 13 Apr, 2021 1 commit
    • Vihang Mehta's avatar
      Rewrite generated file checker tests · d2835115
      Vihang Mehta authored 
      Summary:
This splits up the generated file checker tests into 3, uses `.arcunit`
to specify includes when they should be triggered, uses a base class for the
shared code and cleans up some of the bazel querying to figure out targets.

Test Plan:
Made changes that should trigger the unit tests. Ran `arc unit`

Before running generate scripts:
{F132932}

After running generate scripts:
{F132933}

Reviewers: michelle, zasgar

Reviewed By: michelle

Differential Revision: https://phab.corp.pixielabs.ai/D8138

GitOrigin-RevId: 96587005672e7e7aed9d8e5d7e1f3f8137fb4b55
      d2835115
  47. 12 Apr, 2021 4 commits
    • Zain Asgar's avatar
      Move chef under tools · 75b037b2
      Zain Asgar authored 
      Summary:
Trying to cleanup top-level folders.
This moves chef under the tools directory.

Test Plan: N/A

Reviewers: michelle, vihang, #third_party_approvers

Reviewed By: vihang, #third_party_approvers

Differential Revision: https://phab.corp.pixielabs.ai/D8133

GitOrigin-RevId: 231419eb22fc42c03752cadcf7ed19e15109cc51
      75b037b2
    • Vihang Mehta's avatar
      Replace gazelle tester with linter · 7f4008c9
      Vihang Mehta authored 
      Summary:
The gazelle checker was run as an arcanist unit test. It would modify
and autofix the files underneath you but then send out the diff anyway causing
folks to have to `arc diff` again.

Instead, run gazelle in diff mode, and as an arcanist linter and send the diff
to arcanist so that `arc` will ask and apply the patch before sending the diff
out. (Sadly arcanist doesn't accept the patch format, it take a set of original
content plus new content, so generating the diff for arcanist is a bit ...
heavy handed.)

Test Plan:
Make some changes that would make gazelle unhappy. Run `arc lint`
{F127064}

Reviewers: zasgar, michelle

Reviewed By: zasgar

Differential Revision: https://phab.corp.pixielabs.ai/D8131

GitOrigin-RevId: b7523e14821ee959e4f1f3a24c49ea348512f711
      7f4008c9
    • Vihang Mehta's avatar
      Replace experimental build checker with a script · 4ee03850
      Vihang Mehta authored 
      Summary:
The linter to check that targets in `//experimental` were marked as
manual was written as a `unit test`. Additionally the linter relied on custom
build rules and checking those rules and as a result missed targets like
`//experimental/stirling/proto_data_model/proto:http_record_pl_go_proto` which
aren't manual since they use `pl_go_proto_library` (due to a lack of a `pl_exp_go_proto_library`).

Instead let's use bazel to query targets that are not marked as manual and convert
this check into a script and regex linter. It's also easier to not have to create
custom targets just to mark things as manual and instead rely on the linter to
enforce the check on normal targets.

Used buildozer to rewrite all rules in `experimental` to have a manual tag and
found a bug in `pl_bpf_cc_resource` where tags weren't being passed down by the
macro and fixed it.

Test Plan:
Unmarked a rule in experimental as manual. Ran `arc lint`.
{F127036}

Reviewers: zasgar, michelle

Reviewed By: zasgar, michelle

Differential Revision: https://phab.corp.pixielabs.ai/D8129

GitOrigin-RevId: 08dc4a93188e178bd12058aff935da0b52f55e79
      4ee03850
    • Vihang Mehta's avatar
      Covert proto break check detector into a linter · b2c0d072
      Vihang Mehta authored 
      Summary:
We currently run prototool as a "unit test" for arcanist and run it
over the entire repo. Instead, let's run it as a linter. This means the checker
will run only on `.proto` files and one at a time instead of the entire repo.
This will also make lint messages show up inline in the diff.

Downgrade from error to warnings since we do sometimes make what would be
considered a breaking change (such as renaming a field) or removing an unused
field. So these are warnings and should be treated as such.

Test Plan:
Made some breaking changes and ran `arc lint`
{F127032}

Reviewers: zasgar, michelle

Reviewed By: michelle

Differential Revision: https://phab.corp.pixielabs.ai/D8128

GitOrigin-RevId: 70c4a66a0f233f39a14b2a8b177236dc157f5818
      b2c0d072
  49. 09 Apr, 2021 1 commit
    • Vihang Mehta's avatar
      Cleanup arc linter organization · 76fca6e0
      Vihang Mehta authored 
      Summary:
This moves them out of linters since we both have lint and "unit test"
engines in there.
Cleans up the organization of all the subfolders and makes the naming a bit more
consistent.
Adds a missing License file.

Test Plan: `arc lint` and `arc unit` should continue to work.

Reviewers: zasgar, michelle

Reviewed By: zasgar

Differential Revision: https://phab.corp.pixielabs.ai/D8105

GitOrigin-RevId: 9677abf9f9b3e7f460413ba54fdaeac5d55a431b
      76fca6e0

免费DevSecOps平台，让您的项目体验完整的DevSecOps流程，让项目更安全