This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 19 Apr, 2021 2 commits
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: N/A Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8258 GitOrigin-RevId: afb11cfcb277186a2bd681ecd46fccc351b8382b
-
Vihang Mehta authored
Summary: As per guidance from oazizi Test Plan: N/a Reviewers: zasgar, michelle, oazizi Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8255 GitOrigin-RevId: 8fac789f7e2642b09ea10b5c5b6def59145e5868
-
- 18 Apr, 2021 2 commits
-
-
Zain Asgar authored
Summary: TSIA Test Plan: n/a Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PP-2566 Differential Revision: https://phab.corp.pixielabs.ai/D8244 GitOrigin-RevId: a606c02e6c05f580fbd290cbf730f6f5c8bdd14d
-
Zain Asgar authored
Summary: TSIA Test Plan: existing files. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PP-2566 Differential Revision: https://phab.corp.pixielabs.ai/D8243 GitOrigin-RevId: 9d06b2500f659d56e9d9ef6e6c6cb67e9c6faf85
-
- 17 Apr, 2021 1 commit
-
-
Zain Asgar authored
Summary: Add license checker and linter. Will add the license separately, to prevent noise in review. Test Plan: Tested on several license variants. Reviewers: vihang, michelle Reviewed By: michelle JIRA Issues: PP-2566 Differential Revision: https://phab.corp.pixielabs.ai/D8240 GitOrigin-RevId: ab8509355d4bcd23f9ec3557f4a425ee4d49e1c0
-
- 18 Apr, 2021 2 commits
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: N/A Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8235 GitOrigin-RevId: 05034a6561712ac55a7b204012f1528bf1c405ce
-
Vihang Mehta authored
Summary: TSIA this is what arcanist wants Test Plan: n/a Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8234 GitOrigin-RevId: 79b937d23eff11ed83b6ec6b9bf769a9db805e92
-
- 14 Apr, 2021 1 commit
-
-
Vihang Mehta authored
Summary: Move linters and arc plugins for linters into tools Test Plan: N/A Reviewers: zasgar, michelle, #third_party_approvers Reviewed By: zasgar, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8154 GitOrigin-RevId: 76a7af8f71dd27a5fdbbbb992cb0876e389b7dbd
-
- 13 Apr, 2021 1 commit
-
-
Vihang Mehta authored
Summary: This splits up the generated file checker tests into 3, uses `.arcunit` to specify includes when they should be triggered, uses a base class for the shared code and cleans up some of the bazel querying to figure out targets. Test Plan: Made changes that should trigger the unit tests. Ran `arc unit` Before running generate scripts: {F132932} After running generate scripts: {F132933} Reviewers: michelle, zasgar Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8138 GitOrigin-RevId: 96587005672e7e7aed9d8e5d7e1f3f8137fb4b55
-
- 12 Apr, 2021 4 commits
-
-
Zain Asgar authored
Summary: Trying to cleanup top-level folders. This moves chef under the tools directory. Test Plan: N/A Reviewers: michelle, vihang, #third_party_approvers Reviewed By: vihang, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8133 GitOrigin-RevId: 231419eb22fc42c03752cadcf7ed19e15109cc51
-
Vihang Mehta authored
Summary: The gazelle checker was run as an arcanist unit test. It would modify and autofix the files underneath you but then send out the diff anyway causing folks to have to `arc diff` again. Instead, run gazelle in diff mode, and as an arcanist linter and send the diff to arcanist so that `arc` will ask and apply the patch before sending the diff out. (Sadly arcanist doesn't accept the patch format, it take a set of original content plus new content, so generating the diff for arcanist is a bit ... heavy handed.) Test Plan: Make some changes that would make gazelle unhappy. Run `arc lint` {F127064} Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8131 GitOrigin-RevId: b7523e14821ee959e4f1f3a24c49ea348512f711
-
Vihang Mehta authored
Summary: The linter to check that targets in `//experimental` were marked as manual was written as a `unit test`. Additionally the linter relied on custom build rules and checking those rules and as a result missed targets like `//experimental/stirling/proto_data_model/proto:http_record_pl_go_proto` which aren't manual since they use `pl_go_proto_library` (due to a lack of a `pl_exp_go_proto_library`). Instead let's use bazel to query targets that are not marked as manual and convert this check into a script and regex linter. It's also easier to not have to create custom targets just to mark things as manual and instead rely on the linter to enforce the check on normal targets. Used buildozer to rewrite all rules in `experimental` to have a manual tag and found a bug in `pl_bpf_cc_resource` where tags weren't being passed down by the macro and fixed it. Test Plan: Unmarked a rule in experimental as manual. Ran `arc lint`. {F127036} Reviewers: zasgar, michelle Reviewed By: zasgar, michelle Differential Revision: https://phab.corp.pixielabs.ai/D8129 GitOrigin-RevId: 08dc4a93188e178bd12058aff935da0b52f55e79
-
Vihang Mehta authored
Summary: We currently run prototool as a "unit test" for arcanist and run it over the entire repo. Instead, let's run it as a linter. This means the checker will run only on `.proto` files and one at a time instead of the entire repo. This will also make lint messages show up inline in the diff. Downgrade from error to warnings since we do sometimes make what would be considered a breaking change (such as renaming a field) or removing an unused field. So these are warnings and should be treated as such. Test Plan: Made some breaking changes and ran `arc lint` {F127032} Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8128 GitOrigin-RevId: 70c4a66a0f233f39a14b2a8b177236dc157f5818
-
- 09 Apr, 2021 2 commits
-
-
Vihang Mehta authored
Summary: This moves them out of linters since we both have lint and "unit test" engines in there. Cleans up the organization of all the subfolders and makes the naming a bit more consistent. Adds a missing License file. Test Plan: `arc lint` and `arc unit` should continue to work. Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8105 GitOrigin-RevId: 9677abf9f9b3e7f460413ba54fdaeac5d55a431b
-
Vihang Mehta authored
Summary: We can't use `all` with exclusions. So let's use `default`, include the stuff that's in `all` and exclude docstrings which are too annoying to fix. Test Plan: Existing Reviewers: zasgar, #third_party_approvers Reviewed By: zasgar, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8081 GitOrigin-RevId: 6c031da96eb245bff827da8d290ac08d7feab2aa
-
- 07 Apr, 2021 1 commit
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: `arc lint BUILD.bazel` now complains Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8035 GitOrigin-RevId: 0150c81c73877523a1b9c4581b3cdedb4a11ad05
-
- 29 Mar, 2021 1 commit
-
-
Vihang Mehta authored
Summary: Add a chef installers, config, phab linter bindings and enable linter. Test Plan: Jenkins. Reviewers: zasgar Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D7893 GitOrigin-RevId: e743737c5d39957b8e4f70fa644c9701d7bcb46a
-
- 17 Mar, 2021 1 commit
-
-
Vihang Mehta authored
Summary: These were extending `ArcanistLinter` instead of `ArcanistExternalLinter` Cleanup futures and lint message collection too. Test Plan: Introduce a variety of errors that would be caught by golint/govet/goimports. Run `arc lint --trace` Reviewers: zasgar Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D7716 GitOrigin-RevId: 555e0a1d65198fa4918d24895988047c7ebf74bd
-
- 16 Mar, 2021 1 commit
-
-
Vihang Mehta authored
Summary: This should keep our imports consistently ordered. Test Plan: Edit a go file and intentionally mess up import order. Run `arc lint` Ensure that the goimports linter fires and catches the error and suggests a patch to fix the order. Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D7711 GitOrigin-RevId: 64c571407764161363decb3d1dca77db6c34d3d2
-
- 03 Mar, 2021 1 commit
-
-
Vihang Mehta authored
Summary: Previously, we were running the `eslint_ui.sh` helper script as part of the version check even if we didn't have any files to lint with `eslint`. To speed it up, I removed the version check. However arcanist runs linters in parallel, which now meant that we had multiple `yarn install`s running concurrently. These would stomp on the contents of `node_modules` and the `eslint` binary causing some lint runs to emit no output which in turn cause `arc` to fatal. Instead we hook into `willLintPaths` and run a setup script once if there are any paths before calling the parent class's `willLintPaths` which will actually create the futures to run the linter. Test Plan: Before this change - edit multiple `ts` files - `rm -rf src/ui/node_modules; arc lint --trace` - notice failure After this change - edit multiple `ts` files - `rm -rf src/ui/node_modules; arc lint --trace` - notice `eslint_setup.sh` being run first - notice `eslint_ui.sh` being run in parallel after `eslint_setup.sh` exits - no failures Reviewers: nlanam, #engineering Reviewed By: nlanam, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7541 GitOrigin-RevId: d92ba7a602974dbf8736df1c2191984b0fb41804
-
- 27 Jan, 2021 1 commit
-
-
Nick Lanam authored
Summary: Separates usage of the gRPC and GraphQL APIs into a TypeScript library. This cleans up a bit, and creates a reusable option for other interfaces like extensions to Grafana or VS Code. This diff only moves the core API files to the new package, sets it up, and cleans up in the places affected. Future diffs will do the real work, including a proper README.md. That way there isn't a monstrous green diff burying the meaningful changes later. Quick notes on some of the less direct changes: * Deleting `local-gql.tsx`: dead code. We don't use it. * Extracting the `redirect` usage in CloudClient: avoids sending flags across the module boundary / avoids an import. * Existing support files like the arc lint config: making everything aware of the new package. * Cloning the Protobuf definitions rather than moving them: cleanup for this is complex enough for its own diff. Test Plan: `yarn dev` in `src/ui` and verify everything still behaves as usual. Reviewers: michelle, vihang, nserrino, philkuz, #engineering Reviewed By: michelle, vihang, #engineering Subscribers: zasgar JIRA Issues: PC-738 Differential Revision: https://phab.corp.pixielabs.ai/D7209 GitOrigin-RevId: d43fd634a25bbf06c4a05a009a5dee97a68aefcc
-
- 13 Jan, 2021 1 commit
-
-
Omid Azizi authored
Summary: More organization. Test Plan: Existing tests Reviewers: yzhao, jps, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7098 GitOrigin-RevId: 3e473b05cef5f3846244de99afa8ad00013137c8
-
- 22 Nov, 2020 3 commits
-
-
Zain Asgar authored
Summary: This reverts commit 3d60b2c830b7ed6847e86ac376eee81887ddcc83. Needs to be script to handle installing JS deps. Test Plan: Jenkins Reviewers: vihang, michelle, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6825 GitOrigin-RevId: 1174916c3a2cc4aef011fecc8cb1f13dedc7c454
-
Vihang Mehta authored
Summary: - `nolint` linter doesn't do what folks think it does. Besides `src/ui/dist` is gitignored. - Sort excludes - Cleanup regexes to not do silly things like `.*$` - Make includes and excludes always be arrays so there's less lines changed when adding or removing other includes/excludes. - Fix the `yaml`s that the yaml linter was complaining about. Test Plan: `arc lint --everything --trace` should lint the files we expect and not return lint errors. Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6823 GitOrigin-RevId: 52a90309389aff42a66957d244bdd3a94ab093b9
-
Zain Asgar authored
Summary: This helps a lot with linting performance. @vihang is going to add a ifthisthenthat linter soonish :)? Test Plan: Jenkins Reviewers: vihang, michelle, #engineering Reviewed By: vihang, #engineering Subscribers: vihang Differential Revision: https://phab.corp.pixielabs.ai/D6818 GitOrigin-RevId: 3d60b2c830b7ed6847e86ac376eee81887ddcc83
-
- 19 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: No more line length annoyance. Let language linters enfore it. Reviewers: #engineering, zasgar Reviewed By: #engineering, zasgar Subscribers: michelle Differential Revision: https://phab.corp.pixielabs.ai/D6772 GitOrigin-RevId: e725e9ee4f9ba38fca43da45a4554a9769db4b4f
-
- 13 Nov, 2020 2 commits
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` and storybook Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6735 GitOrigin-RevId: 30c3bb8c4ff19c2ba24002fa98a11dc0b612369d
-
Vihang Mehta authored
Summary: This sets up a pixie-components subpackage and moves the drawer compoenents into it. TODO: Fix styling. It looks like the styles for the drawer components gets overriden when used by the pixie app. Should we be exporting unstyled components and let the pixie app call the styling hooks? TODO: Setup linting for components. The top level eslint + tsconfig doesn't play nicely with a component with it's own eslint + tsconfig. This linter setup needs some help. Stories are still in top level pixie to make it easier to debug whether the packaging is working, to be moved into subcomponents eventually. Test Plan: Check `yarn storybook` and `yarn dev` Reviewers: zasgar, michelle, nick, philkuz, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-1680 Differential Revision: https://phab.corp.pixielabs.ai/D6710 GitOrigin-RevId: cc65338599b74809a5d23ccb1cb12145bea63418
-
- 07 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: This seemed easier than shaving the yak that is `react-scripts-ts`. (Addresses security vuln in `dot-prop`). Once we are ready to spend some serious efforts into creating and maintaining a component lib, we can recreate (hopefully with some saner deps). Test Plan: N/A Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6681 GitOrigin-RevId: 9bf0dcddf71357f21a1ab59b0676eae0a48225ae
-
- 29 Oct, 2020 1 commit
-
-
Vihang Mehta authored
Summary: Fixes issues with go license generation. Brings back js license generation. TODO: Still need to handle go packages that are from https://pkg.go.dev/ and not https://github.com TODO: CPP license generation should probably include a SPDX ID for the license instead of just the raw license text. Test Plan: Run the tools to collect js, go, cpp licenses. Reviewers: zasgar, michelle, philkuz, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6642 GitOrigin-RevId: 5b59eb01c198b4d835d4034fbed8c0bff1028fa3
-
- 25 Sep, 2020 1 commit
-
-
Phillip Kuznetsov authored
Summary: Credits page is necessary, took a stab at it. Reviewers could help in a few ways: 1. Assessing styling data structure 2. Make sure my inclusion of JSON is the expected format. 3. Make sure I'm not doing something inefficient by my processing of JSON in line. {F95656} {F95658} Test Plan: Ran yarn dev, all the data shows up. Reviewers: nick, michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6332 GitOrigin-RevId: 41bfb61bfcdda388de85e6de79b8bede2f65ceb4
-
- 15 May, 2020 1 commit
-
-
Malthus Yau authored
Summary: Fix all eslint errors. Test Plan: typescript compiles Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering JIRA Issues: PC-168 Differential Revision: https://phab.corp.pixielabs.ai/D4767 GitOrigin-RevId: 820a0dd488d7b89cc2bda6321a6f854779a79dc3
-
- 01 May, 2020 1 commit
-
-
Ryan Cheng authored
Summary: This diff checks in the result of running the MySQL Test Generation Tool on the tshark captured output of mysql_container_bpf_test. The expected response messages have been manually modified to be correct(not automatically generated currently). Add arclint ignore Test Plan: NA Reviewers: oazizi, yzhao, #engineering Reviewed By: oazizi, #engineering JIRA Issues: PP-1798 Differential Revision: https://phab.corp.pixielabs.ai/D4634 GitOrigin-RevId: bac7fc18695ae0c8abea1e22e1568c32661a25ec
-
- 01 Apr, 2020 1 commit
-
-
Malthus Yau authored
Summary: Ran create-react-library Test Plan: added storybook to test component in main UI lib Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering JIRA Issues: PL-1680 Differential Revision: https://phab.corp.pixielabs.ai/D4124 GitOrigin-RevId: 7eb179253e310702d6a5dfb3bc494b9fa587b06a
-
- 10 Mar, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: we need to backup our spinnaker configs in our repo. this means separating our secrets, which we encrypt in sops, then plugging them in later when we need to generate the config. this is done using a script called generate_config.sh Test Plan: ran generate_config and check that the config it created is correct Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.c.pixielabs.ai/D3838 GitOrigin-RevId: b4d021ddf50b2adac94e4938d74f6664d50e2ebe
-
- 09 Mar, 2020 2 commits
-
-
James Bartlett authored
Summary: Depends on D3792. Patches the pem daemonset to also include a fluent-bit container. This fluent-bit container uses a patched version of fluent-bit to allow for both logfmt and glog parsing. Test Plan: Tested end to end with log collector. Reviewers: #engineering, zasgar Reviewed By: #engineering, zasgar Subscribers: zasgar Differential Revision: https://phab.c.pixielabs.ai/D3793 GitOrigin-RevId: c3308a99efcd7dd99646038e0d8081a72f6b0c6c
-
Zain Asgar authored
Summary: TSIA Test Plan: `arc lint` Reviewers: michelle, philkuz, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D3834 GitOrigin-RevId: 05da01b4e449470eeb555c84debd06d52ec20c3a
-
- 21 Feb, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: as discussed with malthus, the types directory is the best place to keep this code. i put it into a "generated" directory so that excluding it from lint is easier Test Plan: n/a... need to write an arc unit test to make sure these files are regenerated Reviewers: zasgar, malthus, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D3579 GitOrigin-RevId: 45dc28a54c087c5bbcdedbacc348006c09f3c318
-
- 08 Feb, 2020 2 commits
-
-
Zain Asgar authored
Summary: To be splitted into another repo soon. Test Plan: N/A Reviewers: michelle, malthus, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D3470 GitOrigin-RevId: fd7d4ec01b3bccd0466d96b36938349b46b2a194
-
Zain Asgar authored
Summary: Added eslint config and added lint.sh files. Fixed all existing lint issues. This is in preperation for moving docs outside of our repo so that we have external contributors to it. Test Plan: Run `./lint.sh` Reviewers: michelle, malthus, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D3467 GitOrigin-RevId: 6b2a2564591e56985c3c62088adc366a4b8cc6f0
-