Commit 3afa259a authored by Vihang Mehta's avatar Vihang Mehta
Browse files

Ignore atomic_races in TSAN

Summary:
This seems to be an issue with abseil https://github.com/google/sanitizers/issues/953
and the expected resolution is just to set `report_atomic_races` to `0`. *facepalm*

This is what grpc does: https://github.com/grpc/grpc/commit/ac8065cb04e6f98e9d023eacb99f33f8cef075aa

Test Plan: Run `//src/carnot:carnot_test` under TSAN with `runs_per_test=40`

Reviewers: zasgar, nserrino, #engineering

Reviewed By: zasgar, #engineering

JIRA Issues: PP-2451

Differential Revision: https://phab.corp.pixielabs.ai/D7391

GitOrigin-RevId: 35b8feaeb074bed63e4e8a7349854bb248d113a3
parent f100e611
Showing with 6 additions and 1 deletion
+6 -1
...@@ -117,6 +117,7 @@ build:msan --build_tag_filters=-no_msan ...@@ -117,6 +117,7 @@ build:msan --build_tag_filters=-no_msan
build:msan --test_tag_filters=-no_msan,-requires_root,-requires_bpf,-disabled build:msan --test_tag_filters=-no_msan,-requires_root,-requires_bpf,-disabled
build:msan --copt -fsanitize-memory-track-origins=2 build:msan --copt -fsanitize-memory-track-origins=2
build:msan --define tcmalloc=disabled build:msan --define tcmalloc=disabled
build:msan --copt -DMEMORY_SANITIZER=1
# bazel build --config tsan # bazel build --config tsan
build:tsan --define PL_CONFIG_TSAN=1 build:tsan --define PL_CONFIG_TSAN=1
...@@ -127,6 +128,10 @@ build:tsan --define tcmalloc=disabled ...@@ -127,6 +128,10 @@ build:tsan --define tcmalloc=disabled
build:tsan --build_tag_filters=-no_tsan build:tsan --build_tag_filters=-no_tsan
build:tsan --test_tag_filters=-no_tsan,-requires_root,-requires_bpf,-disabled build:tsan --test_tag_filters=-no_tsan,-requires_root,-requires_bpf,-disabled
build:tsan --define tcmalloc=disabled build:tsan --define tcmalloc=disabled
build:tsan --copt -DTHREAD_SANITIZER=1
# This is needed to address false positive problem with abseil.
# https://github.com/google/sanitizers/issues/953
build:tsan --test_env=TSAN_OPTIONS=report_atomic_races=0
# Note that we are lumping tests that require root into the BPF tests below # Note that we are lumping tests that require root into the BPF tests below
# to minimize number of configs. # to minimize number of configs.
......
...@@ -7,7 +7,7 @@ cd "$(git rev-parse --show-toplevel)" || exit ...@@ -7,7 +7,7 @@ cd "$(git rev-parse --show-toplevel)" || exit
bazel_query="bazel query --keep_going --noshow_progress" bazel_query="bazel query --keep_going --noshow_progress"
# A list of patterns that will trigger a full build. # A list of patterns that will trigger a full build.
poison_patterns=('^Jenkinsfile' '^ci\/' '^docker\.properties') poison_patterns=('^Jenkinsfile' '^ci\/' '^docker\.properties' '^.bazelrc')
# Set the default values for the flags. # Set the default values for the flags.
all_targets=false all_targets=false
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment