Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://gitee.com/BiAn-MoShangHuaKai/velero.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 20 Mar, 2019 1 commit
  3. 19 Mar, 2019 6 commits
  5. 18 Mar, 2019 3 commits
  7. 14 Mar, 2019 2 commits
  9. 13 Mar, 2019 2 commits
  11. 12 Mar, 2019 2 commits
  13. 11 Mar, 2019 1 commit
  15. 08 Mar, 2019 1 commit
  17. 07 Mar, 2019 2 commits
    • asaf-erlich's avatar
      Update ark restore to not open every single file open during extraction of the data · 4041044a
      asaf-erlich authored 
      Original error was:

```
ark -n <redacted> restore logs <redacted>
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=nodes logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events.events.k8s.io logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=backups.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=restores.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Starting restore of backup backup/<redacted>" logSource="pkg/restore/restore.go:342"
time="2019-03-06T18:31:06Z" level=info msg="error unzipping and extracting: open /tmp/604421455/resources/rolebindings.rbac.authorization.k8s.io/namespaces/<redacted>/<redacted>: too many open files" logSource="pkg/restore/restore.go:346"
```

Downloading the directory from s3 and untarring it I found 1036 files. The ulimit -n output says 1024. This is our team's best guess at a root cause. But the code fixed in the PR definitely is holding all the files open until the method closes: https://blog.learngoprogramming.com/gotchas-of-defer-in-go-1-8d070894cb01



Please note my go code abilities are not great and I did not test this. I just edited the file in github. All I did was remove the defer and put fileClose after the copy is done. Theoretically this should only hold one file open at a time now. Let me know if you want me to do any further steps.

Thank you,
-Asaf
Signed-off-by: default avatarAsaf Erlich <aerlich@groupon.com>
      4041044a
    • Nolan Brubaker's avatar
      Merge pull request #1256 from carlisia/c-plugins · 5e12a921
      Nolan Brubaker authored 
      Add original item to restore plugin interface
      5e12a921
  19. 06 Mar, 2019 2 commits
  21. 05 Mar, 2019 2 commits
  23. 04 Mar, 2019 2 commits
  25. 01 Mar, 2019 2 commits
  27. 28 Feb, 2019 12 commits

免费DevSecOps平台，让您的项目体验完整的DevSecOps流程，让项目更安全