Remove Key validation on KV2 (#12045)

* remove check on key

* clean up

* amend test

* remove leftover

ui/app/components/secret-edit.js

@@ -87,7 +87,6 @@ export default Component.extend(FocusOnInsertMixin, WithNavToNearestAncestor, {
     }
     this.set('validationMessages', {
       path: '',
-      key: '',
       maxVersions: '',
     });
     // for validation, return array of path names already assigned
@@ -195,20 +194,18 @@ export default Component.extend(FocusOnInsertMixin, WithNavToNearestAncestor, {
   },
 
   checkValidation(name, value) {
-    // because path and key are not on the model performing custom validations instead of cp-validations
-    if (name === 'path' || name === 'key') {
-      // no value indicates missing presence
+    if (name === 'path') {
       !value
         ? set(this.validationMessages, name, `${name} can't be blank.`)
         : set(this.validationMessages, name, '');
-
-      // only check duplicate on path not on the key
-      if (name === 'path') {
-        this.secretPaths?.includes(value)
-          ? set(this.validationMessages, name, `A secret with this ${name} already exists.`)
-          : set(this.validationMessages, name, '');
-      }
     }
+    // check duplicate on path
+    if (name === 'path' && value) {
+      this.secretPaths?.includes(value)
+        ? set(this.validationMessages, name, `A secret with this ${name} already exists.`)
+        : set(this.validationMessages, name, '');
+    }
+    // check maxVersions is a number
     if (name === 'maxVersions') {
       // checking for value because value which is blank on first load. No keyup event has occurred and default is 10.
       if (value) {
@@ -362,15 +359,10 @@ export default Component.extend(FocusOnInsertMixin, WithNavToNearestAncestor, {
     createOrUpdateKey(type, event) {
       event.preventDefault();
       let model = this.modelForData;
-      let arraySecretKeys = Object.keys(model.secretData);
       if (type === 'create' && isBlank(model.path || model.id)) {
         this.checkValidation('path', '');
         return;
       }
-      if (arraySecretKeys.includes('')) {
-        this.checkValidation('key', '');
-        return;
-      }
 
       this.persistKey(() => {
         this.transitionToRoute(SHOW_ROUTE, this.model.path || this.model.id);

ui/app/templates/components/secret-edit-display.hbs

@@ -66,7 +66,7 @@
           @value={{secret.name}}
           placeholder="key"
           @change={{action @editActions.handleChange}}
-          class="input {{if @validationMessages.key "has-error-border"}}"
+          class="input"
           @autocomplete="off"
           @spellcheck="false"
           {{on "keyup" (fn @onKeyUp "key" secret.name)}}

ui/tests/acceptance/secrets/backend/kv/secret-test.js

@@ -73,13 +73,12 @@ module('Acceptance | secrets/secret/create', function(hooks) {
     await click('[data-test-secret-create="true"]');
     await fillIn('[data-test-secret-path="true"]', secretPath);
     await fillIn('[data-test-input="maxVersions"]', maxVersions);
-    await fillIn('[data-test-secret-key]', 'key');
     await click('[data-test-secret-save]');
     await settled();
     await click('[data-test-secret-edit="true"]');
     await settled();
-
-    let savedMaxVersions = document.querySelector('[data-test-input="maxVersions"]').value;
+    // convert to number for IE11 browserstack test
+    let savedMaxVersions = Number(document.querySelector('[data-test-input="maxVersions"]').value);
     assert.equal(
       maxVersions,
       savedMaxVersions,