This project is mirrored from https://:*****@github.com/hashicorp/terraform.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 18 Mar, 2022 1 commit
  2. 16 Mar, 2022 1 commit
  3. 15 Mar, 2022 7 commits
  4. 14 Mar, 2022 4 commits
  5. 11 Mar, 2022 14 commits
  6. 10 Mar, 2022 7 commits
    • GoodmanBen's avatar
    • Laura Pacilio's avatar
      Merge pull request #30637 from kderck/patch-2 · 821064ed
      Laura Pacilio authored
      Change aws.dest to aws.dst
      821064ed
    • Laura Pacilio's avatar
      Merge pull request #30631 from savage-tm/patch-1 · 63fa7202
      Laura Pacilio authored
      Document logical operators not short-circuiting
      63fa7202
    • Alisdair McDiarmid's avatar
      ef0d859a
    • Alisdair McDiarmid's avatar
      core: Fix expanded condition block validation · ad995322
      Alisdair McDiarmid authored
      The previous precondition/postcondition block validation implementation
      failed if the enclosing resource was expanded. This commit fixes this by
      generating appropriate placeholder instance data for the resource,
      depending on whether `count` or `for_each` is used.
      ad995322
    • Martin Atkins's avatar
      Update CHANGELOG.md · 2aa1613c
      Martin Atkins authored
      2aa1613c
    • Martin Atkins's avatar
      configs: Refined error messages for mismatched provider passing · 1879a39d
      Martin Atkins authored
      This set of diagnostic messages is under a number of unusual constraints
      that make them tough to get right:
       - They are discussing a couple finicky concepts which authors are
         likely to be encountering for the first time in these error messages:
         the idea of "local names" for providers, the relationship between those
         and provider source addresses, and additional ("aliased") provider
         configurations.
       - They are reporting concerns that span across a module call boundary,
         and so need to take care to be clear about whether they are talking
         about a problem in the caller or a problem in the callee.
       - Some of them are effectively deprecation warnings for features that
         might be in use by a third-party module that the user doesn't control,
         in which case they have no recourse to address them aside from opening
         a feature request with the upstream module maintainer.
       - Terraform has, for backward-compatibility reasons, a lot of implied
         default behaviors regarding providers and provider configurations,
         and these errors can arise in situations where Terraform's assumptions
         don't match the author's intent, and so we need to be careful to
         explain what Terraform assumed in order to make the messages
         understandable.
      
      After seeing some confusion with these messages in the community, and
      being somewhat confused by some of them myself, I decided to try to edit
      them a bit for consistency of terminology (both between the messages and
      with terminology in our docs), being explicit about caller vs. callee
      by naming them in the messages, and making explicit what would otherwise
      be implicit with regard to the correspondences between provider source
      addresses and local names.
      
      My assumed audience for all of these messages is the author of the caller
      module, because it's the caller who is responsible for creating the
      relationship between caller and callee. As much as possible I tried to
      make the messages include specific actions for that author to take to
      quiet the warning or fix the error, but some of the warnings are only
      fixable by the callee's maintainer and so those messages are, in effect,
      a suggestion to send a request to the author to stop using a deprecated
      feature.
      
      I think these new messages are also not ideal by any means, because it's
      just tough to pack so much information into concise messages while being
      clear and consistent, but I hope at least this will give users seeing
      these messages enough context to infer what's going on, possibly with the
      help of our documentation.
      
      I intentionally didn't change which cases Terraform will return warnings
      or errors -- only the message texts -- although I did highlight in a
      comment in one of the tests that what it is a asserting seems a bit
      suspicious to me. I don't intend to address that here; instead, I intend
      that note to be something to refer to if we later see a bug report that
      calls that behavior into question.
      
      This does actually silence some _unrelated_ warnings and errors in cases
      where a provider block has an invalid provider local name as its label,
      because our other functions for dealing with provider addresses are
      written to panic if given invalid addresses under the assumption that
      earlier code will have guarded against that. Doing this allowed for the
      provider configuration validation logic to safely include more information
      about the configuration as helpful context, without risking tripping over
      known-invalid configuration and panicking in the process.
      1879a39d
  7. 09 Mar, 2022 2 commits
  8. 08 Mar, 2022 3 commits
    • James Bardin's avatar
      Merge pull request #30629 from hashicorp/jbardin/data-read-hook · e543dda0
      James Bardin authored
      ensure UI hooks are called for data sources
      e543dda0
    • James Bardin's avatar
      remove PreDiff and PostDiff hook calls · 05a10f06
      James Bardin authored
      PreDiff and PostDiff hooks were designed to be called immediately before
      and after the PlanResourceChange calls to the provider. Probably due to
      the confusing legacy naming of the hooks, these were scattered about the
      nodes involved with planning, causing the hooks to be called in a number
      of places where they were designed, including data sources and destroy
      plans. Since these hooks are not used at all any longer anyway, we can
      removed the extra calls with no effect.
      
      If we choose in the future to call PlanResourceChange for resource
      destroy plans, the hooks can be re-inserted (even though they currently
      are unused) into the new code path which must diverge from the current
      combined path of managed and data sources.
      05a10f06
    • James Bardin's avatar
      ensure UI hooks are called for data sources · dc668dff
      James Bardin authored
      The UI hooks for data source reads were missed during planning. Move the
      hook calls to immediatley before and after the ReadDataSource calls to
      ensure they are called during both plan and apply.
      dc668dff
  9. 07 Mar, 2022 1 commit