This project is mirrored from https://:*****@github.com/hashicorp/terraform.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 18 Mar, 2022 1 commit
-
-
uturunku1 authored
Upgrade go-tfe dependency to use 1.0 version. It contains breaking changes, so we are updating method signatures, method names and the type of optional parameters, as needed.
-
- 16 Mar, 2022 1 commit
-
-
Craig Wright authored
Update toset.mdx
-
- 15 Mar, 2022 7 commits
-
-
Theo Chupp authored
fix: local variables should not be overridden by remote variables during `terraform import` (#29972) * fix: local variables should not be overridden by remote variables during `terraform import` * chore: applied the same fix in the 'internal/cloud' package * backport changes from cloud package to remote package Co-authored-by:
Alisdair McDiarmid <alisdair@users.noreply.github.com> Co-authored-by:
uturunku1 <luces.huayhuaca@gmail.com>
-
Laura Pacilio authored
Terraform may be misled, not provider
-
Laura Pacilio authored
Documentation Update: Capture `cloud`/ `backend` block override behavior in docs
-
GoodmanBen authored
-
GoodmanBen authored
-
GoodmanBen authored
-
Loek Duys authored
Fix output in `toset` ``` toset(["a", "b", 3]) toset([ "3", "a", "b", ]) ``` This is the actual output from the tf console, using Terraform v1.1.5 on windows_amd64
-
- 14 Mar, 2022 4 commits
-
-
GoodmanBen authored
-
Laura Pacilio authored
-
Laura Pacilio authored
-
Laura Pacilio authored
-
- 11 Mar, 2022 14 commits
-
-
Alisdair McDiarmid authored
core: Fix crashes when condition block expressions refer to sensitive values
-
Craig Wright authored
Clearify which type of id is used in the documentation
-
Alisdair McDiarmid authored
Variable validation error message expressions which generated sensitive values would previously crash. This commit updates the logic to align with preconditions and postconditions, eliding sensitive error message values and adding a separate diagnostic explaining why.
-
Alisdair McDiarmid authored
Precondition and postcondition blocks which evaluated expressions resulting in sensitive values would previously crash. This commit fixes the crashes, and adds an additional diagnostic if the error message expression produces a sensitive value (which we also elide).
-
Alisdair McDiarmid authored
core: Eval pre/postconditions in refresh-only mode
-
Alisdair McDiarmid authored
Evaluate precondition and postcondition blocks in refresh-only mode, but report any failures as warnings instead of errors. This ensures that any deviation from the contract defined by condition blocks is reported as early as possible, without preventing the completion of a state refresh operation. Prior to this commit, Terraform evaluated output preconditions and data source pre/postconditions as normal in refresh-only mode, while managed resource pre/postconditions were not evaluated at all. This omission could lead to confusing partial condition errors, or failure to detect undesired changes which would otherwise cause resources to become invalid. Reporting the failures as errors also meant that changes retrieved during refresh could cause the refresh operation to fail. This is also undesirable, as the primary purpose of the operation is to update local state. Precondition/postcondition checks are still valuable here, but should be informative rather than blocking.
-
James Bardin authored
Always validate the graph
-
James Bardin authored
The graphs used for the CBD tests wouldn't validate because they skipped adding the root module node. Re add the root module transformer and transitive reduction transformer to the build steps, and match the new reduced output in the test fixtures.
-
James Bardin authored
Complete the removal of the Validate option for graph building. There is no case where we want to allow an invalid graph, as the primary reason for validation is to ensure we have no cycles, and we can't walk a graph with cycles. The only code which specifically relied on there being no validation was a test to ensure the Validate flag prevented it.
-
Alisdair McDiarmid authored
core: Fix expanded condition block validation
-
Till Hoffmann authored
-
Till Hoffmann authored
-
GoodmanBen authored
Update documentation around `cloud` and `backend` override behavior
-
GoodmanBen authored
-
- 10 Mar, 2022 7 commits
-
-
GoodmanBen authored
-
Laura Pacilio authored
Change aws.dest to aws.dst
-
Laura Pacilio authored
Document logical operators not short-circuiting
-
Alisdair McDiarmid authored
-
Alisdair McDiarmid authored
The previous precondition/postcondition block validation implementation failed if the enclosing resource was expanded. This commit fixes this by generating appropriate placeholder instance data for the resource, depending on whether `count` or `for_each` is used.
-
Martin Atkins authored
-
Martin Atkins authored
This set of diagnostic messages is under a number of unusual constraints that make them tough to get right: - They are discussing a couple finicky concepts which authors are likely to be encountering for the first time in these error messages: the idea of "local names" for providers, the relationship between those and provider source addresses, and additional ("aliased") provider configurations. - They are reporting concerns that span across a module call boundary, and so need to take care to be clear about whether they are talking about a problem in the caller or a problem in the callee. - Some of them are effectively deprecation warnings for features that might be in use by a third-party module that the user doesn't control, in which case they have no recourse to address them aside from opening a feature request with the upstream module maintainer. - Terraform has, for backward-compatibility reasons, a lot of implied default behaviors regarding providers and provider configurations, and these errors can arise in situations where Terraform's assumptions don't match the author's intent, and so we need to be careful to explain what Terraform assumed in order to make the messages understandable. After seeing some confusion with these messages in the community, and being somewhat confused by some of them myself, I decided to try to edit them a bit for consistency of terminology (both between the messages and with terminology in our docs), being explicit about caller vs. callee by naming them in the messages, and making explicit what would otherwise be implicit with regard to the correspondences between provider source addresses and local names. My assumed audience for all of these messages is the author of the caller module, because it's the caller who is responsible for creating the relationship between caller and callee. As much as possible I tried to make the messages include specific actions for that author to take to quiet the warning or fix the error, but some of the warnings are only fixable by the callee's maintainer and so those messages are, in effect, a suggestion to send a request to the author to stop using a deprecated feature. I think these new messages are also not ideal by any means, because it's just tough to pack so much information into concise messages while being clear and consistent, but I hope at least this will give users seeing these messages enough context to infer what's going on, possibly with the help of our documentation. I intentionally didn't change which cases Terraform will return warnings or errors -- only the message texts -- although I did highlight in a comment in one of the tests that what it is a asserting seems a bit suspicious to me. I don't intend to address that here; instead, I intend that note to be something to refer to if we later see a bug report that calls that behavior into question. This does actually silence some _unrelated_ warnings and errors in cases where a provider block has an invalid provider local name as its label, because our other functions for dealing with provider addresses are written to panic if given invalid addresses under the assumption that earlier code will have guarded against that. Doing this allowed for the provider configuration validation logic to safely include more information about the configuration as helpful context, without risking tripping over known-invalid configuration and panicking in the process.
-
- 09 Mar, 2022 2 commits
-
-
Kyle Davies authored
Documentation is wrong the `configuration_aliases` should be `[ aws.src, aws.dst ]` not `[ aws.src, aws.dest ]`.
-
savage-tm authored
Including a note about logical operators not short-circuiting will make the documentation clearer and more useful. https://github.com/hashicorp/terraform/issues/24128 includes examples of people being caught out by this lack of clarity.
-
- 08 Mar, 2022 3 commits
-
-
James Bardin authored
ensure UI hooks are called for data sources
-
James Bardin authored
PreDiff and PostDiff hooks were designed to be called immediately before and after the PlanResourceChange calls to the provider. Probably due to the confusing legacy naming of the hooks, these were scattered about the nodes involved with planning, causing the hooks to be called in a number of places where they were designed, including data sources and destroy plans. Since these hooks are not used at all any longer anyway, we can removed the extra calls with no effect. If we choose in the future to call PlanResourceChange for resource destroy plans, the hooks can be re-inserted (even though they currently are unused) into the new code path which must diverge from the current combined path of managed and data sources.
-
James Bardin authored
The UI hooks for data source reads were missed during planning. Move the hook calls to immediatley before and after the ReadDataSource calls to ensure they are called during both plan and apply.
-
- 07 Mar, 2022 1 commit
-
-
Alisdair McDiarmid authored
-