This project is mirrored from https://:*****@github.com/hashicorp/terraform.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 06 Oct, 2022 1 commit
  2. 05 Oct, 2022 4 commits
  3. 04 Oct, 2022 8 commits
  4. 03 Oct, 2022 4 commits
  5. 30 Sep, 2022 1 commit
  6. 29 Sep, 2022 2 commits
    • Martin Atkins's avatar
      Update CHANGELOG.md · b3c50857
      Martin Atkins authored
      b3c50857
    • Martin Atkins's avatar
      core: Don't re-register checkable outputs during the apply step · df9b3ffe
      Martin Atkins authored
      Once again we're caught out by sharing the same output value node type
      between the plan phase and the apply phase. To allow for some slight
      variation between plan and apply without drastic refactoring here we just
      add a new flag to nodeExpandOutput which is true only during the planning
      phase.
      
      This then allows us to register the checkable objects only during the
      planning phase and not incorrectly re-register them during the apply phase.
      It's incorrect to re-register during apply because we carry over the
      planned checkable objects from the plan phase into the apply phase so we
      can guarantee that the final state will have all of the same checkable
      objects that the plan did.
      
      This avoids a panic during the apply phase from the incorrect duplicate
      registration.
      df9b3ffe
  7. 28 Sep, 2022 4 commits
  8. 26 Sep, 2022 10 commits
    • zisom-hc's avatar
      backport of commit d08fcd63 · 367730c8
      zisom-hc authored
      367730c8
    • Martin Atkins's avatar
      Update CHANGELOG.md · a0ac2b2f
      Martin Atkins authored
      a0ac2b2f
    • Martin Atkins's avatar
      core: Document that TransformRoot must produce coalescable node · 4f5b9d0e
      Martin Atkins authored
      We use a non-pointer value for this particular node, which means that
      there can never be two root nodes in the same graph: the graph
      implementation will just coalesce them together when a second one is added.
      
      Our resource expansion code is relying on that coalescing so that it can
      subsume together multiple graphs for different modules instances into a
      single mega-graph with all instances across all module instances, with
      any root nodes coalescing together to produce a single root.
      
      This also updates one of the context tests that exercises resource
      expansion so that it will generate multiple resource instance nodes per
      module and thus potentially have multiple roots to coalesce together.
      However, we aren't currently explicitly validating the return values from
      DynamicExpand and so this test doesn't actually fail if the coalescing
      doesn't happen. We may choose to validate the DynamicExpand result in a
      later commit in order to make it more obvious if future modifications fail
      to uphold this invariant.
      4f5b9d0e
    • Martin Atkins's avatar
      core: Eliminate NodePlannableResource indirection · b9b39e96
      Martin Atkins authored
      We previously did two levels of DynamicExpand to go from ConfigResource to
      AbsResource and then from AbsResource to AbsResourceInstance.
      
      We'll now do the full expansion from ConfigResource to AbsResourceInstance
      in a single DynamicExpand step inside nodeExpandPlannableResource.
      
      The new approach is essentially functionally equivalent to the old except
      that it fixes a bug in the previous implementation: we will now call
      checkState.ReportCheckableObjects only once for the entire set of
      instances for a particular resource, which is what the checkable objects
      infrastructure expects so that it can always mention all of the checkable
      objects in the check report even if we bail out partway through due to
      a downstream error.
      
      This is essentially the same code but now turned into additional methods
      on nodeExpandPlannableResource instead of having the extra graph node
      type. This has the further advantage of this now being straight-through
      code with standard control flow, instead of the unusual inversion of
      control we were doing before bouncing in and out of different Execute and
      DynamicExpand implementations to get this done.
      b9b39e96
    • Martin Atkins's avatar
      core: DynamicExpand can return diagnostics · c1f0ff5f
      Martin Atkins authored
      We were previously _trying_ to handle diagnostics here but were not quite
      doing it right because we were testing whether the resulting error was
      nil rather than appending it to the diagnostics and then seeing if the
      result has errors.
      
      The difference here is important because it allows DynamicExpand to return
      warnings without associated errors when needed. Previously the graph
      walker would treat a warnings-only result as if it were an error.
      
      Ideally we'd change DynamicExpand to return diagnostics directly, but we
      previously decided against that because there were so many implementors
      to update, and my intent for this change is to be surgical in the update
      so we minimize risk of backporting the change into patch releases.
      c1f0ff5f
    • James Bardin's avatar
      update CHANGELOG.md · dc9e83e2
      James Bardin authored
      dc9e83e2
    • James Bardin's avatar
      Merge pull request #31874 from... · a29b5707
      James Bardin authored
      Merge pull request #31874 from hashicorp/backport/jbardin/remove-planned-during-import/genuinely-shining-boar
      
      Backport of RemovePlannedResourceInstanceObjects during import into v1.3
      a29b5707
    • James Bardin's avatar
      Merge pull request #31873 from hashicorp/backport/jbardin/prune-plan-destroy/inherently-close-fly · 8cc551ae
      James Bardin authored
      Backport of prune unused nodes from a destroy plan graph into v1.3
      8cc551ae
    • James Bardin's avatar
      Merge pull request #31872 from... · 1fede245
      James Bardin authored
      Merge pull request #31872 from hashicorp/backport/jbardin/destroy-edge-cycles/instantly-prepared-hagfish
      
      Backport of prevent cycles when connecting destroy nodes into v1.3
      1fede245
    • James Bardin's avatar
      backport of commit ce023445 · ab85a629
      James Bardin authored
      ab85a629
  9. 25 Sep, 2022 1 commit
  10. 23 Sep, 2022 5 commits