This project is mirrored from https://:*****@github.com/hashicorp/terraform.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 28 Oct, 2020 10 commits
    • Alisdair McDiarmid's avatar
      Another action regex fix attempt · 61b38f3a
      Alisdair McDiarmid authored
      This time I actually tested the regex
      61b38f3a
    • Alisdair McDiarmid's avatar
      Try to fix backport action · e65f4279
      Alisdair McDiarmid authored
      I made a mistake editing the regex. Here's hoping this works!
      e65f4279
    • Pam Selle's avatar
      Merge pull request #26740 from hashicorp/pselle/show-output-sensitive · 2a222985
      Pam Selle authored
      Hide sensitive outputs in terraform show
      2a222985
    • Pam Selle's avatar
      Hide sensitive outputs in terraform show · f61a3423
      Pam Selle authored
      f61a3423
    • Martin Atkins's avatar
      providercache: verify locked hashes for local package dirs · e6e0b6ee
      Martin Atkins authored
      Previously we were only verifying locked hashes for local archive zip
      files, but if we have non-ziphash hashes available then we can and should
      also verify that a local directory matches at least one of them.
      
      This does mean that folks using filesystem mirrors but yet also running
      Terraform across multiple platforms will need to take some extra care to
      ensure the hashes pass on all relevant platforms, which could mean using
      "terraform providers lock" to pre-seed their lock files with hashes across
      all platforms, or could mean using the "packed" directory layout for the
      filesystem mirror so that Terraform will end up in the install-from-archive
      codepath instead of this install-from-directory codepath, and can thus
      verify ziphash too.
      
      (There's no additional documentation about the above here because there's
      already general information about this in the lock file documentation
      due to some similar -- though not identical -- situations with network
      mirrors.)
      e6e0b6ee
    • Martin Atkins's avatar
      providercache: More exhaustive testing of the main installer · 24d32e9c
      Martin Atkins authored
      We previously had some tests for some happy paths and a few specific
      failures into an empty directory with no existing locks, but we didn't
      have tests for the installer respecting existing lock file entries.
      
      This is a start on a more exhaustive set of tests for the installer,
      aiming to visit as many of the possible codepaths as we can reasonably
      test using this mocking strategy. (Some other codepaths require different
      underlying source implementations, etc, so we'll have to visit those in
      other tests separately.)
      24d32e9c
    • Martin Atkins's avatar
      depsfile: Allow loading locks from a byte array in memory · fc5a41b5
      Martin Atkins authored
      This won't be a typical usage pattern for normal code, but will be useful
      for tests that need to work with locks as input so that they don't need to
      write out a temporary file on disk just to read it back in immediately.
      fc5a41b5
    • Alisdair McDiarmid's avatar
      Fix label regexp · 1e32354e
      Alisdair McDiarmid authored
      We only use two components for versions, e.g. `0.13-backport` -> `v0.13`
      1e32354e
    • Alisdair McDiarmid's avatar
      Add backport assistant · fd14b237
      Alisdair McDiarmid authored
      Based on documentation in https://github.com/hashicorp/backport-assistant, using a
      token from the teamterraform user.
      fd14b237
    • alevinetx's avatar
      website: Update module-registry-protocol.html.md (#26639) · 66393bb6
      alevinetx authored
      * Update module-registry-protocol.html.md
      
      1: There is a mismatch in the segment labels for the version query URL (system vs provider)
      2: There is a discrepancy between the documentation and the actual generated request for retrieving module source code (URL segments 4 vs 3)
       - There is no segment for "provider"
      
      * Update module-registry-protocol.html.md
      
      Changed ```:system``` to ```:provider``` for versions and source API URLs
      66393bb6
  2. 27 Oct, 2020 1 commit
  3. 26 Oct, 2020 19 commits
    • Martin Atkins's avatar
      getproviders: Consistent ordering of terms in VersionConstraintsString · 430318e2
      Martin Atkins authored
      An earlier commit made this remove duplicates, which set the precedent
      that this function is trying to canonically represent the _meaning_ of
      the version constraints rather than exactly how they were expressed in
      the configuration.
      
      Continuing in that vein, now we'll also apply a consistent (though perhaps
      often rather arbitrary) ordering to the terms, so that it doesn't change
      due to irrelevant details like declarations being written in a different
      order in the configuration.
      
      The ordering here is intended to be reasonably intuitive for simple cases,
      but constraint strings with many different constraints are hard to
      interpret no matter how we order them so the main goal is consistency,
      so those watching how the constraints change over time (e.g. in logs of
      Terraform output, or in the dependency log file) will see fewer noisy
      changes that don't actually mean anything.
      430318e2
    • Pam Selle's avatar
      Merge pull request #26710 from aazon/patch-1 · 5f065c76
      Pam Selle authored
      Small spelling improvement
      5f065c76
    • Pam Selle's avatar
      Merge pull request #26706 from hashicorp/pselle/provider-sens-experiment · bc14a1c8
      Pam Selle authored
      Add provider sensitivity propagation experiment
      bc14a1c8
    • Pam Selle's avatar
      Add provider sensitivity propagation experiment · bd70bc63
      Pam Selle authored
      Rolls back marking attributes providers mark as sensitive
      to an `experiment` and adds associated docs and adjustments
      to the upgrade guide.
      bd70bc63
    • Alex Litvinenko's avatar
      Small spelling improvement · 1a371c3c
      Alex Litvinenko authored
      It seems that the word `with` is redundant in the following sentence:
      
      > For a module with without count or for_each, the address will not...
      1a371c3c
    • Kristin Laemmert's avatar
      Update CHANGELOG.md · 2b73a2c0
      Kristin Laemmert authored
      2b73a2c0
    • Kristin Laemmert's avatar
      b8e3b803
    • Martin Atkins's avatar
      website: Don't claim that things are "very easy" · ddf9635a
      Martin Atkins authored
      We typically try to avoid making subjective, boasty claims in our
      documentation in recent times, but there remained both some older
      documentation that we've not recently revised and also some newer examples
      that are, in retrospect, also perhaps more "boasty" than they need to be.
      
      We prefer not to use this sort of boasty language because not everyone
      using Terraform has the same background and experience, and so what is
      "easy" or "intuitive" to one person may not be so to another person, and
      that should not suggest that the second person is in any way wrong or
      inadequate.
      
      In reviewing some of our use of the word "easy" here I tried as much as
      possible to surgically revise the existing content without getting drawn
      into a big rewrite, but in some cases the content was either pretty
      unsalvageable (due to talking about obsolete features that were removed
      long ago) or required some broader changes to make the result hopefully
      still get the same facts across. In those cases I've both removed some
      content entirely or adjusted larger paragraphs.
      
      This was not an exhaustive review and so I'm sure there's still plenty of
      room for similar improvements elsewhere. I also resisted the urge to
      update some pages that contain outdated information about currently-active
      features.
      ddf9635a
    • Martin Atkins's avatar
      Update CHANGELOG.md · d2034013
      Martin Atkins authored
      d2034013
    • Martin Atkins's avatar
      website: Update the CLI commands index page for latest help output · 6a44586a
      Martin Atkins authored
      My initial motivation here was to update the example output from
      Terraform's top-level help list to match recent updates in the layout
      and language used.
      
      However, while here I took the opportunity to update some dated language
      that was not consistent with our modern documentation writing style,
      in particular including a totally unnecessary and potentially-alienating
      claim that Terraform is "very easy to use". Our modern writing style
      discourages this sort of "boastful" language and encourages us to focus on
      the facts at hand.
      6a44586a
    • Martin Atkins's avatar
      main: A slightly more compact presentation of the main help text · 248cf7f1
      Martin Atkins authored
      This just reduces the amount of space between different elements on in the
      main help output from four columns to two. The main motivation here was
      to give some of the longer command descriptions a little more horizontal
      breathing room, but subjectively I also find the tighter column gutters
      easier to scan. Others may disagree, of course.
      248cf7f1
    • Martin Atkins's avatar
      command: Improve consistency of the command short descriptions · c94a6102
      Martin Atkins authored
      The short description of our commands (as shown in the main help output
      from "terraform") was previously very inconsistent, using different
      tense/mood for different commands. Some of the commands were also using
      some terminology choices inconsistent with how we currently talk about
      the related ideas in our documentation.
      
      Here I've tried to add some consistency by first rewriting them all in
      the imperative mood (except the ones that just are just subcommand
      groupings), and tweaking some of the terminology to hopefully gel better
      with how we present similar ideas in our recently-updated docs.
      
      While working on this I inevitably spotted some similar inconsistencies
      in the longer-form help output of some of the commands. I've not reviewed
      all of these for consistency, but I did update some where the wording
      was either left inconsstent with the short form changes I'd made or
      where the prose stood out to me as particularly inconsistent with our
      current usual documentation language style.
      
      All of this is subjective, so I expect we'll continue to tweak these over
      time as we continue to develop our documentation writing style based on
      user questions and feedback.
      c94a6102
    • Martin Atkins's avatar
      main: Emphasize only the primary workflow commands in our help · 9665901e
      Martin Atkins authored
      A long time ago we introduced this separation between "common commands"
      and "all other commands", but over the intervening years we've not really
      done a good job of classifying new commands we've added and so by default
      most of them ended up being classified as "common".
      
      In the interests of making this output more useful for those getting
      started, this switches the two categories so that "Main commands" is now
      the curated list, and "all other commands" is the bucket for everything
      else.
      
      The intent here is that the "main commands" are the ones users are likely
      to try as part of their initial learning of Terraform, while the other
      commands are for less common situations where the user is more likely to
      learn about a specific command in some other context, like a tutorial
      about a special situation.
      
      The "main commands" are also now ordered by the sequence users will
      typically run them in, rather than alphabetical order. That's a subjective
      readability tradeoff, but I think as long as the list stays relatively
      short (which it should) it's still relatively easy to scan and find a
      particular command in the shortlist.
      9665901e
    • Martin Atkins's avatar
      main: Hide several commands from our help · f44265e5
      Martin Atkins authored
      These are commands that either no longer do anything aside from emitting
      an error message or are just backward-compatibility aliases for other
      commands.
      
      This generalizes our previous situation where we were specifically
      hiding "internal-plugin", and does so in a way that fixes the
      long-standing cosmetic bug that the column width in the help output was
      chosen based on the hidden command "internal-plugin", which is
      unfortunately also the longest command in our command set.
      f44265e5
    • Martin Atkins's avatar
      command: Remove the useless "debug" subcommand · 39504ede
      Martin Atkins authored
      This is just a husk of a container command that has no nested commands
      under it, so it isn't serving any purpose.
      39504ede
    • Alisdair McDiarmid's avatar
      Merge pull request #26678 from hashicorp/alisdair/suppress-duplicate-version-constraints · 8eed9424
      Alisdair McDiarmid authored
      internal: Suppress duplicate version constraints
      8eed9424
    • James Bardin's avatar
      Merge pull request #26694 from hashicorp/jbardin/plugin-panics · 12c07752
      James Bardin authored
      Handle panics in plugins
      12c07752
    • James Bardin's avatar
      make grpcErr work for either plugin type · 5f063ae9
      James Bardin authored
      Extract a better function name and make the errors generic for different
      plugin types.
      5f063ae9
    • James Bardin's avatar
      record all plugin panics, and print on main exit · 3225d9ac
      James Bardin authored
      Create a logger that will record any apparent crash output for later
      processing.
      
      If the cli command returns with a non-zero exit status, check for any
      recorded crashes and add those to the output.
      3225d9ac
  4. 23 Oct, 2020 10 commits
    • James Bardin's avatar
      convert rpc errors · b4cb64d9
      James Bardin authored
      Terraform does not use rpc errors for any error communication, so these
      are always something that went wrong in outside of the plugin protocol.
      The most common example of which is a provider crash, which would return
      "rpc error: code = Unavailable desc = transport is closing". Replace
      these error codes with something a little more presentable for the user,
      and insert the calling method name to help correlate it to the
      operation that failed.
      b4cb64d9
    • Arthur Burkart's avatar
      lang/funcs: "anytrue" function · d4716a69
      Arthur Burkart authored
      This is an analog to the "alltrue" function, using OR as the reduce
      operator rather than AND.
      
      This also includes some simplification of the "alltrue" implementation
      to implement it similarly as a sort of reduce operation with AND
      as the reduce operator, but with the same effective behavior.
      d4716a69
    • Alisdair McDiarmid's avatar
      Merge pull request #26690 from hashicorp/alisdair/codecov-patch-stop-please · 5522a799
      Alisdair McDiarmid authored
      build: Set Codecov to informational mode again
      5522a799
    • Alisdair McDiarmid's avatar
      build: Set Codecov to informational mode again · 6345187c
      Alisdair McDiarmid authored
      We have informational mode enabled for pull requests. This commit
      enables it for individual commits, too.
      
      Informational mode registers the result of a Codecov check without ever
      failing due to low coverage. This is appropriate for Terraform because
      much of the test coverage comes from cross-package tests, which Codecov
      misses.
      6345187c
    • Petros Kolyvas's avatar
      website: Fix for documentation around local-name conflicts (#26689) · b1671b2c
      Petros Kolyvas authored
      * Fixes #26684
      
      * Update provider-requirements.html.md
      
      Removing additional/extra newlines
      
      * Update provider-requirements.html.md
      
      And now some trailing spaces. le sigh
      b1671b2c
    • James Bardin's avatar
      Merge pull request #26685 from hashicorp/jbardin/separate-loggers · ff94be21
      James Bardin authored
      Separate loggers
      ff94be21
    • James Bardin's avatar
      logging env variable docs · eb2d4434
      James Bardin authored
      eb2d4434
    • James Bardin's avatar
      separate core and provider loggers · f8893785
      James Bardin authored
      Now that hclog can independently set levels on related loggers, we can
      separate the log levels for different subsystems in terraform.
      
      This adds the new environment variables, `TF_LOG_CORE` and
      `TF_LOG_PROVIDER`, which each take the same set of log level arguments,
      and only applies to logs from that subsystem. This means that setting
      `TF_LOG_CORE=level` will not show logs from providers, and
      `TF_LOG_PROVIDER=level` will not show logs from core. The behavior of
      `TF_LOG` alone does not change.
      
      While it is not necessarily needed since the default is to disable logs,
      there is also a new level argument of `off`, which reflects the
      associated level in hclog.
      f8893785
    • Pam Selle's avatar
      Merge pull request #26653 from hashicorp/pselle/getresource · c9e362bb
      Pam Selle authored
      Return marked After values in GetResource
      c9e362bb
    • James Bardin's avatar
      Merge pull request #26687 from hashicorp/jbardin/warning-errors · 37d57a25
      James Bardin authored
      do not return warnings as errors from eval
      37d57a25