Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
小 白蛋
Terraform
Commits
74129323
Commit
74129323
authored
8 years ago
by
Radek Simko
Committed by
GitHub
8 years ago
Browse files
Options
Download
Email Patches
Plain Diff
Mention LOC of incoming PRs in contributors guide (#13737)
parent
8939ac22
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
.github/CONTRIBUTING.md
+8
-0
.github/CONTRIBUTING.md
with
8 additions
and
0 deletions
+8
-0
.github/CONTRIBUTING.md
+
8
-
0
View file @
74129323
...
...
@@ -201,6 +201,9 @@ Implementing a new resource is a good way to learn more about how Terraform
interacts with upstream APIs. There are plenty of examples to draw from in the
existing resources, but you still get to implement something completely new.
-
[ ] __Minimal LOC__: It can be inefficient for both the reviewer
and author to go through long feedback cycles on a big PR with many
resources. We therefore encourage you to only submit
**1 resource at a time**
.
-
[ ] __Acceptance tests__: New resources should include acceptance tests
covering their behavior. See
[
Writing Acceptance
Tests
](
#writing-acceptance-tests
)
below for a detailed guide on how to
...
...
@@ -223,6 +226,11 @@ Implementing a new provider gives Terraform the ability to manage resources in
a whole new API. It's a larger undertaking, but brings major new functionality
into Terraform.
-
[ ] __Minimal initial LOC__: Some providers may be big and it can be
inefficient for both reviewer & author to go through long feedback cycles
on a big PR with many resources. We encourage you to only submit
the necessary minimum in a single PR, ideally
**just the first resource**
of the provider.
-
[ ] __Acceptance tests__: Each provider should include an acceptance test
suite with tests for each resource should include acceptance tests covering
its behavior. See
[
Writing Acceptance Tests
](
#writing-acceptance-tests
)
below
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Projects
Groups
Snippets
Help