* sly.el (sldb-frame-map): Set `sly-part-button-keymap' as parent
of `sly-frame-keymap'.
(sldb-frame): Make this button type inherit from `sly-part', not
`sly-button'.
(sldb-frame-button): Add `part-args' and `part-label' props to
`sldb-frame' buttons.

* contrib/sly-mrepl.el (define-sly-contrib sly-mrepl): Define a new
"part-action" `sly-mrepl-copy-call-to-repl'. Put this is
`sldb-frame' and `sly-trace-dialog-spec' button types. Rename
previous `sly-mrepl-copy-to-repl' action to
`sly-mrepl-copy-part-to-repl'
(sly-inspector-copy-part-to-repl): Renamed from
`sly-inspector-copy-down-to-repl'
(sldb-copy-part-to-repl): Renamed from `sldb-copy-down-to-repl'.
(sly-trace-dialog-copy-part-to-repl): Renamed from
`sly-trace-dialog-copy-down-to-repl'
(sly-mrepl--insert-call, sldb-copy-call-to-repl)
(sly-trace-dialog-copy-call-to-repl): New functions.

* contrib/sly-trace-dialog.el (sly-trace-dialog-spec):
`sly-button-inspect' method takes more (ignored) arguments.
(sly-trace-dialog-spec-button): `sly-trace-dialog-spec' buttons
have more props.
(sly-trace-dialog--insert-trace): Pass trace to
`sly-trace-dialog-spec-button'

* contrib/swank-trace-dialog.lisp (trace-arguments): New function.

* contrib/sly-mrepl.el (sly-mrepl--commiting-text): edebug and indent specs.
(sly-mrepl--send-input-sexp): change name to clarify that this is
only for sending sexps.
(sly-mrepl-return): Use `comint-send-input' directly.
(sly-mrepl--commiting-text): edebug spec.
(sly-mrepl--send-input-sexp): change name to clarify that this is
only for sending sexps.
(sly-mrepl-return): Use `comint-send-input' directly.
(sly-mrepl--pending-output): New variable.
(sly-mrepl--insert-output): Insert or save pending output.
(listener): Save pending output.
(sly-mrepl-return, sly-mrepl-guess-package): Format messages with
"[sly]". FIXME, use `sly-message'.

* contrib/swank-mrepl.lisp (initialize-instance): Must init listener's
SWANK::IN slot here.
(create-mrepl): Not here.
(mread-eval-1): Fix whitespace.

* sly-mrepl.el (sly-mrepl-mode-map): Add "M-p" and "M-n"
lost when `comint-mode-map' inheritance was broken.
(sly-mrepl--insert-output): Ensure prettier insertion of
unexpected async output.

* sly.el (sldb-setup, sldb-insert-frames, sldb-insert-frame)
(sldb-frame-details-region): New function.
(sldb-frame-details-visible-p): Deleted.
(sldb-sugar-move,sldb-hide-frame-details, sldb-toggle-details):
Use `sldb-frame-details-region'
(sldb-sugar-move): Fix bug.

Work in progress.

* sly.el (sly-inspector-mode-map): Remove some invalid
keybindings.
(menubar-sly, menubar-sly-sldb): Removed.
(sly-menu, sly-sldb-menu, sly-inspector-menu): New menus.
(sly-sldb-easy-menu, sly-easy-menu): These variables are unneeded.
(sly-add-easy-menu, sly-sldb-add-easy-menu): Removed.

* contrib/sly-mrepl.el (sly-mrepl--last-prompt-overlay):
Resurrected.
(sly-mrepl-mode): Remove `sly-mrepl-mode-map' comint parent.
(sly-mrepl--shortcut-menu, sly-mrepl--menu): New menus.

* contrib/sly-trace-dialog.el (sly-trace-dialog--shortcut-menu)
(sly-trace-dialog--menu): New menus.
(sly-trace-dialog--menubar): Remove.

* swank-cmucl.lisp (pcl-class-location): Renamed from
class-location.
(class-location): New.
(class-definitions): Search condition classes in infodb.

(cherry picked from SLIME commit
ab5991d4)

Conflicts:
	ChangeLog

* lib/lisp/swank.lisp (before-init): Don't call
warn-unimplemented-interfaces as it confuses first time users.
(thread-for-evaluation): Suppress unused var warnings.

* contrib/swank-asdf.lisp: Avoid unreachable code for version check.
(unique-string-list): Avoid unreachable code warnings.

* contrib/swank-fuzzy.lisp (*all-chunks*): Defvar it and declaim the type
to avoid type uncertainty warnings.

* contrib/swank-package-fu.lisp (export-structure): Suppress warning about
unknown function list-structure-symbols with #+.

(cherry picked from SLIME commit
98e1a8c2)

Conflicts:
	ChangeLog
	contrib/ChangeLog
	contrib/swank-presentations.lisp
	lib/lisp/swank.lisp

* swank-backend.lisp (utf8-encode): Avoid unreachable code
warnings.
(%utf8-encode): New helper.
* swank-sbcl.lisp (sbcl-wrap): Add ignore declaration.

(cherry picked from SLIME commit
8eec94d1)

Conflicts:
	ChangeLog

While CLHS seems to guarantee PATHNAME-HOST to return a string, this is
not always the case in practice (e.g. SBCL returns a
SB-IMPL:LOGICAL-HOST instance).

* swank-fancy-inspector.lisp (emacs-inspect logical-pathname): wrap the
  return value of PATHNAME-HOST in a (:value ...) in case it is not a
  string

(cherry picked from SLIME commit
a27493d1)

Conflicts:
	contrib/ChangeLog

(cherry picked from SLIME commit
5c6e36bd)

* swank-kawa.scm (connection-info): Return :encoding options
to make slime-repl work.
(listener): Set current-output-port.

Also add a version check at the beginning and update the
compilation instructions.

(cherry picked from SLIME commit
ef96edee)

Conflicts:
	contrib/ChangeLog
	contrib/swank-kawa.scm

There's no TRACE-TABLE-OFFSET slot. Don't bother showing it on
older SBCLs, since it isn't really useful.

(cherry picked from SLIME commit 250dda50)

Conflicts:
	ChangeLog

* contrib/swank-fancy-inspector.lisp (method-specializers-for-inspect):
  in SBCL use `sb-pcl:unparse-specializer-using-class' instead of simply
  `class-name'
  (specializer<): only use CPL-based method for `class' specializers

(cherry picked from SLIME commit
6b745f1c)

Conflicts:
	contrib/ChangeLog

Adapted from SLIME commit 04b5b048.

* sly.el (sldb-confirm-buffer-kill): Confirm buffer kill even if
`sldb-quit' errors.
(sly-update-connection-list): Make more robust when
`sly-connection-name' and `sly-lisp-implementation-type' aren't known yet.

* contrib/swank-mrepl.lisp (create-mrepl):
MAYBE-REDIRECT-GLOBAL-IO must be called without any listener.

* contrib/swank-trace-dialog.lisp (:swank-trace-dialog): Use
:SWANK-API package.

* lib/lisp/swank.lisp (close-connection%): When closing channels
and listeners, ensure *EMACS-CONNECTION* is set.
(defpackage :swank-api): Don't use `eval'

* contrib/sly-trace-dialog.el (sly-trace-dialog--detail-mode)
(sly-trace-dialog--detail-mode-map)
(sly-trace-dialog--make-autofollow-fn)
(sly-trace-dialog--open-detail): Removed.
(sly-trace-dialog-spec, sly-trace-dialog-spec-button): New button
type and constructor.
(sly-trace-dialog--insert-trace): Simplify using buttons.
(sly-trace-dialog--insert-trace): Call
`sly-trace-dalog-part-button'.

* contrib/swank-trace-dialog.lisp (inspect-trace): New slyfun.

* contrib/sly-mrepl.el (:copy-to-repl, :evaluation-aborted): Use
`sly-mrepl--insert-output' to insert notes.
(:copy-to-repl): Simplify. Doesn't need to `mrepl--send-input'
(:copy-to-repl, :evaluation-aborted, :write-string): Use
`sly-mrepl--catch-up'
(sly-mrepl--catch-up): New function.
(sly-mrepl-insert-input): Fix error when getting input.

* contrib/sly-mrepl.el (sly-mrepl--stacked-errors): New buffer-local variable.
(sly-mrepl--frozen-prompt-overlays): Remove
(:freeze-prompt, :unfreeze-prompt): Simplify.
(sly-mrepl-errored-prompt-face): New face.
(sly-mrepl--prompt-face): Decides which face based on
`sly-mrepl--stacked-errors'.

* sly.el (sly-easy-menu): Remove profiling section.
(sly-easy-menu): Remove stale "Create Trace Buffer" option.
(sly-toggle-profile-fdefinition, sly-unprofile-all)
(sly-profile-report, sly-profile-reset, sly-profiled-functions)
(sly-profile-package, sly-profile-by-substring): Remove.

* doc/slime.texi (Top): Remove Profiling node.

* lib/lisp/swank.lisp (profiledp, toggle-profile-fdefinition)
(profile-by-substring, swank-profile-package): Remove.
(defpackage :swank): Remove exported profile-related functions.

* sly.el (define-sldb-faces): Remove faces `restart-type' and
`detailed-frame-line'.
(sly-property-bounds): Removed.
(sly--highlight-sexp, sly--highlight-line): Moved up here and made
internal.
(sly--display-source-location, sly--pop-to-source-location)
(sly-goto-next-xref): Use `sly--highlight-sexp' and
`sly--highlight-line'.
(sldb-mode-map): Keep only generic keybindings applicable to all
buffer points. Don't bind TAB to `sldb-cycle', but to
`forward-button'.
(sldb-mode): Update doc.
(sldb-confirm-buffer-kill): New function.
(sldb-setup): Add it to `kill-button-query-functions'. `frames'
are now `frame-specs'.
(sldb-insert-condition): No need for `sly-insert-propertized'
(sldb-insert-restarts): Use action buttons.
(sldb-insert-more-restarts, sldb-frame.string)
(sldb-frame.number, sldb-frame.plist): Removed.
(sldb-prune-initial-frames): Don't use frame-spec accessors.
(sldb-insert-frames): Rewrite to use buttons.
(sldb-compute-frame-face): Remove.
(sldb-insert-frame): Rewrite.
(sldb-fetch-more-frames, sldb-restart-at-point): Removed.
(sldb-frame-number-at-point): Rewritten.
(sldb-frame-map): New map.
(sldb-previous-frame-number): Removed.
(sldb-frame-region): Removed.
(sldb-frame, sldb-frame-button): New button type and constructor.
(sldb-forward-frame, sldb-backward-frame): Removed.
(sldb-frame-button-near-point): New finder.
(sly-save-coordinates, sly-coordinates, sly-restore-coordinate)
(sly-count-lines, sldb-default-action)
(sldb-default-action/mouse): Removed.
(sldb-show-frame-source): Make interactive and replaces
`sldb-show-source'.
(sldb-show-source): Removed.
(sldb-toggle-details, sldb-show-frame-details)
(sldb-hide-frame-details): Rewritten to use buttons.
(sldb-frame-details): Removed.
(sldb-local-variable, sldb-local-variable-button): New button type
and constructor.
(sldb-frame-eval-interactive, sldb-pprint-eval-in-frame)
(sldb-inspect-in-frame, sldb-eval-in-frame): Use `frame-number'
not `frame'
(sldb-down): More powerful and use buttons.
(sldb-up): Use `sldb-down'
(sldb-sugar-move): Rewrite to use buttons.
(sldb-details-down, sldb-details-up): Use new `sldb-sugar-move'
protocol.
(sldb-invoke-restart): `restart-number` arg is mandatory.
(sldb-step, sldb-next, sldb-out, sldb-break-on-return)
(sldb-recompile-frame-source, sldb-return-from-frame)
(sldb-restart-frame): Take `frame-number' as interactive arg.
(sly-inspector-part-button): This is the constructor for
`sly-inspector-part' buttons.

* contrib/sly-mrepl.el (sly-mrepl): Use `sldb-local-variable', not
`sldb-local-part' to insinuate M-RET.

* lib/sly-buttons.el (sly-button-at): New function.
(sly-button-at-point): Removed.
(sly-button-define-part-action): Use `sly-button-at'
(sly-button): New button type which is the supertype of all others
sly-related.

* sly.el (sldb-mode): SLDB buffer must be read only.
(sldb-var-number-at-point): Removed.
(sldb-local-part): New button type and constructor.
(sldb-inspect-var): Removed.
(sldb-insert-locals): Insert a `sly-local-part' button.

* contrib/sly-mrepl.el (sly-mrepl): Use `button-type-put' on
`sldb-local-part' buttons as well.
(sldb-copy-down-to-repl): No longer interactive.

* contrib/sly-autodoc.el (sly-autodoc-inhibit-autodoc): New variable.
(sly-autodoc): Inhibit according to
`sly-autoloads-inhibit-autodoc' variable.

* contrib/sly-mrepl.el (sly-mrepl-mode): Set
`sly-autodoc-inhibit-autodoc' to
`sly-mrepl-inside-string-or-comment-p'
(sly-mrepl-inside-string-or-comment-p): New function.

Also some sly-mrepl groundwork for returning calls to REPL

* contrib/sly-mrepl.el (sly-mrepl--copy-to-repl): New function.
(sly-mrepl--eval-for-repl): Call `sly-mrepl--copy-to-repl'
(:copy-to-repl): Add `note' arg and insert it after the ";;"
(sly-mrepl--eval-for-repl): Add `note' arg. Send note to lisp.
(sldb-copy-down-to-repl, sly-trace-dialog-copy-down-to-repl)
(sly-inspector-copy-down-to-repl): Pass a note to
`sly-mrepl--eval-for-repl'
(sly-inspector-copy-down-to-repl): Use
SWANK:INSPECTOR-NTH-PART-OR-LOSE

* contrib/swank-mrepl.lisp (mrepl-get-history-entry): New function.
(mrepl-get-object-from-history): Use it.
(globally-save-object): Saves SLAVE-SLYFUN's multiple return
values. Pass a note to COPY-VALUES-TO-REPL
(:copy-to-repl): Can copy multiple values to REPL.
(copy-values-to-repl): Add NOTE arg.
(:sync-package-and-default-directory): Pass a note to
COPY-VALUES-TO-REPL.
(*saved-objects*, *saved-objects-note*): New variables

* lib/lisp/swank.lisp (inspector-nth-part-or-lose): New
slyfun. Wonder if the other one is still useful.

* contrib/sly-mrepl.el (sly-mrepl--commiting-text): Accept `props' arg.
(sly-mrepl--insert): Adjust call to `sly-mrepl--commiting-text'.
(sly-mrepl--send-input): Make input a field with a keymap.
(sly-mrepl-insert-input): New interactive command.

* sly.el (sly-inspector-operate-on-point)
(sly-inspector-property-at-point, sly-inspector-operate-on-click):
Removed this silly function.
(sly-curry, sly-rcurry): Make properly lexical.
(sly-inspector-insert-more-button, sly-inspector-insert-ispec):
Use `sly-make-action-button'.
(sly-inspector-fetch-more): Use Emacs' button API

* sly-buttons.el (sly-part-button-keymap): Keymap declaration is simpler.
(sly-button--popup-option-name)
(sly-button--popup-part-menu-options): Removed. Clever but horrible.
(sly-button-popup-part-menu-keymap): New keymap.
(sly-button-popup-part-menu): Use the rest of
`sly-button-popup-part-menu-keymap'.
(sly-button-define-part-action): Rewritten.
(sly-button-not-implemented): Removed.

* sly.el (sly-inspector-part): Use new action prop names.

* contrib/sly-mrepl.el (sly-mrepl): Use better
`sly-button-define-part-action'
(sly-mrepl-part): Use new action prop names.

* contrib/sly-trace-dialog.el (sly-trace-dialog-part): Use new action prop names.

Probably buggy though, and `sly-button-define-part-action' could help
much further.

* sly-buttons.el (sly-part-button-keymap): Add
`sly-button-pretty-print' and `sly-button-show-source'
(sly-button--popup-option-name): Return just name.
(sly-button--popup-part-menu-options, sly-button-popup-part-menu):
Watch for `sly-button-not-implemented' when building menu.
(sly-button-define-part-action): New macro.
(sly-button-inspect, sly-button-describe): Defined with calls to
new macro.

* sly.el (sly-inspector-part): New button type and constructor function.
(sly-inspector-insert-ispec-function): Remove this indirection.
(sly-inspector-insert-ispec, sly-open-inspector): Use
sly-inspector-part.
(sly-inspector-insert-chunk): Don't use `sly-inspector-insert-ispec-function'
(sly-inspector-operate-on-point, sly-inspector-property-at-point):
Don't use `sly-part-number'
(sly-find-inspectable-object)
(sly-inspector-next-inspectable-object)
(sly-inspector-previous-inspectable-object)
(sly-inspector-pprint, sly-inspector-show-source): Remove.

* contrib/sly-mrepl.el (sly-mrepl): Insinuate into inspector using
`button-type-put'.
(sly-button-copy-to-REPL): Defined with
`sly-button-define-part-action'.
(sly-inspector-copy-down-to-repl)
(sly-trace-dialog-copy-down-to-repl): Simplify.

* contrib/sly-trace-dialog.el (sly-trace-dialog-mode-map): Use
`backward-button' and `forward-button'.
(sly-trace-dialog--detail-mode-map): No remaps needed.
(sly-trace-dialog-part): Skip trace parts buttons.
(sly-trace-dialog-next-button, sly-trace-dialog-prev-button): Remove.

* sly-buttons.el: New file.

* sly.el (sly): Remove "Buttons" section in favour of requiring
`sly-buttons.el'.

* contrib/sly-mrepl.el (sly-mrepl): Setup M-RET slightly
differently. Insinuate into new keymaps from
sly-button.el. Insinuate into new button-type
`sly-trace-dialog-part'.
(sly-mrepl-part): New button type.
(sly-button-copy-to-REPL): New function.
(sly-mrepl-copy-to-repl, sly-mrepl--get-object-indexes-at-point)
(sly-mrepl-inspect-object-at-point, sly-mrepl-copy-down-to-repl):
Remove.

* contrib/sly-trace-dialog.el (sly-trace-dialog-part): New button type.
(sly-trace-dialog--format-part): Simplify.
(sly-trace-dialog--button): Remove.
(sly-trace-dialog--open-specs)
(sly-trace-dialog--update-progress)
(sly-trace-dialog--insert-trace): Use `sly-make-action-button'

* contrib/sly-mrepl.el (sly-mrepl--insert-output): Insert newline
explicitly, don't use `sly-mrepl--ensure-newline'. Solve read-line
issues.
(sly-mrepl--ensure-newline): Simplify implementation.
(:prompt, sly-mrepl--insert-returned-values): Don't pass mark to
`sly-mrepl--ensure-newline'

* sly.el (sly-maybe-start-lisp, sly-net-close, sly-net-sentinel)
(sly-net-read-or-lose, sly-check-version, sly-disconnect)
(sly-disconnect-all, sly-restart-sentinel, sly-quit-sentinel):
Pass close reason to `sly-net-close'

* contrib/sly-mrepl.el (sly-mrepl--teardown-repls): fetch teardown
reason from process args.
(sly-mrepl--teardown): Take new optional reason arg.

* contrib/sly-mrepl.el (sly-mrepl--insert-returned-values): Don't
increment the result counter if no results are reported.

* contrib/swank-mrepl.lisp (mrepl-eval): Call MREPL-EVAL-1.
(mread-eval-1): Renamed from REPL-EVAL. Fixed handling of
*PACKAGE*.