* slynk-mrepl.lisp (sync-package-and-default-directory)
(guess-and-set-package): Slave "slyfuns" must return an elisp-
readable value.

* CONTRIBUTING.md: Update example and fix a typo.

* contrib/sly-mrepl.el (sly-mrepl--result-counter): Remove variable.
(sly-mrepl-mode): Don't set `sly-mrepl--result-counter'
(:write-values): Rename arg to "results".
(:clear-repl-history): Don't set `sly-mrepl--result-counter'.
(sly-mrepl--eval-for-repl): Rewrite using `cl-destructuring-bind'.
(sly-mrepl--make-result-button): Only two arguments.
(sly-mrepl--insert-returned-values): Don't use `sly-mrepl--result-counter'.
(sly-mrepl-shortcut-alist): Add "clear repl" as a REPL shortcut.
* test/sly-stickers-tests.el (stickers-in-a-file): New test.
(stickers-record-stuff): Fix FIXME.

* contrib/slynk-mrepl.lisp (make-results): New helper.
(mrepl-eval): Use MAKE-RESULTS.
(inspect-entry): Don't use SLYNK::TO-LINE here.
(copy-to-repl): Use MAKE-RESULTS.

explicitly to appease sbcl.

* sly.el (sly-region-for-defun-at-point): Accept POS as default point.

* contrib/sly-stickers.el
(sly-stickers-compile-region-aware-of-stickers-1): New helper
function. Accept `callback'. Accept `sync', `flash` and `fallback`
as boolean kwargs.
(sly-stickers-compile-region-aware-of-stickers): Make use of
`sly-stickers-compile-region-aware-of-stickers-1'
(sly-stickers-after-buffer-compilation): Implemented, makes use of
`sly-stickers-compile-region-aware-of-stickers-1'.

* contrib/slynk-stickers.lisp (defpackage :slynk-stickers): Export slyfuns
explicitly to appease sbcl.
(compile-for-stickers): Add docstring. Only return PROBE if it was
a successful compilation. Return nil if no ORIGINAL-STRING was
given.

* test/sly-stickers-tests.el (stickers-in-a-file): New test.
(stickers-record-stuff): Fix FIXME.

* sly.el (sly-menu): Reorganize. Tracing options moved to
`sly-trace-dialog' contrib.

* contrib/sly-trace-dialog.el (sly-trace-dialog-untrace-all): New function.
(sly-trace-dialog--shortcut-menu): Add new "Untrace all" option.

* contrib/slynk-trace-dialog.lisp (dialog-untrace-all): Return number of
specs untraced.

* sly.el (sly-messages): Require new lib.
(sly-message, sly--last-message, sly-temp-message, sly-warning)
(sly-error, sly-display-oneliner, sly-oneliner)
(sly-completing-read-function, sly-completing-read)
(sly-flash-inhibit, sly-flash-region): Move to new
lib/sly-messages.el lib

* lib/sly-buttons.el (sly-messages): require new lib.

* lib/sly-messages.el: New file.

* sly-buttons.el (sly-button--searchable-buttons-at): Ensure the
non-overlay button is actually not an overlay.

Include the docstring in the inspector for SBCL

Update refcard docs and cross-reference sections

Update the keymaps in the documentation and cross-reference sections
of the refcard to match the current default maps in the code.

An idea by henkvr from https://github.com/slime/slime/issues/193.

* slynk/backend/slynk-sbcl.lisp (emacs-inspect): Include the
  documentation string of the function in the inspector for the SBCL
  backend.

* sly.el (sly-macroexpansion-minor-mode-map): Use defvar.
(sly-show-notes): Use `sly-button-flash'.

* contrib/sly-mrepl.el (sly-mrepl-mode-map): Define more interesting
bindings for M-p and M-n, also C-M-p, C-M-n.
(sly-mrepl--make-result-button): Assign `sly-button-search-id' to
new button.
(sly-mrepl-previous-input-or-button)
(sly-mrepl-next-input-or-button): New functions.

* contrib/sly-stickers.el (sly-stickers--echo-sticker): Use new `sly-button-flash'
(sly-stickers--flash-sticker): Removed.
(sly-stickers-fetch): Use new `sly-button-flash'

* lib/sly-buttons.el (sly-button-at): Use `button-type-subtype-p'
(sly-button): Set a basic `sly-button-search-id' here.
(sly-button-flash): New function.
(sly-button-echo-part): Flash buttons by default.
(sly-button--overlays-starting-at): Renamed to
`sly-button--searchable-buttons-starting-at'
(sly-button--searchable-buttons-at): Consider text buttons.
(sly-button-search): Use `sly-button--searchable-buttons-at'
(sly-button-search): Error instead of message.

* test/sly-mrepl-tests.el (sly-mrepl-tests--assert-prompt): More
interesting search for prompt.
(sly-mrepl-tests--with-basic-repl-setup): New macro.
(repl-values-and-button-navigation): New test.

* sly-stickers.el (sly-stickers-after-buffer-compilation): Check for `stickers'

* sly.el (sly-macroexpansion-minor-mode-map): Use defvar.

* contrib/sly-mrepl.el (sly-mrepl-shortcut-key): Move down to "comma shortcut" section.
(sly-mrepl-reset-shortcut-key): Check for `sly-mrepl-shortcut-key' with boundp.

Also make the macroexpansion buffer read-only.

* sly.el (remap): Remove obsolete toplevel remappings block.
(sly-macroexpansion-minor-mode-map): Setup remaps here.

* sly-mrepl.el (sly-mrepl-shortcut-key): Add a `:set'
specification, otherwise the variable's useless.
(sly-mrepl-reset-shortcut-key): New function.
(sly-mrepl--shortcut-location-p): Only attempt to search for "`"
if the shortcut key is ","

* contrib/sly-mrepl.el (sly-mrepl--eval-for-repl): Use `after-prompt'.
(sly-mrepl--eval-for-repl): Accept `before-prompt' and
`after-prompt' callbacks.
(sly-mrepl--copy-objects-to-repl): Pass `callback' as an
`after-prompt' callback.
(sly-mrepl--insert-call): Fix off-by-one.

* contrib/sly-mrepl.el (sly-mrepl--copy-to-repl-after): Removed
hackish variable.
(sly-mrepl-mode): Ditto.
(:copy-to-repl): Delete channel method.
(sly-mrepl--insert-prompt): `condition' arg is optional.
(sly-mrepl--eval-for-repl): New function (little relation to the
old function with the same name.)
(sly-mrepl--copy-objects-to-repl): Use `sly-mrepl--eval-for-mrepl'
(sly-mrepl--save-and-copy-for-repl): Renamed from
`sly-mrepl--eval-for-mrepl'.
(sly-inspector-copy-part-to-repl, sly-db-copy-part-to-repl)
(sly-apropos-copy-symbol-to-repl)
(sly-trace-dialog-copy-part-to-repl, sly-db-copy-call-to-repl)
(sly-trace-dialog-copy-call-to-repl, sly-mrepl-set-directory): Use
`sly-mrepl--save-and-copy-for-repl'.
(sly-mrepl-set-package): Use `sly-mrepl--eval-for-repl'.

* contrib/slynk-mrepl.lisp (copy-values-to-repl): Deleted.
(prompt-arguments): New helper.
(send-prompt): Use PROMPT-ARGUMENTS.
(:copy-to-repl): Removed channel method.
(:sync-package-and-default-directory): Removed channel method.
(guess-and-set-package): Moved slyfun down.
(eval-for-mrepl): Add docstring and clarify behaviour.
(copy-to-repl, sync-package-and-default-directory): New "slave" slyfuns.

* contrib/sly-mrepl.el (sly-mrepl-shortcut-key): New variable.
(sly-mrepl-mode-map): New entry for `sly-mrepl-shortcut-key'
(sly-mrepl--shortcut-location-p): New helper.
(sly-mrepl-shortcut-alist): New variable.
(sly-mrepl-set-package, sly-mrepl-set-directory): New functions.
(sly-mrepl-shortcut): New interactive command.

* contrib/slynk-mrepl.lisp (:sync-package-and-default-directory):
Use new GUESS-AND-SET-PACKAGE.
(guess-and-set-package): New slyfun.
(with-eval-for-repl): Accept an extra MREPL-SYM arg
(eval-for-mrepl): Send prompt after evaluating slave slyfun.

If point is at note beginning and last command is not a navigation
command, begin by displaying the note at point. Otherwise go on to
next note as usual. Affects `sly-button-forward' and
`sly-button-backward'.

* sly-buttons.el (sly-button--overlays-starting-at): New helper.
(sly-button--last-search-command): New variable.
(sly-button--search-1): New helper.
(sly-button-search): Use `sly-button--search-1' and
`sly-button--overlays-starting-at'

* Makefile (check-%): Accept extra SELECTOR arg
(check-fancy): `debug-on-error' is useless.

* contrib/sly-mrepl.el (sly-mrepl--teardown): Cleanup `sly-mrepl--channel'
property in dedicated stream process.
(sly-mrepl--dedicated-stream-output-filter): Protect against
killed buffers.

* test/sly-stickers-tests.el (sly-stickers--call-with-fixture):
Reorganize macro helper.
(sly-stickers--face-p): Make logic explicit.
(stickers-record-stuff): Remove useless "coiso" sticker.
(stickers-record-stuff): Add extra check and sync.

* contrib/sly-stickers.el (sly-stickers--stickers-between)
(sly-stickers--stickers-at, sly-stickers--stickers-between)
(sly-stickers--stickers-exactly-at): Resurrected abstractions.
(sly-stickers--sticker, sly-stickers--sticker-substickers)
(sly-stickers-clear-region-stickers)
(sly-stickers-delete-sticker-at-point)
(sly-stickers-maybe-add-sticker)
(sly-stickers-compile-region-aware-of-stickers)
(sly-stickers-after-buffer-compilation): Use sticker-specific abstractions.

* lib/sly-buttons.el (sly-button--overlays-in)
(sly-button--overlays-between, sly-button--overlays-exactly-at)
(sly-button--overlays-at): Take optional `filter' arg.
(sly-button--searchable-buttons-at): Use `sly-button--overlays-at'.

* contrib/sly-stickers.el (sly-stickers-exited-non-locally-face):
Fix docstring.
(sly-stickers-fetch): Check all stickers in the "CL_USER" package.

* test/sly-stickers-tests.el (sly-stickers--call-with-fixture):
Don't need find-file-literally.
(stickers-record-stuff): Return a symbol, not a keyword from BAR
in fixture. Fix expectation. Comment out a part, needs work still

* sly.el (sly-note): Fix essential typo.
(sly--add-in-buffer-note): Assign higher priorities to contained notes.

Added just a note in the docstring.

* sly-stickers-tests.el (sly-stickers--call-with-fixture):
Bind `sly-net-send-translator' to nil while testing.

    When non nil sly-macroexpand-all will only expand once.

* contrib/sly-stickers.el (sly-stickers--last-value-desc): New function.
(sly-stickers--populate-sticker)
(sly-stickers--mark-empty-sticker): Use it.

* test/sly-stickers-tests.el (sly-stickers--call-with-fixture):
Use :CL explicitly.
(stickers-basic-navigation, stickers-should-stick)
(stickers-when-invalid-dont-stick): Don't need the defpackage
forms here. Fix doncstrings.

* sly.el (sly-flash-inhibit): New variable.
(sly-flash-region): Use it.

* contrib/sly-stickers.el (top): Require 'sly-buttons
(sly-stickers--stickers-in, sly-stickers--stickers-between)
(sly-stickers--stickers-exactly-at, sly-stickers--stickers-at)
(sly-stickers--sticker-priority): Move to sly-buttons.el.
(sly-stickers--set-face, sly-stickers--sticker)
(sly-stickers--sticker-substickers)
(sly-stickers--decrease-prio, sly-stickers--increase-prio)
(sly-stickers-clear-region-stickers)
(sly-stickers-delete-sticker-at-point)
(sly-stickers-maybe-add-sticker)
(sly-stickers-compile-region-aware-of-stickers)
(sly-stickers-after-buffer-compilation): Use `sly-button-*' functions.
(sly-stickers--populate-sticker): Also record case when no values were returned.

* lib/sly-buttons.el (sly-button--overlays-in)
(sly-button--overlays-between, sly-button--overlays-exactly-at)
(sly-button--overlays-at, sly-button--overlay-priority): New functions.

* lib/sly-tests.el (defun): No need to check for ert.el.

* test/sly-stickers-test.el (sly-stickers): New file.

* slynk.lisp (handle-indentation-cache-request): Handle case
where PACKAGE was deleted, would otherwise error and terminate the
indentation sync thread.

Not the other way around!

* sly.el (sly-highlight-face): Don't need this face.
(sly-flash-region): Use `highlight' as the default flashing face.
(sly-last-visited-note-buttons): Removed.
(sly--note-buttons-at): Removed.
(sly--search-note): Removed.
(sly-next-note): Alias to `sly-button-forward'
(sly-previous-note): Alias to `sly-button-backward'
(sly-goto-first-note): use `sly-next-node'
(sly-show-notes): Consider more than one button. Fancy flash
notes.
(sly-in-buffer-note): Add `sly-button-echo' property.
(sly--add-in-buffer-note): Add `sly-button-search-id' property.
(sly--compilation-note-group-button): Notes property is now
`sly-notes-group'
(sly--add-in-buffer-note): Notes property is now `sly-note'
(sly-note-filter-function): New variable.
(sly-next-note):

* contrib/sly-stickers.el (sly-stickers-prefix-map): Deleted.
(sly-stickers-mode-map): Restore previous simpler keybindings.
(sly-stickers--sticker): Use `sly-button-echo' property.
(sly-stickers--echo-sticker): Accept more stickers but assert they
are not there.
(sly-stickers--sticker): Add `sly-button-search-id' property.
(sly-stickers-next-sticker, sly-stickers-prev-sticker): Use
`sly-button-search'

* lib/sly-buttons.el (sly-action, sly-part): New `sly-button-echo'
property.
(sly-button-echo-button, sly-button-echo-part): New functions.
(sly-button--next-search-id, sly-button-next-search-id)
(sly-button--searchable-buttons-at, sly-button-search)
(sly-button-filter-function, sly-button-forward)
(sly-button-backward): New functions.

* lib/sly-tests.el (sly-test--compile-defun): Call
`sly-previous-note' interactively.