Other uses of the minibuffer always prefix the message with
"[sly]"

* sly.el (sly-message): Redone.
(sly-message-function, sly-background-message-function)
(sly-background-message): Removed.
(sly-error): New function.

Also in /lisp/backend

New sophisticated in-buffer navigation of compilation notes. Perhaps
too sophisticated...

* sly-tests.el (compile-defun)
(compile-defun-with-reader-conditionals): Restore `sly-previous-note'
call and make slightly more readable.

* sly.el (sly-next-note): New variable.
(sly--note-buttons-at, sly--search-note): New functions.
(sly-next-note, sly-previous-note, sly-goto-first-note): Unbreak
them.
(sly--add-in-buffer-note): Simplify: in-buffer notes are not
merged.
(sly--compilation-note-group-button): Must return the string for
Emacs 24.3

* sly.el (sly-apropos-symbol): New button type.
(sly-apropos-designator-string, sly-apropos-insert-symbol): New
function.
(sly-print-apropos): Rewritten. Uses more buttons.
(sly-insert-xrefs): Add `sly-location' property to area near xref
button.

* lib/lisp/swank-backend.lisp (make-cl-ppcre-matcher)
(make-plain-matcher): New functions.
(make-apropos-matcher): Redesigned.

* lib/lisp/swank.lisp (apropos-list-for-emacs): Rewrittern with
for new retval of APROPOS-SYMBOLS.
(briefly-describe-symbol-for-emacs): Designator is now a triplet.
(apropos-symbols): Rewrite. Returns a list of lists.

* sly.el (sly-simple-completions): Ressurected.

* sly-tests.el (compile-defun)
(compile-defun-with-reader-conditionals): Pass mandatory arg to
`sly-previous-node'

* sly.el (sly-move-to-source-location): Document NOERROR and
return nil in that case.
(sly--display-source-location): New optional NOERROR param.
(sly-xref-mode): Enter sly-mode and make buffer read-only
(sldb-frame-map): RET bound to `sldb-toggle-details'.
(sldb-frame-menu-map): Simpler menu.
(sldb-local-variable-button, sldb-frame-button): Simpler label.
(sly-inspector-mode-map): Bind D, not d, to
`sly-inspector-describe-inspectee'
(sly-inspector-part): Implement `sly-button-describe'
(sly-inspector-part): Pass `noerror' to
`sly--display-source-location'
(sly-inspector-part-button): Simpler label.
(sly-inspector-describe-inspectee): Add docstring and rename from
`sly-inspector-describe'

* sly-mrepl.el (sly-mrepl--make-result-button): Simpler button label.

* lib/sly-buttons.el (sly-button-popup-part-menu): Fix label.

* lib/lisp/swank.lisp (describe-inspector-part): New slyfun.
(pprint-inspector-part): Fix docstring.

(sldb-frame-menu-map): Use a little macrolet sugar.

* sly.el (sly-most-severe): Removed.
(sly-merge-notes): Removed. Done in `sly--add-in-buffer-note'.
("pretty colors"): Remove reference to two macros which are gone.
(sly--add-in-buffer-note): Consider note severity.

* sly.el (sly-read-package-name): Don't use `sly-bogus-completion-alist'
(sly-completions-buffer-name)
(sly-complete-saved-window-configuration, sly-completions-window)
(sly-complete-delay-restoration)
(sly-complete-forget-window-configuration)
(sly-complete-restore-window-configuration)
(sly-complete-maybe-restore-window-configuration)
(sly-completion-window-active-p, sly-display-completion-list)
(sly-display-or-scroll-completions, sly-scroll-completions): Removed.
(sly-simple-complete-symbol): Much simplified
(sly-complete-symbol): Use `completion-at-point-functions'
(sly-maybe-complete-as-filename): Removed, seems useless.
(sly-minibuffer-respecting-message): Removed.
(sly-indent-and-complete-symbol): Call `indent-for-tab-command'
(sly-bogus-completion-alist): Removed.
(sly-simple-completions): Removed.

* sly.el (sly-compilation-finished-hook): Remove option `sly-list-compiler-notes'.
(sly-load-failed-fasl): Change default to a saner option 'NEVER.
(sly-highlight-notes): Use `sly--add-in-buffer-note'.
(sly-note-overlays, sly-remove-old-overlays, sly-filter-buffers): Removed.
(sly-merge-notes-for-display, sly-merge-notes)
(sly-notes-in-same-location-p): Removed.
(sly-create-compilation-log): Enter `sly-mode' as well.
(sly-compilation-log--notes): New variable.
(sly-insert-compilation-log): Use buttons and fields.
(sly-overlay-note, sly-goto-note-in-compilation-log): Removed.
(sly-create-note-overlay, sly-merge-note-into-overlay): Removed.
(sly-choose-overlay-for-sexp, sly-choose-overlay-region)
(sly-choose-overlay-for-read-error): Replace `cl-values' with plain `list'
(sly-severity-face-plist): Fix indentation.
(sly-visit-source-path): Removed.
(sly-next-note): Simplify.
(sly-previous-note): Simplify.
(sly-goto-first-note): Simplify.
(sly-remove-notes): New function.
(sly-merge-notes): New function.
(sly-show-note): Redone.
(sly-temporarily-highlight-note): Removed.
(sly-note-at-point, sly-note-overlay-p)
(sly-note-overlays-at-point, sly-find-next-note)
(sly-find-previous-note): Removed.
(sly-note, sly-in-buffer-note, sly-compilation-note-group): New
button types.
(sly--in-buffer-note-modification, sly--add-in-buffer-note)
(sly--compilation-note-group-button): New functions.
(sly-filter-buffers): Moved to SLDB section where it's used.
(sly-menu): Replace `sly-list-compiler-notes' with
`sly-show-compilation-log'

* sly.el (sly-mode-map): `sly-next-location' and
`sly-previous-location' unbound.
(sly-xref-face, sly-xref, sly-xref-button): New button type, face
and constructor.
(sly-insert-xrefs): Insert buttons.
(sly-xref-prev-line, sly-xref-next-line): Use buttons.
(sly-next-location-function, sly-previous-location-function)
(sly-goto-next-xref, sly-goto-previous-xref, sly-next-location)
(sly-previous-location): Remove.
(sly-xref--show-buffer): Don't set `sly-next-location-function' or
`sly-previous-location-function'

* sly-mrepl.el (sly-mrepl--insert-prompt): Helper function for :prompt method.
(define-channel-method :write-values): Don't `accept-process-output' here.
(sly-mrepl-return): Do it here.

* contrib/sly-mrepl.el (define-channel-method :prompt): Insert a button to
the associated debugger.
(sly-mrepl--prompt-face): Removed.
(sly-mrepl-prompt-face): Renamed from
`sly-mrepl-normal-prompt-face'
(sly-mrepl-errored-prompt-face): Removed.

* contrib/sly-mrepl.el (sly-mrepl-mode): Overlay should be pushed on
insertion before.
(sly-mrepl--insert-output): Another case for a "\n" isnertion.
(sly-mrepl--stacked-errors, :freeze-prompt, :unfreeze-prompt):
Delete.
(:prompt): Takes new `error-level' and `condition' args.
(sly-mrepl--prompt-face): Take `error-level' arg.

* contrib/swank-mrepl.lisp (declass mrepl): New PENDING-ERRORS slot.
(swank::drop-unprocessed-events): Don't SEND-PROMPT from here.
(mrepl-eval): Redesigned and simplified (hopefully).
(mrepl-eval-1): Renamed from MREAD-EVAL-1 (which was a typo)

* sly.el (sldb--guess-frame-name): New function.
(sldb-frame-button): Use it.

* contrib/sly-mrepl.el (define-sly-contrib sly-mrepl): Better keydindings.

* contrib/sly-fontifying-fu.el (sly-activate-font-lock-magic): Remove
xemacs branch.

* contrib/sly-mrepl.el (sly-mrepl--copy-objects-to-repl)
(sly-mrepl-sync-package-and-default-directory)
(sly-mrepl--insert-output): Simplify.

* lib/sly-buttons.el (sly-part-button-keymap): Don't bind RET
here.

* lib/lisp/backend/swank-allegro.lisp (frame-restartable-p):
Remove spurious and useless log.

* sly.el (sly-canonicalized-location, sly-choose-overlay-for-sexp)
(sly--display-source-location, sly--pop-to-source-location)
(sly-recompile-locations,sly-recompile-location): Use
`sly-move-to-source-location'.
(sly-move-to-source-location): Renamed from
`sly--move-to-source-location'

* sly.el (define-button-type sldb-frame): Default action is to
toggle details.
(sldb-frame-button): Extract spec and put it in the `part-args'
property.

* contrib/sly-mrepl.el (define-button-type sly-mrepl-part): rename
`object-idx' to `entry-idx' for clarity.
(sly-mrepl--copy-part-to-repl): New function just for copying REPL
parts.
(sly-mrepl--copy-to-repl-after): New buffer-local variable.
(sly-mrepl--copy-objects-to-repl): New function for copying any
object generically.
(listener): Don't take `note' arg and execute
`sly-mrepl--copy-objects-to-repl'
(sly-mrepl--eval-for-repl): Better protocol.
(sly-inspector-copy-part-to-repl, sldb-copy-part-to-repl)
(sly-trace-dialog-copy-part-to-repl): Adapt to new protocol.
(sly-mrepl--insert-call): Take a `spec' argument.
(sly-trace-dialog-copy-call-to-repl): Use new protocol of
`sly-mrepl--eval-for-repl'.
(sly-mrepl-sync-package-and-default-directory): Set
`sly-mrepl--copy-to-repl-after'.

* contrib/sly-mrepl.el (:unfreeze-prompt): Remove frequently failing
assertion assertion. Have to investigate.

* contrib/sly-trace-dialog.el (sly-trace-dialog--shortcut-menu): Avoid compiler warning.
(define-button-type sly-trace-dialog-spec): `part-args' property
was simplified.

* contrib/swank-mrepl.lisp (copy-values-to-repl): Don't take NOTE arg.
(:sync-package-and-default-directory): Don't pass notes to
COPY-VALUES-TO-REPL.
(*saved-objects-note*): Removed.
(globally-save-object): Don't set *SAVED-OBJECTS-NOTE*
(:copy-to-repl): Simplified.

* lib/lisp/swank-backend.lisp (frame-arguments): New interface.

* lib/lisp/backend/swank-allegro.lisp (frame-arguments): New
implementation of interface. Probably not very good.

* lib/lisp/backend/swank-ccl.lisp (frame-call): Removed implementation.

* lib/lisp/backend/swank-sbcl.lisp (frame-call): Removed implementation.

* sly.el (sly-canonicalized-location, sly-choose-overlay-for-sexp)
(sly--display-source-location, sly--pop-to-source-location)
(sly-recompile-locations,sly-recompile-location): Use
`sly-move-to-source-location'.
(sly-move-to-source-location): Renamed from
`sly--move-to-source-location'

* contrib/sly-fancy-inspector.el (sly-edit-inspector-part) Removed.
(define-sly-contrib sly-fancy-inspector): Remove :on-load and
:on-unload hooks use this contrib. `sly-edit-inpector-part'
covered by "." in inspector

* contrib/sly-package-fu.el (sly-goto-package-source-definition): Use
`sly-move-to-source-location'.

* sly.el (sldb-frame-menu-map): New keymap.
(sldb-frame): Use it heree.
(sldb-frame-button-near-point): First try button with
`sly-button-at' only then use `nearby-frame-button'

* lib/sly-buttons.el (sly-button-popup-part-menu): Add indirection and
fetch menu from the button.
(sly-part): Add `part-menu-keymap' prop

* sly.el (sldb-frame-map): Set `sly-part-button-keymap' as parent
of `sly-frame-keymap'.
(sldb-frame): Make this button type inherit from `sly-part', not
`sly-button'.
(sldb-frame-button): Add `part-args' and `part-label' props to
`sldb-frame' buttons.

* contrib/sly-mrepl.el (define-sly-contrib sly-mrepl): Define a new
"part-action" `sly-mrepl-copy-call-to-repl'. Put this is
`sldb-frame' and `sly-trace-dialog-spec' button types. Rename
previous `sly-mrepl-copy-to-repl' action to
`sly-mrepl-copy-part-to-repl'
(sly-inspector-copy-part-to-repl): Renamed from
`sly-inspector-copy-down-to-repl'
(sldb-copy-part-to-repl): Renamed from `sldb-copy-down-to-repl'.
(sly-trace-dialog-copy-part-to-repl): Renamed from
`sly-trace-dialog-copy-down-to-repl'
(sly-mrepl--insert-call, sldb-copy-call-to-repl)
(sly-trace-dialog-copy-call-to-repl): New functions.

* contrib/sly-trace-dialog.el (sly-trace-dialog-spec):
`sly-button-inspect' method takes more (ignored) arguments.
(sly-trace-dialog-spec-button): `sly-trace-dialog-spec' buttons
have more props.
(sly-trace-dialog--insert-trace): Pass trace to
`sly-trace-dialog-spec-button'

* contrib/swank-trace-dialog.lisp (trace-arguments): New function.

* contrib/sly-mrepl.el (sly-mrepl--commiting-text): edebug and indent specs.
(sly-mrepl--send-input-sexp): change name to clarify that this is
only for sending sexps.
(sly-mrepl-return): Use `comint-send-input' directly.
(sly-mrepl--commiting-text): edebug spec.
(sly-mrepl--send-input-sexp): change name to clarify that this is
only for sending sexps.
(sly-mrepl-return): Use `comint-send-input' directly.
(sly-mrepl--pending-output): New variable.
(sly-mrepl--insert-output): Insert or save pending output.
(listener): Save pending output.
(sly-mrepl-return, sly-mrepl-guess-package): Format messages with
"[sly]". FIXME, use `sly-message'.

* contrib/swank-mrepl.lisp (initialize-instance): Must init listener's
SWANK::IN slot here.
(create-mrepl): Not here.
(mread-eval-1): Fix whitespace.

* sly-mrepl.el (sly-mrepl-mode-map): Add "M-p" and "M-n"
lost when `comint-mode-map' inheritance was broken.
(sly-mrepl--insert-output): Ensure prettier insertion of
unexpected async output.

* sly.el (sldb-setup, sldb-insert-frames, sldb-insert-frame)
(sldb-frame-details-region): New function.
(sldb-frame-details-visible-p): Deleted.
(sldb-sugar-move,sldb-hide-frame-details, sldb-toggle-details):
Use `sldb-frame-details-region'
(sldb-sugar-move): Fix bug.

Work in progress.

* sly.el (sly-inspector-mode-map): Remove some invalid
keybindings.
(menubar-sly, menubar-sly-sldb): Removed.
(sly-menu, sly-sldb-menu, sly-inspector-menu): New menus.
(sly-sldb-easy-menu, sly-easy-menu): These variables are unneeded.
(sly-add-easy-menu, sly-sldb-add-easy-menu): Removed.

* contrib/sly-mrepl.el (sly-mrepl--last-prompt-overlay):
Resurrected.
(sly-mrepl-mode): Remove `sly-mrepl-mode-map' comint parent.
(sly-mrepl--shortcut-menu, sly-mrepl--menu): New menus.

* contrib/sly-trace-dialog.el (sly-trace-dialog--shortcut-menu)
(sly-trace-dialog--menu): New menus.
(sly-trace-dialog--menubar): Remove.

* swank-cmucl.lisp (pcl-class-location): Renamed from
class-location.
(class-location): New.
(class-definitions): Search condition classes in infodb.

(cherry picked from SLIME commit
ab5991d4)

Conflicts:
	ChangeLog

* lib/lisp/swank.lisp (before-init): Don't call
warn-unimplemented-interfaces as it confuses first time users.
(thread-for-evaluation): Suppress unused var warnings.

* contrib/swank-asdf.lisp: Avoid unreachable code for version check.
(unique-string-list): Avoid unreachable code warnings.

* contrib/swank-fuzzy.lisp (*all-chunks*): Defvar it and declaim the type
to avoid type uncertainty warnings.

* contrib/swank-package-fu.lisp (export-structure): Suppress warning about
unknown function list-structure-symbols with #+.

(cherry picked from SLIME commit
98e1a8c2)

Conflicts:
	ChangeLog
	contrib/ChangeLog
	contrib/swank-presentations.lisp
	lib/lisp/swank.lisp

* swank-backend.lisp (utf8-encode): Avoid unreachable code
warnings.
(%utf8-encode): New helper.
* swank-sbcl.lisp (sbcl-wrap): Add ignore declaration.

(cherry picked from SLIME commit
8eec94d1)

Conflicts:
	ChangeLog

While CLHS seems to guarantee PATHNAME-HOST to return a string, this is
not always the case in practice (e.g. SBCL returns a
SB-IMPL:LOGICAL-HOST instance).

* swank-fancy-inspector.lisp (emacs-inspect logical-pathname): wrap the
  return value of PATHNAME-HOST in a (:value ...) in case it is not a
  string

(cherry picked from SLIME commit
a27493d1)

Conflicts:
	contrib/ChangeLog

(cherry picked from SLIME commit
5c6e36bd)

* swank-kawa.scm (connection-info): Return :encoding options
to make slime-repl work.
(listener): Set current-output-port.

Also add a version check at the beginning and update the
compilation instructions.

(cherry picked from SLIME commit
ef96edee)

Conflicts:
	contrib/ChangeLog
	contrib/swank-kawa.scm