Run the tests on latest nautilus with the tag ceph/ceph:v14 so we
are constantly testing on the latest release.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

Remove crashcollector pod automatically when the node is deleted.

Ensure go.sum is updated with every PR

Every developer should commit all the files that need to be changed
in a given set of changes. The go.sum file was not being generated
as expected since the update to go modules. Since the Jenkinsfile
was running make mod.check, the build was ending up with a modified
file, which caused a dirty tag on the build. Now it is expected
that each PR will merge with the corresponding go.sum changes.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

The CrashCollector pod remains in pending state indefinitely after
running on a k8s node that was deleted. The code now deletes the
deployment after the node is deleted.
Signed-off-by: rohan47 <rohgupta@redhat.com>

Enable mergify for backport commits to release-1.3

incoming!
Signed-off-by: Sébastien Han <seb@redhat.com>

This flag is gone since we move to go modules.
Signed-off-by: Sébastien Han <seb@redhat.com>

k8sutil: mitigate UpdateDeploymentAndWait condition to help controllers

If a deployment stays in pending we should give early by looking at
ProgressDeadlineExceeded, this will reduce the time to wait from 20 min
to 10 min because ProgressDeadlineExceeded default is 600 seconds.

Prior to this patch we would wait 20min since we take
currentDeployment.Spec.ProgressDeadlineSeconds which is typically 600
then retry every 2 seconds, which makes it 20min total.

Closes: https://github.com/rook/rook/issues/5090

Signed-off-by: Sébastien Han <seb@redhat.com>

Let's just read the given value from the spec.
Signed-off-by: Sébastien Han <seb@redhat.com>

The owner ref is set right after the deployment is created one level on
top.
Signed-off-by: Sébastien Han <seb@redhat.com>

Simplify internal pool implementation by removing unnecessary model types

The pools had some legacy structs that translated between the
ceph.v1 types used by the CRDs and the internal implementation
of the pools. This simplifies the pool implementation by removing
the intermediate model and leaving us only with the ceph v1
pool types and no unnecessary translation.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

Misc controller runtime fixes

They are cases where we let the exponential backoff retry and some where
we force our own retry. Let's properly log this information.
Signed-off-by: Sébastien Han <seb@redhat.com>

Let's not wait for the CephCluster to be done reconciling but instead
check for the Ceph cluster status, if it's closed to "ok" then we
proceed so HEALTH_OK and HEALTH_WARN are accepted.
Signed-off-by: Sébastien Han <seb@redhat.com>

ceph: some minor cleanups

Even if there is no CephCluster we still want to retry every 10sec as
one will likely show up soon.
Signed-off-by: Sébastien Han <seb@redhat.com>

With the recent exex update we missed this one.
Signed-off-by: Sébastien Han <seb@redhat.com>

Let's not apply the exponential backoff when waiting for the cluster to
be ready, let's only apply it when there is no cluster.

Closes: https://github.com/rook/rook/issues/5059

Signed-off-by: Sébastien Han <seb@redhat.com>

With 1.1.1, the object matcher seems not to preserve annotation's order,
this is tracked here: https://github.com/banzaicloud/k8s-objectmatcher/issues/24

1.1.0 does not have that issue, so let's go back with 1.1.0.

Closes: https://github.com/rook/rook/issues/5047

Signed-off-by: Sébastien Han <seb@redhat.com>

Let's use 0.5.1
Signed-off-by: Sébastien Han <seb@redhat.com>

The path of sgdisk depends on the systems.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

"comment" here should mean the comments of `pg_autoscaler`
in cluster/examples/kubernetes/ceph/cluster.yaml. However, it's
ambiguous. It's straightforward to use "add".
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Allow creation of object store with pre-existing pools

Ceph: fix updates for servicemonitor

with older implementation, servicemonitor was not getting
updated due to missing resource version. This fix adds
resource version to the servicemonitor definition and
ensures that the object is properly created or
updated.
Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>

The pools may already be created by the mgr module. If the pool specs
are not specified in the object CR, skip pool creation for the
object store. The pools are required to exist and the reconcile
will fail until they do exist.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

ceph: set pgnum of block pools to the default value

Rook should always set the pgnum of the new block pool
to the default value("0"). Current implementation accidentally
works fine because newPool.Number is always 0 here.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

ceph: avoid duplication of mon anti-affinity

The default pod anti-affinity for the mons that rook adds
automatically intended to be appended to any anti-affinity that
is specified in the cluster CR.

There is a bug in the ApplyToPodSpec() method that has long existed.
The issue is that when antiaffinity is appended, it will append not only
to the pod spec, but will modify the original placement spec. Thus, each
mon that is started will have one more antiaffinity clause than the previous mon.

This condition is rarely hit or noticed because it commonly is only hit
in the canary pods. Since these pods are immediately deleted,
there are no side effects of the duplicate affinity clauses. The place
where it becomes an issue is when the mons are backed by a PVC. In this case,
the mons do not have node affinity and will hit the code path that appends
to the antiaffinity and thus modifies the original antiaffinity.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

remove unnecessary namespace fields

ceph: convert NFS controller to the controller-runtime

This is critical to get this information so that the label can be set
properly and also the configuration done appropriately.
Signed-off-by: Sébastien Han <seb@redhat.com>

The CRD watcher has been replaced by the new controller-runtime
framework.
This brings robustness in our operator, meaning that any resources that
are modified will be reconciled into the desired state.

Closes: https://github.com/rook/rook/issues/4941

Signed-off-by: Sébastien Han <seb@redhat.com>

We can now execute commands and pass env variables to the executor.
Signed-off-by: Sébastien Han <seb@redhat.com>

ceph: convert Filesystem controller to the controller-runtime

The CRD watcher has been replaced by the new controller-runtime
framework.
This brings robustness in our operator, meaning that any resources that
are modified will be reconciled into the desired state.

Closes: https://github.com/rook/rook/issues/4940

Signed-off-by: Sébastien Han <seb@redhat.com>