remove unnecessary namespace fields

ceph: convert NFS controller to the controller-runtime

This is critical to get this information so that the label can be set
properly and also the configuration done appropriately.
Signed-off-by: Sébastien Han <seb@redhat.com>

The CRD watcher has been replaced by the new controller-runtime
framework.
This brings robustness in our operator, meaning that any resources that
are modified will be reconciled into the desired state.

Closes: https://github.com/rook/rook/issues/4941

Signed-off-by: Sébastien Han <seb@redhat.com>

We can now execute commands and pass env variables to the executor.
Signed-off-by: Sébastien Han <seb@redhat.com>

ceph: convert Filesystem controller to the controller-runtime

The CRD watcher has been replaced by the new controller-runtime
framework.
This brings robustness in our operator, meaning that any resources that
are modified will be reconciled into the desired state.

Closes: https://github.com/rook/rook/issues/4940

Signed-off-by: Sébastien Han <seb@redhat.com>

ceph: mention helm upgrade path for csi driver

Update documentation to mention helm chart upgrade path for csi driver.

This prevents the user from manually applying the RBAC roles when the helm chart does it for him also notifies him where to set the images for CSI in the helm chart.
Signed-off-by: Paul <paulcatinean@gmail.com>

Logging and exec package cleanup

ceph: child controller-runtime stop watching for deployment

ceph: Make error unique when OSD on PVC fails to initialize

The bump from 0.2 to 0.4 controller-runtime versions which happened
during the use of Go Modules (bumping Go version to 1.13) introduced an
issue where the deployment annotations keep getting changed during
watch update event.
The easy fix is to stop watching Deployment objects for now.
Signed-off-by: Sébastien Han <seb@redhat.com>

Document monitoring namespace for OpenShift

All processes created with the exec package will now only have debug logging
for the commands and their output. The osd prepare job relies heavily
on many of these commands so we can enable debug logging for the entire
job.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

The helpers for executing a process have long required an actionName
param which is not being used. Now we remove the old param
while also cleaning up various other usages of the exec
package.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

The methods and arguments to the exec methods are not all used anymore.
This cleans up the methods to only what is necessary to improve
the readability and maintainability.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

The ceph commands are now only written to the log in debug mode.
For commands that change the system state we now ensure that
a useful log entry is written. If all the details of the ceph
commands are needed, debug logging should still be enabled.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

Long ago the ipv4 flags were renamed to public-ip and private-ip
so we can go ahead and remove the obsolete flags.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

Rook no longer relies on its own process management, now we can rely
completely on Kubernetes to manage the pod lifecycle. The code
to check for running processes and replacement them hasn't been
used for a long while.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

To make debugging easier, make sure each error path has
a unique message.
Signed-off-by: Kristoffer Grönlund <kgronlund@suse.com>

Design for ceph cluster clean up

OpenShift requires the monitoring to be bound to the openshift-monitoring
namespace instead of the rook default
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

There are many namespace fields in ClusterRole{,Binding}. However,
ClusterRole{,Binding} are not namespaced. So we can remove these.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

ceph: allow size option on pacific only

LVM infos for RancherOS added to Ceph docs

ceph: update pool.yaml with more options

- RancherOS does not activate logical volumes during boot by default
- This breaks the Ceph OSD recovery, because the LV will not be found
- This Ceph docs update describes the needed RancherOS change

Closes: https://github.com/rook/rook/issues/5027

Signed-off-by: Birk Bohne <birk@batchworks.de>

Expose:

* crushRoot
* deviceClass

To the example pool.yaml for awareness.
Signed-off-by: Sébastien Han <seb@redhat.com>

Ceph: ObjectStore replica size will not change

This flag only exists in Pacific, not Octopus.
Signed-off-by: Sébastien Han <seb@redhat.com>

Design docs cleanup

ceph: convert the Ceph ObjectStore controller to the controller-runtime

The pool cleanup only needs to happen for an individual pool.
No need to query the block images in all pools. One of the rgw
pools is periodically causing a hang when it is queried,
but there is no need to query for it when we are cleaning
up the pool tests.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

Activate DEBUG logging for the integration tests.
Signed-off-by: Sébastien Han <seb@redhat.com>

Let's upgrade from 1.1.9 to 1.2.6
Signed-off-by: Sébastien Han <seb@redhat.com>

Purge the object store properly, otherwise the cephobjectstore CRD won't
be deleted since a finalizer is in place for the CR.
Signed-off-by: Sébastien Han <seb@redhat.com>

The CRD watcher has been replaced by the new controller-runtime
framework.
This brings robustness in our operator, meaning that any resources that
are modified will be reconciled into the desired state.

Closes: https://github.com/rook/rook/issues/4937

Signed-off-by: Sébastien Han <seb@redhat.com>

Let's return the original error instead and just log the status change
error.
Signed-off-by: Sébastien Han <seb@redhat.com>