ceph: fix nfs daemons not updating

docs: revise Ceph upgrade docs for v1.5 release

Update docs and manifests as needed for v1.5 release.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>

The NFS reconciler was not updating NFS daemons that already existed.
The controller would fail to update daemons if the number of active
daemons did not increase or decrease.

Make sure existing NFS daemons are updated to new versions with all
scale up and scale down events.

Resolves #6611
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>

ceph: allow pod labels to be added to CSI components

ceph: Add 'ganesha-' to nfs-ganesha config object name

Since ceph octopus version, the expected nfs-ganesha config object name by
mgr/volumes/nfs[1] plugin is "conf-nfs.ganesha-<clustername>". For older
versions the name is "conf-<clustername>.<nodeid>".

[1] https://github.com/ceph/ceph/blob/master/src/pybind/mgr/volumes/fs/nfs.py#L648-L655

Signed-off-by: Varsha Rao <varao@redhat.com>

This adds the functionality to add custom pod labels to the CSI
components through the operator configuration way of env vars or config
map.

Resolves #6593
Signed-off-by: Alexander Trost <galexrt@googlemail.com>

docs: link to master branch for ceph-csi-snapshot

ceph: associate newly created pools to existing filesystem

ceph: fill in rgw deployment version

ceph: Update helm version to 3.4

When new pools are added to an already existing filesystem, we would
create them but not actually associate them to the filesystem. Ensure
that we do this.

Also, while we're here, we refactor the CreateFilesystem test: before,
we were not properly testing creating the filesystem from scratch
because we would return valid JSON for *every* ceph command. Change this
by making the first run return an error so that we get some better
coverage.

After this, we also add a check for the correctness of adding new pools
to the CreateFilesystem unittest.

Fixes #5876
Signed-off-by: Lalit Maganti <lalitm@google.com>

The RGW deployment's ceph-version label should now display the same
version as the image it is using.

It previously displayed an empty version: 0.0.0-0.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>

This updates the chart to make use of helm3 which has been released
for some time, and also permits CRDs to be installed pror to other objects
allowing the chart to be deployed at the same time as CRs for rook objects.
Co-authored-by: Pete Birley <pete@port.direct>
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

The CRDs need to be installed and updated separately from the
rest of the manifests. Helm charts also do not have a way to update
CRDs, therefore, any updates to the CRD schema must be done separately
from the helm chart. Now the CRDs are created in a new crd.yaml that must
be created along with common.yaml and before creating the operator.

The helm chart still contains the CRDs for initial creation, though
the helm chart will never update or remove them.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

ceph: upgrade test Rook only from v1.4 to master

ceph: change nfs-ganesha log level

this commit allows changing the default
log level from nfs.yaml file by adding
new command.
Signed-off-by: subhamkrai <srai@redhat.com>

fix: issue#6460 remove helm2 section, upgrade helm3

docs: clarify the meaning of cleanup policy of ceph cluster crd

The description of cleanupPolicy is a bit ambiguous. First, we should clarify
that both skipping orchestration and data cleanup will happen iff
"yes-really-destroy-data" is set to `confirmation`. Second, We should also
describe wiping devices will happen even if user don't specify `sanitizeDisks`
explicitly.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Since Rook no longer supports legacy filestore devices, there is
no need to keep testing upgrades from v1.2 all the way to master.
We can now just test v1.4 to master.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>

ceph: Disable the discovery daemon by default

Due to upstream code motion, the current link to the upstream
ceph-csi-snapshot documentation no longer points to the correct
location of their CRDs. Fix this by just using the master branch.
Signed-off-by: Mike Latimer <mlatimer@suse.com>

The discovery daemon is not needed in most scenarios, therefore we disable it
by default. More and more clusters are moving to the cluster-on-pvc scenario
which certainly does not need the local discovery. Even where clusters are not
running on PVCs, the discovery is not needed since the device discovery is again
performed in the osd prepare job.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

Merge pull request #6483 from cybozu-go/ceph-make-the-placement-of-admission-controller-configurable

ceph: make the placement of admission controller configurable

If users want to restrict the nodes where Ceph daemons should exist,
it's better to make the placement of admission controller configurable
as other daemons.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

docs: better Ceph toolbox kubectl commands

Signed-off-by: Richard Patel <me@terorie.dev>

Integration test fixes for release branch to preserve in master

docs: precise three nodes

The csi tests require 1.14 or newer to run
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>

The nullable attribute was causing the integration tests to fail
on 1.13 and earlier where it is not supported in the schema.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit cc8f406c)

NFS tests are not supported on older than K8s 1.14.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 4adc54e6)

ci: .github/workflows: add codespell pipeline

When following the quick start, it may not work, because the user don't know that he need three nodes. And three nodes may also not be correct, because the control plane is also a node. So we should precise what the user need to run his cluster correctly.

Closes: https://github.com/rook/rook/issues/6540

Signed-off-by: Gerhard Seidel <gseidel.message@googlemail.com>

ceph: Stretch cluster configuration

bot: update mergify to release 1.5 branch

ceph: add privileged securityContext to cephfs deployment