This project is mirrored from https://gitee.com/wangmingco/rook.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 01 Nov, 2018 11 commits
  2. 30 Oct, 2018 1 commit
  3. 29 Oct, 2018 4 commits
  4. 26 Oct, 2018 1 commit
  5. 18 Oct, 2018 4 commits
  6. 17 Oct, 2018 7 commits
  7. 16 Oct, 2018 2 commits
  8. 15 Oct, 2018 1 commit
    • Angus Lees's avatar
      Don't misinterpret command output as string format · 9c95ed5f
      Angus Lees authored
      
      Previous code tried to interpret the string output as a `fmt.Sprintf`
      string formatter, mangling `%` into `%!(MISSING)`, etc.
      
      Thanks to go, I don't belive these are exploitable (unlike the similar
      error in C).
      
      Since this seemed to be a common error in the codebase, I did a quick
      audit by visually inspecting the results of `git grep 'f([^"]'`.  I
      don't have a good suggestion for automated tests to prevent this in
      future :(
      
      Example error (look for `(MISSING)`):
      ```
      E0927 05:31:07.618429   11227 driver-call.go:237] Failed to unmarshal output for command: unmount, output: "2018-09-27 05:31:07.191711 I | exec: Running command: df --type ceph /var/lib/kubelet/pods/95461479-c216-11e8-bcf0-02030782ac80/volumes/ceph.rook.io~rook/oe-scratch\n2018-09-27 05:46:43.808596 I | Filesystem                                                 1K-blocks     Used Available Use%!M(MISSING)ounted on\n2018-09-27 05:46:43.808659 I | 10.107.25.147:6790,10.109.173.79:6790,10.104.85.255:6790:/ 151678976 49410048 102268928  33%!/(MISSING)var/lib/kubelet/pods/95461479-c216-11e8-bcf0-02030782ac80/volumes/ceph.rook.io~rook/oe-scratch\n{\"status\":\"Success\"}\n", error: invalid character '-' after top-level value
      ```
      Signed-off-by: default avatarAngus Lees <gus@inodes.org>
      9c95ed5f
  9. 13 Oct, 2018 1 commit
  10. 12 Oct, 2018 2 commits
  11. 11 Oct, 2018 3 commits
  12. 10 Oct, 2018 3 commits