This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 09 Sep, 2021 3 commits
-
-
Hannah Troisi authored
Test Plan: n/a Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9720 GitOrigin-RevId: 855b3c73054039313bef9174f57df39310501e6a
-
Omid Azizi authored
Summary: More consistent naming across protocols Test Plan: Existing tests Reviewers: #stirling, jps Reviewed By: #stirling, jps Differential Revision: https://phab.corp.pixielabs.ai/D9722 GitOrigin-RevId: 7375108c0e53a07298307d34bdc920014d2bcac0
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9708 GitOrigin-RevId: c198bbeebf465bd94affdb39ba7831b2e2cb4c37
-
- 08 Sep, 2021 6 commits
-
-
Zain Asgar authored
Summary: This is easier to manage than certs we have to manually update. Test Plan: Deployed Reviewers: michelle, vihang Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9717 GitOrigin-RevId: b8ffcf217d646910621486bbbc1803e8ddf982fa
-
James Bartlett authored
Summary: Adds a test that trys to run the planner on all of the scripts in `src/pxl_scripts`. It currently skips any scripts with mutations in them. Test Plan: New test passes Reviewers: philkuz, vihang, oazizi Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9689 GitOrigin-RevId: 2a759e7131cba9d8c329255b6a3cc85cb95a509e
-
Ryan Cheng authored
Summary: It is often useful to have a state in ParseFrame and FindFrameBoundary in many protocols, such as Kafka, to make these functions more robust. For example, with a state, we could use information from request packets when inferring the boundary of response packets (correlation_id in Kafka, and seq_number in MySQL). This is one of the rearchitecture diffs to make the parsing and stitching pipeline more robust, and more standardized. Also updates Kafka FindFrameBoundary and ParseFrame. Test Plan: new and existing tests. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: yzhao Differential Revision: https://phab.corp.pixielabs.ai/D9673 GitOrigin-RevId: 2f9b658f9bfb09b214dfacd53814cc3973253fa8
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9577 GitOrigin-RevId: cd820aa64d84fe224c1435ab5bb4aa344575ca5c
-
Vihang Mehta authored
Summary: `rbac.authorization.k8s.io/v1` has been availabe since k8s v1.8 `rbac.authorization.k8s.io/v1beta1` has been removed in k8s v1.22 https://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122 Test Plan: Everything still works on k8s clusters that are older than 1.22 and are running 1.22 Reviewers: philkuz, michelle Reviewed By: philkuz JIRA Issues: PP-2991 Differential Revision: https://phab.corp.pixielabs.ai/D9703 GitOrigin-RevId: 871c1d1c8a661c6f8aa4bbe1e1578f3f48d1728d
-
Nick Lanam authored
Summary: TSIA. Also fixes some weirdness where you need to click twice. Test Plan: Run `px/cluster`. Click the tiny p50 / p90 / p99 bars in the quantile columns. The title and cells in that column should update upon doing so, without extra clicks and without expanding the row either. Clicking outside the quantiles (even the number to their right) should still expand/collapse the row. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1131 Differential Revision: https://phab.corp.pixielabs.ai/D9704 GitOrigin-RevId: f40a6781586a23c037010e0959a7b072a320fcdc
-
- 07 Sep, 2021 12 commits
-
-
Vihang Mehta authored
Summary: Minor cleanup after some refactoring Test Plan: bazel build Reviewers: philkuz, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9700 GitOrigin-RevId: 0ef5e5658b8b09f7c9e4ef6e911b95553558e595
-
Vihang Mehta authored
Summary: D9695 added a dep that was moved in D9693 Test Plan: bazel build and test all Reviewers: michelle, philkuz Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9699 GitOrigin-RevId: f8f1415b778254b8e730f069e7a435365d592d97
-
Vihang Mehta authored
Summary: Using a generator means that we get access to more verbs, fakes for testing and it is easier to keep this up to date. Test Plan: Existing tests, skaffold operator Reviewers: michelle, philkuz Reviewed By: michelle, philkuz Differential Revision: https://phab.corp.pixielabs.ai/D9692 GitOrigin-RevId: 911736599f2ae9ecbfa21be19b0b3884b8528384
-
Vihang Mehta authored
Summary: Using `client-gen` requires apis to be in `<groupname>/<versionname>` This is the folder structure used by most CRDs (I looked at etcd, jaeger, nats) and so let's follow the same. Test Plan: N/A. Moving files around. Reviewers: michelle, philkuz Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9693 GitOrigin-RevId: b693de36f511936ca6569509cb770da675470d76
-
Vihang Mehta authored
Summary: Switches over from poll to push just like the node watcher. Note that status aggregation currently causes a fetch on the vizier CRD. There's room for improvment in the design there. Test Plan: Existing tests + skaffold vizier Reviewers: michelle, philkuz Reviewed By: philkuz Differential Revision: https://phab.corp.pixielabs.ai/D9695 GitOrigin-RevId: 046018a63a5a2011c2d9459667e138a94a56fc72
-
Omid Azizi authored
Summary: Instead of tracing open/creat and keeping all open files in a map, we can trace sock_sendmsg and sock_recvmsg to figure out whether the traffic is going to a socket. For the moment, these new probes work in conjunction with the existing probes like read/write/send/recv, because it is easier to get the FD from those high-level functions. Test Plan: Test case added Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Differential Revision: https://phab.corp.pixielabs.ai/D9629 GitOrigin-RevId: 74c66d9b73a3c4ca7fdc01d70738c3735eb02da0
-
Omid Azizi authored
Summary: Maintain consistency with TCPSocket by using append instead of assign. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D9669 GitOrigin-RevId: 3cdbf57828adb6f30c951d540c401a610620d550
-
Nick Lanam authored
Summary: D9651 made use eslint to enforce memoization. This file wasn't updated to comply yet, and is about to get other changes, so updating the lint stuff first. Test Plan: Change column selections in a table, change sorting, resize rows, select P50/90/99 in a quantile column. They should do the same thing as in production (there is a known bug with P50/90/99 is tracked in PC-1131). Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1161 Differential Revision: https://phab.corp.pixielabs.ai/D9698 GitOrigin-RevId: 49e2d21e298d1b3438cff9db96fcc61bdfdd1732
-
Vihang Mehta authored
Summary: Remove default condition from for-select to reduce CPU usage. Add more logging for some failure conditions. Test Plan: skaffold Reviewers: michelle, philkuz Reviewed By: michelle, philkuz Differential Revision: https://phab.corp.pixielabs.ai/D9697 GitOrigin-RevId: 271a2cca415ab2461329d421a478b8e103ec5e2f
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9675 GitOrigin-RevId: 03e2252e3344b5cabee0231576651039f3b98408
-
Michelle Nguyen authored
Summary: 10 minutes is probably too short for the authconnector to complete all necessary logins/signup flows/etc. 30 minutes is safer. Test Plan: n/a Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9696 GitOrigin-RevId: c6f925591a766e70bf74305431c5628c60de2f20
-
Michelle Nguyen authored
Summary: We now have some external consumers of the UserService, so we need to make sure to expose Test Plan: n/a Reviewers: vihang, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9694 GitOrigin-RevId: 852189a2030a12c9ca01946c02dc7ef84a853f99
-
- 04 Sep, 2021 1 commit
-
-
Vihang Mehta authored
Summary: Our stan consumers are slow. That combined with a large MaxInFlight and a large AckWait causes memory to grow really fast. See https://github.com/nats-io/stan.go/issues/314 We had a MaxInFlight in D8658 but it got removed as part of D9448. Test Plan: N/A Reviewers: philkuz, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9690 GitOrigin-RevId: 261448b21ab94d42c4213a59ed36101e67bfde37
-
- 03 Sep, 2021 15 commits
-
-
Vihang Mehta authored
Summary: Mostly cleaning up interfaces and making it easier to parse. Test Plan: Existing test Reviewers: michelle, philkuz Reviewed By: michelle, philkuz Differential Revision: https://phab.corp.pixielabs.ai/D9681 GitOrigin-RevId: de1f11838845b5ce8612655a8b030a8c9bb1d4b2
-
Vihang Mehta authored
Summary: TSIA Test Plan: Ran it Reviewers: philkuz Reviewed By: philkuz Differential Revision: https://phab.corp.pixielabs.ai/D9686 GitOrigin-RevId: 63919faef659606824d53403c523f2353bf7e5de
-
Nick Lanam authored
Summary: Adds rules to enforce the use of pure components (`React.memo`, `PureComponent`) and memoization (`React.useMemo`, `React.useCallback`) to improve performance and prevent useless renders. See [this document](https://www.notion.so/pixielabs/UI-Performance-Tooling-1960f7d9c7ce440aaa5a0442eeba5815) for details on rationale. Introducing this rule also introduces quite a few warnings in high-touch files. It also triggers a bug in the new plugin that has to be addressed before turning the plugin on. See D9661 for that fix. Other diffs for high-touch files will also submit before this one, so head off annoyingly frequent warnings before they happen. Of note, most of the new warnings appear to be valid, but low-value to fix in terms of performance (the big ones were already fixed without this rule's help). The rules are being added for the benefit of future changes: defaulting to memoization helps us avoid writing components that can introduce new per...
-
Nick Lanam authored
Summary: D9651 will use eslint to enforce memoization. Frequently-changed files are being updated to comply with these rules in advance, to limit annoyances. Test Plan: Play around with the cluster details view in the admin area. As with every diff for this issue, check that all actions that _should_ update affected components still do. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1161 Differential Revision: https://phab.corp.pixielabs.ai/D9684 GitOrigin-RevId: e7372f863cf89c6196e22b940224014e4facf639
-
Nick Lanam authored
Summary: D9651 will use eslint to enforce memoization. Frequently-changed files are being updated to comply with these rules in advance, to limit annoyances. Test Plan: Logging out/in and changing clusters should behave as before. As with every diff for this issue, check that all actions that _should_ update affected components still do. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1161 Differential Revision: https://phab.corp.pixielabs.ai/D9682 GitOrigin-RevId: 3a8d9aa980b49d336df039b33e9bd9753ff043d5
-
Nick Lanam authored
Summary: D9651 will use eslint to enforce memoization. Frequently-changed files are being updated to comply with these rules in advance, to limit annoyances. Test Plan: Run a few scripts. As with every diff for this issue, check that all actions that _should_ update affected components still do. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1161 Differential Revision: https://phab.corp.pixielabs.ai/D9683 GitOrigin-RevId: b092c507495126cc2e31c1e36942c071c4bfc637
-
Nick Lanam authored
Summary: D9651 will use eslint to enforce memoization. Frequently-changed files are being updated to comply with these rules in advance, to limit annoyances. Test Plan: Play around with the sidebar in live views. As with every diff for this issue, check that all actions that _should_ update affected components still do. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1161 Differential Revision: https://phab.corp.pixielabs.ai/D9685 GitOrigin-RevId: 522b10162a9712a9b8aee3abe77f891bd1bdc2fd
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9671 GitOrigin-RevId: cd4070b7680c7cc02771eec9a5fef322295a46fd
-
Michelle Nguyen authored
Summary: we were noticing instances where there were multiple copies of service tokens. after some investigation, these are basically created everytime the operator tries to run an update. this is because the token is created everytime the service account is reapplied. updated the deploy logic so that if it is doing an update, the service accoutns arent reapplied. this didnt use to happen in our old update scheme because we used to fully delete all resources and recreate them. Test Plan: skaffolded operator, triggered an update and verify that the token was not created Reviewers: vihang, philkuz, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9679 GitOrigin-RevId: 87f296933f093596bb64e8d8f7e75bf4d3549a30
-
Vihang Mehta authored
Summary: Buildifier rewrote this Test Plan: n/a Reviewers: michelle, zasgar Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9680 GitOrigin-RevId: ee797d04cadd288dace10b549c6ee8dae4a94642
-
Michelle Nguyen authored
Summary: we previously allowed the MUI theme to be specified in a postmessage. however, that causes a brief flicker between when the page first renders and then applies the customTheme from the postmessage. instead, we can allow users to specify the custom theme in the URL similar with how we allow them to set the "theme" from "light"/"dark". alternatively, another solution was to add logic so that we wait until the postMessage is received until we render the page. however, the series of postmessage calls is already complex enough and becomes harder to test. so lets keep with the simple solution for now. the largest downside is the max length of the URL, but we shouldnt be close to hitting that. Test Plan: yarn dev Reviewers: vihang, nlanam, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9677 GitOrigin-RevId: a4ef96de99ac1de3cdf69af0ba6e24e6cc70d479
-
Michelle Nguyen authored
Summary: add configs for launching testing.withpixie.dev Test Plan: deployed testing cloud Reviewers: zasgar, vihang Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D9672 GitOrigin-RevId: d05681351b67c02dec3dc0bfe84b7851e3f87bc5
-
Omid Azizi authored
Summary: Resolve issue that was reported in https://github.com/pixie-io/pixie/issues/309. recvmmsg and sendmmsg are rare, so likely wasn't hurting too much, but conn_stats would have been wrong in such cases. And the DCHECK would fire, of course. Test Plan: Added a test that uses recvmmsg/sendmmsg with TCP. Reviewers: #stirling, jps Reviewed By: #stirling, jps Differential Revision: https://phab.corp.pixielabs.ai/D9663 GitOrigin-RevId: f7bd20498427dd5dc74a0dc53626a8b39303eb92
-
Vihang Mehta authored
Summary: TSIA Test Plan: skaffold Reviewers: michelle, philkuz Reviewed By: michelle, philkuz Differential Revision: https://phab.corp.pixielabs.ai/D9674 GitOrigin-RevId: 23c2ab88c59b206f1bd4f6d0ab8572fe2bde3226
-
Phillip Kuznetsov authored
Summary: Events cause unnecessary complexity and we can just get the same data from the actual pod conditions. Might as well remove this extra load from the k8s api and rely on what's inside PodConditions. Test Plan: tested on skaffold with memory scheduling, taint scheduling, and updated unit tests. Reviewers: vihang, michelle Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9670 GitOrigin-RevId: 0d822cd2e8e04b1e61bcb17bb8d5a0019dda3562
-
- 02 Sep, 2021 3 commits
-
-
Zain Asgar authored
Summary: TSIA Test Plan: existing Reviewers: michelle, vihang, #third_party_approvers Reviewed By: michelle, vihang, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D9655 GitOrigin-RevId: bfbbd3d5690b53193ce564aa03b0e1f61ef19906
-
Michelle Nguyen authored
Summary: we are linking to a new place now in our footer/timeArgDetail Test Plan: yarn dev Reviewers: vihang, nlanam, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9668 GitOrigin-RevId: 4623eda957aec51fbc95ce03e583f625dfde8ec2
-
Nick Lanam authored
Summary: D9651 will use eslint to enforce memoization. Frequently-changed files are being updated to comply with these rules in advance, to limit annoyances. Test Plan: Run scripts like `px/pod` that have charts. Interact with them. Re-run with the same params; different params. As with every diff for this issue, check that all actions that _should_ update affected components still do. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1161 Differential Revision: https://phab.corp.pixielabs.ai/D9664 GitOrigin-RevId: e5dde9d66194bb571770a54f8a5526f1da0860ba
-