This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 19 Aug, 2021 2 commits
-
-
Michelle Nguyen authored
Summary: this was left in after verifying some changes. we should remove it because it can be spammy Test Plan: n/a Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9504 GitOrigin-RevId: a66a1f0fcd3c07b8f36c1b25d56f534aec561c0f
-
James Bartlett authored
Summary: I overlooked a weird case when I was refactoring the qb. We return a nil error on planner errors because of the way the UI handles mutations. In the refactor, I overlooked the need to end query execution early when this nil error is propagated. Instead of doing this nil error on planner errors, the qb will now just return the error. I have a diff out to fix the UIs handling such that returning this error doesn't mess up the mutations modal. Test Plan: Added test that reveals the error michelle was seeing. Added test for mutations in query_executor_test. Mutations work properly when combined with the UI change diff. Reviewers: michelle, nserrino, vihang Reviewed By: nserrino JIRA Issues: PP-2946 Differential Revision: https://phab.corp.pixielabs.ai/D9479 GitOrigin-RevId: 0d44ae4cdb97bc0df482f0beb10d9f7e726fb3b7
-
- 18 Aug, 2021 15 commits
-
-
Michelle Nguyen authored
Summary: we forgot to include configmgr service in the configmap, so it was using the default plc namespace instead. Test Plan: deployed the configmap to staging, verify calls to configmgr wor Reviewers: nserrino, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9502 GitOrigin-RevId: 7afdbe75a5988c4279cc786b6a331dc2c7915c46
-
Omid Azizi authored
Summary: Convert time column to nanoseconds which is the standard approach. Also some lint. Test Plan: Manual Reviewers: #stirling, jps Reviewed By: #stirling, jps Differential Revision: https://phab.corp.pixielabs.ai/D9292 GitOrigin-RevId: 6ea690e4684c7c584ad2b50dba093ab6588c682b
-
Zain Asgar authored
Summary: This adds triggers to store prev heartbeat status. We will delete the other columns that add previous status after moving over to the new columns. Test Plan: N/A, tested postgres triggers. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1128 Differential Revision: https://phab.corp.pixielabs.ai/D9501 GitOrigin-RevId: ef2089feda346e7893ec127baf76665465cdf74a
-
Omid Azizi authored
Summary: Tweaks to logging behavior. Test Plan: None Reviewers: #stirling, rcheng Reviewed By: #stirling, rcheng Differential Revision: https://phab.corp.pixielabs.ai/D9493 GitOrigin-RevId: c4837a0cc42ff86788eec784e5ab60bb2e7df16a
-
Michelle Nguyen authored
Summary: We updated the name of the cluster role binding, which changed the name of the file that is generated from kustomize Test Plan: ran operator release candidate build Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9492 GitOrigin-RevId: a5eaca91ca10d6a162232f60a81926684be06495
-
Vihang Mehta authored
Summary: vzmgr now runs a bunch of sharded goroutines which try to read and write to the DB. Allow more connections to let all the goroutines parallelize. Test Plan: N/A Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D9491 GitOrigin-RevId: 584e3857241f1d0cfc85165835a4ddfc6cca1ca2
-
Yaxiong Zhao authored
Test Plan: Manual testing in scratch pad Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9484 GitOrigin-RevId: cc1bec05e19f6406e2fd9127e4fda94d6bf0c439
-
Yaxiong Zhao authored
Summary: This is used for testing pgsql tracing on k8s cluster Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9490 GitOrigin-RevId: 5caaf7bb4659173d0e62ca543522b7cec544a4d4
-
Omid Azizi authored
Summary: To be used for testing sendfile. Test Plan: Test added Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D9488 GitOrigin-RevId: 4e03ab622b8d2ed38b4e77888f3b3ae3c52129f4
-
Michelle Nguyen authored
Summary: the operator's monitor is responsible for: 1. watching the K8s API for tracking the latest pod statuses. we keep a version of this in memory since the # of vizier pods is small. the retry watcher code is mostly borrowed from the vizier metadata's retry watcher code. 2. periodically pinging the statusz endpoints of the vizier pods to determine the latest state. for now, this logic is very simple and we only look at whether the cloudConnector can run basic queries (this is the status quo). once the entire pipeline is more built out, we can make this even smarter. Test Plan: skaffold deployed vizier and operator. played around with cloudconn status to make sure the CRD status gets updated to reflect its new state. Reviewers: vihang, nserrino, zasgar Reviewed By: vihang JIRA Issues: PP-2875 Differential Revision: https://phab.corp.pixielabs.ai/D9466 GitOrigin-RevId: 8482820e17982959bb47615068bfdd98a6ddbb0b
-
Michelle Nguyen authored
Summary: we will start pinging the statusz for individual pods, and we want those communications to be SSLed. to do so, we need to add the pod DNS resolution to our vizier certs. Test Plan: ensure that the pod DNS resolution does exist by `kubectl exec`ing into a bash pod and curling the pod URL Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9485 GitOrigin-RevId: fb13a9f469f2a02d09ceccf89c7076da21773ffa
-
Michelle Nguyen authored
Summary: at one point we had a "bootstrap" mode, to unify our deploy and update paths. however, we found that users actually preferred to see all of the YAMLs in deploy mode, so ended up removing bootstrap mode. this diff cleans up the instances of bootstrap. Test Plan: built an rc, deployed in operator/non-operator, and updated in operator/non-operator versions of pixie. Reviewers: vihang, zasgar, nserrino Reviewed By: vihang JIRA Issues: PP-2944 Differential Revision: https://phab.corp.pixielabs.ai/D9483 GitOrigin-RevId: ff8285eb20aa1db283f55769ece52dc3193f05c0
-
Natalie Serrino authored
Summary: We want to add sampled erroneous data plane pod state as well as previous status to the db. This diff adds the graphql endpoints and logic in the api and vzmgr services to propagate that information from the db. Test Plan: added unit Reviewers: michelle, philkuz, vihang, zasgar Reviewed By: philkuz JIRA Issues: PP-2931 Differential Revision: https://phab.corp.pixielabs.ai/D9481 GitOrigin-RevId: d30f047e0fbad3292392d35f35cc56044ec7f248
-
Ryan Cheng authored
Summary: Add Extact functions for fetch response. Test Plan: unit test Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9459 GitOrigin-RevId: 4afadbad55494513fc7d5ac0d72d34aab9d913b6
-
Michelle Nguyen authored
Summary: D9413 updated the Delete so that we automatically use the k8s API to fetch all deletable resources. this actually causes the Delete to result in an error (and thus a Fatal, which leaves the Vizier in a bad state) in the non-operator update job, because the update job doesnt actually have RBAC permissions to list all deleteable resources. it does, however, still delete all other resources that it does have access to. we should proceed with the update job even if this command errors. the reason that we didnt catch this earlier was because the operator does not do a similar delete, and the CLI which does do a similar delete has the RBAC permissions for doing so. Test Plan: build RC, run a deploy with an older CLI and then try to update. Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9482 GitOrigin-RevId: e1ce82fbbdcf6c068a408ddd7688c28d71243c4e
-
- 17 Aug, 2021 11 commits
-
-
Vihang Mehta authored
Summary: CLI proxy command was used before passthrough mode existed in Pixie. It's not needed anymore, since we can pick between direct mode and passthrough. Test Plan: N/A Reviewers: vihang, michelle Reviewed By: vihang, michelle Differential Revision: https://phab.corp.pixielabs.ai/D9477 GitOrigin-RevId: 1eb21f56f5aa0cd134a072ff19e02cfa831749fb
-
Nick Lanam authored
Summary: Was triggering a React error. Test Plan: Attempt to load a cluster or script when the cluster throws an error. The snackbar comes up, but there should no longer be an extra React-related console error when it does. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1109 Differential Revision: https://phab.corp.pixielabs.ai/D9480 GitOrigin-RevId: 8b93e07415dee9043a3b1cbee15321970edf3efb
-
Michelle Nguyen authored
Summary: in order to display the Vizier's status message in the UI, we must expose it through gql. this diff updates the grpc/gql endpoints for fetching clusterInfo to also include the statusMessage. Test Plan: unit tests Reviewers: nserrino, vihang, zasgar Reviewed By: vihang JIRA Issues: PP-2878 Differential Revision: https://phab.corp.pixielabs.ai/D9470 GitOrigin-RevId: f7e6878ead41a986257259190bcb62c0d89846ac
-
Michelle Nguyen authored
Summary: Viziers will now send a human-readable message containing the reason for why it is in its current state to Pixie cloud. Pixie cloud should store this in the db with the other status info, so that it can be retrieved by the UI/API/CLI. Test Plan: unit test Reviewers: nserrino, vihang, zasgar Reviewed By: vihang JIRA Issues: PP-2876 Differential Revision: https://phab.corp.pixielabs.ai/D9469 GitOrigin-RevId: 2d486fe7271095030b2887b84235b77733b657fd
-
Michelle Nguyen authored
Summary: this diff implements the statusz endpoint for the cloudconnector. it is able to detect whether or not it has failed to connect to cloud and whether it can run basic queries. we can add more reasons over time, after the basic pipeline is fleshed out Test Plan: ran skaffold and curled statusz with cloudconn in different states Reviewers: vihang, nserrino, zasgar Reviewed By: vihang JIRA Issues: PP-2875 Differential Revision: https://phab.corp.pixielabs.ai/D9465 GitOrigin-RevId: d7995b5039de73e7b5ce958a8098e7a35f9be32b
-
Michelle Nguyen authored
Summary: we are updating our pods to include a "statusz" endpoint which returns either "OK" if the pod is healthy, or a simple reason string for why the pod is in its current state. this will be used by the operator to determine the status of the vizier pods. Test Plan: used helpers to create statusz endpoint for cloudconn (followup diff) Reviewers: vihang, nserrino, zasgar Reviewed By: vihang JIRA Issues: PP-2875 Differential Revision: https://phab.corp.pixielabs.ai/D9464 GitOrigin-RevId: c71f16d6267693fa600d0453e8109f3145af5848
-
Nick Lanam authored
Summary: Two bugs were present. First, since the mutation modal is a child of the canvas, it wasn't showing if the canvas was suppressed. I had introduced a faulty condition for hiding the canvas. Second bug was that `ScriptContext` was using stale data in a `setResults` call, undoing previous `setResults` calls in so doing. Fixing both restores the modal. Test Plan: Run `px/tcp_drops` to deploy a tracepoint (you can inject `pxtrace.DeleteTracepoint` to the script right above `pxtrace.UpsertTracepoint` to make the script reset the tracepoints each run as well). Between runs (you may need to edit the script with a comment or something to force it to reload), you should now see the mutation modal once more. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1124 Differential Revision: https://phab.corp.pixielabs.ai/D9478 GitOrigin-RevId: 00b2c209193f9d86663d71b8f6ba8e0ae3d19306
-
Nick Lanam authored
Summary: This one will take multiple diffs and mix with PC-1116 work. This diff memoizes `LayoutContext` and `DataDrawerContext`, and makes `ResizableDrawer` into a function component. Test Plan: Run a script with React Dev Tools monitoring performance. The data drawer and layout contexts should not update as often now. There's still a ways to go with this. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1084, PC-1120 Differential Revision: https://phab.corp.pixielabs.ai/D9473 GitOrigin-RevId: 2befd227e74808856e9179f9a62ea7448ee96767
-
Nick Lanam authored
Summary: TSIA. Test Plan: Run `px/cluster`. Note the "Pods" table now correctly chooses the "Pod" column for sorting instead of trying to sort by the status gutter column. Reviewers: michelle, vihang Reviewed By: vihang Subscribers: nserrino JIRA Issues: PC-1122 Differential Revision: https://phab.corp.pixielabs.ai/D9475 GitOrigin-RevId: 8fdc4300b5ea1027ec4af03f89b94a98e87b34a9
-
Michelle Nguyen authored
Summary: we are logging too much info Test Plan: n/a Reviewers: zasgar, vihang, philkuz Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9472 GitOrigin-RevId: 8a9da3a6864c3d6601d6c52f0d34122f72346671
-
Zain Asgar authored
Summary: Multiple go routines in parallel were using up all the DB resources causing vzmgr to hang. Test Plan: existing, but we are adding some load tests. Reviewers: michelle, vihang, jamesbartlett Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9476 GitOrigin-RevId: 91c8b063c48525dc190010786e3ba2a3a1e8da27
-
- 16 Aug, 2021 10 commits
-
-
Nick Lanam authored
Summary: TSIA. Test Plan: Expand a row in script results. The `controls` column shouldn't show up there anymore. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1119 Differential Revision: https://phab.corp.pixielabs.ai/D9471 GitOrigin-RevId: 4e7618ef46401b5effa0b7adf822810648fe7f5b
-
James Bartlett authored
Summary: I hit a case where tsan errors were not reported because bes upload also failed so bazel retval was 38 instead of 3 expected on a tsan failure. Test Plan: N/A Reviewers: vihang, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9449 GitOrigin-RevId: 735ee7fa633c87cb27c59759e085e9094c4f1a9a
-
Nick Lanam authored
Summary: The default width of a column is computed as a fraction of the whole available space. Browsers try not to render thing between two pixels; Chrome was rounding up while Firefox was rounding down. This was making horizontal scroll bars (as the cells totalled a higher width than their container) appear in Chrome only. Test Plan: Run `px/cluster` in Chrome and in Firefox. No more horizontal scrollbars with a single pixel to scroll in Chrome. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1118 Differential Revision: https://phab.corp.pixielabs.ai/D9467 GitOrigin-RevId: 7495343f9d30ce32cd826b4a83a630a82a1f66f7
-
Vihang Mehta authored
Summary: Remove no folders that no longer exist and add new ones. Test Plan: N/A Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D9463 GitOrigin-RevId: 03d2112b86bcd5c24aba1b2dbf826ec3b3390a7c
-
Vihang Mehta authored
Summary: Implement encryption on the python api by using Authlib. Test Plan: run an example with encryption enabled. Printed to make sure that encrypted mode occurred. Reviewers: vihang, zasgar, michelle, #third_party_approvers Reviewed By: vihang, #third_party_approvers JIRA Issues: PC-1100 Differential Revision: https://phab.corp.pixielabs.ai/D9456 GitOrigin-RevId: d678b81b2f994ed9e618c232e6aa52a10056cded
-
Natalie Serrino authored
Summary: Depends on D9455. The px debug API is a different API than the cloud info for each cluster, so we have to add it in here separately. Test Plan: ran the CLI Reviewers: michelle, vihang, zasgar Reviewed By: zasgar JIRA Issues: PP-2902 Differential Revision: https://phab.corp.pixielabs.ai/D9458 GitOrigin-RevId: d2a96d2a6c80d6468b1b129bfee2a4d6172187d5
-
Natalie Serrino authored
Summary: We will now send K8s version, (max 10) unhealthy data plane pod statuses, and also include pod/container restart counts in the PodStatus in the Vizier heartbeat. This information will be picked up by cloud and written to the db for debugging purposes. Test Plan: edited existing proto_utils, ran Vizier. Reviewers: michelle, vihang, zasgar Reviewed By: zasgar JIRA Issues: PP-2904 Differential Revision: https://phab.corp.pixielabs.ai/D9455 GitOrigin-RevId: 808a399560e856b18743c21a217d1c7c88fdb409
-
Vihang Mehta authored
Summary: Depends on D9461. Upgrade `grpc-ecosystem/go-grpc-middleware` to drop dependence on `google.golang.org/grpc/examples` Cleanup/upgrade all other indirect deps. Test Plan: Existing build + tests Reviewers: zasgar, michelle, #third_party_approvers Reviewed By: zasgar, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D9462 GitOrigin-RevId: 3da7ad154aadedaa0d739631c00272b5ee29951c
-
Vihang Mehta authored
Summary: Delete the containerd indirect dep from `go.mod` and run `go mod tidy` `go mod download` to cause an upgrade. The other upgrades were a result of what containerd itself depends on. Addresses https://github.com/advisories/GHSA-36xw-fx78-c5r4 Test Plan: Existing build + tests work Reviewers: zasgar, michelle, #third_party_approvers Reviewed By: zasgar, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D9461 GitOrigin-RevId: 62338c908466ca79dcf7c3f70b24192e98839fd7
-
Zain Asgar authored
Summary: TSIA Test Plan: Jenkins Reviewers: michelle, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9447 GitOrigin-RevId: 1015807ad170a59ebb0fa3a3a7a5c2936606fde7
-
- 12 Aug, 2021 1 commit
-
-
Omid Azizi authored
Summary: Use 64-bit integers more consistently. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Differential Revision: https://phab.corp.pixielabs.ai/D9460 GitOrigin-RevId: 6d20d73fd04d0684245b6afb3a34a5070a6ccaa7
-
- 11 Aug, 2021 1 commit
-
-
Ryan Cheng authored
Summary: Adds fetch request Test Plan: unit test Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9432 GitOrigin-RevId: e6dc1499fc768c44adc9eea49672ad1651899487
-