This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 12 Jul, 2021 25 commits
-
-
Zain Asgar authored
Summary: Add CSP headers and allow embeded views to login. Test Plan: Tested on staging. Will update tests once CSRF mitigations are complete Reviewers: michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9120 GitOrigin-RevId: 2f6f544c38cb3f2b5d51d24d21681bd1a5addfca
-
Vihang Mehta authored
Summary: Add flag to disable analytics. Change env prefix to be `PX` by default. Support `PL` for backwards compatibility. Parse flags in `init` so that we have access to flags before `Execute` (this is necessary because `px.go` sets up the analytics client and enqueues events before `Execute` is called. Cleanup testing banner. Cleanup flag overrides. Test Plan: `bazel build` cli and run a variety of commands with console logging for sanity checks. Reviewers: zasgar, michelle Reviewed By: zasgar JIRA Issues: PP-2624 Differential Revision: https://phab.corp.pixielabs.ai/D9116 GitOrigin-RevId: f52ac14f47dc0c5014bf4d9478ca7784f817c23f
-
Vihang Mehta authored
Summary: This removes the need to call `viper.Set` and instead just names the flags to line up with their ENV var counterparts. Test Plan: bazel build and run a cli with the appropriate env vars and ensure that updates pick up the specified version. Reviewers: michelle, zasgar Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D9113 GitOrigin-RevId: c002b1e5a964005c1ff8ad018c233f4c12eb38cc
-
Natalie Serrino authored
Summary: tsia, we changed the schema but didn't update all of the old references Test Plan: existing tests Reviewers: oazizi, yzhao, vihang Reviewed By: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9099 GitOrigin-RevId: 33d2c624f81389a186ca3c4c4b489428c918224f
-
Michelle Nguyen authored
Summary: this diff adds the gql endpoint for getting and updating user attributes. Test Plan: unit test passes Reviewers: vihang Reviewed By: vihang JIRA Issues: PC-992 Differential Revision: https://phab.corp.pixielabs.ai/D9102 GitOrigin-RevId: 5b33cd2c41c03e9f77fa987785396ebc34eaa1cd
-
Michelle Nguyen authored
Summary: our convention is that graphql requests should be backed by an actual grpc service in cloudapi. this diff adds userAttributes to the cloudapi proto. next diff will add the gql schema for getting/setting userAttributes, which essentially just makes a call to the user cloudapi server (see how user settings currently works, etc). Test Plan: everything builds Reviewers: vihang Reviewed By: vihang JIRA Issues: PC-992 Differential Revision: https://phab.corp.pixielabs.ai/D9101 GitOrigin-RevId: a0202b45c31ad1a228bebee492ec6fd40b44c880
-
Michelle Nguyen authored
Summary: Previous diffs added the proto + db schema for the attributes table. This diff actually implements the Get/SetUserAttributes call in the profile service. Test Plan: unit tests Reviewers: vihang Reviewed By: vihang JIRA Issues: PC-992 Differential Revision: https://phab.corp.pixielabs.ai/D9097 GitOrigin-RevId: 93555dc4e1ace9e2d8d1c88a4144ec27861aefd2
-
Michelle Nguyen authored
Summary: There is a cluster causing staging to crash because it tries to access sp[1]. this check was incorrect Test Plan: n/a Reviewers: zasgar, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9109 GitOrigin-RevId: 482ec45905e4397797031faa0c02915ce27d6936
-
Vihang Mehta authored
Summary: Upgraded viper and cobra manually in `go.mod` other changes to `go.mod` came from `make go-setup`. Realized that etcd was out of alpha so upgraded that too. Test Plan: Ran existing unit tests. Reviewers: zasgar, michelle, #third_party_approvers Reviewed By: michelle, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D9108 GitOrigin-RevId: e337fbea626f4e72f7641a9dd48f5c0e159243e5
-
Vishal Jain authored
Summary: Config service will call artifact service to get a download link. Then get a tar file and convert to a yaml map. This rpc endpoint will be called by grpc in cloud api service. Test Plan: Manual Deploy to Pixie Cloud Reviewers: michelle, nserrino, vihang Reviewed By: michelle JIRA Issues: PP-2834 Differential Revision: https://phab.corp.pixielabs.ai/D9086 GitOrigin-RevId: cb4484d8be52be9e977f532244469ad0f1207cce
-
Ryan Cheng authored
Summary: Kafka client may read the 4-byte header first, and then read the rest in a seperate read, just as MySQL. This diff handles this case in protocol inference. Test Plan: protocol_inference_test Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9034 GitOrigin-RevId: 943b17837680940a3f643576300afa81e3f07231
-
Omid Azizi authored
Summary: Our periodic dumps no longer include list of PIDs. Test Plan: Manual Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Differential Revision: https://phab.corp.pixielabs.ai/D9078 GitOrigin-RevId: 0d59bf810d36b44f8df174366b28a099f4ae4e36
-
Vihang Mehta authored
Summary: We were calling `setCWD` on null Test Plan: Run it Reviewers: michelle, vjain Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9104 GitOrigin-RevId: d945950937c540a543a17c1ccbf238569ece8d56
-
Natalie Serrino authored
Summary: For some cases with /embed, we want the time to be fixed. (In the non-widget case that allows breadcrumbes). In this scenario, we will omit the start_time breadcrumb from the breadcrumbs. This is controlled by a query param, and is not the default behavior. fix test Test Plan: ran various cases in UI, tests Reviewers: zasgar, philkuz, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9090 GitOrigin-RevId: 5795598116bfedaa2e87b756135d72ec25510487
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9093 GitOrigin-RevId: 5265ef9fc24ece6a57306ecd9ad01d61d06b6f64
-
Natalie Serrino authored
Summary: We had some stray http_resp_status references in the vis.json after the schema changed to resp_status. Make sure to check vis.json and *.pxl scripts when making a column schema change. Test Plan: ran the views Reviewers: oazizi, yzhao, vihang, htroisi Reviewed By: vihang JIRA Issues: PC-1067 Differential Revision: https://phab.corp.pixielabs.ai/D9094 GitOrigin-RevId: d3c8b9645415203dbe87b97c690e10d7d94063be
-
Natalie Serrino authored
Summary: We had some deep linking via px.Service in a few PxL scripts. These were invalid because they weren't actually services, they were the results of nslookup (which may not return a k8s service). Test Plan: ran the offending views and they no longer falsely deep link in the wrong place w/ a borken link Reviewers: vihang, philkuz, htroisi Reviewed By: vihang JIRA Issues: PC-1057 Differential Revision: https://phab.corp.pixielabs.ai/D9092 GitOrigin-RevId: 557d2f18049373493b5f5482594088ecee0abee3
-
Natalie Serrino authored
Summary: DNS flow graph was buggy because 1. We were falsely casting 'to_entity' columns like kube-dns.kube-system to px.Service (when they are not formatted as services and can't be, because other items like localhost will be present in that same column) 2. We redundantly displayed an oddly formatted service (which was buggy for multi-service records like [pl/nats, pl/nats-external] or whatever) in to_entity, instead let's just put pod like some of the other flow graph scripts.= Test Plan: ran it, and now the graph renders correctly without broken links, and the table contents look more correct without broken links Reviewers: htroisi, vihang, philkuz Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9091 GitOrigin-RevId: 5ba5ef47947a9526fcd6d5c0420fb700291a9626
-
Nick Lanam authored
Summary: Part of PC-1050. Implements a new DataTable using `react-table` and `react-window`, instead of `react-virtualized`. Uses it in the data drawer. Future diffs will add the remaining features that the data drawer wasn't using, then swap over all uses and remove `react-virtualized`. Note: column resize behavior is much less clever. Whether this is desirable is open for discussion; `react-table` will let us change it if we want. Features present in the old implementation, but not yet in the new one, include: - Column show/hide - Expanding raw data - Gutter column - Column-specific default widths (right now they just split the available space) - Performance improvements (right now it's about the same as the old impl) - Head/tail mode Test Plan: Run a few scripts and look at the data drawer. The overall result should be quite similar. Reviewers: michelle, vihang, #third_party_approvers Reviewed By: michelle, #third_party_approvers JIRA Issues: PC-1050, PC-1058 Differential Revision: https://phab.corp.pixielabs.ai/D9045 GitOrigin-RevId: a26256b29205d0b15099d447b6e8429e6d689a4f
-
Vihang Mehta authored
Summary: TSIA, this breaks the interdependency between updating cloud and cli. Test Plan: Added console logging and checked that both new and old clouds were supported. Reviewers: michelle, zasgar Reviewed By: michelle JIRA Issues: PP-2626 Differential Revision: https://phab.corp.pixielabs.ai/D9087 GitOrigin-RevId: 4d6a0ea1ab48363deade5fd6425abe43ca7ab0b8
-
Michelle Nguyen authored
Summary: this diff adds the protos for getting/setting user attributes. Test Plan: everything builds Reviewers: vihang, zasgar Reviewed By: vihang JIRA Issues: PC-992 Differential Revision: https://phab.corp.pixielabs.ai/D9085 GitOrigin-RevId: 73ac10cfe79abd43436b6204c14039da230ab260
-
Michelle Nguyen authored
Summary: I tried running `arc diff` from one of the lower levels in our repo and noticed the lint was failing because it was trying to look for `.git` in the directory I was in Test Plan: run `arc diff` in one of the internal directories with a proto change Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9089 GitOrigin-RevId: f1d42be8f76f28ad72bf38e0a46ddc65df5adf67
-
Phillip Kuznetsov authored
Summary: CreateInviteLink needs to be separated in light of the `auth_provider_id` changes. Basically, identities need to exist in the idprovider before we create the user in the database. So now we need to separate out the method into two separate calls. Test Plan: things compile, but this is an interface change Reviewers: vihang, michelle, vjain, nserrino Reviewed By: vihang JIRA Issues: PC-1072 Differential Revision: https://phab.corp.pixielabs.ai/D9088 GitOrigin-RevId: 3da5c5a31d9c257a2f082e6ee2ffe5c47565737c
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9073 GitOrigin-RevId: eb86c11de6d90e6f3df4630e3bced31d1160fe38
-
Michelle Nguyen authored
Summary: We need a new userAttributes table to track whether a user has seen the tour. Once this table is populated and hooked up to the UI, we can drop the old userSettings and refactor it Test Plan: n/a Reviewers: vihang, zasgar Reviewed By: vihang JIRA Issues: PC-992 Differential Revision: https://phab.corp.pixielabs.ai/D9084 GitOrigin-RevId: f0b7949f54041a8ff16d1d8de72a1cca543bcc5b
-
- 08 Jul, 2021 5 commits
-
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9077 GitOrigin-RevId: ff7d10c83f4255d8b2dcba61514fe63312f8ab5d
-
Omid Azizi authored
Summary: Another prepatory diff. Rename some classes and move both path resolvers into the same file. Still sticking with LegacyCGroupPathResolver for now, but should be hooking in the new one soon. Test Plan: Existing tests. Reviewers: michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9083 GitOrigin-RevId: dc413d0a6d8b67072b6920728a6c5c195e9ab085
-
Omid Azizi authored
Summary: This is prepatory refactoring/modularization work to make swapping in the new scheme easier. Test Plan: Existing tests updated. Reviewers: michelle Reviewed By: michelle JIRA Issues: PP-2841 Differential Revision: https://phab.corp.pixielabs.ai/D9082 GitOrigin-RevId: 25357d7f74ca0a1d22bbc34ca09f823c997acd56
-
Omid Azizi authored
Summary: Vestiges that are no longer used. Test Plan: Existing tests Reviewers: #stirling, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9080 GitOrigin-RevId: c352f40c9c7d72f3659835e747c2a89649f2acea
-
Vihang Mehta authored
Summary: This helps us differentiate between dev/staging/prod and also handles the OSS pixie deployment better. This moves the viper flag parsing so that it happens in init and the cloud_addr is accessible by the time analytics client is created. After this we will use cloud to check for analytics opt outs and use that in the CLI. Test Plan: Ran cli with some logs around the analytics keys Reviewers: zasgar, michelle Reviewed By: michelle JIRA Issues: PP-2626 Differential Revision: https://phab.corp.pixielabs.ai/D9071 GitOrigin-RevId: 22ea9c762dd8dfb9dde213a438af2d0f70fbfb9c
-
- 07 Jul, 2021 9 commits
-
-
Omid Azizi authored
Summary: We've been bitten a number of times by systems that follow different naming conventions for their cgroup paths. When this happens we fail to monitor anything, because our list of PIDs is blank. To make our approach more robust, this file automatically discovers the appropriate path template to use. This is in place of us having to manually put the templates in place. Test Plan: Note that this is not yet enabled, it just adds the utility. The utility itself includes tests on different formats added. I also tested manually on a GKE cluster to ensure no regression. Reviewers: michelle, zasgar Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9076 GitOrigin-RevId: 05379c5a39537446793a7f3cc238f74aa7fa1a66
-
Vishal Jain authored
Summary: Introducing Config Manager Service. This service is responsbile for all the logic to compute any paramaters/fields for the Vizier operator. Test Plan: Dev Cloud run Reviewers: nserrino, michelle, vihang Reviewed By: michelle JIRA Issues: PP-2838 Differential Revision: https://phab.corp.pixielabs.ai/D9070 GitOrigin-RevId: e2ded275abd616cfbcb1a1ba911ea92e800e8eaf
-
Phillip Kuznetsov authored
Summary: Lengthening column because we don't need to be austere with this, and we might find some provider has a super long id. Test Plan: Tested on skaffold. Reviewers: michelle, vihang, vjain Reviewed By: michelle, vihang Differential Revision: https://phab.corp.pixielabs.ai/D9074 GitOrigin-RevId: 38091331faac1ad51f342a53bb798419e7113d36
-
Vihang Mehta authored
Summary: This showed up when running `make buildifer` Test Plan: N/A Reviewers: #stirling, zasgar, jamesbartlett, jps Reviewed By: #stirling, jamesbartlett, jps Differential Revision: https://phab.corp.pixielabs.ai/D9075 GitOrigin-RevId: 20f491fcc7d53c7267dcc1b05897462e16d0d402
-
Phillip Kuznetsov authored
Summary: TSIA Test Plan: Added a test. Reviewers: michelle, nserrino, vjain Reviewed By: michelle JIRA Issues: PC-1045 Differential Revision: https://phab.corp.pixielabs.ai/D9066 GitOrigin-RevId: 6f89c0bbe63ad7761d290cb197c95496067c7cf1
-
Nick Lanam authored
Summary: The CLI auth flow in particular made it weird for the box to be so thin. Most dialogs still look the same: {F160994} CLI token growing to fit: {F160995} An error dialog growing wider to fit its text: {F160993} What happens if the screen isn't wide enough: {F160996} Test Plan: `withpixie.ai:8080/login?local_mode=true`. If you refresh that view, you'll get an error page that is also affected. The sign up and log in boxes are not any wider as they didn't need to be. Reviewers: #third_party_approvers, michelle, vihang Reviewed By: #third_party_approvers, michelle JIRA Issues: PC-1061 Differential Revision: https://phab.corp.pixielabs.ai/D9072 GitOrigin-RevId: f435da62815d4eea0f4f459e37f1a350b2f3aa56
-
Phillip Kuznetsov authored
Summary: We need this to determine whether a user has uniquely logged in. Currently, we rely on email which has flaws in case a user changes their email or someone else authenticates with an old existing email. Test Plan: Added tests. Reviewers: michelle, vihang, nserrino, vjain Reviewed By: michelle JIRA Issues: PC-1045 Differential Revision: https://phab.corp.pixielabs.ai/D9065 GitOrigin-RevId: 1e82e241273d5b7d5f18c810f5c07bd4f41c3a61
-
Pete Stevenson authored
Remove unused constexpr kStackTraceTablePushPeriod, deprecated by the switch over to frequency manager. Summary: Remove unused constexpr kStackTraceTablePushPeriod, deprecated by the switch over to frequency manager. Test Plan: Existing. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi JIRA Issues: PP-2772 Differential Revision: https://phab.corp.pixielabs.ai/D9068 GitOrigin-RevId: 32887db33b71f9ee968a897b94a2cd6f1b69b997
-
Omid Azizi authored
Summary: We discovered a cluster with K8s 1.21 and containerd that used a different cgroup naming scheme. Test Plan: Will include test in a separate diff. Manually tested. Reviewers: nserrino, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9069 GitOrigin-RevId: 734066a8bb5283131206bbb68f849390b32201d5
-
- 06 Jul, 2021 1 commit
-
-
Phillip Kuznetsov authored
Summary: I needed to setup an independent auth0 dev environment and discovered that we don't propagate auth0 host information properly. This diff propagates the auth0 host information up properly. Test Plan: tested on dev cluster with new auth0 setup and our shared dev setup. Reviewers: michelle, vihang, nserrino, vjain Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9062 GitOrigin-RevId: 5b9dd31ea332cd5d7f135d29e476033080d1d250
-