This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 02 Jul, 2021 12 commits
-
-
Vihang Mehta authored
Summary: Running prototool once per proto file causes a variety of problems, a common one of which is the fact that it will warn on new proto files. This causes us to lose information about what file the breaking change comes from but should ease some of the other painpoints from this linter. Test Plan: Ran `arc lint` after making some breaking proto changes. Reviewers: michelle, zasgar Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9042 GitOrigin-RevId: 72a08085270b7dff3da4dc96384d389be747c82e
-
Vihang Mehta authored
Summary: sdpxID is optional since we don't always seem to parse one and it's unused in the UI anyway Test Plan: Ran `yarn dev` with extracted licenses. Reviewers: michelle, nlanam Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9043 GitOrigin-RevId: 289ab530660e35d3f8d847616bbc429eb4097fb8
-
Omid Azizi authored
Summary: In preparation of further optimizations, factor out a SymbolCache object for each process. In future diffs, the plan is to add some sort of memory bound on the cache via LRU or similar policies. Test Plan: Existing tests. Reviewers: #stirling, jps Reviewed By: #stirling, jps JIRA Issues: PP-2821 Differential Revision: https://phab.corp.pixielabs.ai/D9029 GitOrigin-RevId: e0ffbc5a034d2a29064b7bd0a5ec3416d81d8e15
-
Natalie Serrino authored
Summary: In the UI, we have some special handling to propagate the "start_time" parameter of scripts when links are clicked and views are switched. We were inconsistent with the naming in some of our scripts, calling the field "start" in some places. This diff standardizes our scripts on "start_time". Additionally, in the process of updating all of the usage of "start", discovered some stale scripts and deleted them. Test Plan: ran every view that has changed to ensure compilation and successful execution Reviewers: vihang, zasgar, michelle Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9031 GitOrigin-RevId: 9e0fe6c7f1922c17fbe51b954905d7e2daaa00a8
-
Michelle Nguyen authored
Summary: the auth token is inside a code renderer which overflows the size of the authbox. since this token can get very long, stretching the size of the authbox to fit the token won't always work. instead, we can make the box scroll. also updated the scrollbar styles so that it better matches the rest of our scrollbars. Test Plan: yarn dev Reviewers: nlanam, vihang Reviewed By: nlanam JIRA Issues: PC-1052 Differential Revision: https://phab.corp.pixielabs.ai/D9026 GitOrigin-RevId: 3e95b2b6fa4a1b145031172f4edb047fd6a76e8a
-
Michelle Nguyen authored
Summary: Our apply code was refactored into two parts: parse the YAML into unstructured objects, apply the unstructured objects. however, the former stage was causing errors if the Kind does not exist on the cluster. The first stage should not depend on existing k8s objects. this way, we can run `retryDeploy` on the apply stage for resources that may have a race condition Test Plan: ran px deploy on a cluster with no NATS crd Reviewers: vihang Reviewed By: vihang JIRA Issues: PP-2656 Differential Revision: https://phab.corp.pixielabs.ai/D9039 GitOrigin-RevId: 1b4cb18c0371340768b22d2fe2f6656e88973921
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9038 GitOrigin-RevId: 2dbd5aa5686ca97fa4eb8b8dccff3751331a6468
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9035 GitOrigin-RevId: 46895658e7d29121c158638884e57fcd2ed2bd68
-
Omid Azizi authored
Summary: Stack ID's aren't strictly necessary. They are useful for normalization (which we have not yet done), and for quicker aggregation by Carnot, but right now the memory cost outweighs the benefits. Test Plan: Existing tests Reviewers: #stirling, jps Reviewed By: #stirling, jps Subscribers: jps JIRA Issues: PP-2821 Differential Revision: https://phab.corp.pixielabs.ai/D9024 GitOrigin-RevId: 8fa926fcaea59fbfbf61e394f6600c616d37b392
-
Ryan Cheng authored
Summary: Add protocol inference rules for kafka. {F160540} Test Plan: Updated protocol_inference_test Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9020 GitOrigin-RevId: cf3e725be8026eea21db3f00ec8fd5594eae16df
-
Zain Asgar authored
Summary: This allows the Go API to create API keys. Test Plan: Tested with example code. Reviewers: vihang, michelle, nserrino Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9040 GitOrigin-RevId: ce7654e22e664731bd04d81d6fcc860dae75b44b
-
Michelle Nguyen authored
Summary: I broke the licenses when making changes to deploy OSS pixie every OSS build. This should check the configurables/private path is a valid directory, rather than a valid file. This was always returning false, so wouldn't move the licenses to the correct path. However, the licenses in the OSS build will still be broken. this is because the licenses build requires private creds. This is filed here: https://pixie-labs.atlassian.net/browse/PC-1055 Test Plan: should test with a deploy to staging Reviewers: vihang, zasgar Reviewed By: vihang JIRA Issues: PC-1054 Differential Revision: https://phab.corp.pixielabs.ai/D9032 GitOrigin-RevId: d98d97abcfda91c2b4076d96ca6177e18841fdfc
-
- 01 Jul, 2021 8 commits
-
-
Michelle Nguyen authored
Summary: since we were not passing the clusterName to the data drawer's table, the entity links in the data drawer all had clusterName=null, which links to a broken page. also fixed a bug where the page would whitescreen when opening up the data drawer. Test Plan: yarn dev Reviewers: vihang, nlanam Reviewed By: nlanam JIRA Issues: PC-1053 Differential Revision: https://phab.corp.pixielabs.ai/D9027 GitOrigin-RevId: 033f06416fac36f04d0e6cdecdf6b8df1a7c8f7c
-
Michelle Nguyen authored
Summary: we currently always show a tour overlay for support accounts, because we try to fetch the user setting which doesnt exist. we then try to write a user setting to record that the user has seen the tour. however, support accounts arent real users, so the query fails. Test Plan: yarn dev Reviewers: vihang, nlanam, nserrino Reviewed By: nlanam JIRA Issues: PP-2827 Differential Revision: https://phab.corp.pixielabs.ai/D9028 GitOrigin-RevId: dfaea121ea8fd849f64afb013055f91780886c81
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9013 GitOrigin-RevId: bd60069871baa58a1720ac5bd73d128775835bb4
-
Vihang Mehta authored
Summary: TSIA Test Plan: Existing tests + build Reviewers: michelle, nlanam Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9021 GitOrigin-RevId: 073394d8d21aa2dac0ff19758b917e2f00831e56
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9002 GitOrigin-RevId: 3fc00345ce126090fc4e4f156934c011828d4ce6
-
Michelle Nguyen authored
Summary: Currently, we are throwing a snackbar error in the liveview if the user has no clusters. this is because: 1. clusterName in live-routing is stringified. undefined clusterName becomes "undefined" 2. live.tsx makes a gql to fetch clusterInfo for "undefined". gql request returns an error since "undefined" does not exist. 3. since there is an error, we show the snackbar notification. unfortunately, since the gql query is a react hook, we can't conditionally make the call. however, it also doesnt seem right to update the gql request to not return an error, because it /should/ throw an error if you're fetching clusterInfo for a non-existent cluster. instead, if the clusterName is empty, we should know to expect an error and not show the snackbar. ideally we should also check the error message, but the error message from GQL is just a string rather than a nice error code. Test Plan: yarn dev Reviewers: vihang, nlanam, philkuz Reviewed By: vihang JIRA Issues: PC-1051 Differential Revision: https://phab.corp.pixielabs.ai/D9022 GitOrigin-RevId: 4c4580de4daa77eedb8b54f51da4cd5407b6c0ce
-
Vihang Mehta authored
Summary: TSIA, minor cleanup Test Plan: Existing tests, `yarn typecheck` Reviewers: nlanam, nserrino Reviewed By: nlanam Differential Revision: https://phab.corp.pixielabs.ai/D9017 GitOrigin-RevId: f1e4900d380fb9bd5d094ed49ee753003c1f3302
-
Vihang Mehta authored
Summary: This adds support for `/embed/live` routes that hide top navbar and left sidebar. Also hides the breadcrumbs if a widget is selected. Test Plan: `yarn dev` Embedded with Widget param specified {F160493} Embedded with no Widget param {F160494} Regular live view {F160495} Reviewers: nserrino, zasgar, michelle, nlanam Reviewed By: nlanam Differential Revision: https://phab.corp.pixielabs.ai/D9018 GitOrigin-RevId: 788fc4af6268c9c83f9c2baee5c065fb50c00b6c
-
- 30 Jun, 2021 3 commits
-
-
Natalie Serrino authored
Summary: We want to be able to support embedding Live Views and Widgets via link. This diff adds an optional "widget" param to Live View URLs, which will support the case of embedding a particular widget via link. This is for the cases where you would rather show a single widget rather than the whole grid. Test Plan: ran it in mobile, selected and unselected widget cases, updated unit tests. Reviewers: zasgar, michelle, vihang, nlanam Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9016 GitOrigin-RevId: 87f0693e2468593796af30b9e3a7072febb0fcbe
-
Michelle Nguyen authored
Summary: we are adding the ability to embed Pixie in iframes. in order to better fit the theme of the site embedding Pixie, we are allowing users to specify the theme in the query params. in the future, we should add support to toggle the theme based on a switch and user-settings. for now, the query param will suffice. theme colors for the light theme are from: https://www.figma.com/file/WkM4NrbvWOZloJauYy54YP/Color-Palette-2.0?node-id=2%3A68 We should play around with the flamegraph colors to make those more presentable. Test Plan: screenshot:{F160403} {F160419} {F160420} Reviewers: nlanam, vihang, zasgar Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D9010 GitOrigin-RevId: a86aa316cd8f0a2c7e11a6024c015b19becff986
-
Zain Asgar authored
Summary: Right not this allows /live to be embedded, but we will change this to be /embed shortly. Test Plan: Tested on staging cloud Reviewers: michelle, nserrino, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9011 GitOrigin-RevId: b9ceaa189072324ae740f0cf93bc5f9a615abd22
-
- 29 Jun, 2021 11 commits
-
-
Yaxiong Zhao authored
Summary: Using member variables makes it difficult to see the logic from the test code. Test Plan: Jenkins Reviewers: #stirling, jps, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9008 GitOrigin-RevId: 59913af5a3451c1a4e8af42aad135b0899fffa09
-
Yaxiong Zhao authored
Summary: RecordBuilder's destructor already check this. Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D9007 GitOrigin-RevId: d3b84ed7a52dff9c13a6aa5d687b96c5263e2a65
-
Michelle Nguyen authored
Summary: the relative path is relative to the request path, which is not what we want Test Plan: staging Reviewers: zasgar Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D9009 GitOrigin-RevId: 8e3618707755a5866af6b7247c74e1a18f45284d
-
Michelle Nguyen authored
Summary: this allows the user to login by posting form-encoded params to the /api/auth/loginEmbed. This will then redirect them to the redirectURI Test Plan: unit test Reviewers: zasgar Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D9006 GitOrigin-RevId: a6139a4f58420837a2488b381d3bdc6552452947
-
Yaxiong Zhao authored
Summary: This allows frequency management inside SourceConnector. Make the interface consistent between sampling and push data. Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8991 GitOrigin-RevId: 85dec11fcf1d2930f91ac4c7b21f0b2db28c7656
-
Nick Lanam authored
Summary: `makeCancellable(somePromise).cancel()` works by rejecting a wrapper promise so that any `.then` calls never get invoked. We need to `.catch` the wrapped promise to silence `Uncaught rejection in promise` logs in the console. Notably, any rejections NOT caused by cancellation still happen so they can be caught (or ignored) normally. Test Plan: Load the live view. No more console error about autocomplete cancelling a call. Reviewers: michelle, vihang, nserrino Reviewed By: vihang JIRA Issues: PC-1049 Differential Revision: https://phab.corp.pixielabs.ai/D9005 GitOrigin-RevId: ace2486605e034e6ad731480dc2643c426c305b2
-
Ryan Cheng authored
Summary: Adds infer_mongo_message to protocol_inference.h and the python benchmark.{F159902} Test Plan: na Reviewers: oazizi, yzhao, jps Reviewed By: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8969 GitOrigin-RevId: 9c6c102d25d63014722688021c0ee8606436f4e6
-
Vihang Mehta authored
Summary: This reverts commit cca6af96ebc3d108ab6bb559661390f7f5950b77. Test Plan: Ran yarn dev with local script bundle Reviewers: michelle, zasgar Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9004 GitOrigin-RevId: ccdec8b6f98323a8a8d6dcc11db220afeb8349f9
-
Omid Azizi authored
Summary: Modifies the script so we can choose the apps to deploy. The HTTP stressor app is included as an option now. Test Plan: Manual. Reviewers: #stirling, jps Reviewed By: #stirling, jps Subscribers: jps, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8883 GitOrigin-RevId: 4f45ae2174f86530585e169b7657d6e2cade2bad
-
Michelle Nguyen authored
Summary: our fields are too short and can cause problems when creating users or logging in Test Plan: migrate on staging Reviewers: zasgar, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D9003 GitOrigin-RevId: 8ff632f0aa010b2f5a8660cad3c568bcac5f49ed
-
Yaxiong Zhao authored
Summary: This prepares to add SourceConnector::PushData() which move pushing data into SourceConnector. Since PushData() only takes a vector of DataTable, it still needs a global ID to identify the right destination. The ID is owned by InfoClassManager, such that when DataTable objects are replaced, the ID stays the same. Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8989 GitOrigin-RevId: a9b2d3f8d6104da8cdf8d12ed62d4df29b1324ac
-
- 28 Jun, 2021 6 commits
-
-
Vihang Mehta authored
Summary: Runs queued for pixie-oss were causing pixie-main runs to be skipped. This adds skip logic for pixie-oss too and makes sure that they don't skip each other. Test Plan: Jenkins? Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9001 GitOrigin-RevId: cb2299e902144a109003d0b71ecffdbfab20f487
-
Vihang Mehta authored
Summary: Holding onto both the parsed and string versions was getting a bit squirelly and we want the parsed version at almost all times anyway. The only place that consumes the raw string is the editor and manually stringifying and parsing at that boundary is easier. This also eases the transision to proto parsing the Vis (instead of just JSON parsing). Test Plan: `yarn dev` Reviewers: nlanam, philkuz, michelle Reviewed By: nlanam Differential Revision: https://phab.corp.pixielabs.ai/D8983 GitOrigin-RevId: abce0b2d8bdb66b8c5c55901529ae378f914363e
-
Vihang Mehta authored
Summary: This was causing the create_admin_job to fail. Test Plan: Built a new image, recreated create_admin_job, it succeeds now. Reviewers: michelle, philkuz Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D9000 GitOrigin-RevId: 2ff0cf3ca4658534b41fd084d995667e3389db47
-
Nick Lanam authored
Summary: Using `withStyles` was causing `yarn coverage` to generate different class names (tacking a 2 onto the component name) than `yarn test`. This seems to be an interaction with `jest-esbuild` and Material. Using `makeStyles` and `createStyles` instead ensures consistent results. Test Plan: `yarn test`; `yarn coverage`. Both should now pass rather than just the former. Reviewers: michelle, vihang Reviewed By: vihang JIRA Issues: PC-1048 Differential Revision: https://phab.corp.pixielabs.ai/D8999 GitOrigin-RevId: 71450efbe9e1aef6a9321e777f1514babc576b90
-
Vihang Mehta authored
Summary: `rest.RESTClient` doesn't support DeepCopy by default and we don't seem to use DeepCopy on v1alpha1.VizierClient Disable geneartion of deepcopy so that running `go generate ./...` from TOT doesn't break the build. Test Plan: Ran `go generate ./...` Reviewers: michelle, zasgar Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8998 GitOrigin-RevId: 65fc1c4f6cb34c3c4d270f73c774afecaf011a6c
-
Vihang Mehta authored
Summary: I ran `go generate ./...` as part of D8981 which added the `DeepCopy` and `DeepCopyInto` calls which fail to compile. Revert those changes. Test Plan: bazel build //... Reviewers: michelle, zasgar Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8997 GitOrigin-RevId: 801d7bfce25360fdd97fb111ada0d7a93781201b
-