This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 26 May, 2021 1 commit
    • Nick Lanam's avatar
      [PC-959] Don't forget selection index in cluster selector · e81fc310
      Nick Lanam authored
      Summary: Some stuff wasn't being memoized that should have been.
      
      Test Plan: Open the cluster selector in the top bar of the live view. It should no longer lose track of what you're hovering if you move your mouse around wildly (especially outside of the dropdown).
      
      Reviewers: michelle, vihang, zasgar
      
      Reviewed By: zasgar
      
      Subscribers: zasgar
      
      JIRA Issues: PC-959
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8734
      
      GitOrigin-RevId: 3e831cbefc3232ae1d4791be6e6c60e6ca31f0f5
      e81fc310
  2. 25 May, 2021 16 commits
    • Michelle Nguyen's avatar
      PC-958 Fix navigation for clusters with "/" in the name · fdddc2cb
      Michelle Nguyen authored
      Summary: the "/" was getting parsed incorrectly. luckily we have handy functions for encoding/decoding URI strings.
      
      Test Plan: changed my cluster name to include a "/". test that default cluster navigation works, that switching to the cluster works, and navigating to the URL works
      
      Reviewers: vihang, nlanam, philkuz
      
      Reviewed By: vihang
      
      JIRA Issues: PC-958
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8746
      
      GitOrigin-RevId: 7d899519f80f9274ddc0029829a21fa226c542bc
      fdddc2cb
    • Vihang Mehta's avatar
      Fix left sidebar open/close and zindex · 559fd10d
      Vihang Mehta authored
      Summary:
      This includes the following fixes:
      - The hamburger now opens and closes the sidebar. (Used to fail to close
        previously).
      - The sidebar is higher than the data drawer.
      - The sidebar flows below the topbar and doesn't have a hidden hamburger element
        in it.
      - Verified that the tour correctly sets/resets the sidebar and datadrawer state.
      
      Test Plan: tested a bunch of sidebar/datadrawer/tour navs on dev.
      
      Reviewers: michelle, philkuz, zasgar, nlanam
      
      Reviewed By: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8735
      
      GitOrigin-RevId: 45b8323174da66f52d8af776d680aebcfa1f8c98
      559fd10d
    • Phillip Kuznetsov's avatar
      PC-960: Render an error if on exists in the resultsContext instead of trying to load a cluster. · 00268f70
      Phillip Kuznetsov authored
      Summary: We need to support situations where an error should render if it's created even if the cluster is still loading. Fix is to check that results context has an error. If the error is resolved before a cluster has been loaded, the loading cluster dialog will show up again which is intended.
      
      Test Plan: Tested on yarn dev. Added a required arg to a script (`px/cluster`), received an error, then navigated to a new cluster where I saw the error again. Fixed the error, then reran script and saw ClusterLoading component show up.
      
      Reviewers: michelle, vihang, nlanam
      
      Reviewed By: michelle, vihang
      
      JIRA Issues: PC-960
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8737
      
      GitOrigin-RevId: 1574267e9a77627cf04316a47f882537237a8907
      00268f70
    • Phillip Kuznetsov's avatar
      PC-961: Render an error when a required argument is missing · 32b59234
      Phillip Kuznetsov authored
      Summary:
      We had an unnecessary check in our script-context to make sure args are valid. We do this check in execute() anyways and so remove the one in script-context.
      Also updated the error rendering to be in resultsContext rather than a bar.
      {F157703}
      
      Test Plan: Tested on yarn dev and now px/pod can be navigated too without a silent error.
      
      Reviewers: vihang, nlanam, michelle
      
      Reviewed By: vihang, michelle
      
      JIRA Issues: PC-961
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8736
      
      GitOrigin-RevId: e0e9e6e435a338710116d110d0f38170011ca961
      32b59234
    • Zain Asgar's avatar
      Remove period at the end of line making URLs harder to copy/paste · 26780ab9
      Zain Asgar authored
      Summary: TSIA
      
      Test Plan: N/A
      
      Reviewers: michelle, vihang
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8731
      
      GitOrigin-RevId: a945b68b10761f75d2f0f20aa45d93914baf4ca8
      26780ab9
    • Nick Lanam's avatar
      [PC-956] Fix sidebar toggle button · 4f084000
      Nick Lanam authored
      Summary: Minor oversight since the function it calls serves double duty
      
      Test Plan: Open the live tour with the sidebar already closed; then try with it already open. Also try opening and closing it from the top left hamburger button. It should close for the tour if open, remember what state it was in when the tour closes, and the hamburger button should switch open/closed as long as said button is available (the tour hides/blocks it).
      
      Reviewers: michelle, vihang
      
      Reviewed By: michelle
      
      JIRA Issues: PC-956
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8732
      
      GitOrigin-RevId: 350fa43d52be5fa451d0d9012b1380e43a395848
      4f084000
    • Michelle Nguyen's avatar
      Fix request graph icons · 907e797f
      Michelle Nguyen authored
      Summary: Accidentally switched the icons for hierarchy/clustered modes
      
      Test Plan: yarn dev
      
      Reviewers: vihang, zasgar, philkuz
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8728
      
      GitOrigin-RevId: 6b5d3491fe8c13a277139bd1782f1b4a0641b0b8
      907e797f
    • Michelle Nguyen's avatar
      PC-955 Reenable tour in UI · 1aa35556
      Michelle Nguyen authored
      Summary: after we fixed the tour, we forgot to add it back to the toolbar
      
      Test Plan: yarn dev
      
      Reviewers: nlanam, vihang, zasgar
      
      Reviewed By: vihang
      
      JIRA Issues: PC-955
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8727
      
      GitOrigin-RevId: 9efb64be32c0a07732e137df69548ed2cd08132f
      1aa35556
    • Michelle Nguyen's avatar
      Update cluster selector styling · 87f95fc4
      Michelle Nguyen authored
      Summary:
      we should add a label for now so that its clear what this selector is for.
      in the future, we can add an icon
      
      Test Plan:
      screenshot
      {F157635}
      
      Reviewers: zasgar, vihang, philkuz
      
      Reviewed By: zasgar
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8725
      
      GitOrigin-RevId: ed62a83c41e53d7f801e571a2036be5d0c90aec1
      87f95fc4
    • Nick Lanam's avatar
      [PC-956] Restore live tour functionality · a3d5156d
      Nick Lanam authored
      Summary:
      Fixes a sizing bug in the menu, restores the context needed for the live tour to open, fixes a logic flaw in `toggleSidebar` for the same purpose, then moves punchouts and tips around in the tour to mostly suit the new UI layout. Not perfect, but good enough for a demo tomorrow.
      
      {F157645}
      
      Test Plan: Open the live tour. You may need to wait a few seconds before the button is responsive (seems to be an unrelated bug).
      
      Reviewers: michelle, vihang
      
      Reviewed By: michelle
      
      JIRA Issues: PC-956
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8726
      
      GitOrigin-RevId: acd5df6528a5bfcd3bfd1032e21aeaa2ba36b10a
      a3d5156d
    • James Bartlett's avatar
      Change flamegraph styling. · bbe88aae
      James Bartlett authored
      Summary:
      Change flamegraph colors.
      Add better minimap interactions
      Add double click to reset view.
      
      Test Plan: Bikeshed
      
      Reviewers: michelle, zasgar, vihang
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8723
      
      GitOrigin-RevId: da0d856b272e8268b89a1b6b7908905f071cc2ab
      bbe88aae
    • Michelle Nguyen's avatar
      Fix styling of data drawer · e968856c
      Michelle Nguyen authored
      Summary:
      Updated the data drawer toggle so that it is not rounded on the bottom.
      also updated the background color of the data drawer so that it appears to be on elevation 2.
      
      Test Plan: yarn dev
      
      Reviewers: zasgar, vihang, philkuz
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8724
      
      GitOrigin-RevId: d2bb9deb21318a0cfe1cf28491b773add54f6f0f
      e968856c
    • Natalie Serrino's avatar
      Warn the user that px delete without clobber will delete the entire namespace.... · 99ed057c
      Natalie Serrino authored
      Warn the user that px delete without clobber will delete the entire namespace. Add y/n verification for delete to match deploy.
      
      Summary: TSIA. If we do px delete, we will delete the whole namespace and the user should give y/n confirmation. Also we should tell them that px delete is going to do that, in case they deployed px to a namespace with other things in it, like a monitoring namespace.
      
      Test Plan: ran it
      
      Reviewers: michelle, zasgar, vihang
      
      Reviewed By: michelle, zasgar
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8718
      
      GitOrigin-RevId: 7c7436ed73996d582edff506d874c942a3beddc5
      99ed057c
    • Natalie Serrino's avatar
      PP-2737: Vizier pods (besides bootstrap) should wait for cloud connector to... · 4857b762
      Natalie Serrino authored
      PP-2737: Vizier pods (besides bootstrap) should wait for cloud connector to assign cluster ID before starting
      
      Summary: We had a problem where users would be confused when deploying via helm, becuase many Vizier pods would show up as CreateConfigError. This was due to the fact that a subset of vizier pods (non-bootstrap pods) are configured to require PL_CLUSTER_ID, which is assigned in the bootstrap phase by cloud-connector. This diff adds a /readyz to cloud-connector which checks whether or not PL_CLUSTER_ID has been assigned. /readyz is then used by the non-bootstrap pods to determine whether or not the pod should start up yet (having received PL_CLUSTER_ID by that point).
      
      Test Plan: ran it in skaffold various times
      
      Reviewers: michelle, zasgar, vihang
      
      Reviewed By: michelle
      
      JIRA Issues: PP-2737
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8712
      
      GitOrigin-RevId: 9cef9278b2dbf919f6bcd02b1aa239e13ca2adfa
      4857b762
    • Vihang Mehta's avatar
      Update UI styling for topbar · 78962b14
      Vihang Mehta authored
      Summary: TSIA
      
      Test Plan: {F157586}
      
      Reviewers: michelle, zasgar, philkuz
      
      Reviewed By: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8721
      
      GitOrigin-RevId: 1834174cc992dede05aee584dfa00b40f6d44a53
      78962b14
    • Nick Lanam's avatar
      [PC-953] Add footer to all pages that didn't already have it · b3224613
      Nick Lanam authored
      Summary: Auth had it already. Credits, admin, and live did not. Made it stick to the bottom of the page if content would not have pushed it further. If content scrolls, footer ends up below it so as not to waste screen real estate. Also renames the component for the footer since it's general-use now.
      
      Test Plan: Check live, credits, and admin. In all cases, scrolling to the bottom should show the footer (ts&cs, privacy policy, copyright). If the page is shorter than the viewport, the footer should push itself to the bottom of the viewport (credits page does this, as does the scratch pad script before putting code into it).
      
      Reviewers: michelle, vihang
      
      Reviewed By: michelle
      
      JIRA Issues: PC-953
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8722
      
      GitOrigin-RevId: 66d73f826ae98547e8b0aff8a6ff6bd1db05cced
      b3224613
  3. 24 May, 2021 16 commits
  4. 22 May, 2021 3 commits
    • Michelle Nguyen's avatar
      Update most cases of useListCluster to only fetch necessary fields · f1265d57
      Michelle Nguyen authored
      Summary:
      we only need all fields in useListCluster in the admin page... the rest of the pages actually only care about id/name/status.
      this diff updates useListCluster so that you can query for the full set of data, or just the necessary subset.
      after D8691, more of these can change to a single getClusterInfoByName call.
      
      Test Plan: yarn dev
      
      Reviewers: vihang, philkuz
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8693
      
      GitOrigin-RevId: 432d4f1df10a703cf8a6bebed329f7a705765c47
      f1265d57
    • Michelle Nguyen's avatar
      Add gql endpoint to get clusterInfo by name · ff6fbf65
      Michelle Nguyen authored
      Summary:
      In many places in the UI, we reference the cluster by name (for example, URL).
      however, the backend only provides a way to fetch a single ClusterInfo by ID. therefore, consumers who need clusterInfo but only have a clusterName currently fetch the entire list of clusters, and filter through the list to get the correct clusterInfo.
      Instead, we can clean this logic up by doing this filtering in the backend.
      
      Test Plan: unit test
      
      Reviewers: vihang, philkuz
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8691
      
      GitOrigin-RevId: c2c80b16292a476adca197c4ccbcd80bf66d1f54
      ff6fbf65
    • Michelle Nguyen's avatar
      PC-940 Actually fix topbar when showing deployInstructions · 7e9d1cc1
      Michelle Nguyen authored
      Summary: D8689 was supposed to fix the topbar in the deployinstructions... It did fix it in the deployInstructions, but didn't work when in an org with clusters. this is because we shouldn't actually make topbar absolute, because other content will go underneath the topbar.
      
      Test Plan: checked org with and without clusters
      
      Reviewers: vihang, philkuz, zasgar
      
      Reviewed By: vihang
      
      JIRA Issues: PC-940
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8692
      
      GitOrigin-RevId: 797caafe2e993526295d9e46913f89355994e68d
      7e9d1cc1
  5. 21 May, 2021 4 commits
    • Michelle Nguyen's avatar
      PC-940 Remote interactive from tooltips in sidebar · 1e8d3361
      Michelle Nguyen authored
      Summary: the recent MaterialUI update made tooltips interactive by default. this actually made hovering over items in the sidebar a little annoying, because the tooltip for an item can block the item below it.
      
      Test Plan: yarn dev, hover on tooltips in sidebar
      
      Reviewers: vihang, philkuz, zasgar
      
      Reviewed By: vihang
      
      JIRA Issues: PC-940
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8690
      
      GitOrigin-RevId: bc73387af56f631a96dca0ed11a367a47ef2ce22
      1e8d3361
    • Michelle Nguyen's avatar
      PC-940 Fix topbar when showing deployInstructions · 10db4283
      Michelle Nguyen authored
      Summary: Currently when a user has no clusters and we should the deploy instructions, the topbar is rendered in a weird position rather than the top of the page.
      
      Test Plan: yarn dev
      
      Reviewers: vihang, philkuz, zasgar
      
      Reviewed By: vihang
      
      JIRA Issues: PC-940
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8689
      
      GitOrigin-RevId: bbb7be76af5a53ba6b2ab2c31aea6726ebb626bf
      10db4283
    • Michelle Nguyen's avatar
      Don't specify background color in vega · a66eb202
      Michelle Nguyen authored
      Summary:
      we were hardcoding a background color in vega before. this color no longer matches with the gridItem background color.
      we can just leave it transparent so that it matches with whatever the gridItem's background is.
      
      Test Plan: yarn dev
      
      Reviewers: vihang, philkuz, nlanam
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8677
      
      GitOrigin-RevId: 2004ac793de7d86d0899232b798c8af6625f51b5
      a66eb202
    • Natalie Serrino's avatar
      PP-2751: px/service should work for services that come in pairs · 74179aa8
      Natalie Serrino authored
      Summary: Previously, px/service checked for service string equality (e.g. df.service == 'ns/sv1'). This caused data to now show up for records that are part of multiple services. This change fixes that problem by switching the equality checks to px.has_service_name, which allows for checking if a service is in the list of services.
      
      Test Plan: ran it with a service that comes in a pair.
      
      Reviewers: michelle, philkuz, zasgar, vihang
      
      Reviewed By: michelle
      
      JIRA Issues: PP-2751
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8687
      
      GitOrigin-RevId: 222576192de80021d8e390e3a956074c5edfe292
      74179aa8