This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 27 Jan, 2021 6 commits
-
-
Michelle Nguyen authored
Summary: we need to expose this to the public api Test Plan: unit test Reviewers: zasgar, philkuz, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7199 GitOrigin-RevId: 2c62cfa378de1503d596c4a7b93f73ac0485f071
-
Michelle Nguyen authored
Summary: we need to make this public because we use it in some of our public apis Test Plan: tested by deploying to staging. ran old, current vizier release. verified running a query with a uuid col (agent_status) works on skaffold cli and old cli release ran vizier with skaffold. verified running a query with with a uuid col works on skaffold cli and old cli release Reviewers: zasgar, philkuz, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7198 GitOrigin-RevId: f0408c91f436cee101b774a21034760385930e91
-
Phillip Kuznetsov authored
Summary: Script wasn't the right term for this. ScriptExecutor makes more sense. Test Plan: Updated tests and they still work. Reviewers: zasgar, vihang, #engineering Reviewed By: zasgar, vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7196 GitOrigin-RevId: d709b88144c6ca20715f354b77ac49dffd03f405
-
Phillip Kuznetsov authored
Summary: bazel tends to have generic library target names. You add specificity from the path of the build file. This conforms to that standard. Test Plan: Tested and al lwork. Reviewers: zasgar, vihang, #engineering Reviewed By: zasgar, vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7188 GitOrigin-RevId: 4d846665cc397fd9f6beb8f4a3b1d06ef0ef9b6b
-
Michelle Nguyen authored
Summary: Our original cloudapipb and vizierpb protos weren't actually in a state where we could make them public. This diff creates new proto files for the protos that we do want to make public. The changes are as follows: CloudAPI: - created new pl.cloudapi.public proto package for our public protos - Created ClusterManager, which is a wrapper around the ClusterInfoService. This service excludes unnecessary functions such as creating/updating clusters. Users can GetClusters, which contains a subset of data from the original GetClusterInfo. ClusterManager also contains UpdateClusterConfig, which is a wrapper around the internal UpdateClusterConfig. - copied APIKey/DeployKey services to the new public protos. *in the current state, this will break the old CLI, which points to the old API/DeployKey service.* the CLI, which is the only external place which uses these services, has been updated to use the new public proto. is it worth keeping the old service around for users with the old CLI, or should we just ask them to update? Vizierpb: - Renamed old, internal proto package to `pl.api.internal.vizierpb`, so that the public package can be `pl.api.vizierpb`, in hopes of maintaining backwards compatibility. - Copied ExecuteScript/HealthCheck to new public package Test Plan: On Pixie Cloud with new API changes: - deployed current release version of Vizier. verify that UI + new & old CLI can still query vizier. with new CLI, debugLog continues to work. with old CLI, debugLog does not work. - deployed Vizier using skaffold. verify that UI + new & old CLI can still query vizier. with new CLI, debugLog works. with old CLI, debugLog does not work. Reviewers: zasgar, philkuz, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7185 GitOrigin-RevId: f01d8a8a2d0d11256c308f3c4dcaf9b1c5a3b763
-
Phillip Kuznetsov authored
Summary: I miscopied the config to the wrong part of the file. Had to move it down. Caused proxy to loop-crash on main. Fixed here. Test Plan: Tested with skaffold. Reviewers: zasgar, jamesbartlett, vihang, #engineering Reviewed By: jamesbartlett, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7194 GitOrigin-RevId: a6093fe92459e9806b35e833f9516531567f2fb7
-
- 26 Jan, 2021 12 commits
-
-
Phillip Kuznetsov authored
Summary: rip Test Plan: Updated tests so that they only run on one connection. Reviewers: zasgar, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7191 GitOrigin-RevId: a09b8cbb87e82075269e306e79f02cce94ddcc0a
-
Phillip Kuznetsov authored
Summary: PxL stuff is called scripts everywhere else in teh API. Updating to match that. Test Plan: Ran tests and they still work Reviewers: zasgar, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7190 GitOrigin-RevId: 2b3068a692e0b19c41ee7d25177b11bc64df4b91
-
Omid Azizi authored
Summary: Ruby client now makes multiple requests and we make sure we capture all of them. Test Plan: This is a test Reviewers: jps, yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7186 GitOrigin-RevId: ebdfa0e72ab2e45449dfa22c3fc888933b7b1d97
-
Phillip Kuznetsov authored
Summary: py_client was in a placeholder directory. Moving to src/api/python instead. Test Plan: Tests should still pass. Had to update some paths. Reviewers: zasgar, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7187 GitOrigin-RevId: 6a08db587e41d44898b544cb678142a4fe5bf57c
-
Phillip Kuznetsov authored
Summary: match golang api Test Plan: tests pass Reviewers: zasgar, #engineering, vihang Reviewed By: #engineering, vihang Differential Revision: https://phab.corp.pixielabs.ai/D7184 GitOrigin-RevId: 5ddfbda0e5f565df0637e668f31caa748b2130ea
-
Yaxiong Zhao authored
Summary: We will use this map to figure out the names of the command arguments Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7182 GitOrigin-RevId: a13f46a774feae0d0ae5d35da721b1d33ce47a69
-
Yaxiong Zhao authored
Summary: For general information, for example: tips of working with BCC. Test Plan: Jenkins Reviewers: jps, oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7169 GitOrigin-RevId: ae3225ce3b475fcb16cad4bcbf626f228f82d6f9
-
Natalie Serrino authored
Summary: During the refactor of the agent side of the metadata service, I noticed that these fields and messages were unused. Removing them so that it doesn't get confusing during the refactor. Test Plan: existing should pass Reviewers: michelle, vihang, #engineering Reviewed By: vihang, #engineering Subscribers: vjain JIRA Issues: PP-2370 Differential Revision: https://phab.corp.pixielabs.ai/D7175 GitOrigin-RevId: d9873ec74d5fe722b3fba203c554a84863a4ead1
-
Phillip Kuznetsov authored
Summary: @zasgar suggested we try to get more erg in our API. add a `results` that combineds listening to a table and iterating over the results. Test Plan: Added unit test Reviewers: vihang, zasgar, #engineering Reviewed By: zasgar, #engineering Subscribers: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D7183 GitOrigin-RevId: 935ff8e91b86cbb6f7163eb38f4f0acfed74bab6
-
Phillip Kuznetsov authored
Summary: Goal: Match the go api access methods. Need to access with indices. Test Plan: UPdate data tests Reviewers: zasgar, vihang, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7181 GitOrigin-RevId: 36747281700b1d61de5091e289b127ed9529a415
-
Phillip Kuznetsov authored
Summary: Type formatter function was only on tyhe column, not an index. This adds index support so this is better. Test Plan: Tested locally Reviewers: zasgar, vihang, nserrino, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7180 GitOrigin-RevId: 3ce74ac21c4dff7438d2ea63dd6f30cc7a35cce7
-
Phillip Kuznetsov authored
Summary: Py API shold support direct connections. Actually had to make an envoy proxy fix to make this owrk. Test Plan: Tested on a direct conn and added a unit test and both should pass Reviewers: htroisi, vihang, nserrino, zasgar, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7179 GitOrigin-RevId: 79c6b2eda23732199c129687e4f0da2c71da4770
-
- 25 Jan, 2021 3 commits
-
-
Phillip Kuznetsov authored
Summary: As suggested by Zain because our multi-cluster needs more stability improvements before we can default encourage our users to go for it. Test Plan: Updated tests and seems to connect fine. Reviewers: zasgar, vihang, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7178 GitOrigin-RevId: 787c6465dafb35e778bee2a896a1f29378864463
-
Yaxiong Zhao authored
Test Plan: Manual test Reviewers: jps, oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7168 GitOrigin-RevId: b521a7ab66949f7f746aa8d34fc4666dd1dfcbe3
-
Phillip Kuznetsov authored
Summary: Added new docs for the python api that are necessary. Test Plan: n/a Reviewers: vihang, nserrino, htroisi, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D7177 GitOrigin-RevId: 572a1a6b75da24a18cc0ec458f2da0c1dace1e75
-
- 26 Jan, 2021 1 commit
-
-
Phillip Kuznetsov authored
Summary: Discovered that python API couldn't talk directly with Vizier, had an issue where ALDP wasn't found. Go API doesn't need this but c-based grpc apis do. Test Plan: Tested on my personal cluster and fixed the issue Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7176 GitOrigin-RevId: f8438e47446773c220c715c8142279f910c4af35
-
- 25 Jan, 2021 2 commits
-
-
Omid Azizi authored
Summary: Choose the offset based on the OpenSSL version number (currently a simple placeholder--Pete to implement more robust version), and test different OpenSSL versions. Test Plan: Two different nginx servers, one with OpenSSL 1.1.0 and one with OpenSSL 1.1.1 Reviewers: yzhao, jps, #engineering Reviewed By: yzhao, jps, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7165 GitOrigin-RevId: fa4d01146d357c5f5a5ac59589076320a00bd13c
-
Vishal Jain authored
Summary: Added a UDF to convert a pod ip to service id. Test Plan: Unit Test. Reviewers: nserrino, michelle, #engineering, philkuz Reviewed By: #engineering, philkuz Subscribers: vihang JIRA Issues: PP-2311 Differential Revision: https://phab.corp.pixielabs.ai/D7172 GitOrigin-RevId: 4cb9d15947e145db2007192a31792e398e9247ce
-
- 24 Jan, 2021 1 commit
-
-
Vihang Mehta authored
Summary: TSIA. We use GetAll for tracepoints. Depends on D7125 Test Plan: Added tests. Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7166 GitOrigin-RevId: c951bcbf6547ef71c71917e03d4a95c83e6f7f0a
-
- 25 Jan, 2021 2 commits
-
-
Vihang Mehta authored
Summary: TSIA. This will let us filter on the tag for CI as need be. Depends on D7125 Test Plan: N/A Reviewers: nserrino, michelle, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D7171 GitOrigin-RevId: 459a2ac7e56d81a99d0eb4fe53831460eca2b360
-
Vihang Mehta authored
Summary: This seems cleaner since our datastore are basically wrappers and convenience methods to unify different backends. Depends on D7125 Test Plan: Existing tests. Reviewers: nserrino, michelle, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7170 GitOrigin-RevId: bbd3f5a40a5a3e7432a06bcbf6f1cf6e9200f065
-
- 24 Jan, 2021 1 commit
-
-
Vihang Mehta authored
Summary: While this doesn't quite follow the pattern of having the interface implemented at the consumer, it attempts to split up the interface into smaller logical pieces. To avoid test dupe, and to ensure that both implementations behave similarly, I decided to combine the `etcd` and `pebbledb` tests into one test. To run a single test on both implementations, we need a interface for the two datastores. Hence this does the same. Test Plan: Refactored existing tests. Reviewers: nserrino, michelle, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-2376 Differential Revision: https://phab.corp.pixielabs.ai/D7125 GitOrigin-RevId: 311944a8fb67c7753278c8976012758a2ac5e482
-
- 25 Jan, 2021 3 commits
-
-
Nick Lanam authored
Summary: Part number next. Test Plan: No manual testing needed. Coverage improvements. Reviewers: michelle, vihang, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D7173 GitOrigin-RevId: 7a44a710ea81c0462db4a71b0c50d26b0219fa5f
-
Omid Azizi authored
Summary: We need different symbol addresses depending on the OpenSSL version. This diff adds the mechanism by which we can change the symbol addresses used in the uprobe dynamically. Test Plan: Existing tests for now. Will need more tests based on OpenSSL version once things are pieced together. Reviewers: yzhao, jps, #engineering Reviewed By: yzhao, jps, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7160 GitOrigin-RevId: 68890fb972d67dca732c1614f9cd5f51fc21c689
-
Yaxiong Zhao authored
Summary: This helps readers understand the format of the syscall probes. Test Plan: Jenkins Reviewers: jps, oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7150 GitOrigin-RevId: b934a958b208a1c7740d79014ad934937d1f7b88
-
- 23 Jan, 2021 1 commit
-
-
Yaxiong Zhao authored
Summary: For https://pixie-labs.atlassian.net/browse/PP-2400 This should provides the context on why the exception throws. Test Plan: Jenkins Reviewers: jps, oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7163 GitOrigin-RevId: e05a95c56f2047f0f1dd5bff92b7ea75f875865a
-
- 22 Jan, 2021 2 commits
-
-
Natalie Serrino authored
Summary: Depends on D7154. Add a GetTables UDTF to Carnot which calls GetSchemas() in the metadata service (similar to GetTableSchemas()). Test Plan: We didn't have a test for GetTableSchemas, likely due to the fact that that it would need to rely on a mock of the MDS and would likely not add much value beyond the template checks that are done during compilation, so I followed the same pattern here. Reviewers: zasgar, philkuz, #engineering Reviewed By: zasgar, #engineering Subscribers: vjain JIRA Issues: PP-2396 Differential Revision: https://phab.corp.pixielabs.ai/D7155 GitOrigin-RevId: 1d24e0b6bc3611c0d16ef826569d6a41efc15f32
-
Michelle Nguyen authored
Summary: we updated the run command to do so, but never updated `get pem` to use the current context cluster if its available. pulled the logic for doing this out of the `run` command, so that `run` and `get` can both use it. Test Plan: ran CLI `get pem` Reviewers: philkuz, nserrino, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7157 GitOrigin-RevId: eb555be587cd96576b05cb2bd8503e7e779fc442
-
- 25 Jan, 2021 1 commit
-
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: jps, oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7142 GitOrigin-RevId: 924544b02a2ba4e7a304d27164aa9097e2c48926
-
- 24 Jan, 2021 1 commit
-
-
Vihang Mehta authored
Summary: Adds a etcd implementation for use as a KVStore. (Note: This is largely the same as the existing etcd implementation, but done in a clean room to make switching to this easier. Also lines up with the pebbledb implementation to have a common interface). Test Plan: Added unit tests. Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Subscribers: vjain JIRA Issues: PP-2379 Differential Revision: https://phab.corp.pixielabs.ai/D7158 GitOrigin-RevId: e887543a6e412e2476c652c1a952c7da472f7df7
-
- 22 Jan, 2021 1 commit
-
-
Vihang Mehta authored
Summary: This helps the importname not stutter ... it's `pebbledb.DataStore` instead of `pebbledb.PebbleWrapper`. Also set a test size so that the timeout is shorter. Test Plan: Existing tests. Reviewers: michelle, nserrino, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7159 GitOrigin-RevId: a53e745147c0d5e9812b02b24295d5a89640ee7b
-
- 21 Jan, 2021 1 commit
-
-
Omid Azizi authored
Summary: Will make further changes, but clean-up for now. Test Plan: Existing tests. Reviewers: yzhao, jps, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7136 GitOrigin-RevId: 15e7f53de4830f79a25680a69dd8fabee6ce6ec4
-
- 22 Jan, 2021 2 commits
-
-
Zain Asgar authored
Summary: TSIA Test Plan: `go mod tidy`, `make gazelle`, `bazel build //...` Reviewers: michelle, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7161 GitOrigin-RevId: 58420dff9c4a85212412c5214a83014e0344600f
-
Omid Azizi authored
Summary: Noticed stirling was spending quite a bit of time during initialization trying to uprobe itself. By skipping that, we can speed up init time. This means we won't see any SSL traffic traced at Stirling/PEM, but that should be okay, since today we use grpc_cpp, which we don't trace anyways. Test Plan: Manual Reviewers: yzhao, jps, zasgar, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D7135 GitOrigin-RevId: 41934f44bd9d81880fc0b5392b89d44f28a7a9ba
-