This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 27 Jan, 2021 6 commits
    • Michelle Nguyen's avatar
      Add GetClusterConnection to public cloud api · b5a2ade1
      Michelle Nguyen authored
      Summary: we need to expose this to the public api
      
      Test Plan: unit test
      
      Reviewers: zasgar, philkuz, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7199
      
      GitOrigin-RevId: 2c62cfa378de1503d596c4a7b93f73ac0485f071
      b5a2ade1
    • Michelle Nguyen's avatar
      Move uuidpb to public api · a91d3d1d
      Michelle Nguyen authored
      Summary: we need to make this public because we use it in some of our public apis
      
      Test Plan:
      tested by deploying to staging.
      ran old, current vizier release. verified running a query with a uuid col (agent_status) works on skaffold cli and old cli release
      ran vizier with skaffold. verified running a query with with a uuid col works on skaffold cli and old cli release
      
      Reviewers: zasgar, philkuz, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7198
      
      GitOrigin-RevId: f0408c91f436cee101b774a21034760385930e91
      a91d3d1d
    • Phillip Kuznetsov's avatar
      s/Script/ScriptExecutor/g and s/create_script/prepare_script/g · a7e4679e
      Phillip Kuznetsov authored
      Summary: Script wasn't the right term for this. ScriptExecutor makes more sense.
      
      Test Plan: Updated tests and they still work.
      
      Reviewers: zasgar, vihang, #engineering
      
      Reviewed By: zasgar, vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7196
      
      GitOrigin-RevId: d709b88144c6ca20715f354b77ac49dffd03f405
      a7e4679e
    • Phillip Kuznetsov's avatar
      Rename the python library to -> use paths as naming scheme · 8ad3cdd4
      Phillip Kuznetsov authored
      Summary: bazel tends to have generic library target names. You add specificity from the path of the build file. This conforms to that standard.
      
      Test Plan: Tested and al lwork.
      
      Reviewers: zasgar, vihang, #engineering
      
      Reviewed By: zasgar, vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7188
      
      GitOrigin-RevId: 4d846665cc397fd9f6beb8f4a3b1d06ef0ef9b6b
      8ad3cdd4
    • Michelle Nguyen's avatar
      Separate cloud/vizier APIs into public protos · f95105bb
      Michelle Nguyen authored
      Summary:
      Our original cloudapipb and vizierpb protos weren't actually in a state where we could make them public.
      This diff creates new proto files for the protos that we do want to make public.
      The changes are as follows:
      CloudAPI:
      - created new pl.cloudapi.public proto package for our public protos
      - Created ClusterManager, which is a wrapper around the ClusterInfoService. This service excludes unnecessary functions such as creating/updating clusters. Users can GetClusters, which contains a subset of data from the original GetClusterInfo. ClusterManager also contains UpdateClusterConfig, which is a wrapper around the internal UpdateClusterConfig.
      - copied APIKey/DeployKey services to the new public protos. *in the current state, this will break the old CLI, which points to the old API/DeployKey service.* the CLI, which is the only external place which uses these services, has been updated to use the new public proto. is it worth keeping the old service around for users with the old CLI, or should we just ask them to update?
      Vizierpb:
      - Renamed old, internal proto package to `pl.api.internal.vizierpb`, so that the public package can be `pl.api.vizierpb`, in hopes of maintaining backwards compatibility.
      - Copied ExecuteScript/HealthCheck to new public package
      
      Test Plan:
      On Pixie Cloud with new API changes:
      - deployed current release version of Vizier. verify that UI + new & old CLI can still query vizier. with new CLI, debugLog continues to work. with old CLI, debugLog does not work.
      - deployed Vizier using skaffold. verify that UI + new & old CLI can still query vizier. with new CLI, debugLog works. with old CLI, debugLog does not work.
      
      Reviewers: zasgar, philkuz, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7185
      
      GitOrigin-RevId: f01d8a8a2d0d11256c308f3c4dcaf9b1c5a3b763
      f95105bb
    • Phillip Kuznetsov's avatar
      Fix envoy config after key placed in wrong part of config · cf56f4bc
      Phillip Kuznetsov authored
      Summary: I miscopied the config to the wrong part of the file. Had to move it down. Caused proxy to loop-crash on main. Fixed here.
      
      Test Plan: Tested with skaffold.
      
      Reviewers: zasgar, jamesbartlett, vihang, #engineering
      
      Reviewed By: jamesbartlett, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7194
      
      GitOrigin-RevId: a6093fe92459e9806b35e833f9516531567f2fb7
      cf56f4bc
  2. 26 Jan, 2021 12 commits
  3. 25 Jan, 2021 3 commits
  4. 26 Jan, 2021 1 commit
  5. 25 Jan, 2021 2 commits
    • Omid Azizi's avatar
      OpenSSL tracing: Test different version numbers · 3f6f1faf
      Omid Azizi authored
      Summary:
      Choose the offset based on the OpenSSL version number (currently a simple placeholder--Pete to implement more robust version),
      and test different OpenSSL versions.
      
      Test Plan: Two different nginx servers, one with OpenSSL 1.1.0 and one with OpenSSL 1.1.1
      
      Reviewers: yzhao, jps, #engineering
      
      Reviewed By: yzhao, jps, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7165
      
      GitOrigin-RevId: fa4d01146d357c5f5a5ac59589076320a00bd13c
      3f6f1faf
    • Vishal Jain's avatar
      Added UDF to Convert Pod IP to Service ID · 6666d620
      Vishal Jain authored
      Summary: Added a UDF to convert a pod ip to service id.
      
      Test Plan: Unit Test.
      
      Reviewers: nserrino, michelle, #engineering, philkuz
      
      Reviewed By: #engineering, philkuz
      
      Subscribers: vihang
      
      JIRA Issues: PP-2311
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7172
      
      GitOrigin-RevId: 4cb9d15947e145db2007192a31792e398e9247ce
      6666d620
  6. 24 Jan, 2021 1 commit
    • Vihang Mehta's avatar
      Add GetAll to DataStores · f73af753
      Vihang Mehta authored
      Summary:
      TSIA. We use GetAll for tracepoints.
      Depends on D7125
      
      Test Plan: Added tests.
      
      Reviewers: michelle, nserrino, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7166
      
      GitOrigin-RevId: c951bcbf6547ef71c71917e03d4a95c83e6f7f0a
      f73af753
  7. 25 Jan, 2021 2 commits
  8. 24 Jan, 2021 1 commit
    • Vihang Mehta's avatar
      Add a DataStore interface · 04df9b8f
      Vihang Mehta authored
      Summary:
      While this doesn't quite follow the pattern of having the interface implemented at the consumer, it attempts to split up the interface into smaller logical pieces.
      
      To avoid test dupe, and to ensure that both implementations behave similarly, I decided to combine the `etcd` and `pebbledb` tests into one test.
      To run a single test on both implementations, we need a interface for the two datastores. Hence this does the same.
      
      Test Plan: Refactored existing tests.
      
      Reviewers: nserrino, michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      JIRA Issues: PP-2376
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7125
      
      GitOrigin-RevId: 311944a8fb67c7753278c8976012758a2ac5e482
      04df9b8f
  9. 25 Jan, 2021 3 commits
    • Nick Lanam's avatar
      UI Coverage: Live context. · 7f266950
      Nick Lanam authored
      Summary: Part number next.
      
      Test Plan: No manual testing needed. Coverage improvements.
      
      Reviewers: michelle, vihang, #engineering, zasgar
      
      Reviewed By: #engineering, zasgar
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7173
      
      GitOrigin-RevId: 7a44a710ea81c0462db4a71b0c50d26b0219fa5f
      7f266950
    • Omid Azizi's avatar
      OpenSSL tracing: use symaddrs · 746a9296
      Omid Azizi authored
      Summary: We need different symbol addresses depending on the OpenSSL version. This diff adds the mechanism by which we can change the symbol addresses used in the uprobe dynamically.
      
      Test Plan: Existing tests for now. Will need more tests based on OpenSSL version once things are pieced together.
      
      Reviewers: yzhao, jps, #engineering
      
      Reviewed By: yzhao, jps, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7160
      
      GitOrigin-RevId: 68890fb972d67dca732c1614f9cd5f51fc21c689
      746a9296
    • Yaxiong Zhao's avatar
      [CLEANUP] Add syscall signature for syscall probes · e36753c5
      Yaxiong Zhao authored
      Summary: This helps readers understand the format of the syscall probes.
      
      Test Plan: Jenkins
      
      Reviewers: jps, oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7150
      
      GitOrigin-RevId: b934a958b208a1c7740d79014ad934937d1f7b88
      e36753c5
  10. 23 Jan, 2021 1 commit
  11. 22 Jan, 2021 2 commits
    • Natalie Serrino's avatar
      PP-2396 Add GetTables UDTF to Carnot to fetch tables and their descriptions · b59dd2ae
      Natalie Serrino authored
      Summary: Depends on D7154. Add a GetTables UDTF to Carnot which calls GetSchemas() in the metadata service (similar to GetTableSchemas()).
      
      Test Plan: We didn't have a test for GetTableSchemas, likely due to the fact that that it would need to rely on a mock of the MDS and would likely not add much value beyond the template checks that are done during compilation, so I followed the same pattern here.
      
      Reviewers: zasgar, philkuz, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Subscribers: vjain
      
      JIRA Issues: PP-2396
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7155
      
      GitOrigin-RevId: 1d24e0b6bc3611c0d16ef826569d6a41efc15f32
      b59dd2ae
    • Michelle Nguyen's avatar
      Update CLI "get pem" to use current context cluster if available · a0bb5de3
      Michelle Nguyen authored
      Summary:
      we updated the run command to do so, but never updated `get pem` to use the current context cluster if its available.
      pulled the logic for doing this out of the `run` command, so that `run` and `get` can both use it.
      
      Test Plan: ran CLI `get pem`
      
      Reviewers: philkuz, nserrino, #engineering
      
      Reviewed By: nserrino, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7157
      
      GitOrigin-RevId: eb555be587cd96576b05cb2bd8503e7e779fc442
      a0bb5de3
  12. 25 Jan, 2021 1 commit
  13. 24 Jan, 2021 1 commit
    • Vihang Mehta's avatar
      Add etcd implementation · 350c7735
      Vihang Mehta authored
      Summary:
      Adds a etcd implementation for use as a KVStore.
      (Note: This is largely the same as the existing etcd implementation, but done
      in a clean room to make switching to this easier. Also lines up with the pebbledb
      implementation to have a common interface).
      
      Test Plan: Added unit tests.
      
      Reviewers: michelle, nserrino, #engineering
      
      Reviewed By: michelle, #engineering
      
      Subscribers: vjain
      
      JIRA Issues: PP-2379
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7158
      
      GitOrigin-RevId: e887543a6e412e2476c652c1a952c7da472f7df7
      350c7735
  14. 22 Jan, 2021 1 commit
    • Vihang Mehta's avatar
      Minor fixes to pebbledb impl · 19cf2147
      Vihang Mehta authored
      Summary:
      This helps the importname not stutter ... it's `pebbledb.DataStore`
      instead of `pebbledb.PebbleWrapper`.
      Also set a test size so that the timeout is shorter.
      
      Test Plan: Existing tests.
      
      Reviewers: michelle, nserrino, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7159
      
      GitOrigin-RevId: a53e745147c0d5e9812b02b24295d5a89640ee7b
      19cf2147
  15. 21 Jan, 2021 1 commit
    • Omid Azizi's avatar
      DeployUprobes clean-up · 5fa76f01
      Omid Azizi authored
      Summary: Will make further changes, but clean-up for now.
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, jps, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7136
      
      GitOrigin-RevId: 15e7f53de4830f79a25680a69dd8fabee6ce6ec4
      5fa76f01
  16. 22 Jan, 2021 2 commits
    • Zain Asgar's avatar
      Fix warnings around Sirupsen and sirupsen in go mod · 244a7d7b
      Zain Asgar authored
      Summary: TSIA
      
      Test Plan: `go mod tidy`, `make gazelle`, `bazel build //...`
      
      Reviewers: michelle, vihang, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7161
      
      GitOrigin-RevId: 58420dff9c4a85212412c5214a83014e0344600f
      244a7d7b
    • Omid Azizi's avatar
      Oh Stirling, please don't try to uprobe yourself · 3d775590
      Omid Azizi authored
      Summary:
      Noticed stirling was spending quite a bit of time during initialization trying to uprobe itself.
      
      By skipping that, we can speed up init time.
      
      This means we won't see any SSL traffic traced at Stirling/PEM, but that should be okay, since today we use grpc_cpp, which we don't trace anyways.
      
      Test Plan: Manual
      
      Reviewers: yzhao, jps, zasgar, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D7135
      
      GitOrigin-RevId: 41934f44bd9d81880fc0b5392b89d44f28a7a9ba
      3d775590