This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 10 Dec, 2020 7 commits
    • Michelle Nguyen's avatar
      PC-701 Move tour overlay out of profile menu button · 89d66619
      Michelle Nguyen authored
      Summary:
      currently whenever you click the tour overlay, it keeps opening the profile menu.
      this is because the tour dialog is nested in the profile menu. it doesnt need to be, so this diff moves it out
      
      Test Plan: ran yarn dev
      
      Reviewers: zasgar, nserrino, vihang, philkuz, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6917
      
      GitOrigin-RevId: 06a6079b5b5b38af663e5e20e9feef90a1be31ff
      89d66619
    • Phillip Kuznetsov's avatar
      Fix deployment spec in tracepoint · bbb2df09
      Phillip Kuznetsov authored
      Summary: deployment spec shouldn't be set for kprobes
      
      Test Plan: tested and works
      
      Reviewers: yzhao, oazizi, jamesbartlett, #engineering
      
      Reviewed By: yzhao, oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6916
      
      GitOrigin-RevId: 3d5942544d03c3ab1351e91dee4a0fe12f4f1c4a
      bbb2df09
    • Omid Azizi's avatar
      [Cleanup] Remove unnecessary CurrentTime() · 2f347a08
      Omid Azizi authored
      Summary: Unnecessary level of indirection
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, jps, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6907
      
      GitOrigin-RevId: 9a6c6ee44ed20a364baa713f8b17b4df7cd7e9a1
      2f347a08
    • Nick Lanam's avatar
      Do not overflow table headers in data drawer · 03699433
      Nick Lanam authored
      Summary: One line of CSS ahoy
      
      Test Plan: Open the data drawer for a scrupt that produces enough columns to overflow, such as `px/http_data`. The header row should no longer grow outside of its container.
      
      Reviewers: nserrino, michelle, vihang, #engineering
      
      Reviewed By: michelle, vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6913
      
      GitOrigin-RevId: 7ce23757de5dfc9b5dfe4208f19e2b8325913194
      03699433
    • Omid Azizi's avatar
      Revamp proc_path_tools for CPU optimization · abbb4f2a
      Omid Azizi authored
      Summary:
      This completes the transition to the new FilePathResolver, and removes the old model from our code.
      
      The new model is considerably more efficient any time > 1 path resolutions are executed (and is no less efficient when number of resolutions == 1).
      
      The new model makes fewer accesses to /proc, which is where the efficiency gains come from, since /proc accesses can be very slow.
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6878
      
      GitOrigin-RevId: d3670c316bf3d69b4759e32ddeb637a4d670f75a
      abbb4f2a
    • Michelle Nguyen's avatar
      Reduce sentry errors · 6bd72a8d
      Michelle Nguyen authored
      Summary:
      these errors are logging way too often and have completely overwhelmed our sentry quota.
      most of these are for stats, which are not crucial for functionality, so i am just removing the logs.
      
      Test Plan: n/a
      
      Reviewers: zasgar, nserrino, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6910
      
      GitOrigin-RevId: 0a3d148533d73a36642d1eeadf80409b1b4aa992
      6bd72a8d
    • Michelle Nguyen's avatar
      Fix gql caching of userinfo · a0d73779
      Michelle Nguyen authored
      Summary: we added id to the field, and this requires id to be added in all the other userInfo fetches or else the cache is unhappy
      
      Test Plan: n/a
      
      Reviewers: zasgar, nserrino, philkuz, #engineering
      
      Reviewed By: philkuz, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6909
      
      GitOrigin-RevId: dcc3d081c564cccb64fb294f05ae853e0f6bb8fc
      a0d73779
  2. 09 Dec, 2020 1 commit
  3. 10 Dec, 2020 2 commits
    • Vihang Mehta's avatar
      golang log filename and linenumber · 5ffa2ed1
      Vihang Mehta authored
      Summary:
      Configure logrus to also log the filename and line number of the log
      message. This makes it easier to track down errors.
      We need to update logrus to get this flag to report the actual file (otherwise
      it reports the logrus/entry.go) on go `v1.14+`
      The prefixed formatter also hasn't been updated in 3 years and doesn't support
      logging filename and linenumber so just remove it. `pixie-cloud` logs still look sane.
      
      This has a perf penalty but hopefully it's not bad enough to be a problem for us.
      
      Test Plan: Deploy pixie cloud and look at logs for various services.
      
      Reviewers: zasgar, michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6903
      
      GitOrigin-RevId: d9660b684270ea1781f5bd988e92be771119c1dc
      5ffa2ed1
    • Michelle Nguyen's avatar
      Update segment identify tracking · ed1cb38e
      Michelle Nguyen authored
      Summary:
      we're seeing some issues on fullstory (powered by our segment events), where users are not correctly getting matches to an email address.
      this means that our identify calls are not properly working in some cases.
      segment recommends to trigger identify calls:
      - on sign up (this needed to be updated. similar to login, we need to wait for the segment events to be sent before redirect)
      - on login (this was already done)
      - recommended: on any pages which the user must be logged into to view. usually login/signup is enough, but in the case where users close the browser, it is better to just resend the identify.
      - on logout: we should reset the analytics to prevent any confusion.
      
      Test Plan: deployed to staging and checked the segment events debugger to make sure the events are correctly sent
      
      Reviewers: zasgar, nick, vihang, nserrino, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6901
      
      GitOrigin-RevId: 0ec138414d2f1d98f3de0cc1e7a0067decd5dcb1
      ed1cb38e
  4. 09 Dec, 2020 1 commit
  5. 10 Dec, 2020 1 commit
  6. 09 Dec, 2020 7 commits
  7. 08 Dec, 2020 1 commit
    • Phillip Kuznetsov's avatar
      Updating support for multiple tracepoints on the same target by cleaning up... · 400d3a1c
      Phillip Kuznetsov authored
      Updating support for multiple tracepoints on the same target by cleaning up mutations data structures
      
      Summary:
        We used to store a mapping of the tracepoint targets to the tracepoints for those targets. For each
        type of target, we had a separate map. I considered two alternatives could be used for these data
        structures:
        1. (Chosen approach) Vector of DeploymentSpec,TracepointDeployment pairs
           a. Lose uniqueness of DeploymentSpecs
               * We don't really have a need for uniqueness constraints anymore. We had some desire for
               it before but I think it's not necessary.
           b. Gain simplicity of writing out protobufs, pay for complexity in the special API which we
              already pay for, honestly looks pretty good.
        2. Single map w/ a unified key of UPID, SharedObject, etc.
           a. Could use DeploymentSpec protobuf message, but not guaranteed to be great keys
              (https://developers.google.com/protocol-buffers/docs/encoding#implications)
           b. Could make a new key that contains all of the fields, but might be a lot of work and more
           complex than separate maps.
      
      Test Plan: updated tests to support the multiple tracepoints
      
      Reviewers: nserrino, jamesbartlett, oazizi, yzhao, #engineering
      
      Reviewed By: jamesbartlett, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6892
      
      GitOrigin-RevId: 02e618b5e910fadcd5e67ad7a209f7f4a1822995
      400d3a1c
  8. 09 Dec, 2020 2 commits
    • Vihang Mehta's avatar
      Get rid of the deps_only flag · b26017a5
      Vihang Mehta authored
      Summary: This does nothing and causes `px deploy` to just hang.
      
      Test Plan: N/A
      
      Reviewers: michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6894
      
      GitOrigin-RevId: 069cff7cc91fff797cb7eef824aad3d6e27be8f7
      b26017a5
    • Vihang Mehta's avatar
      Make etcd not rely on dns resolution · 814da203
      Vihang Mehta authored
      Summary:
      We were having issues with `etcd` running on `minikube` `v1.13.0+`
      The dns resolution for `etcd-0.etcd` would fail causing `etcd` to crashloop.
      
      Since we only run a single replica of `etcd` and are working towards completely getting rid of it, let's just clean this up and get it working.
      
      Test Plan:
      Deploy pixie on a `minikube v1.15.1` cluster. `etcd` fails to run.
      Delete the `etcd` stateful set and apply this new config. `etcd` succeeds.
      
      Reviewers: michelle, oazizi, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6893
      
      GitOrigin-RevId: cfe628b2dc2823edaf08049f9c9d40e3986936d2
      814da203
  9. 08 Dec, 2020 1 commit
    • Nick Lanam's avatar
      Fix cancel button for tracepoint deployment · 5f71ad20
      Nick Lanam authored
      Summary: Not the first bug that came from having to make a fix in both the mutation and normal path. I'll be putting some thought into a more maintainable structure for this file; the behavior is already what we want.
      
      Test Plan: Try to cancel tracepoints being deployed. `tcp_drops` is a good example, and renaming the UpsertTracepoint parameter is sufficient to force it to deploy new tracepoints/see the dialog again.
      
      Reviewers: nserrino, michelle, vihang, #engineering
      
      Reviewed By: nserrino, michelle, #engineering
      
      JIRA Issues: PC-694
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6890
      
      GitOrigin-RevId: 9bbc53fcd4c6da47529d350e75b6a5571c6b7a66
      5f71ad20
  10. 07 Dec, 2020 1 commit
    • Michelle Nguyen's avatar
      PC-687 Track cluster uptime metrics on Segment · 52bad346
      Michelle Nguyen authored
      Summary:
      we want to track user's cluster level uptime to help manage customer expectations and track basic cluster-level metrics.
      this diff will track a segment event everytime a cluster's status changes.
      
      Test Plan: deployed in staging and looked @ segment debugger
      
      Reviewers: zasgar, #engineering, vihang
      
      Reviewed By: #engineering, vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6885
      
      GitOrigin-RevId: b8b7acafb7faaafd60d14dcbe56de04451fb5b78
      52bad346
  11. 08 Dec, 2020 1 commit
  12. 07 Dec, 2020 1 commit
  13. 24 Nov, 2020 1 commit
    • Yaxiong Zhao's avatar
      Simplify code places for adding new protocols · 80a86872
      Yaxiong Zhao authored
      Summary:
      Remove the need to update connection_tracker_test.cc
      Created a new header src/stirling/protocols/stitchers.h to include all headers for the
      StitchFrames() template specializations.
      
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6863
      
      GitOrigin-RevId: e85e0bfbb81f79af579f18aaf2fd5251fe4f489b
      80a86872
  14. 08 Dec, 2020 3 commits
    • Nick Lanam's avatar
      User settings support in the UI · e228f6ab
      Nick Lanam authored
      Summary: This specifies the available settings (currently just one - whether the tour has been seen) and makes them available for read/write. Accessed via React hook.
      
      Test Plan: Unit tests only right now. The next change for this will add a use for the `tourSeen` setting to show the tour once to each new user.
      
      Reviewers: nserrino, michelle, vihang, #engineering
      
      Reviewed By: nserrino, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6888
      
      GitOrigin-RevId: 91dbc658d85abf0a7b9dfa351f283813ac04b399
      e228f6ab
    • Omid Azizi's avatar
      Fix bazel build warning · dd0eb8ec
      Omid Azizi authored
      Summary: Cleaning up a warning that @jps ran identified.
      
      Test Plan: Jenkins
      
      Reviewers: jps, #engineering
      
      Reviewed By: jps
      
      Subscribers: jps
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6887
      
      GitOrigin-RevId: 14fc2da0557223c11c224c53ad13492137c08a76
      dd0eb8ec
    • Omid Azizi's avatar
      [Cleanup] java.h: Refactor common code · 901177f4
      Omid Azizi authored
      Summary:
      Same pattern appears twice between java.cc and jvm_stats_connector.cc. Refactor to share the code.
      
      There is some potential for optimization here. That's coming in subsequent diffs.
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6862
      
      GitOrigin-RevId: c17ee324bea0ee311c170ba707c90c6bf6150971
      901177f4
  15. 07 Dec, 2020 4 commits
  16. 24 Nov, 2020 1 commit
    • Vihang Mehta's avatar
      Kill fluentbit · 51b698d0
      Vihang Mehta authored
      Summary: Remove fluentbit since we now rely on `px debug log`
      
      Test Plan:
      Ran vizier using skaffold, ensured that `px debug log` still worked.
      Trying to run cloud using skaffold to verify it works too.
      
      Reviewers: zasgar, michelle, jamesbartlett, #engineering
      
      Reviewed By: michelle, #engineering
      
      JIRA Issues: PP-2317
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6861
      
      GitOrigin-RevId: 147537b5fc145b73fa080615528b27702f056697
      51b698d0
  17. 26 Nov, 2020 1 commit
  18. 24 Nov, 2020 2 commits
    • Michelle Nguyen's avatar
      Implement usersettings gql resolver · 6ce51aa9
      Michelle Nguyen authored
      Summary: this diff implements the actual graphql resolver for getting/updating userSettings.
      
      Test Plan: unit tests, ran cloud dev and verified making gql requests from the UI worked as expected
      
      Reviewers: nick, vihang, nserrino, zasgar, #engineering
      
      Reviewed By: nick, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6858
      
      GitOrigin-RevId: 1eaccbc16738c77a74e082af0717d74cd9e0a9bf
      6ce51aa9
    • Michelle Nguyen's avatar
      Update profile service to handle Get/UpdateUserSettings · 197fb2ea
      Michelle Nguyen authored
      Summary:
      we are adding user settings in our backend, so that we can use usersettings to determine whether or not to show the onboarding overlay.
      this part updates the profile service to handle getting/updating user settings.
      this diff:
      - updates the profile proto with the new rpc methods
      - updates the profile server to handle the new rpc calls
      - updates profile datastore to actually get/update the values in the db
      
      the last part in the backend is to update the API service to make this call to the profile service.
      
      Test Plan: unit tests
      
      Reviewers: vihang, nserrino, nick, zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6849
      
      GitOrigin-RevId: 649b956e68125348c3cd6e32ce50d65d4d2c40f5
      197fb2ea
  19. 05 Dec, 2020 2 commits