This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 10 Dec, 2020 7 commits
-
-
Michelle Nguyen authored
Summary: currently whenever you click the tour overlay, it keeps opening the profile menu. this is because the tour dialog is nested in the profile menu. it doesnt need to be, so this diff moves it out Test Plan: ran yarn dev Reviewers: zasgar, nserrino, vihang, philkuz, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6917 GitOrigin-RevId: 06a6079b5b5b38af663e5e20e9feef90a1be31ff
-
Phillip Kuznetsov authored
Summary: deployment spec shouldn't be set for kprobes Test Plan: tested and works Reviewers: yzhao, oazizi, jamesbartlett, #engineering Reviewed By: yzhao, oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6916 GitOrigin-RevId: 3d5942544d03c3ab1351e91dee4a0fe12f4f1c4a
-
Omid Azizi authored
Summary: Unnecessary level of indirection Test Plan: Existing tests. Reviewers: yzhao, jps, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6907 GitOrigin-RevId: 9a6c6ee44ed20a364baa713f8b17b4df7cd7e9a1
-
Nick Lanam authored
Summary: One line of CSS ahoy Test Plan: Open the data drawer for a scrupt that produces enough columns to overflow, such as `px/http_data`. The header row should no longer grow outside of its container. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: michelle, vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6913 GitOrigin-RevId: 7ce23757de5dfc9b5dfe4208f19e2b8325913194
-
Omid Azizi authored
Summary: This completes the transition to the new FilePathResolver, and removes the old model from our code. The new model is considerably more efficient any time > 1 path resolutions are executed (and is no less efficient when number of resolutions == 1). The new model makes fewer accesses to /proc, which is where the efficiency gains come from, since /proc accesses can be very slow. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6878 GitOrigin-RevId: d3670c316bf3d69b4759e32ddeb637a4d670f75a
-
Michelle Nguyen authored
Summary: these errors are logging way too often and have completely overwhelmed our sentry quota. most of these are for stats, which are not crucial for functionality, so i am just removing the logs. Test Plan: n/a Reviewers: zasgar, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6910 GitOrigin-RevId: 0a3d148533d73a36642d1eeadf80409b1b4aa992
-
Michelle Nguyen authored
Summary: we added id to the field, and this requires id to be added in all the other userInfo fetches or else the cache is unhappy Test Plan: n/a Reviewers: zasgar, nserrino, philkuz, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6909 GitOrigin-RevId: dcc3d081c564cccb64fb294f05ae853e0f6bb8fc
-
- 09 Dec, 2020 1 commit
-
-
Omid Azizi authored
Summary: We access proc too much. Restructuring things a bit to avoid duplicate work. Profiling shows jvm_stats_connector goes from 18% of total app cycles to 5% of total app cycles. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6865 GitOrigin-RevId: 33feb5bde3da641352839f3ffeff1f17e314ef6e
-
- 10 Dec, 2020 2 commits
-
-
Vihang Mehta authored
Summary: Configure logrus to also log the filename and line number of the log message. This makes it easier to track down errors. We need to update logrus to get this flag to report the actual file (otherwise it reports the logrus/entry.go) on go `v1.14+` The prefixed formatter also hasn't been updated in 3 years and doesn't support logging filename and linenumber so just remove it. `pixie-cloud` logs still look sane. This has a perf penalty but hopefully it's not bad enough to be a problem for us. Test Plan: Deploy pixie cloud and look at logs for various services. Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6903 GitOrigin-RevId: d9660b684270ea1781f5bd988e92be771119c1dc
-
Michelle Nguyen authored
Summary: we're seeing some issues on fullstory (powered by our segment events), where users are not correctly getting matches to an email address. this means that our identify calls are not properly working in some cases. segment recommends to trigger identify calls: - on sign up (this needed to be updated. similar to login, we need to wait for the segment events to be sent before redirect) - on login (this was already done) - recommended: on any pages which the user must be logged into to view. usually login/signup is enough, but in the case where users close the browser, it is better to just resend the identify. - on logout: we should reset the analytics to prevent any confusion. Test Plan: deployed to staging and checked the segment events debugger to make sure the events are correctly sent Reviewers: zasgar, nick, vihang, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6901 GitOrigin-RevId: 0ec138414d2f1d98f3de0cc1e7a0067decd5dcb1
-
- 09 Dec, 2020 1 commit
-
-
Vihang Mehta authored
Summary: This makes it a bit more clear as to whether connecting to NATS or STAN is failing. Test Plan: N/A Reviewers: michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6904 GitOrigin-RevId: e1ac5dc28bc0ad9175e7188b472cc76873485dd7
-
- 10 Dec, 2020 1 commit
-
-
Nick Lanam authored
Summary: Oops. Not the first time I forgot to check this one. Test Plan: Admin page should stop whitescreening Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: michelle, #engineering JIRA Issues: PC-651 Differential Revision: https://phab.corp.pixielabs.ai/D6905 GitOrigin-RevId: dec806f40ae825a65d735cd66b7950be018facf0
-
- 09 Dec, 2020 7 commits
-
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6896 GitOrigin-RevId: 8982e3f2ec63d06c324706a59ac69305349b5e31
-
Yaxiong Zhao authored
Summary: With this, px/schemas no longer show redis_table. Test Plan: Jenkins Reviewers: oazizi, htroisi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6897 GitOrigin-RevId: 2a73c6cd798a3fc46928e7fd17e530e858dc1d19
-
Omid Azizi authored
Summary: Reduced the original diff. Now is just mostly clean-up. BPF map leak is already protected by ConnInfoMapManager. Test Plan: Existing tests Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D4453 GitOrigin-RevId: 7788ded55bf8a7ba4852f57ec86ff91608fb42fa
-
Michelle Nguyen authored
Summary: we need to add a little disclaimer on the signup page, similar to: https://newrelic.com/signup Test Plan: screenshot: {F106776} Reviewers: nick, vihang, nserrino, zasgar, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6902 GitOrigin-RevId: 1621c628603fd07becc337fe2c151fc7d154e0de
-
Nick Lanam authored
Summary: Self-explanatory Test Plan: Disable the `tourOpen` boolean user setting in any way you like, log out, log in fresh, you should no longer see both the tour and command input at the same time (the tour overrides the command input). Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: michelle, #engineering JIRA Issues: PC-651 Differential Revision: https://phab.corp.pixielabs.ai/D6900 GitOrigin-RevId: 6ca3f8a377d008a8d09b4cbe6b55e96dee1eb246
-
Nick Lanam authored
Summary: This waits for a user setting to load, and if it sees that the user has never seen the tour, it marks that flag and shows them the tour. It will not do this again unless something clears that setting - you'll need to use a debugger to reset it for now. In the future when we offer a settings dialog for other preferences, a button can exist there to reset any tours/tips/etc. Test Plan: Open the frontend and note that the tour modal appears fairly quickly by itself - but only ever does this once. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: michelle, #engineering JIRA Issues: PC-651 Differential Revision: https://phab.corp.pixielabs.ai/D6898 GitOrigin-RevId: 4dfe877a0c44d870563e5c0c80df7442672bb4d9
-
Nick Lanam authored
Summary: We prefer `PxL` as the title casing for Pixie scripts. Test Plan: Open the editor. Left tab title. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6895 GitOrigin-RevId: fae9f099efbf81654153f4fc178581dd79b648e6
-
- 08 Dec, 2020 1 commit
-
-
Phillip Kuznetsov authored
Updating support for multiple tracepoints on the same target by cleaning up mutations data structures Summary: We used to store a mapping of the tracepoint targets to the tracepoints for those targets. For each type of target, we had a separate map. I considered two alternatives could be used for these data structures: 1. (Chosen approach) Vector of DeploymentSpec,TracepointDeployment pairs a. Lose uniqueness of DeploymentSpecs * We don't really have a need for uniqueness constraints anymore. We had some desire for it before but I think it's not necessary. b. Gain simplicity of writing out protobufs, pay for complexity in the special API which we already pay for, honestly looks pretty good. 2. Single map w/ a unified key of UPID, SharedObject, etc. a. Could use DeploymentSpec protobuf message, but not guaranteed to be great keys (https://developers.google.com/protocol-buffers/docs/encoding#implications) b. Could make a new key that contains all of the fields, but might be a lot of work and more complex than separate maps. Test Plan: updated tests to support the multiple tracepoints Reviewers: nserrino, jamesbartlett, oazizi, yzhao, #engineering Reviewed By: jamesbartlett, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6892 GitOrigin-RevId: 02e618b5e910fadcd5e67ad7a209f7f4a1822995
-
- 09 Dec, 2020 2 commits
-
-
Vihang Mehta authored
Summary: This does nothing and causes `px deploy` to just hang. Test Plan: N/A Reviewers: michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6894 GitOrigin-RevId: 069cff7cc91fff797cb7eef824aad3d6e27be8f7
-
Vihang Mehta authored
Summary: We were having issues with `etcd` running on `minikube` `v1.13.0+` The dns resolution for `etcd-0.etcd` would fail causing `etcd` to crashloop. Since we only run a single replica of `etcd` and are working towards completely getting rid of it, let's just clean this up and get it working. Test Plan: Deploy pixie on a `minikube v1.15.1` cluster. `etcd` fails to run. Delete the `etcd` stateful set and apply this new config. `etcd` succeeds. Reviewers: michelle, oazizi, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6893 GitOrigin-RevId: cfe628b2dc2823edaf08049f9c9d40e3986936d2
-
- 08 Dec, 2020 1 commit
-
-
Nick Lanam authored
Summary: Not the first bug that came from having to make a fix in both the mutation and normal path. I'll be putting some thought into a more maintainable structure for this file; the behavior is already what we want. Test Plan: Try to cancel tracepoints being deployed. `tcp_drops` is a good example, and renaming the UpsertTracepoint parameter is sufficient to force it to deploy new tracepoints/see the dialog again. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: nserrino, michelle, #engineering JIRA Issues: PC-694 Differential Revision: https://phab.corp.pixielabs.ai/D6890 GitOrigin-RevId: 9bbc53fcd4c6da47529d350e75b6a5571c6b7a66
-
- 07 Dec, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: we want to track user's cluster level uptime to help manage customer expectations and track basic cluster-level metrics. this diff will track a segment event everytime a cluster's status changes. Test Plan: deployed in staging and looked @ segment debugger Reviewers: zasgar, #engineering, vihang Reviewed By: #engineering, vihang Differential Revision: https://phab.corp.pixielabs.ai/D6885 GitOrigin-RevId: b8b7acafb7faaafd60d14dcbe56de04451fb5b78
-
- 08 Dec, 2020 1 commit
-
-
Omid Azizi authored
Summary: Be explicit about kvm2 Test Plan: Ran it. Reviewers: yzhao, jps, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6891 GitOrigin-RevId: a36da2a6eea0f5c3e168dfde88883bf1b4e306bd
-
- 07 Dec, 2020 1 commit
-
-
Vihang Mehta authored
Summary: TSIA. components belong in workspaces/pixie-components, other things are not components Test Plan: `yarn dev` Reviewers: michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6884 GitOrigin-RevId: ee79f926d2e007dbec135e59930c9a84eb7c1d5b
-
- 24 Nov, 2020 1 commit
-
-
Yaxiong Zhao authored
Summary: Remove the need to update connection_tracker_test.cc Created a new header src/stirling/protocols/stitchers.h to include all headers for the StitchFrames() template specializations. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6863 GitOrigin-RevId: e85e0bfbb81f79af579f18aaf2fd5251fe4f489b
-
- 08 Dec, 2020 3 commits
-
-
Nick Lanam authored
Summary: This specifies the available settings (currently just one - whether the tour has been seen) and makes them available for read/write. Accessed via React hook. Test Plan: Unit tests only right now. The next change for this will add a use for the `tourSeen` setting to show the tour once to each new user. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6888 GitOrigin-RevId: 91dbc658d85abf0a7b9dfa351f283813ac04b399
-
Omid Azizi authored
Summary: Cleaning up a warning that @jps ran identified. Test Plan: Jenkins Reviewers: jps, #engineering Reviewed By: jps Subscribers: jps Differential Revision: https://phab.corp.pixielabs.ai/D6887 GitOrigin-RevId: 14fc2da0557223c11c224c53ad13492137c08a76
-
Omid Azizi authored
Summary: Same pattern appears twice between java.cc and jvm_stats_connector.cc. Refactor to share the code. There is some potential for optimization here. That's coming in subsequent diffs. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6862 GitOrigin-RevId: c17ee324bea0ee311c170ba707c90c6bf6150971
-
- 07 Dec, 2020 4 commits
-
-
Phillip Kuznetsov authored
Fix error reporting in agg tuples to CreateError() instead of trying to call node()->CreateError() which might yield a segfault Summary: @jamesbartlett found this error, I'm fixing it now. If you swapped function with column name in aggs, this error would be triggered. Test Plan: Added a test and fixed the problem Reviewers: jamesbartlett, #engineering, vihang Reviewed By: jamesbartlett, #engineering, vihang Subscribers: jamesbartlett Differential Revision: https://phab.corp.pixielabs.ai/D6886 GitOrigin-RevId: c338c8095ef598cd7b1d3ecd8782927b46eff5b3
-
Yaxiong Zhao authored
Summary: Changing this file wont trigger bpf tests; so have this as a compromise. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6835 GitOrigin-RevId: bc943bd3c66973184954ce87933c9f4d89819f41
-
Omid Azizi authored
Summary: Move table definition to own header file, for consistency. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Subscribers: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6880 GitOrigin-RevId: e9b375b905405ce4999b7d3a6fd89b1fcc23a154
-
Yaxiong Zhao authored
Summary: Added an overloaded version of BinaryDecoder::ExtractStringUntil() to accept string_view and pointer. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6844 GitOrigin-RevId: 1ae3265896503229e9ab5e3bed5112ffc9146c54
-
- 24 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: Remove fluentbit since we now rely on `px debug log` Test Plan: Ran vizier using skaffold, ensured that `px debug log` still worked. Trying to run cloud using skaffold to verify it works too. Reviewers: zasgar, michelle, jamesbartlett, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-2317 Differential Revision: https://phab.corp.pixielabs.ai/D6861 GitOrigin-RevId: 147537b5fc145b73fa080615528b27702f056697
-
- 26 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: For consistency (and less macro use). Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6879 GitOrigin-RevId: ca5b5e7dd01183d1c5db19132a991d9527dc036a
-
- 24 Nov, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: this diff implements the actual graphql resolver for getting/updating userSettings. Test Plan: unit tests, ran cloud dev and verified making gql requests from the UI worked as expected Reviewers: nick, vihang, nserrino, zasgar, #engineering Reviewed By: nick, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6858 GitOrigin-RevId: 1eaccbc16738c77a74e082af0717d74cd9e0a9bf
-
Michelle Nguyen authored
Summary: we are adding user settings in our backend, so that we can use usersettings to determine whether or not to show the onboarding overlay. this part updates the profile service to handle getting/updating user settings. this diff: - updates the profile proto with the new rpc methods - updates the profile server to handle the new rpc calls - updates profile datastore to actually get/update the values in the db the last part in the backend is to update the API service to make this call to the profile service. Test Plan: unit tests Reviewers: vihang, nserrino, nick, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6849 GitOrigin-RevId: 649b956e68125348c3cd6e32ce50d65d4d2c40f5
-
- 05 Dec, 2020 2 commits
-
-
Vihang Mehta authored
Summary: It seems like this was used by the code-snippet component which was removed in D5277 Test Plan: `yarn dev` Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6882 GitOrigin-RevId: 9fe87d0faa906e116c2248a001241693b25175a0
-
Omid Azizi authored
Summary: Removing unnecessary links and updating some comments. Test Plan: Existing tests Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6881 GitOrigin-RevId: 39d710a6ae0f27a67d743cdb5eb60b2d5c2a27cf
-