This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 24 Nov, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: this diff implements the actual graphql resolver for getting/updating userSettings. Test Plan: unit tests, ran cloud dev and verified making gql requests from the UI worked as expected Reviewers: nick, vihang, nserrino, zasgar, #engineering Reviewed By: nick, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6858 GitOrigin-RevId: 1eaccbc16738c77a74e082af0717d74cd9e0a9bf
-
Michelle Nguyen authored
Summary: we are adding user settings in our backend, so that we can use usersettings to determine whether or not to show the onboarding overlay. this part updates the profile service to handle getting/updating user settings. this diff: - updates the profile proto with the new rpc methods - updates the profile server to handle the new rpc calls - updates profile datastore to actually get/update the values in the db the last part in the backend is to update the API service to make this call to the profile service. Test Plan: unit tests Reviewers: vihang, nserrino, nick, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6849 GitOrigin-RevId: 649b956e68125348c3cd6e32ce50d65d4d2c40f5
-
- 05 Dec, 2020 2 commits
-
-
Vihang Mehta authored
Summary: It seems like this was used by the code-snippet component which was removed in D5277 Test Plan: `yarn dev` Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6882 GitOrigin-RevId: 9fe87d0faa906e116c2248a001241693b25175a0
-
Omid Azizi authored
Summary: Removing unnecessary links and updating some comments. Test Plan: Existing tests Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6881 GitOrigin-RevId: 39d710a6ae0f27a67d743cdb5eb60b2d5c2a27cf
-
- 06 Dec, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: updated the comments, since this is heavily modified from the version referenced on stack overflow. updated some variable names Test Plan: n/a Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6883 GitOrigin-RevId: 53a352b4405f28d82690e21559cf080a963a01b3
-
- 25 Nov, 2020 12 commits
-
-
Vihang Mehta authored
Summary: We don't actually depend on `highlight.js` directly, so don't install it. Upgrade `@storybook/*` deps so that they pickup newer `highlight.js` Test Plan: `yarn dev` and `yarn storybook` in pixie-components Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Subscribers: nick Differential Revision: https://phab.corp.pixielabs.ai/D6869 GitOrigin-RevId: 406b86857320a80a803555c5af26c151ffcacd24
-
Omid Azizi authored
Summary: No point in having different elf_tools/dwarf_tools namespaces. Plus it matches directory structure now. Test Plan: Existing tests Reviewers: yzhao, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6877 GitOrigin-RevId: a14e9d2d688bf4c16673ef18090221ac16724753
-
Vihang Mehta authored
Summary: This adds `cc_library` and `cc_proto_library` rules to lsif-clang Also cleans up some code dupe in the upload script and hides the sourcegraph credentials. Test Plan: Run on jenkins Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6876 GitOrigin-RevId: 50518269806e8d219836797155e3b5eca4ded574
-
Vihang Mehta authored
Summary: `pixie-components` only uses webpack transitively as part of `@storybook` Since storybook uses webpack4, it needs the older version of `html-webpack-plugin` I think I force resolved this because I was doing the webpack 5 upgrade while the stories were in `src/ui` and concurrently was moving stories into `pixie-components` in a separate diff. Not moving stories required this resolution to happen, moving the stories, make the stories made the resolution unstable. Test Plan: `yarn storybook` works in pixie components again. Reviewers: nick, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6874 GitOrigin-RevId: 5b17e9073ff74b64780dc088b58b8f7f831c3d2a
-
Vihang Mehta authored
Summary: TSIA Depends on D6872 Test Plan: Run it locally Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6875 GitOrigin-RevId: 8600371e98168210f51e557108a92d0774f93767
-
Zain Asgar authored
Summary: LSIF is used for language server features. Test Plan: N/A Reviewers: vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6872 GitOrigin-RevId: 0903de83194c8906824071f6818db5052dcf7c3d
-
Zain Asgar authored
Summary: The files are used for cc_library but not actually used standalone. I think this is actually an issue, but we can work on a better fix. Actually there is probably a cleaner way to accomplish what we are doing with the inl files. Test Plan: Existing + clang-lsif Reviewers: vihang, philkuz, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6873 GitOrigin-RevId: b76c5594048be36b4bd5110816c4e402739cbb5f
-
Vihang Mehta authored
Summary: TSIA Test Plan: N/A Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6871 GitOrigin-RevId: dd30a0792af5b1e8f6dbf1c3dfbb5e88364ab7c1
-
Vihang Mehta authored
Summary: This was used by proc_tracer_bpf_test but didn't get deleted in D6367 Test Plan: N/A Reviewers: oazizi, yzhao, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6870 GitOrigin-RevId: f821982e3e82eba54ba9d298d1b26227aa1ead6a
-
Michelle Nguyen authored
Summary: cancel being null is causing a white screen when navigating to this page Test Plan: ran yarn dev Reviewers: nick, nserrino, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6866 GitOrigin-RevId: 9822f97991d372362106937f9aef7f1ab3519451
-
Michelle Nguyen authored
Summary: I accidentally introduced a flaky test, because of the ordering of maps change. We should just compare the actual pb rather than the unmarshalled bytes Test Plan: ran the test 1000 times Reviewers: nserrino, zasgar, vihang, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6867 GitOrigin-RevId: 30c85cf6d727651e9c6df6cdc620c8d563968d58
-
Vihang Mehta authored
Summary: TSIA. This will collect and upload lsif data for `go` and `typescript` Test Plan: Jenkins Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6868 GitOrigin-RevId: f6ddce988ac926a5f2b79fc809028143e9f91983
-
- 23 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: Store some information when the connector is created, so that repeated calls to GetUPIDs() doesn't do a bunch of extra work. In stirling_wrapper with a StandaloneContext, this reduces the perf from ~75% CPU to ~20% CPU usage. Likely doesn't affect stirling the AgentContext (i.e. in the PEM) in any significant way, since the AgentMetadataState was already snapshotted in AgentContext. So only expect marginal improvements there. Test Plan: Existing tests. Reviewers: zasgar, yzhao, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6841 GitOrigin-RevId: 4d5f30fc86a76300f44f2eadd9fe82024767cff0
-
- 24 Nov, 2020 3 commits
-
-
Michelle Nguyen authored
Summary: the condition was wrong, so we were still sending out "Failed" notifications for passing builds Test Plan: n/a Reviewers: vihang, zasgar, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6864 GitOrigin-RevId: 961bc12d1190cf2d0410ea62c1df5b44afa743b3
-
Omid Azizi authored
Summary: Fix some aspects of the test. Still investigating high CPU usage reported by the test. Test Plan: Manual. Not enabled yet. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6839 GitOrigin-RevId: 146af60ce305c7ac8f56362c6a7eba169d7b2814
-
Michelle Nguyen authored
Summary: we are seeing an issue occuring on clusters (especially larger clusters), where the computedSchema grows too large and can no longer be sent to etcd. after some examination, it appears we are hitting a race condition where if an agent is deleted the same time as another is updating its schema, its possible for zombie agents/tables to be left behind in the computed schema. we could add locks, but that would introduce a performance impact since the lock would have to be around a network call to etcd. we are also heavily refactoring the metadata service, so most of this logic will be removed in the future anyway. we decided that a temporary fix, where we periodically clean up the computedSchema, should suffice until our refactor Test Plan: unit test, ran Vizier with skaffold and verified the zombie agent IDs and tables were pruned. also verified that I could still run scripts afterwards Reviewers: nserrino, zasgar, philkuz, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6860 GitOrigin-RevId: b34109581979dd58d295f6b4bc57f1cf45987253
-
- 23 Nov, 2020 1 commit
-
-
Nick Lanam authored
Summary: the GraphQL language service (used by plugins for editors and IDEs) marks the entire schema invalid if it detects syntax or semantic errors, making the tool think every query is invalid/unknown. Fixing semantic errors takes care of that. Additionally, we have two schemas with some overlap, which were both being seen by that tooling. Using `.graphqlconfig` file to ignore the one that is a subset of the other takes care of this as well. Both fixes combined allow tooling to recognize valid queries. Notably, this does not change the application's behavior at all: it just makes sure editors and IDEs understand what's happening. Test Plan: Check out the various usages of the `gql` template tag in our TypeScript code, in an editor/IDE that can highlight and inspect the syntax. It should now succeed when trying to do so. The build should be entirely unaffected. Reviewers: nserrino, michelle, vihang, #engineering, zasgar Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6838 GitOrigin-RevId: 5fe4cf6418c5e834f26c2be8f5621df12520ef93
-
- 24 Nov, 2020 1 commit
-
-
Natalie Serrino authored
Summary: This diff adds a stats handler to the metadata service which watches the k8s updates and agent heartbeats and notes the volume received by each. It breaks down the k8s updates by entity type (pod, etc) and the agent heartbeats by agent data info, created processes, and terminated processes. We are adding this in order to better understand the load on the metadata service for a series of stability improvements that we want to make. Also for some reason make gazelle changed an autocomplete BUILD.bazel ordering, so added that too. Test Plan: ran it in my cluster and verified the correct information was printed out Reviewers: michelle, zasgar, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-2318 Differential Revision: https://phab.corp.pixielabs.ai/D6859 GitOrigin-RevId: 04e3edbc8f4855d7a3b4045b0caa33394978fc41
-
- 23 Nov, 2020 1 commit
-
-
James Bartlett authored
Summary: Adds a random seed to the kmeans algorithm so that the test doesn't fail some of the time. Test Plan: Ran test 1000 times without failure. Reviewers: zasgar, #engineering, vihang Reviewed By: #engineering, vihang Differential Revision: https://phab.corp.pixielabs.ai/D6845 GitOrigin-RevId: a252ff7cbb389ba344874d135e9519dd20725146
-
- 24 Nov, 2020 9 commits
-
-
Phillip Kuznetsov authored
Summary: Bundle scripts set by user should not go to the cache, instead should always look at the URL. Supports development Test Plan: Tested and made sure it bypasses cache even when cache is turned on. Reviewers: nick, michelle, nserrino, #engineering, zasgar Reviewed By: #engineering, zasgar Subscribers: zasgar JIRA Issues: PC-689 Differential Revision: https://phab.corp.pixielabs.ai/D6856 GitOrigin-RevId: 7f69b0767cc99ed2428cf6ec6415e9578e553890
-
Vihang Mehta authored
Summary: TSIA Test Plan: N/A Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6857 GitOrigin-RevId: c8d3f4fc728ff4224ab61e773eb04451b3110c5a
-
Zain Asgar authored
Summary: Looks like there was a bad merge/change at some point. Also made it robust to missing test outputs. Test Plan: Jenkins Reviewers: michelle, vihang, oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6854 GitOrigin-RevId: aafda01806edfbeb78198b753c1037b01d524432
-
Nick Lanam authored
Summary: When there are multiple lines due to insufficient horizontal space, the right side that only had one line was top-aligned. Before: {F105304} After: {F105305} Test Plan: Try the pictured script in a thin viewport, or anything else that would cause a similar overflow. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6855 GitOrigin-RevId: 2a69f565496ba4a97b137c06752b86908e3a4a8b
-
Zain Asgar authored
Summary: TSIA Test Plan: jenkins Reviewers: vihang, michelle, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6852 GitOrigin-RevId: 6dd8bc32538d976411d64883d79eab37c85bbb4c
-
Vihang Mehta authored
Summary: `lsif-go` and `lsif-ts` will be used to collect `golang` and `TypeScript/JavaScript` lsif data. The `src` tool will be used to upload the data to sourcegraph. Test Plan: TSIA Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6851 GitOrigin-RevId: 48af4b487ecfbb9292acd8d5a7db2beacb3461da
-
Phillip Kuznetsov authored
Summary: PP-2316 highlighted that indentation errorse were hard to spot and libpypa really spit out terrible messages. It missed the proper location of the erorr and hte errors didn't say anythin g, just "Indentation error". I've updated the underlying package to properly manage those situations. https://github.com/pixie-labs/libpypa/pull/3. Some changes had to be done in the compiler code itself so here they are. Test Plan: Added tests to make sure indent errors had readable messages Reviewers: jamesbartlett, nserrino, htroisi, #engineering Reviewed By: jamesbartlett, #engineering JIRA Issues: PP-2316 Differential Revision: https://phab.corp.pixielabs.ai/D6850 GitOrigin-RevId: cc7d25900f536bb8a909ccdce2d717bae6333b40
-
Michelle Nguyen authored
Summary: these are the files needed to set up the ingress/certs for sourcegraph. deploying source graph itself requires A LOT of yamls, which are all located in the deploy-sourcegraph repo. i didnt think it was necessary to duplicate those here. Test Plan: deployed, got a working version of sourcegraph. Reviewers: zasgar, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6848 GitOrigin-RevId: f4cbfa27e073ecc7d232935d6f312c86d6885c8a
-
Vihang Mehta authored
Summary: Checking emptiness of `bazel_buildables_clang_dbg` was bad. It exluded tests as well as bpf tests. Since we gated all cc tests on `bazel_cc_changed` this should work much better now. Test Plan: Run the script with a small change to `http2_trace_bpf_test.cc` Ensure that bazel_cc_changed was written. Reviewers: zasgar, oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6847 GitOrigin-RevId: d460e95ae7a07565583bcd9181e110ba2cee3a52
-
- 23 Nov, 2020 5 commits
-
-
Omid Azizi authored
Summary: Somehow the build for https://phab.corp.pixielabs.ai/D6840 did not catch this. Test Plan: Jenkins (although I'm now suspicious). Reviewers: zasgar, #engineering, vihang Reviewed By: #engineering, vihang Differential Revision: https://phab.corp.pixielabs.ai/D6846 GitOrigin-RevId: 0e5346b0f1c10a948b9fa27e345235b930344fa9
-
Omid Azizi authored
Summary: To unblock others. Test Plan: Existing tests. Reviewers: zasgar, yzhao, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6840 GitOrigin-RevId: d7d8e5f282caf37ccaf78a4e1c39dbf3387fa558
-
Zain Asgar authored
Summary: Fixes two cases: 1. Where BES failes to update. 2. Where there are no tests to run. Test Plan: Jenkins Reviewers: vihang, michelle, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6842 GitOrigin-RevId: f96dc0756a6fa1d79ae905372874250e67f3d26f
-
Michelle Nguyen authored
Summary: along the line somewhere, we removed the part which sets currentBuild.result = 'SUCCESS'. a null currentBuild.result is fine, and does mean a success. we should update our slack notification so that it also accepts null currentBuild.results. Test Plan: ran staging release build, verify that it sends correct slack notification Reviewers: vihang, zasgar, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6843 GitOrigin-RevId: 62e76b3d782f92adeb6a3e5b559477beeacb9e53
-
Nick Lanam authored
Summary: This was causing the tracepoint mutation modal to dismiss itself prematurely. The live view's loading state is marked false when a query completes or is cancelled, and the first step of running a query is cancelling the already-running one. It now won't try to do this if there is nothing to cancel. Test Plan: Run a script with no mutations to completion, like `px/cluster`. Then run one with mutations like `px/tcp_drops`. The tracepoints modal should no longer dismiss itself prematurely. The previous fix for this only fixed it when the first script was cancelled, but not if it completed normally. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6836 GitOrigin-RevId: 1d6ddfec178ef100d39d97ab9931b3fea32198e3
-
- 20 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: A framework for testing Go TLS connections. Test Plan: Just a framework. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6819 GitOrigin-RevId: 4b3ab16ecf849784f6c72316a385303b0d71df3b
-
- 23 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: hsperfdata of java binaries can conflict because they run in bazel sandboxes which operate with pid namespaces. This means PIDs are often the same. The /tmp files that those binaries use, however, are shared. This results in clobbering of files. Address this with sandbox_tmpfs_path, which mounts a /tmp inside each sandbox, making each sandbox operate independently. Test Plan: Jenkins and --runs_per_test=100 Reviewers: yzhao, zasgar, #engineering, vihang Reviewed By: #engineering, vihang Differential Revision: https://phab.corp.pixielabs.ai/D6834 GitOrigin-RevId: ea7cce87cb2df92c9728abb53c7a2950cb5628fe
-