This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 20 Nov, 2020 2 commits
    • Nick Lanam's avatar
      Fix scaling calculation when determining default column widths. · d56497f9
      Nick Lanam authored
      Summary: This applies both to the first render of a table, and double clicking on drag handles.
      
      Test Plan: Try any script with few columns, like `px/agent_status`. The columns should get a sensible layout on first render, not snap around on first resize, and double clicking a drag handle should reset the ratio between the columns on either side without affecting any other columns.
      
      Reviewers: #engineering, nserrino, michelle, vihang, philkuz
      
      Reviewed By: #engineering, philkuz
      
      JIRA Issues: PC-682
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6804
      
      GitOrigin-RevId: 07bee1ea07b5f491cf01b3b79ddec45a89587756
      d56497f9
    • Zain Asgar's avatar
      Add a machine specific bazelrc file · 593236da
      Zain Asgar authored
      Summary: This adds a machine specific bazelrc that we can use.
      
      Test Plan: N/A
      
      Reviewers: vihang, michelle, philkuz, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6802
      
      GitOrigin-RevId: 6c9a04ec6cbee461ad7df51c896a464d31dcf543
      593236da
  2. 19 Nov, 2020 3 commits
    • Omid Azizi's avatar
      Restore experimental GoTLS tracer · c5b0c6ed
      Omid Azizi authored
      Summary: Restore after bit rot.
      
      Test Plan: Manually ran it.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6789
      
      GitOrigin-RevId: c86bb011628beef83e9655334ef8b097cef89237
      c5b0c6ed
    • Omid Azizi's avatar
      [Cleanup] go_grpc -> go_http2_trace · 20af559d
      Omid Azizi authored
      Summary:
      Use _trace suffix to match the rest of the BPF code (socket_trace.c, openssl_trace.c, and soon go_tls_trace.c).
      
      Rename grpc to http2, since we really should be http2 tracer.
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6787
      
      GitOrigin-RevId: 4ad71cb5bcf7d9853db81036bfd6a9f2108c2965
      20af559d
    • Michelle Nguyen's avatar
      Add UserSettings table · 2f682f9c
      Michelle Nguyen authored
      Summary:
      we want to add user settings so that we can track whether or not a user has seen the onboarding tour overlay.
      this will also be used for other settings in the future, such as hotkeys.
      
      this diff only adds the table to the profile service, but doesnt use it yet.
      the following diffs will:
      - add userSettings to the grpc API
      - add userSettings to the gql API
      - implement the API in the backend
      
      followed the typical userSettings design, where the key/value are all strings.
      it is up to the consumer (UI in this case) to know the type of the userSetting it has just requested and do typecasting if needed.
      
      Test Plan: ran plc-dev and made sure the migration goes through
      
      Reviewers: nick, zasgar, nserrino, #engineering, vihang
      
      Reviewed By: #engineering, vihang
      
      Subscribers: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6766
      
      GitOrigin-RevId: cec9c18e9df27827f1c21714ea161ecb6704de14
      2f682f9c
  3. 20 Nov, 2020 3 commits
    • Michelle Nguyen's avatar
      Surface agent pod names · a0e9f3be
      Michelle Nguyen authored
      Summary:
      we updated our logging scheme so that we can view logs for pods, given the cluster ID and pod name.
      however, we previously didnt surface up the pod name anywhere, which makes it impossible for us to look at PEM logs.
      
      Test Plan: unit tests, ran vizier with skaffold and verified it shows up correctly in the script
      
      Reviewers: zasgar, nserrino, philkuz, #engineering, vihang
      
      Reviewed By: #engineering, vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6800
      
      GitOrigin-RevId: 92c631131f76c00a513c7f72111ed933bf169dea
      a0e9f3be
    • Vihang Mehta's avatar
      ESLint fix pixie-components · e1bff652
      Vihang Mehta authored
      Summary: TSIA
      
      Test Plan: Existing tests?
      
      Reviewers: nick, #engineering
      
      Reviewed By: nick, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6799
      
      GitOrigin-RevId: 783d60b0c3f84d0dc10eaed433dbe568fb5fd743
      e1bff652
    • Michelle Nguyen's avatar
      Fix UI flags for nginx deploys · 52091b9e
      Michelle Nguyen authored
      Summary:
      the previous change broke the UI for ngninx, because WEBPACK_REPLACE was an undefined variable.
      there were a few solutions that immediately came to mind:
      - update webpack non-dev server builds to set WEBPACK_REPLACE to false. didn't like this, since we didn't want to use webpack replace/define plugin for non-dev server builds in the first place.
      - update nginx to set WEBPACK_REPLACE to false. also didnt like this, because now nginx has to know about what should be a webpack specific variable.
      we originally wanted the replaced values to be strings so that the code would still build even if there was no replace. but with the webpackDefinePlugin, this looks like we can't do this anymore. so, we might as well make them all variables rather than strings.
      
      Test Plan: deployed to staging and ran yarn dev. verified that both builds are functional
      
      Reviewers: vihang, zasgar, nick, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6795
      
      GitOrigin-RevId: 799aa0a0536b5d4fd173decf6416d01ac2a9b8c2
      52091b9e
  4. 19 Nov, 2020 1 commit
    • Nick Lanam's avatar
      Bump hint size; clean up naming and references of autocomplete and command... · 3025ea90
      Nick Lanam authored
      Bump hint size; clean up naming and references of autocomplete and command input related components.
      
      Summary: The former change solves PC-683, the latter PC-616. Files are moved and symbols renamed to disambiguate the autocomplete used by breadcrumbs from the one used by the command input. This also fixes a bug where the wrong one was being used for Ctrl/Cmd+K following recent build refactors.
      
      Test Plan: Test both autocompletes: the breadcrumbs (like the script selector) and the command input (Ctrl/Cmd+K). They should behave the same.
      
      Reviewers: #engineering, nserrino, michelle, vihang
      
      Reviewed By: #engineering, vihang
      
      JIRA Issues: PC-616, PC-683
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6790
      
      GitOrigin-RevId: f6ba157d0f6e51f80dba4f66620e8b0b4facd96c
      3025ea90
  5. 20 Nov, 2020 1 commit
    • Omid Azizi's avatar
      [Cleanup] create_gke_cluster.sh · 44922a90
      Omid Azizi authored
      Summary: Was running it to create my new cluster, and decided to clean-up a few items along the way.
      
      Test Plan: Manual. Created a pixies cluster for myself. Other cluster environments not tested.
      
      Reviewers: vihang, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6796
      
      GitOrigin-RevId: af322ac3fa6a8e7736b0691c7c1864fdf357f781
      44922a90
  6. 19 Nov, 2020 1 commit
    • Omid Azizi's avatar
      GoTLS symbol extraction · fec7b8ba
      Omid Azizi authored
      Summary: Symbols required for GoTLS probe deployment.
      
      Test Plan: Test added that symbols are extracted properly.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6783
      
      GitOrigin-RevId: 62fb12ab17db3fd9aa5c47b32b369f405f479738
      fec7b8ba
  7. 20 Nov, 2020 4 commits
  8. 19 Nov, 2020 7 commits
    • Michelle Nguyen's avatar
      Add buildbuddy yamls · 44ba2506
      Michelle Nguyen authored
      Summary: we want to add buildbuddy to our jenkins bazel builds so we can track build metrics.
      
      Test Plan: deployed the files, verify buildbuddy is accessible
      
      Reviewers: vihang, zasgar, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6788
      
      GitOrigin-RevId: 9698dba6229091647d4bc039e9e11d5027aec35b
      44ba2506
    • Vihang Mehta's avatar
      Fix webpack define · ef025254
      Vihang Mehta authored
      Summary: This should fix the __PIXIE_FLAGS__ issue. Lmk if there's a better solution.
      
      Test Plan: `webpack dev`, check window.__PIXIE_FLAGS__
      
      Reviewers: nick, nserrino, zasgar, michelle, #engineering
      
      Reviewed By: nick, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6781
      
      GitOrigin-RevId: 93db008325394626cd754cc52c5c2430ea11b8e6
      ef025254
    • Natalie Serrino's avatar
      PP-2310: UI support for ST_SCRIPT_REFERENCE specific rendering · 3f24aa5f
      Natalie Serrino authored
      Summary:
      Depends on D6759. This diff adds deep linking for the ST_SCRIPT_REFERENCE type, which allows the users to make arbitrary deep links to non-entity scripts in PxL.
      I also refactor a bit of the script URL logic to better support this change.
      
      Test Plan: added unit tests, ran in UI
      
      Reviewers: nick, michelle, philkuz, #engineering
      
      Reviewed By: nick, #engineering
      
      JIRA Issues: PP-2310
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6777
      
      GitOrigin-RevId: a6e0871398c8a00b5e4b074ad5407d139dd7e820
      3f24aa5f
    • Nick Lanam's avatar
      Fix incorrect typing (which compiled anyway) in two files · 1284eaf9
      Nick Lanam authored
      Summary: For `callback.tsx`, the issue was that React Router's `<Link>` component supports forwarded props, but does not specify that fact in the typings. Fixed by using a trivial HOC. In `convert-to-vega-spec.ts`, we are using a prop that does not exist in non-patched Vega, but which does in our patched version. Adding a type extension to define it fixes this. In both scenarios, the issue was only with the typings and the compilation succeeded anyway as the code is fine. Also, removes an unused interface.
      
      Test Plan: Run the dev build.
      
      Reviewers: #engineering, nserrino, michelle, vihang
      
      Reviewed By: #engineering, vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6785
      
      GitOrigin-RevId: 94ffca0068a6b39104aedff7ad8e3bd592f14c23
      1284eaf9
    • Omid Azizi's avatar
      GoTLS prep: reorganize symaddrs a bit · de144e34
      Omid Azizi authored
      Summary: We are going to need a separate set of symaddrs for the GoTLS libraries, so organize things a bit.
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6767
      
      GitOrigin-RevId: c19aff68fd3699b40ece844145803693e6e45275
      de144e34
    • Yaxiong Zhao's avatar
      Pull common APIs for every protocol into interface.h · 86e74d27
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6768
      
      GitOrigin-RevId: 184dcfc9826a3d63ada714afe5947bee368571fa
      86e74d27
    • Omid Azizi's avatar
      [Cleanup] ConnectionTracker: SetProtocol/SetRole · cda5ea82
      Omid Azizi authored
      Summary:
      This is part of the process of decoupling protocol and role. Role is now attached to the connect()/accept(), while protocol is data-dependent.
      
      Reflect this in the code. Also deduplicates a replicated part of the code.
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6616
      
      GitOrigin-RevId: 696daa7e7d69987de51f81fd98b23ecc206b0061
      cda5ea82
  9. 18 Nov, 2020 1 commit
    • Nick Lanam's avatar
      Less scary messaging for auth errors · e370a1f5
      Nick Lanam authored
      Summary:
      Displays the Pixienaut being chased by an octopus instead of a big red triangle + exclamation point. Also adds an option to render with the Pixienaut on the toilet, in an "oh no" pose. Messaging for sign in, log in, and general auth errors made more friendly and given a call to action (navigating) button.
      
      The toilet pose is not in use yet. The goal going forward is to use the octopus for recoverable errors and the toilet for fatal errors.
      
      The octopus box:
      {F104225}
      
      The toilet box (not in use at this time, but fatal errors are welcome to use it going forward):
      {F104226}
      
      Test Plan: To trigger the log in error, try to log in with a Google account that isn't registered with us. To trigger the sign up error, try to register an account that is already registered.
      
      Reviewers: nserrino, michelle, #engineering, vihang
      
      Reviewed By: #engineering, vihang
      
      Subscribers: vihang
      
      JIRA Issues: PC-575
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6769
      
      GitOrigin-RevId: 8c4e9cd3163f10e53a3ebafd82dd389ed0930cdc
      e370a1f5
  10. 19 Nov, 2020 2 commits
    • Yaxiong Zhao's avatar
      [CLEANUP] Remove colon in src/stirling/protocols/http/types.h · ad0a44b3
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6778
      
      GitOrigin-RevId: 32fe0fccb705d199fc8031c5e95a865ca0a7cbf9
      ad0a44b3
    • Natalie Serrino's avatar
      PP-2310: Add the public PxL API for creating script reference deep links · 3df6bd45
      Natalie Serrino authored
      Summary: Depends on D6759. This diff adds the public PxL function for creating a custom deep link in a table (as what we are now calling a script reference). I also decided to bump up the max number of supported script arguments in a script reference from 4 to 8 based on the feedback that we would be using 4 right out of the gate. Next up, I will add the ST_SCRIPT_REFERENCE-specific rendering to the UI so that these script references show up as clickable deep links in the UI.
      
      Test Plan: added unit tests
      
      Reviewers: philkuz, zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      JIRA Issues: PP-2310
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6771
      
      GitOrigin-RevId: 1df6eee4f5f7d70307e2e5e1f0de54cd519de72c
      3df6bd45
  11. 18 Nov, 2020 1 commit
    • Natalie Serrino's avatar
      PP-2310: Add semantic type for script reference · cd892717
      Natalie Serrino authored
      Summary: Depends on D6753. This diff adds ST_SCRIPT_REFERENCE as a semantic type so that the UI can interpret columns of this type and render them as deep links. It also adds the semantic type to the UDF added in the prior diff.
      
      Test Plan: run in skaffold
      
      Reviewers: philkuz, jamesbartlett, zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      JIRA Issues: PP-2310
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6759
      
      GitOrigin-RevId: d965486c484b51ae5cf553d160d8b9fc06f2ccdd
      cd892717
  12. 17 Nov, 2020 1 commit
    • Natalie Serrino's avatar
      PP-2310: Add Carnot UDF to create a script reference type for custom deep linking in Live Views · 229cb087
      Natalie Serrino authored
      Summary:
      For our DNS script and other use cases, we want to be able to add custom dynamic deep links within a script. Currently our deep links are exclusive to entity types like pod, but we want to add a capability to PxL for the user to specify a deep link in an arbitrary output column.
      
      This diff adds the 'px._script_reference' UDF which will be responsible for taking a script name, a text label, and script args and returning a stringified JSON value like this:
      
      ```
      {
      	label: 'visible link name',
      	scriptID: 'px/foo',
      	args: {
      		start_time: '-5s',
      		entity_arg: 'val_from_col'
      	}
      }
      ```
      
      This is a bit challenging due to our lack of support for object types in PxL, since creating the above, especially when the script arg comes from a colum in a DataFrame, is a natural fit for an object type in PxL. Once that support comes in, this function will need to be refactored, but I am trying to minimize the amount of unnecessary work while still supporting the requested use case.
      
      In addition to a lack of object types in PxL, we also have a lack of support for variadic UDFS. A function like https://docs.snowflake.com/en/sql-reference/functions/object_construct.html is very difficult to support in our UDF catalog today, so that will be another thing that needs to be refactored once we support object types. Due to this limitation, this diff adds support for up to 4 script args (we don't use that many in most scripts today), but when variadic UDF args are supported in our catalog, we will update this function to use them and remove that limitation.
      
      In the next few diffs, I will
      
      1. Add a semantic type for Script reference (ST_SCRIPT_REFERENCE) and ensure the output of this function is that semantic type.
      
      2. Add handling in the compiler for a public API for this function, which will probably look like
      
      ```
      df.col = px.ScriptReference(label='visible link name', script='px/foo', args={
      	'start_time': '-5s',
      	'entity_arg': df.foo
      })
      ```
      
      3. Add support in the UI to hyperlink columns which are the ST_SCRIPT_REFERENCE semantic type.
      
      Test Plan: added unit test
      
      Reviewers: philkuz, zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Subscribers: htroisi
      
      JIRA Issues: PP-2310
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6753
      
      GitOrigin-RevId: 00a3c541ac9eaf92466486024f01d87b98e3c21b
      229cb087
  13. 19 Nov, 2020 5 commits
    • Vihang Mehta's avatar
      Redirect stderr to /dev/null · 83ca428f
      Vihang Mehta authored
      Summary: TSIA
      
      Test Plan: Running the script after a `bazel clean --expunge` no longer creates spew.
      
      Reviewers: zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6780
      
      GitOrigin-RevId: a34f46667718d3af5376c02377d7ee2429b49b25
      83ca428f
    • Vihang Mehta's avatar
      Limit gcci:opt and clang:dbg to cc only · d236de33
      Vihang Mehta authored
      Summary:
      Limit gcc:opt and and clang:dbg to kind cc_binary and cc_test
      Also write a file `bazel_cc_changed` indicating that we should run clang tidy.
      
      Test Plan: Run the script before and after changing a cc file.
      
      Reviewers: zasgar, michelle, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6779
      
      GitOrigin-RevId: 7cdd6502851a9b6c19f70f47f3d1e5bca2440c68
      d236de33
    • Vihang Mehta's avatar
      k8s configs for bazel-remote cache · 4cd579ba
      Vihang Mehta authored
      Summary: TSIA
      
      Test Plan:
      Run `bazel build` with `--remote_cache=grpc://localhost:10200`
      Observe caching.
      
      Reviewers: zasgar, michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Subscribers: yzhao
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6774
      
      GitOrigin-RevId: 78eefeb6faa29994fc53dce14b22a6e52ff7a53f
      4cd579ba
    • Michelle Nguyen's avatar
      Update gke cluster prettyName to include project if there is a duplicate prettyName · 3101f02c
      Michelle Nguyen authored
      Summary:
      now that people are recreating their clusters in the new project, we're running into an issue where the UI is confused by multiple gke projects with the same GKE name.
      for clusters with the same name, we should add more context so that they can distinguish between the two (and also so our UI can distinguish between them)
      
      Test Plan: unit tests
      
      Reviewers: jamesbartlett, nick, nserrino, zasgar, #engineering
      
      Reviewed By: jamesbartlett, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6770
      
      GitOrigin-RevId: a3a0ba289f81b3e10aaf7b7478c23437f5e3c98a
      3101f02c
    • Vihang Mehta's avatar
      Good riddance text linter · 36f16bff
      Vihang Mehta authored
      Summary: TSIA
      
      Test Plan: No more line length annoyance. Let language linters enfore it.
      
      Reviewers: #engineering, zasgar
      
      Reviewed By: #engineering, zasgar
      
      Subscribers: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6772
      
      GitOrigin-RevId: e725e9ee4f9ba38fca43da45a4554a9769db4b4f
      36f16bff
  14. 18 Nov, 2020 1 commit
    • Omid Azizi's avatar
      GoTLS prep: Create DwarfReader once · ecbdd0c5
      Omid Azizi authored
      Summary: With the GoTLS code, we'll need dwarf_reader as well. Move the creation of dwarf_reader higher up, so it can be shared.
      
      Test Plan: Existing tests
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6765
      
      GitOrigin-RevId: 33187f01ebbd54e49da3e0f9f92913774a6d694d
      ecbdd0c5
  15. 17 Nov, 2020 1 commit
    • Zain Asgar's avatar
      Remove SSD support in jenkinsfile · adb3dfc9
      Zain Asgar authored
      Summary: We are moving everything over to K8s and don't need support for SSD workers anymore. This is just a simplification step.
      
      Test Plan: Jenkins
      
      Reviewers: michelle, vihang, oazizi, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6757
      
      GitOrigin-RevId: 64e3c0c12ec09ca30e041f3d0857d1fc94a6ba8d
      adb3dfc9
  16. 18 Nov, 2020 2 commits
    • Yaxiong Zhao's avatar
      Add StitchFrames() function template as the common interface for stitching... · 8a242ab3
      Yaxiong Zhao authored
      Add StitchFrames() function template as the common interface for stitching requests & responses of all protocols
      
      Summary:
      Also rename ProcessFrames() -> StitchFrames().
      
      This matches the ParseFrame() pattern.
      
      The benefit is that it now is easier to understand the expectation on the ProcessFrames()
      API. Previously, ProcessFrames() is only linked, it was obscure to learn how it's invoked.
      
      In a followup diff, the common interface templates will be moved into one single header file.
      
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6763
      
      GitOrigin-RevId: 2a710bc4c9368645b05eeea2bb7e7d218e5f216d
      8a242ab3
    • Vihang Mehta's avatar
      Enable autoscaling in create_gke_cluster · f8257ef0
      Vihang Mehta authored
      Summary: TSIA. Included a flag to disable autoscaling.
      
      Test Plan: Run the script with `set -x` with and without the `-f` flag
      
      Reviewers: philkuz, zasgar, michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Subscribers: oazizi
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6762
      
      GitOrigin-RevId: 005c9fa435ca0d2ffb6dd7c932d98082ffcdff55
      f8257ef0
  17. 21 Oct, 2020 1 commit
    • Nick Lanam's avatar
      Static Tour Overlay (WIP) · e28f8649
      Nick Lanam authored
      Summary:
      Currently only opens from a new button in the sidebar. A future change can make it appear once automatically per user. The button does not appear on mobile (viewport widths under 960px) as the tour does not fit there and the layout is different anyway.
      
      When it's open:
      {F103838}
      
      Test Plan: Open the profile/admin menu in the bottom left in the sidebar. It should contain a `Tour` item that should open the tour.
      
      Reviewers: nserrino, michelle, zasgar, #engineering
      
      Reviewed By: michelle, #engineering
      
      Subscribers: htroisi
      
      JIRA Issues: PC-426
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6557
      
      GitOrigin-RevId: a8a8670fc811314ff2fc82478d0a2a00295ca2ee
      e28f8649
  18. 18 Nov, 2020 3 commits
    • Yaxiong Zhao's avatar
      Add redis_trace_bpf_test.cc · 1fafcc7c
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6755
      
      GitOrigin-RevId: 58d452091ed4a78c6421e5a6f33887cc1f3cca55
      1fafcc7c
    • Omid Azizi's avatar
      DNS: More tests based on real packet captures · 1317704a
      Omid Azizi authored
      Summary:
      Trying to catch a bug I see in the UI.
      
      This didn't end up revealing catching it, but worth keeping.
      
      Test Plan: This is a test.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6738
      
      GitOrigin-RevId: 91b0008fe9ea7605c2c8aa1ac5020f1adc183541
      1317704a
    • Vihang Mehta's avatar
      Upgrade webpack · b5a77be9
      Vihang Mehta authored
      Summary:
      `storybook` + `html-webpack-plugin` seem to not play nicely with webpack4. https://github.com/storybookjs/storybook/issues/9216
      Force resolving `html-webpack-plugin` to a new alpha version seems to work.
      
      `babel` modules need to be upgraded to address `.mjs` files. https://github.com/babel/babel/issues/8462
      
      `favicons-webpack-plugin` needs to be upgraded to handle API changes for webpack plugins https://github.com/jantimon/favicons-webpack-plugin/issues/222
      Upgrading to the new alpha version seems to work.
      
      A handful of other plugins also don't work due to API changes in webpack but upgrading them to their latest stable versions works.
      
      Test Plan:
      Build time perf for Webpack4:
      ```
      === PHASE SUMMARY INFORMATION ===
      
      Total launch phase time         1.200 s    0.59%
      Total init phase time           0.342 s    0.17%
      Total target pattern evaluation phase time    1.228 s    0.61%
      Total interleaved loading-and-analysis phase time    1.807 s    0.89%
      Total preparation phase time    0.058 s    0.03%
      Total execution phase time    197.507 s   97.70%
      Total finish phase time         0.013 s    0.01%
      ------------------------------------------------
      Total run time                202.157 s  100.00%
      
      Critical path (197.212 s):
             Time Percentage   Description
         91.785 s   46.54%   action 'Generating webpack deps src/ui/ui-deps.tar.gz'
         10.071 s    5.11%   action 'Generating licenses src/ui/npm_licenses.json'
          40.3 ms    0.02%   action 'Executing genrule //tools/licenses all_licenses'
         95.316 s   48.33%   action 'Generating webpack bundle src/ui/ui-bundle.tar.gz'
      ```
      
      Build time perf for Webpack5:
      ```
      === PHASE SUMMARY INFORMATION ===
      
      Total launch phase time         0.020 s    0.01%
      Total init phase time           0.180 s    0.09%
      Total target pattern evaluation phase time    0.118 s    0.06%
      Total interleaved loading-and-analysis phase time    0.145 s    0.07%
      Total preparation phase time    0.007 s    0.00%
      Total execution phase time    207.184 s   99.77%
      Total finish phase time         0.004 s    0.00%
      ------------------------------------------------
      Total run time                207.660 s  100.00%
      
      Critical path (207.116 s):
             Time Percentage   Description
         93.509 s   45.15%   action 'Generating webpack deps src/ui/ui-deps.tar.gz'
         10.430 s    5.04%   action 'Generating licenses src/ui/npm_licenses.json'
          30.0 ms    0.01%   action 'Executing genrule //tools/licenses all_licenses'
        103.148 s   49.80%   action 'Generating webpack bundle src/ui/ui-bundle.tar.gz'
      ```
      
      Reviewers: #engineering, michelle, nick
      
      Reviewed By: #engineering, michelle, nick
      
      Subscribers: nick
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6761
      
      GitOrigin-RevId: 6584b9806e6c35138b721af6e522b6da7a60b36b
      b5a77be9