This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 29 Oct, 2020 5 commits
-
-
Michelle Nguyen authored
Summary: the graph wasn't correctly filling the height of the grid container. when the widget container is resized, it can sometimes be larger than the widget container itself and make the "enable hierarchy" button impossible to click Test Plan: ran webpack Reviewers: zasgar, nserrino, oazizi, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6640 GitOrigin-RevId: 03275d6b49c47d31b48a9bc1e57d7dcd1c88425d
-
Yaxiong Zhao authored
Summary: Such that pxtrace.PodProcess() can specify a prefix of pod name. This is useful when pods are restarted, where its prefix is the same, but the suffix is different. This ensures the script remain valid after pod restarting. Test Plan: Manual test on GKE cluster Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6639 GitOrigin-RevId: 5d659cb0d42e14a3c4f093238138962c9a7b2c55
-
Yaxiong Zhao authored
Test Plan: Manual test on test gke cluster Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6637 GitOrigin-RevId: 9a4c13f4da80f681d6101c142c0962faddd0f262
-
Michelle Nguyen authored
Summary: similar to our request graphs, we want to give the option of having a hierarchical layout Test Plan: spent awhile tweaking the params to try to get something that looked ok with larger graphs. this is what i came up with so far: zoomed out: {F98772} closer view: {F98773} net_flow_graph slight zoom-in view (without any filtering) {F98774} Reviewers: zasgar, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6638 GitOrigin-RevId: 3fdb285d52b59701b659a5f56854cdcf4794447c
-
Yaxiong Zhao authored
Summary: The buggy code overlooks the continue statement, causing the indexes mismatching. Test Plan: Manual test on gke Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6636 GitOrigin-RevId: d5e9989a1f30c3caebfe9fda52cb8238d530f12a
-
- 27 Oct, 2020 1 commit
-
-
Vihang Mehta authored
Summary: The PodConditions include all condition types and states for each condition, so this goes from holding on to just a repeated set of conditions, to conditions and their statuses, and propagating the same down to the metadata state. Also add a UDF to get pod ready state. This UDF just returns a bool that checks for the PodCondition Ready and returns false if the state is either unknown or false. We can consider beefing up this UDF to instead return all possible condition states (true/false/unknown) and letting the user query either of the known states. Test Plan: Added unit tests wherever applicable. Would love help integration testing it on my dev machine. Reviewers: nserrino, michelle, zasgar, #engineering Reviewed By: nserrino, #engineering JIRA Issues: PP-2079 Differential Revision: https://phab.corp.pixielabs.ai/D6628 GitOrigin-RevId: 1c615bf521b668a19278224df78c16ea6db6f19a
-
- 28 Oct, 2020 5 commits
-
-
Michelle Nguyen authored
Summary: we wanted to update our graphs so that: 1. the simulations stop after things have stabilized, so that nodes/edges aren't still moving around/spinning. 2. dragging nodes around should not be affected by physics this turned out to be a pretty simple change Test Plan: ran in webpack, ran some large graphs and dragged the nodes around Reviewers: zasgar, nserrino, nick, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6634 GitOrigin-RevId: 86eba07ea33a7c7a9f49b90525da36c9f0e1573a
-
Yaxiong Zhao authored
Summary: Use pxtrace.PodProcess() for specifying target Use Struct tracing for arguments and return value Use Interface tracing for returned error interface Added pxtrace.FunctionLatency() to showcase the full list of trace value Test Plan: Manually test on webui Reviewers: oazizi, htroisi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6629 GitOrigin-RevId: cec8e87f18726e30274c68d86a5785e76ac475d1
-
Omid Azizi authored
Summary: Testing a more stressful case, to make sure it parses correctly. Test Plan: This is a test. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6633 GitOrigin-RevId: 098c5944200961419f75bb63960b0d07cf5f1309
-
Omid Azizi authored
Summary: Add DNS request body to the record Test Plan: Updated tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6632 GitOrigin-RevId: dc5323144be3b5c57d52c7c099360fc540db2b7a
-
Yaxiong Zhao authored
Test Plan: Manual test, works as expected, i.e., column value is colored. Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6631 GitOrigin-RevId: 5a81b33ccc3c9d74daa097c4fe31df3a06049646
-
- 27 Oct, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: We noticed that health checks were starting to get stuck in customer. Upon closer investigation, this would always occur after the querybroker logged: `rpc error: code = Unauthenticated desc = invalid auth token: Token used before issued` To try to repo in my own environment, I updated exec stats to initiate the TransferResultChunk stream with a jwt with an IAT in the future. this was able to reproduce the issue. after adding in tons of logs, it looks like our healthcheck is getting stuck in qb's `StreamResults`, which keeps waiting forever until the query is done or has been cancelled. however, it never receives anything and waits forever because once carnot fails to send the ExecStats, it doesn't try again. we already have a healthCheckInterval which should unblock the healthcheck after it waits too long. we just need to make sure this also cancels the query, in case it has gotten stuck. as for why customer hit the "Token used before issued" problem, I'm guessing there is possibly some small clock skew between the kelvin and qb on their cluster. Test Plan: had carnot try to send exec stats with a token with a IAT in the future. verified that this causes the healthchecks to hang while waiting for StreamResults to finish. Added in my change, and verify that health checks no longer hang. Reviewers: zasgar, nserrino, #engineering, vihang Reviewed By: vihang Subscribers: vihang Differential Revision: https://phab.corp.pixielabs.ai/D6627 GitOrigin-RevId: 9fc9ae9664491590c568a9adeb5422d827c7fe0c
-
Omid Azizi authored
Summary: Tests Non-blocking recv calls don't interfere. Provides coverage for the BPF changes in D6625. Test Plan: This is all tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6626 GitOrigin-RevId: b91d2c8aa1e6c1abd805fbdca99f963f1b4d86ac
-
- 28 Oct, 2020 1 commit
-
-
Vihang Mehta authored
Summary: The linter checks to make sure the generated go_proto is `newer` than the source `.proto`, but the message always reads the failure condition even if the check passes. This fixes this minor issue. Test Plan: N/A Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6630 GitOrigin-RevId: b7c6525a365a9655972193af57416861b15ff664
-
- 27 Oct, 2020 7 commits
-
-
Zain Asgar authored
Summary: This also fixes and issue that gobpf is having building bcc dependencies. Test Plan: Existing tests/Jenkins. Reviewers: michelle, oazizi, vihang, #engineering Reviewed By: oazizi, vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6609 GitOrigin-RevId: 14983216056b69a92af0414c506b3715afd26c97
-
Omid Azizi authored
Summary: Collection of small items. Test Plan: Manual Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6625 GitOrigin-RevId: 374ba3244f57300b6f88f479a9ed24dbb23f3ffb
-
Vihang Mehta authored
Summary: Add UDFs for container start and stop times. Also add lookup for container name to container ID. Test Plan: Added test. Reviewers: nserrino, michelle, zasgar, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-2000 Differential Revision: https://phab.corp.pixielabs.ai/D6621 GitOrigin-RevId: 2d27d0ecd2200b663ab916a5e0bd5f47e93b41b6
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6620 GitOrigin-RevId: faefc6f92e830e9f385305ae6be846b25c90f380
-
Yaxiong Zhao authored
Summary: In addition to '.', also replace '/', which can happen in Golang program, like: github.com/... Additionally, remove all non-compatible chars. And add index in the added suffix to avoid potential collisions. Test Plan: Manual test on gke Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6619 GitOrigin-RevId: 429e05601e7daf79e275d549de32d3f8259764ab
-
Omid Azizi authored
Summary: Add DNS headers to the traced records Test Plan: Stitcher test + BPF test added. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6623 GitOrigin-RevId: e46c92be6d25010537c7d090a0edb69b9418f999
-
Omid Azizi authored
Summary: Getting some of the DNS body into the record. More to come. Test Plan: Test cases added in stitcher and BPF test. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6618 GitOrigin-RevId: d38b6ea91fdeaf8c397168436acc307a2fbaddea
-
- 26 Oct, 2020 10 commits
-
-
Vihang Mehta authored
Summary: This adds UDFs to get pod stop times. Test Plan: Added. Reviewers: nserrino, michelle, #engineering, zasgar Reviewed By: #engineering, zasgar JIRA Issues: PP-2000 Differential Revision: https://phab.corp.pixielabs.ai/D6617 GitOrigin-RevId: 708adb21e18ca2e3a05e4b29d9120b39fcd9caec
-
Vihang Mehta authored
Summary: TSIA Test Plan: `blaze run :px -- version` no longer says there's an update available. Reviewers: nserrino, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6611 GitOrigin-RevId: e0955bc1ea69aa422070cbe9febe2e1dcd68fb45
-
Omid Azizi authored
Summary: Enable DNS tracing with a simple test. Still more work to do, but at least can grab basic requests. Test Plan: New BPF test. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6615 GitOrigin-RevId: 4fff6e18322b9112cd914c77b562780a14e82422
-
Omid Azizi authored
Summary: Detect DNS protocol within BPF Test Plan: Added tests Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6614 GitOrigin-RevId: 2eaf2b5bbc554ba82c49b1b9fc69ba144f315a31
-
Vihang Mehta authored
Summary: I'm doing this at the graphql handler layer, but perhaps we can do it even earlier. I couldn't track where these keys were being read from once I hit the VizierDeploymentKeyServer and gRPC server wrapper. Also keys seem to be sorted in ascending order, (order they were added probably) but instead of just reversing the slice, I figured explicitly sorting was better. Let me know if there's a desire and easy way to push down the sort layer into whatever lists these keys. (Or pull it into the rendering layer). Test Plan: Modified test to add keys out of order and ensured that they are returned in sorted order (newest first) Reviewers: nserrino, michelle, #engineering Reviewed By: nserrino, #engineering JIRA Issues: PC-577 Differential Revision: https://phab.corp.pixielabs.ai/D6612 GitOrigin-RevId: c248bb9c388d9b75426ba87cf423f181d12e5403
-
Yaxiong Zhao authored
Summary: process name is a regex searched in the process' cmdline Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6559 GitOrigin-RevId: 40ebb0e1153bb92e53184377fbc3a41b7eb023f3
-
Nick Lanam authored
Summary: ^ Test Plan: Try authenticating from the CLI. The completion and error modes should both center their text now. Reviewers: nserrino, michelle, zasgar, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6613 GitOrigin-RevId: 4064955b3e704b663b46ac9ae75e910acf077aec
-
Yaxiong Zhao authored
Summary: This is necessary to reduce BCC code stack size, which is subject to 512 bytes limit. This technique is a standard idiom in BCC. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6563 GitOrigin-RevId: fdaa6e0cb1aed83471bebe032d2bc46f8cacfae7
-
Omid Azizi authored
Summary: Use the SocketInfo detected role to set client-server role. For when accept/connect was not traced. Test Plan: Test case added. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6610 GitOrigin-RevId: b7b3a709c5968f5653f94c0e46db9d17ed9417aa
-
Omid Azizi authored
Summary: To ensure stability of AggKey in ConnStats, do not submit anything with KRoleNone. This is more acceptable now that we have role detection via connect()/accept(). Test Plan: A test case added to conn_stats_bpf_test Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6604 GitOrigin-RevId: eab73763410cea72475538869e101ac858277cc4
-
- 24 Oct, 2020 1 commit
-
-
Phillip Kuznetsov authored
Summary: preset queries test broke with the script repo changes. Here's a fix. Doesn't work with DT yet, have to make a step to compile mutation, although that's difficult. Test Plan: It's a test Reviewers: zasgar, nserrino, jamesbartlett, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6588 GitOrigin-RevId: 1b7119fdb7b1ef3de75bbca286ae67727e5036a7
-
- 26 Oct, 2020 1 commit
-
-
Omid Azizi authored
Summary: Rules follow this table: ``` // SockAddr | Protocol || Connect/Accept | Data | Close // -----------|------------||-------------------|-------------|------- // INET/UNIX | Unknown || Yes | Summary | Yes // INET/UNIX | Known || N/A | Full | Yes // Other | Unknown || No | No | No // Other | Known || N/A | No | No // Unknown | Unknown || No* | Summary | Yes // Unknown | Known || N/A | Full | Yes ``` Also some clean-up along the way (moved a few functions to keep things organized) Test Plan: Existing tests for now. Just want to make sure we don't break any of the stuff we are supposed to trace. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6600 GitOrigin-RevId: 7ceea0059ab17922108e26ecdbda9c6bf113cb82
-
- 24 Oct, 2020 1 commit
-
-
Omid Azizi authored
Summary: 1) Send ConnOpen immediately when the conn_open event is received, or immediately after an unknown connection is inferred. 2) Only send events when remote addr is resolved. No point in sending the other information since it won't go into the correct AggKey. This, plus the earlier change of removing protocol out of the AggKey, triggered a bunch of simplifications. Test Plan: Modified existing test. Note we no longer need to trigger TransferData() multiple times to trace. Also we have both server and client-side tracing. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6578 GitOrigin-RevId: 171e48b20ec0b16d9fd3da1fd73e37d448bd21ba
-
- 23 Oct, 2020 1 commit
-
-
Omid Azizi authored
Summary: Previously role was inferred from message type (request/response) and direction (egress/ingress). This adds an additional way to infer the connection direction. Test Plan: Manual Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6566 GitOrigin-RevId: c74c58d54b06deeb066f464f895070098f2e199b
-
- 25 Oct, 2020 3 commits
-
-
Omid Azizi authored
Summary: Detect whether an established connection is a client or server, by considering whether there is a matching IP:port in the listening state. To be used for ConnStats role inference, when a connection connect()/accept() was not traced. Test Plan: Test case added. Reviewers: yzhao, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6607 GitOrigin-RevId: af4ddc90d89cab0ee1eb16f74647564406fd9232
-
Omid Azizi authored
Summary: Causing an issue in a separate diff. Fix here. Test Plan: Existing tests. Reviewers: zasgar, jamesbartlett, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6608 GitOrigin-RevId: 845844b9b4f8106379dcc4ba9ae7a5dd607940b1
-
Vihang Mehta authored
Summary: `serviceWatcher` will be nil if an error was returned. So don't defer a `Stop` until we check `err` Test Plan: `dev_dns_updater` does not panic even when gcloud get config fails Reviewers: zasgar, #engineering, oazizi Reviewed By: #engineering, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D6606 GitOrigin-RevId: b5fb08973a592d03a89a673c29f65fe755ae593a
-
- 24 Oct, 2020 2 commits
-
-
Vihang Mehta authored
Summary: The default pod range is `/14` and I believe that is what was preventing me from being able to create a gke cluster. Set it to a much smaller `/21` which should be sufficient for dev purposes. Also explicitly specify the services range, set to the default value of `/20` Test Plan: `./scrips/create_gke_cluster.sh` now works. Reviewers: philkuz, michelle, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6603 GitOrigin-RevId: 7eadb93430422a446ef6db475e75d4843efd314f
-
Omid Azizi authored
Summary: Useful for debugging. Test Plan: Manual Reviewers: yzhao, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6599 GitOrigin-RevId: d1747d9b6c41a49f05389e767021fb4512fbbd91
-