This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 18 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: With the GoTLS code, we'll need dwarf_reader as well. Move the creation of dwarf_reader higher up, so it can be shared. Test Plan: Existing tests Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6765 GitOrigin-RevId: 33187f01ebbd54e49da3e0f9f92913774a6d694d
-
- 17 Nov, 2020 1 commit
-
-
Zain Asgar authored
Summary: We are moving everything over to K8s and don't need support for SSD workers anymore. This is just a simplification step. Test Plan: Jenkins Reviewers: michelle, vihang, oazizi, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6757 GitOrigin-RevId: 64e3c0c12ec09ca30e041f3d0857d1fc94a6ba8d
-
- 18 Nov, 2020 2 commits
-
-
Yaxiong Zhao authored
Add StitchFrames() function template as the common interface for stitching requests & responses of all protocols Summary: Also rename ProcessFrames() -> StitchFrames(). This matches the ParseFrame() pattern. The benefit is that it now is easier to understand the expectation on the ProcessFrames() API. Previously, ProcessFrames() is only linked, it was obscure to learn how it's invoked. In a followup diff, the common interface templates will be moved into one single header file. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6763 GitOrigin-RevId: 2a710bc4c9368645b05eeea2bb7e7d218e5f216d
-
Vihang Mehta authored
Summary: TSIA. Included a flag to disable autoscaling. Test Plan: Run the script with `set -x` with and without the `-f` flag Reviewers: philkuz, zasgar, michelle, #engineering Reviewed By: michelle, #engineering Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D6762 GitOrigin-RevId: 005c9fa435ca0d2ffb6dd7c932d98082ffcdff55
-
- 21 Oct, 2020 1 commit
-
-
Nick Lanam authored
Summary: Currently only opens from a new button in the sidebar. A future change can make it appear once automatically per user. The button does not appear on mobile (viewport widths under 960px) as the tour does not fit there and the layout is different anyway. When it's open: {F103838} Test Plan: Open the profile/admin menu in the bottom left in the sidebar. It should contain a `Tour` item that should open the tour. Reviewers: nserrino, michelle, zasgar, #engineering Reviewed By: michelle, #engineering Subscribers: htroisi JIRA Issues: PC-426 Differential Revision: https://phab.corp.pixielabs.ai/D6557 GitOrigin-RevId: a8a8670fc811314ff2fc82478d0a2a00295ca2ee
-
- 18 Nov, 2020 5 commits
-
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6755 GitOrigin-RevId: 58d452091ed4a78c6421e5a6f33887cc1f3cca55
-
Omid Azizi authored
Summary: Trying to catch a bug I see in the UI. This didn't end up revealing catching it, but worth keeping. Test Plan: This is a test. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6738 GitOrigin-RevId: 91b0008fe9ea7605c2c8aa1ac5020f1adc183541
-
Vihang Mehta authored
Summary: `storybook` + `html-webpack-plugin` seem to not play nicely with webpack4. https://github.com/storybookjs/storybook/issues/9216 Force resolving `html-webpack-plugin` to a new alpha version seems to work. `babel` modules need to be upgraded to address `.mjs` files. https://github.com/babel/babel/issues/8462 `favicons-webpack-plugin` needs to be upgraded to handle API changes for webpack plugins https://github.com/jantimon/favicons-webpack-plugin/issues/222 Upgrading to the new alpha version seems to work. A handful of other plugins also don't work due to API changes in webpack but upgrading them to their latest stable versions works. Test Plan: Build time perf for Webpack4: ``` === PHASE SUMMARY INFORMATION === Total launch phase time 1.200 s 0.59% Total init phase time 0.342 s 0.17% Total target pattern evaluation phase time 1.228 s 0.61% Total interleaved loading-and-analysis phase time 1.807 s 0.89% Total preparation phase time 0.058 s 0.03% Total execution phase time 197.507 s 97.70% Total finish phase time 0.013 s 0.01% ------------------------------------------------ Total run time 202.157 s 100.00% Critical path (197.212 s): Time Percentage Description 91.785 s 46.54% action 'Generating webpack deps src/ui/ui-deps.tar.gz' 10.071 s 5.11% action 'Generating licenses src/ui/npm_licenses.json' 40.3 ms 0.02% action 'Executing genrule //tools/licenses all_licenses' 95.316 s 48.33% action 'Generating webpack bundle src/ui/ui-bundle.tar.gz' ``` Build time perf for Webpack5: ``` === PHASE SUMMARY INFORMATION === Total launch phase time 0.020 s 0.01% Total init phase time 0.180 s 0.09% Total target pattern evaluation phase time 0.118 s 0.06% Total interleaved loading-and-analysis phase time 0.145 s 0.07% Total preparation phase time 0.007 s 0.00% Total execution phase time 207.184 s 99.77% Total finish phase time 0.004 s 0.00% ------------------------------------------------ Total run time 207.660 s 100.00% Critical path (207.116 s): Time Percentage Description 93.509 s 45.15% action 'Generating webpack deps src/ui/ui-deps.tar.gz' 10.430 s 5.04% action 'Generating licenses src/ui/npm_licenses.json' 30.0 ms 0.01% action 'Executing genrule //tools/licenses all_licenses' 103.148 s 49.80% action 'Generating webpack bundle src/ui/ui-bundle.tar.gz' ``` Reviewers: #engineering, michelle, nick Reviewed By: #engineering, michelle, nick Subscribers: nick Differential Revision: https://phab.corp.pixielabs.ai/D6761 GitOrigin-RevId: 6584b9806e6c35138b721af6e522b6da7a60b36b
-
Vihang Mehta authored
Summary: storybook addons do not behave well when hoisted so use nohoist to ensure they are all located within the components folder. As a bonus, now storybook should only be generated when components are changed. Test Plan: `yarn workspace pixie-compoents storybook` + jenkins Reviewers: zasgar, nick, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6760 GitOrigin-RevId: 6cf4f3b4154a8342c6bef04da4c57b38dbc82a86
-
Vihang Mehta authored
Summary: This plugin uses deprecated webpack hooks and prevents us from upgrading to webpack 5 Test Plan: UI build + test on jenkins should work Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6758 GitOrigin-RevId: 0faf44042b6d93564c313c6112279d1a8ce24ba3
-
- 17 Nov, 2020 2 commits
-
-
Zain Asgar authored
Summary: This script reports the Bazel targets for different build configurations. The output of this will be used by Jenkins to run targets as necessary. Test Plan: Tested locally. Reviewers: michelle, vihang, oazizi, #engineering Reviewed By: vihang, oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6748 GitOrigin-RevId: dd4d4782705b8acce79f18359e61cb86cc89247b
-
Omid Azizi authored
Summary: More context for the user. Now the json output will have the record type (e.g. A vs AAAA). Also cname records (aliases) are output, similar to nslookup. Test Plan: Test cases updated. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6736 GitOrigin-RevId: 50eb291676fcd4e9b27987bb973ea58903c341fb
-
- 16 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: Deprecated pieces. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6749 GitOrigin-RevId: d97a79ffa19461d8d0c56e7743396a0766f08660
-
- 17 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: - Setup baseUrl and use root relative imports where necessary - Setup prettier and format all files - TODO: arc lint setup for prettier Test Plan: `yarn build` Reviewers: nick, #engineering Reviewed By: nick, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6751 GitOrigin-RevId: bf4c0818664b5da31dde412edcf040e6ba04097a
-
- 02 Nov, 2020 1 commit
-
-
Nick Lanam authored
Summary: Resizing any column should now be substantially more intelligent. Columns will do their best not to change sizes outside of the one being dragged, but they will yield if they need to. The table as a whole shrinks and grows to help with this. Test Plan: Open a script with a good number of columns like `px/http_data` and play around with resizing columns. Do the same for a table with fewer columns, like `px/agent_status`. See implementation and unit tests for full details on how it should behave. KNOWN ISSUE: For the latter, the first movement jumps all of the column widths to something more uniform. That will be investigated in a future change. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: vihang, #engineering JIRA Issues: PC-655 Differential Revision: https://phab.corp.pixielabs.ai/D6747 GitOrigin-RevId: 6f8d4828a7b251a35e4ef819ad106aeb7dcc0694
-
- 16 Nov, 2020 2 commits
-
-
Omid Azizi authored
Summary: Just adding a space. Test Plan: Jenkins Reviewers: nick, philkuz, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6752 GitOrigin-RevId: 64f9b381faf4013724747e84363b5f28577fc714
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn test` Reviewers: nick, #engineering Reviewed By: nick, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6750 GitOrigin-RevId: a57af73e138bb912c1e88838338bba0e3a76d5a4
-
- 14 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` and storybook Reviewers: zasgar, michelle, nserrino, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6746 GitOrigin-RevId: 58c50f7e0a85022df0d60d81bac01baa62c810e4
-
- 13 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: Disable BPF data transfer to reduce performance overheads Test Plan: Test added. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D5017 GitOrigin-RevId: 24c8835fe15cb867b85698b1f7c59d9ea7430c41
-
- 14 Nov, 2020 1 commit
-
-
Natalie Serrino authored
Summary: There was a previous issue with clang where one of our exec graph tests was falsely triggering TSAN. With the latest upgrade to clang, this issue no longer appears. Test Plan: Ran TSAN Reviewers: vihang, #engineering Reviewed By: vihang, #engineering JIRA Issues: PP-2202 Differential Revision: https://phab.corp.pixielabs.ai/D6745 GitOrigin-RevId: 28416580ff59a0acc9f965a05a191d2677dc130c
-
- 13 Nov, 2020 5 commits
-
-
Vihang Mehta authored
Summary: TSIA. This snuck into D6741 Test Plan: NA Reviewers: michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6743 GitOrigin-RevId: 9e5041263f9814e0d429260cc54588beb47e990e
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` and storybook Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6741 GitOrigin-RevId: d41315c3dc384c1dd87aba23c791c3ce52572a64
-
Vihang Mehta authored
Summary: TSIA, this got a bit hairy because code-editor wanted access to shortcuts to unregister monaco's bindings. I think I landed on a clean solution but open to feedback. Test Plan: `yarn dev` and storybook Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6737 GitOrigin-RevId: 4b2f3a9a2fa69a990aa55b51753c42d4b9474811
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` and storybook Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6735 GitOrigin-RevId: 30c3bb8c4ff19c2ba24002fa98a11dc0b612369d
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6730 GitOrigin-RevId: 6b66dc48e603f1e571e8361f9b1ff5a566f5f264
-
- 12 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` and storybook Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6726 GitOrigin-RevId: 4076de63cb0cff74dcc6a67e102e39367c05535f
-
- 13 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: TSIA. `mui-theme` overrides the Palatte interface and a hence needed to also be moved to ensure that things didn't complain about the Palette type and non existent props. Sigh. Test Plan: `yarn dev` Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6725 GitOrigin-RevId: 530872fdafc51b8959985c1f9279e3039321d223
-
- 12 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: TSIA Test Plan: `yarn dev` Reviewers: zasgar, michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6724 GitOrigin-RevId: 1b997c3f142e95ac438b21874c8aff6c5c17e834
-
- 13 Nov, 2020 2 commits
-
-
Vihang Mehta authored
Summary: This sets up a pixie-components subpackage and moves the drawer compoenents into it. TODO: Fix styling. It looks like the styles for the drawer components gets overriden when used by the pixie app. Should we be exporting unstyled components and let the pixie app call the styling hooks? TODO: Setup linting for components. The top level eslint + tsconfig doesn't play nicely with a component with it's own eslint + tsconfig. This linter setup needs some help. Stories are still in top level pixie to make it easier to debug whether the packaging is working, to be moved into subcomponents eventually. Test Plan: Check `yarn storybook` and `yarn dev` Reviewers: zasgar, michelle, nick, philkuz, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-1680 Differential Revision: https://phab.corp.pixielabs.ai/D6710 GitOrigin-RevId: cc65338599b74809a5d23ccb1cb12145bea63418
-
Vihang Mehta authored
Summary: `go vet` assumes that colocated `.go` and `.cc` files must be built together with `cgo`. In scenarios where we don't need/want to do so, let's move the `.go` source into subfolders. Note: This makes the build rule for the go libs looks a bit weird ... they end in `/go:go_default_library` but IMO this is still cleaner than moving the `.cc` and `.h` files. Test Plan: `bazel build //...` should succeed. Reviewers: zasgar, michelle, philkuz, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6739 GitOrigin-RevId: c6c80acaa32d203aed6b59d88a20d2c8f50d33b6
-
- 12 Nov, 2020 1 commit
-
-
Yaxiong Zhao authored
Summary: Also updated EqualsProto() to use DiffLines() to report the diffs. A sample looks like this: ``` deployment_spec { path: "src/stirling/obj_tools/testdata/dummy_go_binary_/dummy_go_binary" } structs { l: name: "out_table_value_t" r: name: "out_table_value2_t" ``` Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6711 GitOrigin-RevId: 0d6fb3b7faaa5e29e9d79cc79677de39df6855f5
-
- 13 Nov, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: they usually start in the non-hierarchical view by default. in some graphs, we always want to see them the hierarchical view first. Test Plan: ran in webpack Reviewers: zasgar, nserrino, nick, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6740 GitOrigin-RevId: 84fd29b087a9e164718188eb7f9cefdf04b99866
-
- 12 Nov, 2020 2 commits
-
-
Omid Azizi authored
Summary: This diff changes the behavior of px.sum on booleans to return a sum rather than a logical OR. We need a consistent definition of what the sum of two booleans means. So I'm leaving this as a preview until we can make that call. If we decide boolean + boolean = boolean, then this diff is not correct. Note that different languages (or even libraries within languages) have differing approaches. The right long-term solution is to do this via data type casts. So this could be a temporary workaround until that is supported. Test Plan: Modified the tests Reviewers: philkuz, nserrino, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6728 GitOrigin-RevId: 1b0c3a321276b1fb6871991d16d0421edbbec9f9
-
Yaxiong Zhao authored
Summary: Was using this to debug the duplicate req/resp body bug. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6721 GitOrigin-RevId: 16d5261aed012605997b450cefbd218ee02643bd
-
- 13 Nov, 2020 5 commits
-
-
Michelle Nguyen authored
Summary: we should have a help icon in the sidebar which opens up the messenger. when the user runs into an error, we should have a link that opens up the intercom messenger. Test Plan: gifs: {F103061} {F103062} {F103063} Reviewers: zasgar, nick, nserrino, #engineering, vihang Reviewed By: #engineering, vihang Subscribers: vihang Differential Revision: https://phab.corp.pixielabs.ai/D6729 GitOrigin-RevId: b7d733961824d061e34720b7ae1c39072fc4ec12
-
Michelle Nguyen authored
Summary: we used to have this information in the signup event, but it has since disappeared because of some refactoring. it's helpful to have, for joining different tables in bigquery. Test Plan: unit test Reviewers: zasgar, nserrino, #engineering, vihang Reviewed By: #engineering, vihang Differential Revision: https://phab.corp.pixielabs.ai/D6731 GitOrigin-RevId: 7567c601fc4655362bcbf3f3f7f797766a482155
-
Michelle Nguyen authored
Summary: when adding users to the ui_prod table in segment, we also want to capture the emails so that we dont have to do extra joins to get that info in bigquery. Test Plan: n/a Reviewers: zasgar, nserrino, nick, vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6732 GitOrigin-RevId: 31d52c0822b193928bef72e3eaa07355f154d98d
-
Phillip Kuznetsov authored
Summary: This reverts commit 01f74ebb2f608c65ddc0f6954d17c67c679a5190. Part of our decision to keep the time type around and instead make it more comp0atible with arrow. Test Plan: teseted locally and things still work in normal mode. Reviewers: nick, nserrino, vihang, zasgar, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6733 GitOrigin-RevId: 872e49dfc79c8c3d6775d3bdc83ef284fddf07b9
-
Nick Lanam authored
Summary: What I thought was a harmless Scout Rule change was, in fact, harmful. Test Plan: Run `px/cluster` with a long start_time, like an hour. Cancel it before it returns. Then try to run `tcp_retransmits` with fresh tracepoints. The visual loading indicator should stick around for the correct duration. This time, also check that execution stats are retained. Reviewers: michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6734 GitOrigin-RevId: 0bb50d4e49cd8bee1b7dc5fb47a9c9edcc07c3d1
-
- 12 Nov, 2020 1 commit
-
-
Nick Lanam authored
Summary: As every query run and retry cancels the previous one, the user cancelling one script then trying to run another that has mutations was triggering a second cancel on the first query. Due to awkward timing, that was setting loaded state to false a second time right after the second query started, so the tracepoints dialog thought it needed to hide. The fix is for the cancellation function to run once and replace itself with a noop. Test Plan: Run `px/cluster` with a long start_time, like an hour. Cancel it before it returns. Then try to run `tcp_retransmits` with fresh tracepoints. The visual loading indicator should stick around for the correct duration. Reviewers: nserrino, michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6727 GitOrigin-RevId: e0e83aef3549c02676d6c462c5f5948c5ba23560
-