Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 20 Jan, 2022 1 commit
    • Pete Stevenson's avatar
      PerfProfiler: Add method GetNumberOfSymbolsCached() to symbolizer. · c89db08a
      Pete Stevenson authored 
      
Summary: Add a method to get number of symbols cached (across all symbol caches) into the symbolizer. NB the symbolizer provides an API that converts a pid, virtual address tuple into a symbol and may include a cache of previously converted symbols. With no cache, this method returns 0. With a cache, this method iterates all caches (per pid) and sums up the number of symbols cached. We are adding this to help diagnose memory use.

Test Plan: Update to symbolizer test.

Reviewers: #stirling, oazizi

Reviewed By: #stirling, oazizi

Subscribers: yzhao, oazizi

JIRA Issues: PP-3171
Signed-off-by: default avatarPete Stevenson <jps@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10485

GitOrigin-RevId: 8a2d8aa5cefe241fea81f191f3b6901c919604ba
      c89db08a
  3. 19 Jan, 2022 16 commits
  5. 18 Jan, 2022 7 commits
    • Zain Asgar's avatar
      Fetch all artifacts during Jenkins builds · cf75e55f
      Zain Asgar authored 
      
Summary: This will fetch all artifacts to avoid caching issues during the Jenkins build.

Test Plan: Jenkins

Reviewers: vihang, oazizi

Reviewed By: vihang, oazizi
Signed-off-by: default avatarZain Asgar <zasgar@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10531

GitOrigin-RevId: bfeec20d024b3f5621e6a039dd204fcd4d716fa7
      cf75e55f
    • Nick Lanam's avatar
      [PC-1285] Show users they're in a managed org · 156834cf
      Nick Lanam authored 
      
Summary:
When the user is in a managed org (such as Google Workspaces)...
- Shows a banner in the users tab of Admin.
  - This has details and a link to the org settings tab for approvals.
- Shows a banner in the profile menu.
- Hides the section to reset invitation links.
- Changes the invitation dialog to have a signup link.

When in a managed org, these are the new things you'll see:
{F176534}
{F176535}

Test Plan:
Open the Users view in Admin on a managed account.
- There should be a blue banner explaining this.
- Clicking the link inside should go to org settings.
- Changing approval settings should change the banner.
- Option to reset invite links in Org Settings should be hidden.
- Opening the "Invite Members" dialog should look different.

You can quickly test the non-managed experience by changing line 269 of `src/ui/src/containers/App/live.tsx` to read `domainName: null` instead of `domainName: orgDomain`. In this case, behavior should match what happens without this diff:
- No blue banner in users tab
- Invite button says "Invite Users" instead of "Invite Members"
- Dialog summoned by invite button generates an invitation link
- No banner in profile menu
- Option to reset invitation links in Org Settings tab exists again

Reviewers: michelle, vihang

Reviewed By: vihang

JIRA Issues: PC-1364, PC-1366
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10529

GitOrigin-RevId: 610e056762ead12542b7461f0787952035f6165a
      156834cf
    • Phillip Kuznetsov's avatar
      PC-1374: Add prom annotation for indexer testing · c5fe3948
      Phillip Kuznetsov authored 
      
Summary:
Missing annotation meant that prometheus wouldn't scrape this data. Added the annotation
and now I'm getting this data scraped and sitting in prod.

Test Plan: Tested on the testing cluster which has a monitoring setup.

Reviewers: michelle, vihang, nserrino

Reviewed By: vihang

JIRA Issues: PC-1374
Signed-off-by: default avatarPhillip Kuznetsov <pkuznetsov@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10528

GitOrigin-RevId: 2ab40f4176880f36e43cd96d47bcff6781d6c4fc
      c5fe3948
    • Vihang Mehta's avatar
      Increase Jenkins timeout for BPF tests stage · ae85e0de
      Vihang Mehta authored 
      
Summary: TSIA, noticed we hit this a lot in D10356

Test Plan: Future Jenkins runs should be less likely to timeout

Reviewers: zasgar, oazizi

Reviewed By: zasgar, oazizi
Signed-off-by: default avatarVihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10469

GitOrigin-RevId: 7be4e303527e7804f0986cc522fdb84e4988f54f
      ae85e0de
    • Vihang Mehta's avatar
      Fix idea excludes · 7ae3869c
      Vihang Mehta authored 
      
Summary:
TSIA, the bazel build dirs changed at somepoint but the excluded didn't.
This ensures that GoLand doesn't try to index the build dir.

Test Plan: Ran goland, indexing was faster.

Reviewers: zasgar

Reviewed By: zasgar
Signed-off-by: default avatarVihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10522

GitOrigin-RevId: 7d6987e78bd48926cdd95eafe52b69aac2a339ac
      7ae3869c
    • Omid Azizi's avatar
      [Cleanup] HTTP Parser: Create pico wrapper · 6bed9064
      Omid Azizi authored 
      
Summary:
Create wrappers around Pico HTTP parser calls.

This in preparation of a future a coming bug-fix in processing HEAD responses. In that upcoming work, we need to attempt another response parse, so this will help avoid duplicated code.

Test Plan: Existing tests

Reviewers: #stirling, yzhao

Reviewed By: #stirling, yzhao

Subscribers: yzhao
Signed-off-by: default avatarOmid Azizi <oazizi@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10519

GitOrigin-RevId: ea22a2a8c17287afb6aee2e8e9565c29ca6ab932
      6bed9064
    • Michelle Nguyen's avatar
      PC-1368 Update batch size for missing metadata responses · 1a49d85b
      Michelle Nguyen authored 
      
Summary: We can handle larger batches from Vizier in our cloud, so we should increase it to avoid overloading the STAN queues

Test Plan: updated unit tests so that they arent hardcoded with a particular batchsize

Reviewers: vihang, zasgar

Reviewed By: vihang

JIRA Issues: PC-1368
Signed-off-by: default avatarMichelle Nguyen <michellenguyen@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10521

GitOrigin-RevId: d1c13cc06567aad01056ccf90a3e666ef51e562d
      1a49d85b
  7. 15 Jan, 2022 7 commits
    • Michelle Nguyen's avatar
      PC-1359 Add sentry to Pixie Cloud · b8e13972
      Michelle Nguyen authored 
      
Summary: You can use Sentry to track and manage errors. We already allow the use of Sentry in the UI and Vizier, so we should also add it to our cloud

Test Plan: Deploy to staging and check errors are flowing to Sentry

Reviewers: vihang, zasgar, nserrino

Reviewed By: vihang

JIRA Issues: PC-1359
Signed-off-by: default avatarMichelle Nguyen <michellenguyen@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10498

GitOrigin-RevId: cd19a56c14e2308e81d2534955aa38fb6ecab43e
      b8e13972
    • Nick Lanam's avatar
      [PC-1363] Track sharing dialog usage · c9f9f9e4
      Nick Lanam authored 
      
Summary:
Tracks three events:
- Opening the link sharing dialog (Live View nav button)
- Clicking the link inside to the admin invitations
- Clicking the DNS instructions
- Clicking the "Copy Link" button.
Only tracks when analytics are enabled (you can always opt out).

Test Plan:
Open Live UI. Click new button in top right corner.
Click the links; all should track but only if analytics are enabled.

Reviewers: michelle, vihang

Reviewed By: michelle

JIRA Issues: PC-1363
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10516

GitOrigin-RevId: ae075be7ec6aaa7e2bf7e78db5e5fb3b0a9187e3
      c9f9f9e4
    • Nick Lanam's avatar
      [PC-1380] Invite link direct to dialog from share · bc4b980b
      Nick Lanam authored 
      
Summary:
The new Share Script dialog in Live has a link to admin.
It's meant to go to user invitations; that's a dialog.
This change makes it open that dialog.

Test Plan:
Open Live UI. Click new button in top right corner.
Click "Admin View" link.
It should go straight to the invite users dialog in Admin.
Closing the dialog should clear the URL search param used for this.

Reviewers: michelle, vihang

Reviewed By: michelle

JIRA Issues: PC-1380
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10517

GitOrigin-RevId: aadc3ce7e44c28acd8fbf04badbb2cea7382d059
      bc4b980b
    • Nick Lanam's avatar
      [PC-1362] Add Live View button to share link · 36430ab3
      Nick Lanam authored 
      
Summary:
Opens a dialog which allows for copying the page's current URL.
Includes links to details surrounding user invitation.

The button:
{F176404}

Disabled when the currently selected script is a scratchpad:
{F176410}

The dialog (in CC4P):
{F176405}

And in open source:
{F176406}

Test Plan: Open Live UI. Click new button in top right corner. Click links; click copy button. Try closing dialog with `Escape` key or clicking on the background. Should behave like other dialogs already do.

Reviewers: michelle, vihang

Reviewed By: michelle

JIRA Issues: PC-1362
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10515

GitOrigin-RevId: 4dc8e64ad56e70898dd5331044196441102b0ff8
      36430ab3
    • Nick Lanam's avatar
      [PC-819] Upgrade TypeScript to 4.5.4 · bea08f3c
      Nick Lanam authored 
      
Summary: Due to cross-dependent updates, also updates ESLint and Babel's plugin for it. Doing any of these without the others causes strange breakages; doing it all at once doesn't.

Test Plan: `yarn dev`. Smoke test. `yarn test`, `yarn lint`, and `yarn build_prod` should also continue to behave.

Reviewers: michelle, vihang, #third_party_approvers, zasgar

Reviewed By: #third_party_approvers, zasgar

JIRA Issues: PC-819
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10487

GitOrigin-RevId: bb5f38c423ff1fd3d2f77b455f7a37bbdf2771ce
      bea08f3c
    • Nick Lanam's avatar
      [PC-819] Prepare for updates to TypeScript, ESLint, and Babel · 59e32fe5
      Nick Lanam authored 
      
Summary:
Incoming upgrades will adjust a few rules and reveal a few type errors; this diff fixes those in advance.
- Spacing around pipes in type unions (eslint recommended rule didn't recognize this case before, it will on upgrade)
- CodeRenderer and MutationModal had faulty typings; slight adjustment takes care of that. TypeScript before version 4.2 didn't realize it.
- Needed to add `coverage` to eslint's ignore list

The next diff will actually update dependencies, all at once (there's a fair bit of cross-dependency in the changes they made).

Test Plan: `yarn dev`. Nothing should be different; specifically verify that the editor and the mutation scripts modal hasn't changed.

Reviewers: michelle, vihang

Reviewed By: michelle

JIRA Issues: PC-819
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10486

GitOrigin-RevId: 4031d46d8c47f364042bd25c133818a39deccdff
      59e32fe5
    • Nick Lanam's avatar
      [PC-1360] Update Yarn to 3.1.1 · 905da33d
      Nick Lanam authored 
      Summary:
Routine tooling update.

Why: Bugfixes in Yarn itself; make it possible to update other dependencies including TypeScript.

How:
- `yarn set version latest`
- Update `@yarnpkg/pnpify` in `package.json`
  - This got split into 3 packages; we don't use two of them.
- Manually ran `yarn dlx @yarnpkg/sdks` to complete the upgrade
- Update any places that referenced `.pnp.js`, as that changed to `.pnp.cjs` and a new `.pnp.loader.mjs` exists.
- Re-run `yarn install` (without purging lock). This changed every checksum due to adjustments under the hood, but the packages are all the same.
- An extra once-over [Yarn's release notes](https://github.com/yarnpkg/berry/blob/master/CHANGELOG.md#300

) for versions after 2.4.1 (the version we were on).

Test Plan:
- Pull this branch.
- `yarn install`
- `yarn typecheck`
- `yarn build_prod` (should see no surprises)
- `yarn test` (should pass)
- `yarn dev` and smoke test.
Hypothetically, the build and typecheck should be marginally quicker. In practice, it's negligible. There should be no other visible changes; this is a maintenance update.

Reviewers: michelle, vihang, #third_party_approvers, zasgar

Reviewed By: #third_party_approvers, zasgar

JIRA Issues: PC-1360
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10481

GitOrigin-RevId: d4c999cc6ba7bcda41a311a8aa898cef81c47569
      905da33d
  9. 14 Jan, 2022 9 commits

免费DevSecOps平台，让您的项目体验完整的DevSecOps流程，让项目更安全