This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 21 May, 2021 2 commits
-
-
Pete Stevenson authored
Summary: stringifier.cc: revert code that is unsafe for empty stack trace strings. Test Plan: Existing. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi JIRA Issues: PP-2688 Differential Revision: https://phab.corp.pixielabs.ai/D8682 GitOrigin-RevId: 3d97d5e4747ac747ac9309a0f28ac8c7f570ad59
-
Yaxiong Zhao authored
Summary: The existing truncation is removed to avoid duplication. Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8679 GitOrigin-RevId: 7a8acd55ea75f642fb992f328842f3fb78991506
-
- 20 May, 2021 14 commits
-
-
Pete Stevenson authored
Summary: In the perf profiler connector, during stack trace aggregation, allow kernel stack-ids to remain in the stack traces table when encountered in the non-symbolizing branch. Test Plan: Existing. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi JIRA Issues: PP-2688 Differential Revision: https://phab.corp.pixielabs.ai/D8678 GitOrigin-RevId: 843121966cc63091e8c9a0499c709b80a1bbc151
-
Pete Stevenson authored
Summary: In the stirling perf profiler, add a Stringifier class to independently memoize folded symbolic stack traces for user & kernel stack-ids. Fixes the bug of 'empty stack traces' that came as a result of removing stack-ids from the stack table as we iterated through histogram (and then later finding, e.g., the same user stack-id paired with a different kernel stack-id but not being able to read the stack trace addrs because the user stack-id was already removed). Test Plan: stringifier_test (added in this patch) and existing tests. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi JIRA Issues: PP-2688 Differential Revision: https://phab.corp.pixielabs.ai/D8635 GitOrigin-RevId: 4cf38512bdb69bee15966173c71cfe2936030353
-
Vihang Mehta authored
Summary: Takes care of refreshing the editor when the breadcrumbs change, updates the URL whenever breadcrumbs change even if it doesn't yet represent a valid run, auto-runs the script when anything changes if doing so would be valid. Puts back the `/live/clusters/:cluster/script` route for scripts that don't have special routing. DOES NOT re-enable the pod or namespace special URLs yet (nor does it yet put in redirects for them). Test Plan: Visit `withpixie.ai:8080/` with `USE_SIMPLIFIED_ROUTING=true` in `vizier.tsx`. Scripts should execute automatically when the URL contains valid execution params. The breadcrumbs changing should automatically update the editor and run the script when doing so is valid. A number of weird errors should now show the snackbar instead of whitescreening the entire page. Reviewers: vihang, philkuz Reviewed By: vihang Subscribers: philkuz, vihang JIRA Issues: PC-944 Differential Revision: https://phab.corp.pixielabs.ai/D8665 GitOrigin-RevId: 90af447083657ab31c4d806bc3e8c06c0db8c075
-
Phillip Kuznetsov authored
Summary: Cleaning up code to improve readability and help out future devs. Test Plan: n/a Reviewers: vihang Reviewed By: vihang JIRA Issues: PC-942 Differential Revision: https://phab.corp.pixielabs.ai/D8673 GitOrigin-RevId: c4f45e539cbb1897af6f2cc8b817799373a11c81
-
Vihang Mehta authored
Summary: New execute button to save editor which will in turn run the script. Test Plan: Tested with `USE_SIMPLIFIED_ROUTING = true` Reviewers: philkuz, nlanam Reviewed By: philkuz JIRA Issues: PC-942 Differential Revision: https://phab.corp.pixielabs.ai/D8672 GitOrigin-RevId: f8bbd70df54956286f0739a3971451adbcbeb442
-
Phillip Kuznetsov authored
Summary: more misc react useEffects from old to new live view. 1. CancelExecution after unload 2. Disable moving widgets on mobile 3. escape will exit move mode for widgets Test Plan: Tested on yarn dev Reviewers: vihang, nlanam, michelle Reviewed By: vihang JIRA Issues: PC-942 Differential Revision: https://phab.corp.pixielabs.ai/D8666 GitOrigin-RevId: 937240553c0805f28f6af712e7a0cf8e7842d139
-
Michelle Nguyen authored
Summary: there was a warning complaining that the onClick should actually be on the IconButton. moved the onClick to the iconButton Test Plan: yarn dev Reviewers: zasgar, vihang, nlanam, philkuz Reviewed By: vihang JIRA Issues: PC-940 Differential Revision: https://phab.corp.pixielabs.ai/D8669 GitOrigin-RevId: 7e5a89ab575c43a93b2aeae370f875c82ce4d787
-
Hannah Troisi authored
Test Plan: n/a Reviewers: oazizi Reviewed By: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8671 GitOrigin-RevId: fb43b18d2c7ed8708dcaa48403247098a2b9d3ba
-
Vihang Mehta authored
Summary: We need to match `vizierapi_pb.js` `vizierapi_pb.d.ts` `VizierapiServiceClientPb.ts` but not `_objs` The matcher was too loose initially and matched `_objs`, then I made to too restrictive and it stopeed matching `VizierapiServiceClientPb.ts`. Now it does the correct thing again. Test Plan: Ran the script. Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8670 GitOrigin-RevId: 892d339ec12b7ddff2daa866ab26031f88be61c1
-
Zain Asgar authored
Summary: Adds a gutter column that can be used to show status information. Test Plan: N/A, spec change. Reviewers: michelle, vihang, nlanam Reviewed By: vihang JIRA Issues: PC-931 Differential Revision: https://phab.corp.pixielabs.ai/D8662 GitOrigin-RevId: a476a332734250161af07d9a6a9a534c8d851533
-
Michelle Nguyen authored
Summary: The datadrawer is not useful enough to need its own toolbar at the bottom of the page. instead, we provide it a small toggle that allows users to open/close the drawer. Test Plan: yarn dev screenshot: {F157131} {F157132} Reviewers: nlanam, philkuz, vihang, zasgar Reviewed By: vihang JIRA Issues: PC-940 Differential Revision: https://phab.corp.pixielabs.ai/D8667 GitOrigin-RevId: b3c44a36dba0c2e40769ece695e9e9d575f5277c
-
Michelle Nguyen authored
Summary: having them always blue and underlined is distracting. we can show people that these are clickable links by changing the style on hover. generally, people are used to table values being clickable. Test Plan: screenshot {F157137} Reviewers: zasgar, vihang, nlanam, philkuz Reviewed By: vihang JIRA Issues: PC-931 Differential Revision: https://phab.corp.pixielabs.ai/D8668 GitOrigin-RevId: 446b27607c05d3a410c6aee6dc4ad85b8f303658
-
Phillip Kuznetsov authored
Summary: TSIA Test Plan: tested on yarn dev Reviewers: vihang, nlanam, michelle Reviewed By: vihang JIRA Issues: PC-942 Differential Revision: https://phab.corp.pixielabs.ai/D8664 GitOrigin-RevId: 6369640bb7a293bc1cc1e55aae0b71a538aa3ec6
-
Phillip Kuznetsov authored
Summary: Cluster loading component was not acting consistenly with the old stuff, so I fixed it and probably fixed PC-881. Basically switched over from some janky timer component to instead check to see whether a user has run a script on the cluster during the current LiveView session. If they have not, we will show a loading circle. If the cluster is unhealthy, we show an Alert. Test Plan: tested on yarn dev w/ 3 types of clusters 1. Healthy cluster, from start. > shows a ClusterConnecting dialog, then goes away after data loads. 2. Healthy cluster, edit px/namespace then rerun > Does not show clusterconnecting dialog, should just change layout 3. Disconnected cluster > shows an unhealthy alert, never the diagram. 4. Switch from healthy cluster to healthy cluster > same as 1 Reviewers: nlanam, vihang, michelle Reviewed By: vihang JIRA Issues: PC-942, PC-881 Differential Revision: https://phab.corp.pixielabs.ai/D8663 GitOrigin-RevId: 355c2e1f4ca51936c85b6528a86f67e4436d8e2f
-
- 19 May, 2021 18 commits
-
-
Yaxiong Zhao authored
Summary: Achieved through calling ParsePartialFromArray(). Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8656 GitOrigin-RevId: b302722b534c14f43a1399bf43dc66b0376784f2
-
Phillip Kuznetsov authored
Summary: TSIA Test Plan: Tested on yarn dev, the colors seem off, would appreciate some help why they look so drastically different. Reviewers: michelle, nlanam, vihang Reviewed By: nlanam, vihang JIRA Issues: PC-917 Differential Revision: https://phab.corp.pixielabs.ai/D8660 GitOrigin-RevId: 925b102ab4fae9196ce5efff489e0e644152e803
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi, jps Differential Revision: https://phab.corp.pixielabs.ai/D8648 GitOrigin-RevId: d8a3c6ba58356c980967e9206eef71f581bd580d
-
Michelle Nguyen authored
Summary: we are adding a topbar to the UI which contains actions relevant to the current screen + the profile icon we also want to move the cluster selector into here + the run button. that will come in a followup diff. Test Plan: screenshot: {F157037} Reviewers: zasgar, nlanam, vihang Reviewed By: vihang JIRA Issues: PC-940 Differential Revision: https://phab.corp.pixielabs.ai/D8659 GitOrigin-RevId: 7817d8c2f1434b3e6019db6e26ee0c53fb7cdea0
-
Vihang Mehta authored
Summary: This is a durable queue subscription so the subscription should resume where we left off. The only time we want `DeliverAll` is when we update the index version and would like to reindex everything available. Using a queue based on the index version helps achieve this behavior. Also add a MaxInflight to add some backpressure to stan message delivery. Test Plan: dev cloud Reviewers: zasgar, michelle Reviewed By: michelle JIRA Issues: PP-2743 Differential Revision: https://phab.corp.pixielabs.ai/D8658 GitOrigin-RevId: a6dabb3a18257d4f1066512b771c92571473820f
-
Phillip Kuznetsov authored
Summary: Make new canvas, added it to live, and added nav. Test Plan: tested on yarn dev Reviewers: nlanam, vihang, michelle Reviewed By: vihang JIRA Issues: PC-942, PC-943 Differential Revision: https://phab.corp.pixielabs.ai/D8657 GitOrigin-RevId: c4f468a0ccbd5cadf972f18bf86b1ef708f467f0
-
Vihang Mehta authored
Summary: Use a RWMutex to allow concurrent reads. Add some helper methods to proxy map access. Incase contention for holding the lock ever becomes a bottleneck here, this should help alleviate some of those issues. Test Plan: Run on staging cloud with multiple viziers. Reviewers: zasgar, michelle Reviewed By: zasgar JIRA Issues: PP-2743 Differential Revision: https://phab.corp.pixielabs.ai/D8654 GitOrigin-RevId: fe4b0c344610715f38ca61528ab189cbe56aeb58
-
Michelle Nguyen authored
Summary: D8645 updates the UI to use MaterialUI paper components, but keeps our custom styling. This diff removes that custom styling so that we are using the computed MaterialUI coloring. Test Plan: yarn dev Reviewers: nlanam, vihang, zasgar Reviewed By: zasgar JIRA Issues: PC-929 Differential Revision: https://phab.corp.pixielabs.ai/D8646 GitOrigin-RevId: 3e1d328bd4504e254f72c567c758059ffbb23d8a
-
Omid Azizi authored
Summary: HTTP table's resp_message column is going to go away. The number of users of the column are likely very low, and it's redundant information. As a courtesy, we'll provide a UDF to convert the status codes to messages (e.g. 404 -> Not Found). I followed the pattern of `net` for this, but it might be better as part of builtins. Please let me know the preferred location and naming for consistency. Test Plan: Test added Reviewers: philkuz, nserrino Reviewed By: philkuz Subscribers: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8630 GitOrigin-RevId: 835cbfe3f4f4f31fe1afd93cf3c63e5be10e0b1f
-
Michelle Nguyen authored
Summary: We're going to polishing our UI, which includes updating our colors/palette. as part of the process, we should use MaterialUI paper for our different surfaces. MaterialUI will automatically compute the background color for the surfaces based on Material's design patterns. This diff is an intermediary step, where we update our UI to use paper, but use our old styling. Test Plan: yarn dev, checked that UI looks ok Reviewers: nlanam, vihang, zasgar, #third_party_approvers Reviewed By: vihang, #third_party_approvers JIRA Issues: PC-929 Differential Revision: https://phab.corp.pixielabs.ai/D8645 GitOrigin-RevId: 51e37f8edd471ddb72a16e6737f83db3da9150f0
-
Michelle Nguyen authored
Summary: MaterialUI 5.0 has better support for dark theme, such as automatically computing the background color of different components depending on the component's elevation. By using this feature, we'll be able to quickly try out different color schemes in our UI just by changing the base color. Mostly followed https://next--material-ui.netlify.app/guides/migration-v4/#introduction Test Plan: `yarn dev`, make sure UI still works properly... need to get lint and jest working. Reviewers: nlanam, vihang, zasgar, #third_party_approvers Reviewed By: vihang, #third_party_approvers JIRA Issues: PC-928 Differential Revision: https://phab.corp.pixielabs.ai/D8632 GitOrigin-RevId: 5b7b021eceaa320f6f5f502a83812a6877680cd0
-
Vihang Mehta authored
Summary: TSIA. The main changes are around how we handle selecting a new script and args from the breadcrumbs. This change now uses `React.useState` and `React.useEffect` to handle arg validation and sending updates to the script context. Test Plan: Ran it with `USE_SIMPLIFIED_ROUTING = true` Reviewers: nlanam, philkuz, michelle Reviewed By: nlanam JIRA Issues: PC-922 Differential Revision: https://phab.corp.pixielabs.ai/D8655 GitOrigin-RevId: dec0d2fc2149929ceb0e368a81357cf80597e5f4
-
Vihang Mehta authored
Summary: These logs were coming in quite fast and could be the reason that indexer consumes so much CPU. Test Plan: N/A Reviewers: zasgar, michelle, jamesbartlett Reviewed By: zasgar JIRA Issues: PP-2743 Differential Revision: https://phab.corp.pixielabs.ai/D8653 GitOrigin-RevId: d545307920fc6590089ccabfc56af9f0a4732ae3
-
Phillip Kuznetsov authored
Summary: Adding live view shortcuts to make opening the editor easy. Should just be reintroduction of these components. Test Plan: Tested on yarn dev Reviewers: nlanam, vihang Reviewed By: vihang JIRA Issues: PC-917 Differential Revision: https://phab.corp.pixielabs.ai/D8650 GitOrigin-RevId: ced91c7ba7c4b0133d9ed3fdda45a4c8160010cd
-
Vihang Mehta authored
Summary: This is necessary because we are upgradeing to mui@5 which uses esm modules. ESM in node modules are not transformed by default. Unfortunately, changing the tranform rules is not enough since some Babel config is preventing the transformation without the extra level of indirection. Test Plan: tested with current version and update mui. Reviewers: michelle, vihang, nlanam Reviewed By: vihang JIRA Issues: PC-937 Differential Revision: https://phab.corp.pixielabs.ai/D8651 GitOrigin-RevId: a6d0a2b497b88e02222ccc771867008fed108c56
-
Vihang Mehta authored
Summary: `bazelCICmd` can be run in k8s or docker. For the former, we retry if we catch k8s cluster downscale errors. So the command failure isn't treated as an error if it's of type cluster downscale. Since `WithSourceCodeK8s` already handles the `warnError` wrapping, we don't need to. For the latter, we add a `warnError` wrapper in `WithSourceCodeAndTargetsDocker` instead. Test Plan: jenkins Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8652 GitOrigin-RevId: 42f28ef1fcce5ecd9a6962121a1f4988c1d99f25
-
Phillip Kuznetsov authored
Summary: Rewire a new editor to use the new editor-context. Editor context takes over any of the editor related things from scriptcontext into a more coherent location. Test Plan: Tested on `yarn dev` with the script-context flag enabled. 1. Had to manually enable the editor to be open in the Application > Local Storage > `px-live-editor-opened` -> true 2. Had to update the cluster name in ` ? routeFor('px/pod', { cluster: 'gke_pl-pixies_us-west1-a_philkuz-compiler', namespace: 'barNamespace', pod: 'bazPod' })` as a valid cluster in my org. 3. Pressed the Next Route button and saw the editor contents change Reviewers: nlanam, vihang, michelle Reviewed By: nlanam JIRA Issues: PC-938 Differential Revision: https://phab.corp.pixielabs.ai/D8638 GitOrigin-RevId: a58c3dfba8f4a92f578b025a2d3b8a44c5f9f254
-
Vihang Mehta authored
Summary: Update the copyright to the Pixie Authors for public cloud and NR version for hosted cloud. Use the same mechanism to use a fake license.json for `yarn dev` but then use a generated `license.json` for prod cloud. Test Plan: `yarn dev` shows fake licenses and new NR copyright. `skaffold` cloud shows generated licenses and new NR copyright. Public repo cloud build should show public copyright. Reviewers: zasgar, michelle, nlanam Reviewed By: zasgar, michelle, nlanam JIRA Issues: PP-2747 Differential Revision: https://phab.corp.pixielabs.ai/D8647 GitOrigin-RevId: 901a5f69abeef508323e2fda7cec5c0225014c72
-
- 18 May, 2021 6 commits
-
-
Pete Stevenson authored
create_gke_cluster.sh: deprecate use of argument --username, and replace with --no-enable-basic-auth per new requirements from Google. Summary: create_gke_cluster.sh: deprecate use of argument --username, and replace with --no-enable-basic-auth per new requirements from Google. Test Plan: Users using this. Reviewers: #engineering, oazizi Reviewed By: #engineering, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8649 GitOrigin-RevId: 775b058fbbb555a51469516a776f78fd1b2ca5b8
-
Nick Lanam authored
Summary: Exposes `execute` and `cancelExecution` methods in the new `ScriptContext`; runs it when the script/args/vis/pxl change in the new `ScriptLoader`. Shows the results in the new `LiveView`. Test Plan: Visit `withpixie.ai:8080/` with `USE_SIMPLIFIED_ROUTING=true` in `vizier.tsx`. Scripts should execute automatically when the URL contains valid execution params. Reviewers: michelle, vihang, philkuz Reviewed By: philkuz JIRA Issues: PC-917 Differential Revision: https://phab.corp.pixielabs.ai/D8643 GitOrigin-RevId: 027f253de20d80f30e875e32f77ab5caaf65288a
-
Yaxiong Zhao authored
Summary: The ConnInfo and ConnStats exporting is significant. Without this, CPU usage on single node cluster with sock-shop and online-boutique grows to 10%. Test Plan: Manually verify the CPU usage drops with this diff Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8642 GitOrigin-RevId: ffdead9801e75b7fb2887ec88f09a3534a7372f7
-
Zain Asgar authored
Summary: This gives us better support for ES modules, which is useful when we upgrade to a newer material-ui. Test Plan: Existing Reviewers: michelle, vihang, nlanam Reviewed By: michelle JIRA Issues: PC-937 Differential Revision: https://phab.corp.pixielabs.ai/D8639 GitOrigin-RevId: 62f454a501f8130693b6fb5638ba438421b09433
-
Vihang Mehta authored
Summary: This cleans up the links for OSS deploys. Test Plan: Run `px deploy` and `px live` Reviewers: zasgar, michelle, nserrino Reviewed By: nserrino JIRA Issues: PC-913 Differential Revision: https://phab.corp.pixielabs.ai/D8634 GitOrigin-RevId: bf9656c818416b0e3ed410cb557ca86bb3ff9505
-
Phillip Kuznetsov authored
Summary: Was writing a saveEditor() function that only seemed to save one of the editors, but not the other. Both functions were called, but only 1 result remained. Turns out the second call overwrote the first one. Making the state function calls into functions themselves fixed this problem. Test Plan: Tried my save editor function in `D8638` before this change ( only setVis worked ) then after and saw that both worked. Reviewers: nlanam, vihang, michelle Reviewed By: nlanam JIRA Issues: PC-917 Differential Revision: https://phab.corp.pixielabs.ai/D8644 GitOrigin-RevId: 5c0ee3671e4f5a202cb441a8c4686df20cd1d04e
-