This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 26 Aug, 2020 11 commits
-
-
Zain Asgar authored
Summary: If we get the exact same timestamp and it happens to sort so that parent > next_parent then the loop hangs forever. In the longer term we should refactor to do this merge as a heap. Test Plan: Existing Reviewers: michelle, philkuz, nserrino, #engineering Reviewed By: michelle, nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6078 GitOrigin-RevId: bc802d88fabca64adc0549a04bcffef8ce39cd74
-
Natalie Serrino authored
PP-2117: ExecuteScript API should stream results as soon as they are available, and not batch them up in the qb. Summary: This completes the series of diffs that refactor the query broker to stream results using the query forwarder, rather than batching them up using the new deleted query executor before sending them back. I also added new tests, since we didn't actually have any ExecuteScript tests before. Depends on D6073. Test Plan: added. Reviewers: michelle, philkuz, zasgar, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6074 GitOrigin-RevId: d494e7de693ddc747538e4802125d74c431f1446
-
Natalie Serrino authored
Summary: This is going to be the pxl way to mark that a query should be executed in "infinite" streaming mode. Next up, a rule that turns StreamIR nodes into a modification on their parent MemorySources (setting stream=true). Test Plan: added a unit test Reviewers: philkuz, jamesbartlett, zasgar, #engineering Reviewed By: jamesbartlett, #engineering JIRA Issues: PP-2161 Differential Revision: https://phab.corp.pixielabs.ai/D6080 GitOrigin-RevId: 5cacfefec022888c7f2a7b9c44e28a8676aa3d02
-
Zain Asgar authored
Summary: Required as part of Apache2 license. Test Plan: N/A Reviewers: michelle, philkuz, nserrino, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6088 GitOrigin-RevId: e1a89b2bd5a76fdf747971603baec1e1c326a5ee
-
Natalie Serrino authored
PP-2161: Add streaming option to memory source IR node and propagate it down to the memory source plan node. Summary: Next up is an analyzer rule that takes StreamIRs, and sets streaming=true on their parent memory sources. Test Plan: added unit tests Reviewers: philkuz, jamesbartlett, zasgar, #engineering Reviewed By: philkuz, jamesbartlett, #engineering JIRA Issues: PP-2161 Differential Revision: https://phab.corp.pixielabs.ai/D6082 GitOrigin-RevId: a63c45e6f97bb2763c89d1cd8b7a696e81af2402
-
Phillip Kuznetsov authored
Summary: More inline docs, part of PP-2147. Still have to parse these into something useful Test Plan: runs without issues for now Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering JIRA Issues: PP-2171, PP-2172, PP-2147 Differential Revision: https://phab.corp.pixielabs.ai/D6076 GitOrigin-RevId: c9074875e15759b723dde6dcb5501d78048c3658
-
Phillip Kuznetsov authored
Summary: fix udf doc so that identity is different than description for args Test Plan: updates tests Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6084 GitOrigin-RevId: 6210e55e34d471b259ff64733d8bef2079acb487
-
Zain Asgar authored
Summary: This is needed because we started bassing creds between PEM->Kelvin. Test Plan: Tested e2e. Reviewers: michelle, #engineering, nserrino Reviewed By: #engineering, nserrino Differential Revision: https://phab.corp.pixielabs.ai/D6079 GitOrigin-RevId: f78445785e8e3718db5b4560c4a59bacfe444221
-
Michelle Nguyen authored
Summary: other diffs added the state to elastic and to the response proto. this diff actually pipes it from elastic to the response. next diff will use the state to show an icon in the UI Test Plan: ran plc-dev, confirmed that i see the state in the response Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6077 GitOrigin-RevId: 3ca1974ac75483ec533071928f9a18c83fc2f0d8
-
Natalie Serrino authored
Summary: tsia. MemorySink switched over to looking at the table type but I didn't update GRPCSink to do the same. Test Plan: added end to end tests Reviewers: jamesbartlett, philkuz, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6071 GitOrigin-RevId: 90d88311049b27cb2245252abfd47193837c59f8
-
Natalie Serrino authored
PP-2117: Add helper functions and utilities in preparation to stream all agent queries to the client, rather than batching the results up Summary: This was the result of me breaking two diffs up. The next one up will complete PP-2117, and have query results streamed directly from agent to client, rather than batched in the query broker. Test Plan: added tests Reviewers: michelle, philkuz, zasgar, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6073 GitOrigin-RevId: e3aa30451c68b63c4cd7a11f67f6fb4fc0a143c6
-
- 25 Aug, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: we want to show the state of each autocomplete entity so that users may know if they're looking at terminated/running pods/services/etc. this diff adds the state to the proto. a followup diff should actually populate that field Test Plan: unit test Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6061 GitOrigin-RevId: 80d18c817bc5b493034d0f831b0c69cb7be3faeb
-
Michelle Nguyen authored
Summary: we want to show the state when showing our results, so we need to include that in the data we index Test Plan: unit test Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6063 GitOrigin-RevId: 7e117300cd03421b249b3fa33dd73da361b23cfa
-
- 26 Aug, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: we should start on clustered (service) mode by default, especially since some cluster's pod map may be too much to render. the component wasn't actually structured properly to start with clustered mode first, so there was a small refactor to make this possible Test Plan: ran node_modules and checked that toggling the button works correctly Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6065 GitOrigin-RevId: a3d080eddf52cc2ede1670a212ce73e5eb0303fe
-
Omid Azizi authored
Summary: Don't fail on containerd overlay paths. Just print warning and continue. This at least enables kprobes to deploy properly. Test Plan: Manual Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6068 GitOrigin-RevId: c817da2968cdb36ad8e1fda4371497b73959dca2
-
- 24 Aug, 2020 1 commit
-
-
Natalie Serrino authored
Summary: We no longer use ReceiveAgentQueryResult in Carnot. This change updates the logic in Carnot and the agent manager to remove support for sending results over via that endpoint. Depends on D6053. Test Plan: existing Reviewers: michelle, philkuz, jamesbartlett, zasgar, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6055 GitOrigin-RevId: edd6251a66e530cae0af4b1a6a43e9852f4bb937
-
- 26 Aug, 2020 4 commits
-
-
Natalie Serrino authored
Summary: Not sure how to get around the lint error, because the service generated proto has an underscore in the package name too. This will be used for unit tests in the query broker. Test Plan: n/a Reviewers: michelle, philkuz, zasgar, #engineering Reviewed By: zasgar, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6067 GitOrigin-RevId: d98d92065ed9f4deb5b24c09ed3edc19f89c2b0d
-
Natalie Serrino authored
PP-2117: Introduce new QueryResultForwarder to support streaming Kelvin responses back from QueryBroker to client. Summary: This is the new QueryResultForwarder, which in the next diff will take over a lot of the work that the QueryExecutor used to do. The QueryResultForwarder is built to handle streaming responses from the agent and forward those responses (transformed to the public proto) to the client stream. Next diff will change the query broker server to integrate the new QueryResultForwarder. Test Plan: added various tests, including cancellation, to check for hangs Reviewers: michelle, zasgar, #engineering Reviewed By: zasgar, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6066 GitOrigin-RevId: ec1b6a82b63e713c45f8eb5fe49138c16c19482a
-
Phillip Kuznetsov authored
Summary: pipe it all around. untested have fun Test Plan: untested, will test wednesday morn Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6069 GitOrigin-RevId: 542a37962227ee74b03d90ec3c6f7e06dd124d4e
-
Omid Azizi authored
Summary: LinuxKit uses /proc/config.gz, so required. Test Plan: Basic test added. More testing forthcoming. Reviewers: yzhao, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6064 GitOrigin-RevId: 28206d29900c9fc329da26ca313e0b9a44f74b55
-
- 25 Aug, 2020 6 commits
-
-
James Bartlett authored
Summary: TSIA Test Plan: N/A Reviewers: philkuz, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6062 GitOrigin-RevId: da6ea5bbf826c940dd8b62bacec5c351e9c67166
-
Omid Azizi authored
Summary: Moving to a <dst> = <src> data model. Test Plan: Existing tests Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6046 GitOrigin-RevId: d50839d3fa803f5b79e42adf94fb76b49c54486f
-
Phillip Kuznetsov authored
Summary: streamable memory source. Basically always says it has batches remaining. A bit hacky before we figure out how the proto should look like. Test Plan: add a test Reviewers: nserrino, zasgar, michelle, #engineering Reviewed By: nserrino, #engineering JIRA Issues: PP-2119 Differential Revision: https://phab.corp.pixielabs.ai/D6058 GitOrigin-RevId: 3b4e66b2ab67cf9684cf77099afa30eee0da773f
-
Omid Azizi authored
Summary: Final major piece in being able to trace structs. Test Plan: Test case in stirling_dt_bpf_test Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering JIRA Issues: PP-2143 Differential Revision: https://phab.corp.pixielabs.ai/D6040 GitOrigin-RevId: 985cc5b448e30361912688d253acc933e7e3cd67
-
Michelle Nguyen authored
Summary: the current autocomplete doesnt show org-specific scripts. this is mostly because the script-autocompleting logic is temporary until we have an actual script indexer. for now, we are just using the bundle reader. a script in the bundle reader has an orgName for each script. however, we only can get the orgID from the jwt when autocompleting. one option is to add the orgName to the jwt, but that is redundant information. another option is to make a request for the orgName, given the orgID, for every autocomplete call. but we don't want to slow down autocomplete with redundant requests. instead, what I decided is to make a map of orgID -> orgName upon initialization of the API service. the suggester can then use this mapping to determine whether to show a script, given the orgID. again, this is all temporary until we have script indexing. Test Plan: ran plc-dev, checked that i could see pixielabs.org specific scripts Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6057 GitOrigin-RevId: 83c6385cec8a0c7d138cae7b9e8e11bfb0e746cd
-
Omid Azizi authored
Summary: Documentation. Test Plan: None Reviewers: philkuz, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2148 Differential Revision: https://phab.corp.pixielabs.ai/D6060 GitOrigin-RevId: 1b13cb9e0d1e63d9a871aced6cd10fb462b380d7
-
- 24 Aug, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: before we were only matching namespaces if the user explicitly typed "<namespace>/" in the input. it would also only match the namespace text exactly. instead, it should be a fuzzy-match like the name, and we should try to match with namespaces even if the user hasn't explicitly typed the "/" Test Plan: ran plc-dev Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6054 GitOrigin-RevId: 7f1ac8a3e7080d818af3e9fe7549af08dbdb7a1a
-
Michelle Nguyen authored
Summary: this diff includes a bunch of small, minor UI fixes: - don't allow user to press backspace when the input is already empty - center the px icon - rm invalid red border - use darker color for valid border - add a CTA placeholder for when the input box is empty - pressing tab should take the users to the suggestion list Test Plan: ran node modules some screenshots: new valid state: {F92634} placeholder: {F92635} Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6050 GitOrigin-RevId: 8d39af5096539d08c184f1dcc7cd0f14f81db6cc
-
- 25 Aug, 2020 1 commit
-
-
Phillip Kuznetsov authored
Summary: "substring","subtract","sum","tolower","toupper","trim", Test Plan: tested that docs extract, changes to udfs still work. Reviewers: zasgar, michelle, nserrino, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6056 GitOrigin-RevId: 37b985901202726327b6f9064b0722bedd66953b
-
- 24 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: There was a test that broke `bazel coverage` builds. This is because `bazel coverage` was adding extra symbols to dummy_go_binary's itable. Modify the test to detect and avoid the error in such cases. It's a bit of a hack, but it's contained. Test Plan: Jenkins Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6019 GitOrigin-RevId: 2c1fc6786c81320e73461d2065db48e40bd225bd
-
- 25 Aug, 2020 1 commit
-
-
Zain Asgar authored
Summary: It's hard to debug failing scripts without this. Test Plan: N/A Reviewers: michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6059 GitOrigin-RevId: 80e06737cb61a1744103bc0753f386440d8aa1cb
-
- 13 Aug, 2020 1 commit
-
-
Natalie Serrino authored
Summary: Depends on D6051. Depends on D6052. This is the big change that switches over the compiler to generate GRPC sinks (which stream to the query broker) rather than memory sinks. It's a big change but most of it is test code (though I tried to separate out code into separate diffs when possible along the way). Next up will be to clean up in Carnot the old handlers for the memory sink results being sent to the query broker. Then, the query broker itself needs to be refactored, since it buffers up results until EOS is received and then streams them back to the client. Test Plan: edited tests Reviewers: philkuz, jamesbartlett, zasgar, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6053 GitOrigin-RevId: 78a51505103ad3038807a3c791dd0539d4a46bc2
-
- 25 Aug, 2020 1 commit
-
-
Phillip Kuznetsov authored
Summary: "quantiles","round","service_id_to_service_name","service_name_to_namespace","service_name_to_service_id","strip_prefix", Test Plan: should be parsable Reviewers: nserrino, #engineering Reviewed By: nserrino, #engineering JIRA Issues: PP-2155 Differential Revision: https://phab.corp.pixielabs.ai/D6049 GitOrigin-RevId: d870354e3465464eb6d5c8ecb43113b47be2fe44
-
- 24 Aug, 2020 1 commit
-
-
Phillip Kuznetsov authored
Summary: “equal”"max","modulo","multiply","negate","notEqual","pluck","pluck_float64","pluck_int64", Test Plan: docs compile Reviewers: #engineering, nserrino Reviewed By: #engineering, nserrino JIRA Issues: PP-2152 Differential Revision: https://phab.corp.pixielabs.ai/D6045 GitOrigin-RevId: fb31d84d93b64918fda3a30f805b27dad6a9c8cb
-
- 25 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: Adds the decoder to the proto files so they are passed to code gen and eventually to compilation output. Test Plan: Dwarvifier test case added Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6039 GitOrigin-RevId: ddc702aa4207f81d8d212466c15814135564868d
-
- 22 Aug, 2020 1 commit
-
-
Omid Azizi authored
Summary: Forking off clean-ups from my workspace. Test Plan: Existing tests (no functional changes). Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6035 GitOrigin-RevId: 97269bf28a154d5983aef2d925cd78badda9c736
-
- 24 Aug, 2020 4 commits
-
-
Natalie Serrino authored
Summary: The diff that switches memory sinks over to grpc sinks in the planner is coming soon and it is fairly large. This diff is all of the odds and ends in that change that can be separated out for that diff, for diff size reduction purposes. These changes all enable either the switch of GRPC sinks instead of memory sinks as the output sinks in query plans, or enhance testing for those changes. Test Plan: existing Reviewers: michelle, philkuz, zasgar, #engineering, jamesbartlett Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6052 GitOrigin-RevId: f49ac7210ab8ea8830cf579fc1ba428828f63939
-
Natalie Serrino authored
Summary: We need to register the query broker as a servie that implements the GRPC ResultSinkService interface so that Kelvins can stream results directly to the query broker using the TransferResultChunk API. Test Plan: n/a Reviewers: michelle, zasgar, philkuz, #engineering Reviewed By: philkuz, #engineering JIRA Issues: PP-2117 Differential Revision: https://phab.corp.pixielabs.ai/D6051 GitOrigin-RevId: 4688622138ae2e31bf411869588676b2be5e229e
-
Natalie Serrino authored
Summary: I was trying to debug a grpc authentication issue, and added this unit test to make sure that the problem wasn't in this component. It turns out the problem must be somewhere else, but we might as well check this in if we have it. Test Plan: the test Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6048 GitOrigin-RevId: e4da7ab27b0f28f9b4e14bf1aa6f94f046d2eb84
-
Michelle Nguyen authored
Summary: tsia Test Plan: everything builds Reviewers: philkuz, zasgar, #engineering Reviewed By: philkuz, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6047 GitOrigin-RevId: 9a098281d0200d9a2eda638cbb4e5b4b37bd3ad6
-