Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 18 May, 2021 3 commits
    • Zain Asgar's avatar
      PC-937 - Update node to v16 · 78855178
      Zain Asgar authored 
      Summary: This gives us better support for ES modules, which is useful when we upgrade to a newer material-ui.

Test Plan: Existing

Reviewers: michelle, vihang, nlanam

Reviewed By: michelle

JIRA Issues: PC-937

Differential Revision: https://phab.corp.pixielabs.ai/D8639

GitOrigin-RevId: 62f454a501f8130693b6fb5638ba438421b09433
      78855178
    • Vihang Mehta's avatar
      Use cloud_addr when printing links from CLI · d111c95f
      Vihang Mehta authored 
      Summary: This cleans up the links for OSS deploys.

Test Plan: Run `px deploy` and `px live`

Reviewers: zasgar, michelle, nserrino

Reviewed By: nserrino

JIRA Issues: PC-913

Differential Revision: https://phab.corp.pixielabs.ai/D8634

GitOrigin-RevId: bf9656c818416b0e3ed410cb557ca86bb3ff9505
      d111c95f
    • Phillip Kuznetsov's avatar
      PC-917: convert setVis and setPxl as transactions to prevent race issues. · 6798dab5
      Phillip Kuznetsov authored 
      Summary: Was writing a saveEditor() function that only seemed to save one of the editors, but not the other. Both functions were called, but only 1 result remained. Turns out the second call overwrote the first one. Making the state function calls into functions themselves fixed this problem.

Test Plan: Tried my save editor function in `D8638` before this change ( only setVis worked ) then after and saw that both worked.

Reviewers: nlanam, vihang, michelle

Reviewed By: nlanam

JIRA Issues: PC-917

Differential Revision: https://phab.corp.pixielabs.ai/D8644

GitOrigin-RevId: 5c0ee3671e4f5a202cb441a8c4686df20cd1d04e
      6798dab5
  3. 17 May, 2021 4 commits
    • Michelle Nguyen's avatar
      PC-928 Fix lint issues in UI · 8f2c89a3
      Michelle Nguyen authored 
      Summary:
These are lint issues that are triggered by the changes in D8632. It's better to fix them separately to keep that diff size as small as possible.
there are no logic changes here, just movement around of code because of complaints where a component was used before it was defined, addition of default args, etc.

Test Plan: yarn dev

Reviewers: nlanam, vihang, philkuz, zasgar

Reviewed By: vihang

JIRA Issues: PC-928

Differential Revision: https://phab.corp.pixielabs.ai/D8637

GitOrigin-RevId: affa69333ee5300dfd4f6bc525da40f45bcf34a8
      8f2c89a3
    • Vihang Mehta's avatar
      Upgrade gorilla/sessions to handle memory leak · 03504ff2
      Vihang Mehta authored 
      Summary:
inuse heap profiles of the api_service showed a large leak from a
alloc at `net/textproto.(*Reader).ReadMIMEHeader`. Some investigation revealed
that this could be due to some of the `gorilla` packages we used.

We used to depend on `gorilla/sessions@v1.1.3` which in turn
depended on `gorilla/context@v1.1.1`.
As per https://groups.google.com/g/gorilla-web/c/clJfCzenuWY/m/N_Xj9-5Lk6wJ
and https://github.com/gorilla/sessions/pull/23/files it seems like the
`gorilla/context` lib relied on explicit removal of request variables at the
end of the request lifetime.

As of `gorilla/sessions@v1.2.0` they switched over to the golang `context`
package and removed the dependency on `gorilla/context`. The golang `context`
lib no longer holds on to the same request variable and hence doesn't exhibit
the same leaky behavior.

Note, I believe the upgrade to `gorilla/handlers` isn't necessary to fix this
leak but it seemed like a good time to upgrade both gorilla deps.

Test Plan:
inuse heap profiles on a skaffold deploy of cloud no longer
seem to exhibit at leak from `ReadMIMEHeader`

Reviewers: zasgar, michelle, #third_party_approvers

Reviewed By: michelle, #third_party_approvers

JIRA Issues: PP-2740

Differential Revision: https://phab.corp.pixielabs.ai/D8636

GitOrigin-RevId: 97ce53644aeed0654d31ecf3f751c71e626aa79a
      03504ff2
    • Nick Lanam's avatar
      [PC-917] Start overhaul of URL state management (feature flagged) · 7e9d9df9
      Nick Lanam authored 
      Summary:
WARNING: In this diff and those based on it, everything is locked behind the `USE_SIMPLIFIED_ROUTING` feature flag in `vizier.tsx`. Do not submit with that flag set to true; do set it to true for testing though.

Implements `VizierRoutingContext`, a context that handles the URL and parameters therein such that no other code should need to interact with the URL directly. Begins to wire updated versions of `ScriptContext` and so forth to use this simplified model. So far, it only handles the state management relating to the active script and the URL. Implementation for running the script (`ScriptLoader` and `ScriptContext.execute`) is just skeletal so far; numerous contexts still need to be ported.

For any updated components/contexts/etc, please create a `new-whatever-context.tsx` beside the original that contains the changes. Use the new version in the `USE_SIMPLIFIED_ROUTING` path. A final diff once everything works again will remove the flag, call the new path only, delete the old versions of everything, and rename the new versions to take their place.

See [PC-917](https://pixie-labs.atlassian.net/browse/PC-917) for details of what still needs to be done. TODOs are sprinkled generously throughout this diff as well.

Test Plan:
First, ensure behavior is unchanged when `USE_SIMPLIFIED_ROUTING = false`.

Then set it to `true`, and visit `withpixie.ai:8080/`. Watch as the URL and the console. The URL should update automatically to choose a default cluster in the same manner we do now; script memory between sessions should be gone; the `Try Another` button should change the URL; the console should emit a debug message each time the script/args/cluster change - but only once per combination of changes. These methods will be the basis for all new script-related state+url management.

Reviewers: michelle

Reviewed By: michelle

Subscribers: vihang, philkuz

JIRA Issues: PC-917

Differential Revision: https://phab.corp.pixielabs.ai/D8629

GitOrigin-RevId: 820fb6746f443aae4fe27571e1c6a05b6d811044
      7e9d9df9
    • Michelle Nguyen's avatar
      Googlemail should create individual orgs · 9c4569f7
      Michelle Nguyen authored 
      Summary: tsia

Test Plan: n/a

Reviewers: zasgar, vihang

Reviewed By: vihang

Differential Revision: https://phab.corp.pixielabs.ai/D8633

GitOrigin-RevId: dc6a553980236936e00ac3d677f62f12a8fbce81
      9c4569f7
  5. 15 May, 2021 2 commits
    • Michelle Nguyen's avatar
      PC-915 Add admin UI for managing orgs · f9ad5444
      Michelle Nguyen authored 
      Summary:
add admin UI for users to manage org settings.
screenshot:
{F156675}

Test Plan: tried with staging + yarn dev

Reviewers: nlanam, philkuz, vihang

Reviewed By: nlanam

JIRA Issues: PC-915

Differential Revision: https://phab.corp.pixielabs.ai/D8631

GitOrigin-RevId: 38f8b4a8c9283461e4e28b3784df732d6212d2cd
      f9ad5444
    • Michelle Nguyen's avatar
      PC-898 Add admin UI for managing org users · 251bed55
      Michelle Nguyen authored 
      Summary:
This diff adds the admin UI page where users can go and approve other users. the button will only show up if the user is unapproved.
screenshot:
{F156630}

Test Plan: updated staging with latest backend changes, and used yarn dev

Reviewers: nlanam, philkuz, vihang

Reviewed By: nlanam, philkuz

JIRA Issues: PC-898

Differential Revision: https://phab.corp.pixielabs.ai/D8625

GitOrigin-RevId: 2365aa4ddf5201b1ff68e532563bb66ad7876b5f
      251bed55
  7. 14 May, 2021 30 commits
  9. 13 May, 2021 1 commit

免费DevSecOps平台，让您的项目体验完整的DevSecOps流程，让项目更安全