This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 12 Apr, 2021 1 commit
-
-
Zain Asgar authored
Summary: Trying to cleanup top-level folders. This moves chef under the tools directory. Test Plan: N/A Reviewers: michelle, vihang, #third_party_approvers Reviewed By: vihang, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8133 GitOrigin-RevId: 231419eb22fc42c03752cadcf7ed19e15109cc51
-
- 09 Apr, 2021 2 commits
-
-
Omid Azizi authored
Summary: Statistics at play. Test Plan: Jenkins Reviewers: #stirling, jps Reviewed By: #stirling, jps Differential Revision: https://phab.corp.pixielabs.ai/D8107 GitOrigin-RevId: fd8e1fef5a57f0b33eabb8a737b07572894810a8
-
Nick Lanam authored
Summary: This prepares both `@pixie-labs/api` and `@pixie-labs/api-react` for third-party use, and adapts the live UI to the changes. In addition to implementing API key support, all uses of `whatwg-fetch` and the browser native fetch were replaced with `cross-fetch`, which works in NodeJS as well as browsers. The rest of the changes are either for portable typings, or accounting for the other changes downstream. Some are to please ESLint. Expected followup diffs: regenerating `yarn.lock` alongside some mandatory dependency upgrades; adding `@pixie-labs/samples-api` as a demo project of how to use `@pixie-labs/api` independently of our monorepo. Test Plan: Build, smoke test, run unit tests. Reviewers: michelle, vihang, #third_party_approvers Reviewed By: vihang, #third_party_approvers JIRA Issues: PC-736, PC-738 Differential Revision: https://phab.corp.pixielabs.ai/D8108 GitOrigin-RevId: 15ffb446d5f40ef85c93ad16a09179db804ab0a2
-
- 10 Apr, 2021 1 commit
-
-
Natalie Serrino authored
Summary: Packages should always be imported by their name, unless there is a collision. This diff fixes the imports of cli logger, which were misnamed (except in cases where there is a collision, but those names are updated to be more canonical as well). Test Plan: n/a Reviewers: vihang, michelle, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8110 GitOrigin-RevId: 4940ee69f1db4c5cbb2698499dd62e31e0836073
-
- 12 Apr, 2021 4 commits
-
-
Vihang Mehta authored
Summary: The gazelle checker was run as an arcanist unit test. It would modify and autofix the files underneath you but then send out the diff anyway causing folks to have to `arc diff` again. Instead, run gazelle in diff mode, and as an arcanist linter and send the diff to arcanist so that `arc` will ask and apply the patch before sending the diff out. (Sadly arcanist doesn't accept the patch format, it take a set of original content plus new content, so generating the diff for arcanist is a bit ... heavy handed.) Test Plan: Make some changes that would make gazelle unhappy. Run `arc lint` {F127064} Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8131 GitOrigin-RevId: b7523e14821ee959e4f1f3a24c49ea348512f711
-
Vihang Mehta authored
Summary: The linter to check that targets in `//experimental` were marked as manual was written as a `unit test`. Additionally the linter relied on custom build rules and checking those rules and as a result missed targets like `//experimental/stirling/proto_data_model/proto:http_record_pl_go_proto` which aren't manual since they use `pl_go_proto_library` (due to a lack of a `pl_exp_go_proto_library`). Instead let's use bazel to query targets that are not marked as manual and convert this check into a script and regex linter. It's also easier to not have to create custom targets just to mark things as manual and instead rely on the linter to enforce the check on normal targets. Used buildozer to rewrite all rules in `experimental` to have a manual tag and found a bug in `pl_bpf_cc_resource` where tags weren't being passed down by the macro and fixed it. Test Plan: Unmarked a rule in experimental as manual. Ran `arc lint`. {F127036} Reviewers: zasgar, michelle Reviewed By: zasgar, michelle Differential Revision: https://phab.corp.pixielabs.ai/D8129 GitOrigin-RevId: 08dc4a93188e178bd12058aff935da0b52f55e79
-
Vihang Mehta authored
Summary: These changes got dropped from D8124 Test Plan: Build works again (plus testing from D8124) Reviewers: michelle Reviewed By: michelle JIRA Issues: PP-2581 Differential Revision: https://phab.corp.pixielabs.ai/D8130 GitOrigin-RevId: 9107ebd7c068976a7a74ea8d61330595f19ec1a5
-
Vihang Mehta authored
Summary: We currently run prototool as a "unit test" for arcanist and run it over the entire repo. Instead, let's run it as a linter. This means the checker will run only on `.proto` files and one at a time instead of the entire repo. This will also make lint messages show up inline in the diff. Downgrade from error to warnings since we do sometimes make what would be considered a breaking change (such as renaming a field) or removing an unused field. So these are warnings and should be treated as such. Test Plan: Made some breaking changes and ran `arc lint` {F127032} Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8128 GitOrigin-RevId: 70c4a66a0f233f39a14b2a8b177236dc157f5818
-
- 11 Apr, 2021 5 commits
-
-
Michelle Nguyen authored
Summary: we used to allow the wildcard for the allowed origins but we should restrict this to be more secure. since we only allow users to use our api server-side, i can think of only two places where we access our backend from the browser: the UI and docs.pixielabs.ai. all of the requests from the UI are same-origin requests, but I added "https://<domain_name>" and "https://work.<domain_name>" anyway. for the prod api server, i passed in "docs.pixielabs.ai" through an env variable, since we dont need to stick it in for staging/dev/OSS deployments. Test Plan: deployed to staging, verify stuff still works in the UI as expected (it should, since all the requests are same-origin). run `kustomize build prod`, inspect the output yaml. Reviewers: zasgar, vihang, nlanam Reviewed By: zasgar, vihang JIRA Issues: PP-2581 Differential Revision: https://phab.corp.pixielabs.ai/D8124 GitOrigin-RevId: 3b188c34f926d1a6867e3205a0d2c1b7b380e872
-
Zain Asgar authored
Summary: This makes the copying process to public repo a bit easier. We still need to deal with the fact that the protos are in a different directory, but this is a good starting point. Test Plan: existing Reviewers: vihang, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8127 GitOrigin-RevId: da8e063d8b1a768c0468a54681a48d088821da77
-
Vihang Mehta authored
Summary: Move pixielabs linters to pixie folder. Remove unused `gofmt` since `goimports` also covers `gofmt` Test Plan: N/A Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8126 GitOrigin-RevId: 17b76cd8592ef02b0acd76fbf3a03a540f0c12d4
-
Vihang Mehta authored
Summary: Since we import `gogo.proto` but the dependency is fetched by bazel we end up having to copy the bazel fetched gogo lib as a workaround to run prototool. Having the file checked in for prototool to use simplifies this greatly. We will still use the bazel fetched proto for building and hence care must be taken to avoid divergence, but `gogo.proto` has not changed in nearly 2.5 years. Test Plan: `prototool` still works. Reviewers: zasgar, michelle, #third_party_approvers Reviewed By: zasgar, michelle, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8123 GitOrigin-RevId: f96ad8ddcb01bb7b6ab066e1930274d07a1d753c
-
Michelle Nguyen authored
Summary: recent changes to make the ID field required made the gql query error and fail to connect to any clusters, because there was one more place it needed to be changed: {F126992} Test Plan: checked that the fix works on staging Reviewers: zasgar, vihang, nlanam, nserrino Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8121 GitOrigin-RevId: d4796a0c506ac1825377b1bb9f91d0c8b01ddf24
-
- 10 Apr, 2021 4 commits
-
-
Zain Asgar authored
Summary: TSIA Test Plan: N/A Reviewers: michelle, vihang, #third_party_approvers Reviewed By: vihang, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8120 GitOrigin-RevId: 3e5d0985d590273dcf6c25d989cb06d6652d3a06
-
Zain Asgar authored
Summary: Note: We will switch over the the CNCF code of conduct after we become a sandbox project. The repo points to the pixie-labs/pixie where we will eventuall move this repo. Test Plan: N/A Reviewers: michelle, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8119 GitOrigin-RevId: 7e17e5ca57596fb19046150a567dfaf9bf755d99
-
Zain Asgar authored
Summary: This adds the CLA. Note that we will switch over the the CNCF CLA after we get into sandbox. Test Plan: N/A Reviewers: vihang, michelle Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8118 GitOrigin-RevId: 75e57be8a1219ba35a2793a2451f58347ec3f63b
-
Zain Asgar authored
Summary: TSIA Test Plan: Check pxl files on github. Reviewers: vihang, michelle Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8117 GitOrigin-RevId: fe5fc941bd13b128384f467fd876b2149320879e
-
- 09 Apr, 2021 5 commits
-
-
Michelle Nguyen authored
Summary: these configs are technically not secret, but we dont want to check them in with the rest of our repo when we open source. moved them to /credentials/k8s/<env>/configs, which has a special sops rule that allows devs to read them. this is because we need to read these configs when pointing the webpack build to cloud prod. Test Plan: ran webpack, make sure that vendors like auth0/announcekit/etc still work as expected. Reviewers: zasgar, vihang, nlanam Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8095 GitOrigin-RevId: 5c86a6aff923de9259bcfa1fa6ea5b709b9f5101
-
Michelle Nguyen authored
Summary: If the semantic type is specified for the edgeColumn, we should use the same thresholds we do to color our tables (if a custom threshold is not already specified) We should also not allowe certain columns (such as script references) to be used as the source/dest columns. Test Plan: yarn dev Reviewers: nlanam, zasgar Reviewed By: nlanam Differential Revision: https://phab.corp.pixielabs.ai/D7790 GitOrigin-RevId: c53bcaae51ad92b33a14d040fea41a43223791fb
-
Natalie Serrino authored
Summary: Remove stale go TODOs, mostly around incorrect use of logrus. We want to use our CLI logger in most cases so that we don't send unnecessary events to Sentry. Test Plan: existing Reviewers: michelle, vihang, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8102 GitOrigin-RevId: 52f94129cbb9083bb04af89c876d694eceb989c1
-
Natalie Serrino authored
Summary: Cleaning up old TODOs. Our graphql endpoints to fetch cluster and cluster connection info used to not require an ID and we would return the first cluster available. This was back before the UI fully supported multi-cluster, so it was a temporary transition. Now that that UI supports multicluster, we want to require that a cluster ID be passed in for those endpoints. Test Plan: edited existing Reviewers: michelle, vihang, philkuz, nlanam Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8097 GitOrigin-RevId: c88fa1815366fd54d6eb932351e81b69c5d45dab
-
Phillip Kuznetsov authored
Summary: Cleaning this up before another diff. Wanted to remove this dep because I want to add a dep in the other direction. Also it makes more sense for the server not to care about grabbing something from the idprovider anywyas. Test Plan: skaffold'd Reviewers: michelle, vihang, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8100 GitOrigin-RevId: 0fcf90563be71492bce642c4ec2eef4a0b98ff0c
-
- 23 Mar, 2021 1 commit
-
-
James Bartlett authored
Summary: Fixes a failure case in request path clustering when merging across sets of data that disagree about the clustering. Test Plan: Added a simple and more complicated test of the failure case. Reviewers: zasgar, nserrino Reviewed By: nserrino JIRA Issues: PP-2545 Differential Revision: https://phab.corp.pixielabs.ai/D7810 GitOrigin-RevId: 749cd8d8ad3c98ccd8bf13833ebd2858f8c014d4
-
- 09 Apr, 2021 6 commits
-
-
Natalie Serrino authored
Summary: Remove some stale TODOs from UI code. Test Plan: n/a Reviewers: michelle, nlanam, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8106 GitOrigin-RevId: 107b0bc2b5b88fa19edda480002e669df1531b13
-
Omid Azizi authored
Summary: Experimenting with a new idea to optimize communication back to the kernel. Instead of using individual syscalls to delete map entries, we can batch them up, and then send them collectively as a uprobe. Then the uprobe handles the work by tracing the arguments. Still evalutating the peformance gains, but if this works, it could be a useful pattern in a number of instances. Test Plan: Existing tests + Manual inspection via bpf_trace_printk Reviewers: yzhao, jps, rcheng Reviewed By: jps JIRA Issues: PP-2550 Differential Revision: https://phab.corp.pixielabs.ai/D7791 GitOrigin-RevId: 3ffc9d33154ac5ab6941ad39e1a9c8de7c7e3cfb
-
Vihang Mehta authored
Summary: This moves them out of linters since we both have lint and "unit test" engines in there. Cleans up the organization of all the subfolders and makes the naming a bit more consistent. Adds a missing License file. Test Plan: `arc lint` and `arc unit` should continue to work. Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8105 GitOrigin-RevId: 9677abf9f9b3e7f460413ba54fdaeac5d55a431b
-
Vihang Mehta authored
Summary: Use prototool to reformat. Next up investigate switching to `buf` and enforcing proto format lint. Test Plan: N/A Reviewers: zasgar, michelle Reviewed By: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D8099 GitOrigin-RevId: 297ff82f85de669f3b70bffd27065e0477cffc42
-
Omid Azizi authored
Summary: Updates in preparation for open source. Test Plan: None Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8096 GitOrigin-RevId: a82362e4ff89a2fb0b8e8bac4932ee6e9ac975b9
-
Omid Azizi authored
Summary: Notice ByteSize() in our flamegraphs for DNS and http2. Turns out both of these have loops inside their ByteSize() computation, so cache their results inside the struct. Test Plan: Existing tests Reviewers: yzhao, jps, rcheng Reviewed By: yzhao JIRA Issues: PP-2530 Differential Revision: https://phab.corp.pixielabs.ai/D7783 GitOrigin-RevId: 42bb0e6eda94bc3c4dfea2b928dd3246cae0e04c
-
- 08 Apr, 2021 1 commit
-
-
Omid Azizi authored
Summary: Unused and cleaning up. Test Plan: Existing tests. Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8038 GitOrigin-RevId: dcc30fc15dd84bea86618e5f598fab39bd9202dd
-
- 09 Apr, 2021 2 commits
-
-
Omid Azizi authored
Summary: Re-applying D8034, with a Jenkins fix. Had to change the tar command in the Jenkinsfile to use `--no-same-owner`, otherwise the owner of some third_party files would be invalid users, and this would cause problems with cmake, where cmake would fail with "failed to preserve ownership" messages. Test Plan: Jenkins Reviewers: zasgar, #third_party_approvers, jamesbartlett Reviewed By: zasgar, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8087 GitOrigin-RevId: 546708e43c1452d35efcafd5e02667e35608e205
-
Natalie Serrino authored
Summary: Removing nserrino's stale TODOs from .cc and .h files. Test Plan: n/a Reviewers: michelle, vihang, zasgar Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8098 GitOrigin-RevId: 10e88db4bc5e9901fc41231c395d8085a68000ac
-
- 08 Apr, 2021 1 commit
-
-
Vihang Mehta authored
Summary: Restricts to within carnot most places and to carnot+vizier when need be. There's a couple of other imports that we should consider reorganizing. Test Plan: Existing Reviewers: philkuz, michelle, zasgar Reviewed By: philkuz JIRA Issues: PP-2567 Differential Revision: https://phab.corp.pixielabs.ai/D8092 GitOrigin-RevId: dc37fd3dc7e8eb080fba05a6e383d61ca799390a
-
- 09 Apr, 2021 6 commits
-
-
Michelle Nguyen authored
Summary: Missed some files that shouldve been added... guess I should keep my git workspace clean.. Test Plan: n/a Reviewers: nserrino, vihang, zasgar Reviewed By: nserrino Differential Revision: https://phab.corp.pixielabs.ai/D8094 GitOrigin-RevId: ee24ceb7cd9e70e8b74e89dee25acc40fd682add
-
Michelle Nguyen authored
Summary: making sure that the UI works without a LaunchDarkly client ID. without this, things will still work but you will get a bunch of ugly errors printed to the console. our current plan is to completely opensource the UI without modifications--it shouldnt be a surprise to the user that we're using products such as segment/launchdarkly/announcekit/etc. everything should just continue to work properly if none of the configs are specified. launchdarkly is a bit special, since it can control which features are shown in the app. for now, anything with a flag that needs to be enabled just wont be enabled if they dont have a launchdarkly configured. since everything is open source, if they really wanted the feature they could change the sourcecode to enable it. those cases are fine, this is mostly here for us to control things on withpixie.ai. Test Plan: `yarn dev`, tried without a LD_CLIENT_ID, verified there are no LD errors in the console. without a LD_CLIENT_ID, also added in a flag to see what would happen. it does not error, the flag value is just undefined, which should be OK. Reviewers: nlanam, zasgar, vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8090 GitOrigin-RevId: c789548bc8d854788db788d96e45c8313f48ccaa
-
Michelle Nguyen authored
Revert "PP-2445: move limit pushdown rule from optimizer to presplit optimizer in order to add PEM-awareness" Summary: this diff somehow breaks df.ctx in http_data Test Plan: ran in skaffold, confirm that df.ctx works again Reviewers: nserrino, zasgar Reviewed By: nserrino Differential Revision: https://phab.corp.pixielabs.ai/D8091 GitOrigin-RevId: 547f8c6a6c84417b8c504331e4c6823bc0464a91
-
Phillip Kuznetsov authored
Summary: as part of the OSS release, @zasgar wants to create a better separation of components. Notably, we had a misplacement of the dynamic tracing interface - stirling should implement it, but planner be the owner of the interface. This will allow us to implement future dynamic tracepoints with different underlying implementations if we need to in the future. Core change is the movement of the proto files, every other change is a downstream effect of that. Test Plan: Passes all test and builds properly. Should pass Jenkins b4 land. Reviewers: oazizi, vihang, zasgar, yzhao Reviewed By: oazizi, vihang, yzhao Subscribers: zasgar JIRA Issues: PP-2253 Differential Revision: https://phab.corp.pixielabs.ai/D7895 GitOrigin-RevId: 70ee9c060ac46c91881a51dee303497927e2310e
-
Omid Azizi authored
Summary: Anything that shouldn't be open-sourced from Stirling's side goes here. Test Plan: Jenkins Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8073 GitOrigin-RevId: 847438551e79d7cdd56a7c161cd705eda237db34
-
Vihang Mehta authored
Summary: Standardize `option go_package`. This reduces import aliasing. Test Plan: Existing. Reviewers: zasgar, philkuz Reviewed By: philkuz Differential Revision: https://phab.corp.pixielabs.ai/D8086 GitOrigin-RevId: 2ed4b1c8c74a0eac1035d614ba4650b765be7718
-
- 08 Apr, 2021 1 commit
-
-
Vishal Jain authored
Summary: Grafana Backend Datasource Changes & Take out mage & Add Bazel Build. First PR where we are building a Grafana Backend Datasource Plugin. This uses Golang + JS to help visualize datasources. I have taken the starter template code from Grafana. The template code incorporates mage to cross-compile the project. Have replaced Mage with Bazel build (which should work for most cross-compiling but not all). Test Plan: Manually tried testing with darwin amd64 binary. Manually checked that other executables are there. Reviewers: nserrino, michelle, O1 third_party, #third_party_approvers, zasgar Reviewed By: nserrino, O1 third_party, #third_party_approvers, zasgar Subscribers: philkuz, vihang, zasgar JIRA Issues: PC-820 Differential Revision: https://phab.corp.pixielabs.ai/D7968 GitOrigin-RevId: 2f99bb694e53c70a7e67644e5cda49be93cb258f
-