This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 08 Dec, 2020 1 commit
    • Phillip Kuznetsov's avatar
      Updating support for multiple tracepoints on the same target by cleaning up... · 400d3a1c
      Phillip Kuznetsov authored
      Updating support for multiple tracepoints on the same target by cleaning up mutations data structures
      
      Summary:
        We used to store a mapping of the tracepoint targets to the tracepoints for those targets. For each
        type of target, we had a separate map. I considered two alternatives could be used for these data
        structures:
        1. (Chosen approach) Vector of DeploymentSpec,TracepointDeployment pairs
           a. Lose uniqueness of DeploymentSpecs
               * We don't really have a need for uniqueness constraints anymore. We had some desire for
               it before but I think it's not necessary.
           b. Gain simplicity of writing out protobufs, pay for complexity in the special API which we
              already pay for, honestly looks pretty good.
        2. Single map w/ a unified key of UPID, SharedObject, etc.
           a. Could use DeploymentSpec protobuf message, but not guaranteed to be great keys
              (https://developers.google.com/protocol-buffers/docs/encoding#implications)
           b. Could make a new key that contains all of the fields, but might be a lot of work and more
           complex than separate maps.
      
      Test Plan: updated tests to support the multiple tracepoints
      
      Reviewers: nserrino, jamesbartlett, oazizi, yzhao, #engineering
      
      Reviewed By: jamesbartlett, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6892
      
      GitOrigin-RevId: 02e618b5e910fadcd5e67ad7a209f7f4a1822995
      400d3a1c
  2. 09 Dec, 2020 2 commits
    • Vihang Mehta's avatar
      Get rid of the deps_only flag · b26017a5
      Vihang Mehta authored
      Summary: This does nothing and causes `px deploy` to just hang.
      
      Test Plan: N/A
      
      Reviewers: michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6894
      
      GitOrigin-RevId: 069cff7cc91fff797cb7eef824aad3d6e27be8f7
      b26017a5
    • Vihang Mehta's avatar
      Make etcd not rely on dns resolution · 814da203
      Vihang Mehta authored
      Summary:
      We were having issues with `etcd` running on `minikube` `v1.13.0+`
      The dns resolution for `etcd-0.etcd` would fail causing `etcd` to crashloop.
      
      Since we only run a single replica of `etcd` and are working towards completely getting rid of it, let's just clean this up and get it working.
      
      Test Plan:
      Deploy pixie on a `minikube v1.15.1` cluster. `etcd` fails to run.
      Delete the `etcd` stateful set and apply this new config. `etcd` succeeds.
      
      Reviewers: michelle, oazizi, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6893
      
      GitOrigin-RevId: cfe628b2dc2823edaf08049f9c9d40e3986936d2
      814da203
  3. 08 Dec, 2020 1 commit
    • Nick Lanam's avatar
      Fix cancel button for tracepoint deployment · 5f71ad20
      Nick Lanam authored
      Summary: Not the first bug that came from having to make a fix in both the mutation and normal path. I'll be putting some thought into a more maintainable structure for this file; the behavior is already what we want.
      
      Test Plan: Try to cancel tracepoints being deployed. `tcp_drops` is a good example, and renaming the UpsertTracepoint parameter is sufficient to force it to deploy new tracepoints/see the dialog again.
      
      Reviewers: nserrino, michelle, vihang, #engineering
      
      Reviewed By: nserrino, michelle, #engineering
      
      JIRA Issues: PC-694
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6890
      
      GitOrigin-RevId: 9bbc53fcd4c6da47529d350e75b6a5571c6b7a66
      5f71ad20
  4. 07 Dec, 2020 1 commit
    • Michelle Nguyen's avatar
      PC-687 Track cluster uptime metrics on Segment · 52bad346
      Michelle Nguyen authored
      Summary:
      we want to track user's cluster level uptime to help manage customer expectations and track basic cluster-level metrics.
      this diff will track a segment event everytime a cluster's status changes.
      
      Test Plan: deployed in staging and looked @ segment debugger
      
      Reviewers: zasgar, #engineering, vihang
      
      Reviewed By: #engineering, vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6885
      
      GitOrigin-RevId: b8b7acafb7faaafd60d14dcbe56de04451fb5b78
      52bad346
  5. 08 Dec, 2020 1 commit
  6. 07 Dec, 2020 1 commit
  7. 24 Nov, 2020 1 commit
    • Yaxiong Zhao's avatar
      Simplify code places for adding new protocols · 80a86872
      Yaxiong Zhao authored
      Summary:
      Remove the need to update connection_tracker_test.cc
      Created a new header src/stirling/protocols/stitchers.h to include all headers for the
      StitchFrames() template specializations.
      
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6863
      
      GitOrigin-RevId: e85e0bfbb81f79af579f18aaf2fd5251fe4f489b
      80a86872
  8. 08 Dec, 2020 3 commits
    • Nick Lanam's avatar
      User settings support in the UI · e228f6ab
      Nick Lanam authored
      Summary: This specifies the available settings (currently just one - whether the tour has been seen) and makes them available for read/write. Accessed via React hook.
      
      Test Plan: Unit tests only right now. The next change for this will add a use for the `tourSeen` setting to show the tour once to each new user.
      
      Reviewers: nserrino, michelle, vihang, #engineering
      
      Reviewed By: nserrino, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6888
      
      GitOrigin-RevId: 91dbc658d85abf0a7b9dfa351f283813ac04b399
      e228f6ab
    • Omid Azizi's avatar
      Fix bazel build warning · dd0eb8ec
      Omid Azizi authored
      Summary: Cleaning up a warning that @jps ran identified.
      
      Test Plan: Jenkins
      
      Reviewers: jps, #engineering
      
      Reviewed By: jps
      
      Subscribers: jps
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6887
      
      GitOrigin-RevId: 14fc2da0557223c11c224c53ad13492137c08a76
      dd0eb8ec
    • Omid Azizi's avatar
      [Cleanup] java.h: Refactor common code · 901177f4
      Omid Azizi authored
      Summary:
      Same pattern appears twice between java.cc and jvm_stats_connector.cc. Refactor to share the code.
      
      There is some potential for optimization here. That's coming in subsequent diffs.
      
      Test Plan: Existing tests.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6862
      
      GitOrigin-RevId: c17ee324bea0ee311c170ba707c90c6bf6150971
      901177f4
  9. 07 Dec, 2020 4 commits
  10. 24 Nov, 2020 1 commit
    • Vihang Mehta's avatar
      Kill fluentbit · 51b698d0
      Vihang Mehta authored
      Summary: Remove fluentbit since we now rely on `px debug log`
      
      Test Plan:
      Ran vizier using skaffold, ensured that `px debug log` still worked.
      Trying to run cloud using skaffold to verify it works too.
      
      Reviewers: zasgar, michelle, jamesbartlett, #engineering
      
      Reviewed By: michelle, #engineering
      
      JIRA Issues: PP-2317
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6861
      
      GitOrigin-RevId: 147537b5fc145b73fa080615528b27702f056697
      51b698d0
  11. 26 Nov, 2020 1 commit
  12. 24 Nov, 2020 2 commits
    • Michelle Nguyen's avatar
      Implement usersettings gql resolver · 6ce51aa9
      Michelle Nguyen authored
      Summary: this diff implements the actual graphql resolver for getting/updating userSettings.
      
      Test Plan: unit tests, ran cloud dev and verified making gql requests from the UI worked as expected
      
      Reviewers: nick, vihang, nserrino, zasgar, #engineering
      
      Reviewed By: nick, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6858
      
      GitOrigin-RevId: 1eaccbc16738c77a74e082af0717d74cd9e0a9bf
      6ce51aa9
    • Michelle Nguyen's avatar
      Update profile service to handle Get/UpdateUserSettings · 197fb2ea
      Michelle Nguyen authored
      Summary:
      we are adding user settings in our backend, so that we can use usersettings to determine whether or not to show the onboarding overlay.
      this part updates the profile service to handle getting/updating user settings.
      this diff:
      - updates the profile proto with the new rpc methods
      - updates the profile server to handle the new rpc calls
      - updates profile datastore to actually get/update the values in the db
      
      the last part in the backend is to update the API service to make this call to the profile service.
      
      Test Plan: unit tests
      
      Reviewers: vihang, nserrino, nick, zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6849
      
      GitOrigin-RevId: 649b956e68125348c3cd6e32ce50d65d4d2c40f5
      197fb2ea
  13. 05 Dec, 2020 2 commits
  14. 06 Dec, 2020 1 commit
    • Michelle Nguyen's avatar
      Update k8s apply.go · 231e45c8
      Michelle Nguyen authored
      Summary:
      updated the comments, since this is heavily modified from the version referenced on stack overflow.
      updated some variable names
      
      Test Plan: n/a
      
      Reviewers: zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6883
      
      GitOrigin-RevId: 53a352b4405f28d82690e21559cf080a963a01b3
      231e45c8
  15. 25 Nov, 2020 12 commits
    • Vihang Mehta's avatar
      Chore upgrade @storybook/* and highlight.js · 547f712e
      Vihang Mehta authored
      Summary:
      We don't actually depend on `highlight.js` directly, so don't install it.
      Upgrade `@storybook/*` deps so that they pickup newer `highlight.js`
      
      Test Plan: `yarn dev` and `yarn storybook` in pixie-components
      
      Reviewers: zasgar, michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Subscribers: nick
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6869
      
      GitOrigin-RevId: 406b86857320a80a803555c5af26c151ffcacd24
      547f712e
    • Omid Azizi's avatar
      [Cleanup] obj_tools namespace to match directory structure · ff607135
      Omid Azizi authored
      Summary: No point in having different elf_tools/dwarf_tools namespaces. Plus it matches directory structure now.
      
      Test Plan: Existing tests
      
      Reviewers: yzhao, #engineering, zasgar
      
      Reviewed By: #engineering, zasgar
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6877
      
      GitOrigin-RevId: a14e9d2d688bf4c16673ef18090221ac16724753
      ff607135
    • Vihang Mehta's avatar
      Cleanup and updates for script to upload lsif · f5e833fe
      Vihang Mehta authored
      Summary:
      This adds `cc_library` and `cc_proto_library` rules to lsif-clang
      Also cleans up some code dupe in the upload script and hides the sourcegraph
      credentials.
      
      Test Plan: Run on jenkins
      
      Reviewers: zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6876
      
      GitOrigin-RevId: 50518269806e8d219836797155e3b5eca4ded574
      f5e833fe
    • Vihang Mehta's avatar
      Unset yarn resolution for html-webpack-plugin · dd18d74a
      Vihang Mehta authored
      Summary:
      `pixie-components` only uses webpack transitively as part of `@storybook`
      Since storybook uses webpack4, it needs the older version of `html-webpack-plugin`
      
      I think I force resolved this because I was doing the webpack 5 upgrade
      while the stories were in `src/ui` and concurrently was moving stories into
      `pixie-components` in a separate diff. Not moving stories required this resolution
      to happen, moving the stories, make the stories made the resolution unstable.
      
      Test Plan: `yarn storybook` works in pixie components again.
      
      Reviewers: nick, #engineering, zasgar
      
      Reviewed By: #engineering, zasgar
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6874
      
      GitOrigin-RevId: 5b17e9073ff74b64780dc088b58b8f7f831c3d2a
      dd18d74a
    • Vihang Mehta's avatar
      Collect lsif data for cpp files · f0619f3e
      Vihang Mehta authored
      Summary:
      TSIA
      Depends on D6872
      
      Test Plan: Run it locally
      
      Reviewers: zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6875
      
      GitOrigin-RevId: 8600371e98168210f51e557108a92d0774f93767
      f0619f3e
    • Zain Asgar's avatar
      Add clang-lsif to docker image · 6dd37a6c
      Zain Asgar authored
      Summary: LSIF is used for language server features.
      
      Test Plan: N/A
      
      Reviewers: vihang, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6872
      
      GitOrigin-RevId: 0903de83194c8906824071f6818db5052dcf7c3d
      6dd37a6c
    • Zain Asgar's avatar
      Guard INL files to prevent errors during indexing · 680ab6da
      Zain Asgar authored
      Summary: The files are used for cc_library but not actually used standalone. I think this is actually an issue, but we can work on a better fix. Actually there is probably a cleaner way to accomplish what we are doing with the inl files.
      
      Test Plan: Existing + clang-lsif
      
      Reviewers: vihang, philkuz, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6873
      
      GitOrigin-RevId: b76c5594048be36b4bd5110816c4e402739cbb5f
      680ab6da
    • Vihang Mehta's avatar
      Patch generate-compilation-db · 4a02111e
      Vihang Mehta authored
      Summary: TSIA
      
      Test Plan: N/A
      
      Reviewers: zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6871
      
      GitOrigin-RevId: dd30a0792af5b1e8f6dbf1c3dfbb5e88364ab7c1
      4a02111e
    • Vihang Mehta's avatar
      Remove dead forker.c · 39d3335a
      Vihang Mehta authored
      Summary: This was used by proc_tracer_bpf_test but didn't get deleted in D6367
      
      Test Plan: N/A
      
      Reviewers: oazizi, yzhao, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6870
      
      GitOrigin-RevId: f821982e3e82eba54ba9d298d1b26227aa1ead6a
      39d3335a
    • Michelle Nguyen's avatar
      Fix cluster details page · 3bb50797
      Michelle Nguyen authored
      Summary: cancel being null is causing a white screen when navigating to this page
      
      Test Plan: ran yarn dev
      
      Reviewers: nick, nserrino, zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6866
      
      GitOrigin-RevId: 9822f97991d372362106937f9aef7f1ab3519451
      3bb50797
    • Michelle Nguyen's avatar
      Fix metadata flaky test · 275e6740
      Michelle Nguyen authored
      Summary: I accidentally introduced a flaky test, because of the ordering of maps change. We should just compare the actual pb rather than the unmarshalled bytes
      
      Test Plan: ran the test 1000 times
      
      Reviewers: nserrino, zasgar, vihang, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6867
      
      GitOrigin-RevId: 30c85cf6d727651e9c6df6cdc620c8d563968d58
      275e6740
    • Vihang Mehta's avatar
      Add script to collect and upload lsif data from Jenkins · 1e7b7ff1
      Vihang Mehta authored
      Summary: TSIA. This will collect and upload lsif data for `go` and `typescript`
      
      Test Plan: Jenkins
      
      Reviewers: zasgar, michelle, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6868
      
      GitOrigin-RevId: f6ddce988ac926a5f2b79fc809028143e9f91983
      1e7b7ff1
  16. 23 Nov, 2020 1 commit
    • Omid Azizi's avatar
      ConnectorContext optimizations · a8424cb9
      Omid Azizi authored
      Summary:
      Store some information when the connector is created, so that repeated calls to GetUPIDs() doesn't do a bunch of extra work.
      
      In stirling_wrapper with a StandaloneContext, this reduces the perf from ~75% CPU to ~20% CPU usage.
      
      Likely doesn't affect stirling the AgentContext (i.e. in the PEM) in any significant way,
      since the AgentMetadataState was already snapshotted in AgentContext. So only expect marginal improvements there.
      
      Test Plan: Existing tests.
      
      Reviewers: zasgar, yzhao, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6841
      
      GitOrigin-RevId: 4d5f30fc86a76300f44f2eadd9fe82024767cff0
      a8424cb9
  17. 24 Nov, 2020 3 commits
    • Michelle Nguyen's avatar
      Fix slack notification condition · 2a39e450
      Michelle Nguyen authored
      Summary: the condition was wrong, so we were still sending out "Failed" notifications for passing builds
      
      Test Plan: n/a
      
      Reviewers: vihang, zasgar, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6864
      
      GitOrigin-RevId: 961bc12d1190cf2d0410ea62c1df5b44afa743b3
      2a39e450
    • Omid Azizi's avatar
      stirling_perf_test: fixes · fa24ef04
      Omid Azizi authored
      Summary:
      Fix some aspects of the test.
      
      Still investigating high CPU usage reported by the test.
      
      Test Plan: Manual. Not enabled yet.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6839
      
      GitOrigin-RevId: 146af60ce305c7ac8f56362c6a7eba169d7b2814
      fa24ef04
    • Michelle Nguyen's avatar
      Periodically prune computedSchema of any deleted agents · ea2bd143
      Michelle Nguyen authored
      Summary:
      we are seeing an issue occuring on clusters (especially larger clusters), where the computedSchema grows too large and can no longer be sent to etcd.
      after some examination, it appears we are hitting a race condition where if an agent is deleted the same time as another is updating its schema, its possible for zombie agents/tables to be left behind in the computed schema.
      we could add locks, but that would introduce a performance impact since the lock would have to be around a network call to etcd.
      we are also heavily refactoring the metadata service, so most of this logic will be removed in the future anyway. we decided that a temporary fix, where we periodically clean up the computedSchema, should suffice until our refactor
      
      Test Plan: unit test, ran Vizier with skaffold and verified the zombie agent IDs and tables were pruned. also verified that I could still run scripts afterwards
      
      Reviewers: nserrino, zasgar, philkuz, #engineering
      
      Reviewed By: nserrino, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6860
      
      GitOrigin-RevId: b34109581979dd58d295f6b4bc57f1cf45987253
      ea2bd143
  18. 23 Nov, 2020 1 commit
    • Nick Lanam's avatar
      Correct semantic errors in local GQL modifications; add graphclconfig file. · a867d593
      Nick Lanam authored
      Summary: the GraphQL language service (used by plugins for editors and IDEs) marks the entire schema invalid if it detects syntax or semantic errors, making the tool think every query is invalid/unknown. Fixing semantic errors takes care of that. Additionally, we have two schemas with some overlap, which were both being seen by that tooling. Using  `.graphqlconfig` file to ignore the one that is a subset of the other takes care of this as well. Both fixes combined allow tooling to recognize valid queries. Notably, this does not change the application's behavior at all: it just makes sure editors and IDEs understand what's happening.
      
      Test Plan: Check out the various usages of the `gql` template tag in our TypeScript code, in an editor/IDE that can highlight and inspect the syntax. It should now succeed when trying to do so. The build should be entirely unaffected.
      
      Reviewers: nserrino, michelle, vihang, #engineering, zasgar
      
      Reviewed By: nserrino, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6838
      
      GitOrigin-RevId: 5fe4cf6418c5e834f26c2be8f5621df12520ef93
      a867d593
  19. 24 Nov, 2020 1 commit
    • Natalie Serrino's avatar
      PP-2318: collect statistics about inbound k8s updates and agent heartbeats for metadata service. · 22f51314
      Natalie Serrino authored
      Summary:
      This diff adds a stats handler to the metadata service which watches the k8s updates and agent heartbeats and notes the volume received by each.
      It breaks down the k8s updates by entity type (pod, etc) and the agent heartbeats by agent data info, created processes, and terminated processes.
      We are adding this in order to better understand the load on the metadata service for a series of stability improvements that we want to make.
      
      Also for some reason make gazelle changed an autocomplete BUILD.bazel ordering, so added that too.
      
      Test Plan: ran it in my cluster and verified the correct information was printed out
      
      Reviewers: michelle, zasgar, #engineering
      
      Reviewed By: michelle, #engineering
      
      JIRA Issues: PP-2318
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6859
      
      GitOrigin-RevId: 04e3edbc8f4855d7a3b4045b0caa33394978fc41
      22f51314