This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 08 Dec, 2020 1 commit
-
-
Phillip Kuznetsov authored
Updating support for multiple tracepoints on the same target by cleaning up mutations data structures Summary: We used to store a mapping of the tracepoint targets to the tracepoints for those targets. For each type of target, we had a separate map. I considered two alternatives could be used for these data structures: 1. (Chosen approach) Vector of DeploymentSpec,TracepointDeployment pairs a. Lose uniqueness of DeploymentSpecs * We don't really have a need for uniqueness constraints anymore. We had some desire for it before but I think it's not necessary. b. Gain simplicity of writing out protobufs, pay for complexity in the special API which we already pay for, honestly looks pretty good. 2. Single map w/ a unified key of UPID, SharedObject, etc. a. Could use DeploymentSpec protobuf message, but not guaranteed to be great keys (https://developers.google.com/protocol-buffers/docs/encoding#implications) b. Could make a new key that contains all of the fields, but might be a lot of work and more complex than separate maps. Test Plan: updated tests to support the multiple tracepoints Reviewers: nserrino, jamesbartlett, oazizi, yzhao, #engineering Reviewed By: jamesbartlett, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6892 GitOrigin-RevId: 02e618b5e910fadcd5e67ad7a209f7f4a1822995
-
- 09 Dec, 2020 2 commits
-
-
Vihang Mehta authored
Summary: This does nothing and causes `px deploy` to just hang. Test Plan: N/A Reviewers: michelle, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6894 GitOrigin-RevId: 069cff7cc91fff797cb7eef824aad3d6e27be8f7
-
Vihang Mehta authored
Summary: We were having issues with `etcd` running on `minikube` `v1.13.0+` The dns resolution for `etcd-0.etcd` would fail causing `etcd` to crashloop. Since we only run a single replica of `etcd` and are working towards completely getting rid of it, let's just clean this up and get it working. Test Plan: Deploy pixie on a `minikube v1.15.1` cluster. `etcd` fails to run. Delete the `etcd` stateful set and apply this new config. `etcd` succeeds. Reviewers: michelle, oazizi, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6893 GitOrigin-RevId: cfe628b2dc2823edaf08049f9c9d40e3986936d2
-
- 08 Dec, 2020 1 commit
-
-
Nick Lanam authored
Summary: Not the first bug that came from having to make a fix in both the mutation and normal path. I'll be putting some thought into a more maintainable structure for this file; the behavior is already what we want. Test Plan: Try to cancel tracepoints being deployed. `tcp_drops` is a good example, and renaming the UpsertTracepoint parameter is sufficient to force it to deploy new tracepoints/see the dialog again. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: nserrino, michelle, #engineering JIRA Issues: PC-694 Differential Revision: https://phab.corp.pixielabs.ai/D6890 GitOrigin-RevId: 9bbc53fcd4c6da47529d350e75b6a5571c6b7a66
-
- 07 Dec, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: we want to track user's cluster level uptime to help manage customer expectations and track basic cluster-level metrics. this diff will track a segment event everytime a cluster's status changes. Test Plan: deployed in staging and looked @ segment debugger Reviewers: zasgar, #engineering, vihang Reviewed By: #engineering, vihang Differential Revision: https://phab.corp.pixielabs.ai/D6885 GitOrigin-RevId: b8b7acafb7faaafd60d14dcbe56de04451fb5b78
-
- 08 Dec, 2020 1 commit
-
-
Omid Azizi authored
Summary: Be explicit about kvm2 Test Plan: Ran it. Reviewers: yzhao, jps, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6891 GitOrigin-RevId: a36da2a6eea0f5c3e168dfde88883bf1b4e306bd
-
- 07 Dec, 2020 1 commit
-
-
Vihang Mehta authored
Summary: TSIA. components belong in workspaces/pixie-components, other things are not components Test Plan: `yarn dev` Reviewers: michelle, nick, #engineering Reviewed By: michelle, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6884 GitOrigin-RevId: ee79f926d2e007dbec135e59930c9a84eb7c1d5b
-
- 24 Nov, 2020 1 commit
-
-
Yaxiong Zhao authored
Summary: Remove the need to update connection_tracker_test.cc Created a new header src/stirling/protocols/stitchers.h to include all headers for the StitchFrames() template specializations. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6863 GitOrigin-RevId: e85e0bfbb81f79af579f18aaf2fd5251fe4f489b
-
- 08 Dec, 2020 3 commits
-
-
Nick Lanam authored
Summary: This specifies the available settings (currently just one - whether the tour has been seen) and makes them available for read/write. Accessed via React hook. Test Plan: Unit tests only right now. The next change for this will add a use for the `tourSeen` setting to show the tour once to each new user. Reviewers: nserrino, michelle, vihang, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6888 GitOrigin-RevId: 91dbc658d85abf0a7b9dfa351f283813ac04b399
-
Omid Azizi authored
Summary: Cleaning up a warning that @jps ran identified. Test Plan: Jenkins Reviewers: jps, #engineering Reviewed By: jps Subscribers: jps Differential Revision: https://phab.corp.pixielabs.ai/D6887 GitOrigin-RevId: 14fc2da0557223c11c224c53ad13492137c08a76
-
Omid Azizi authored
Summary: Same pattern appears twice between java.cc and jvm_stats_connector.cc. Refactor to share the code. There is some potential for optimization here. That's coming in subsequent diffs. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6862 GitOrigin-RevId: c17ee324bea0ee311c170ba707c90c6bf6150971
-
- 07 Dec, 2020 4 commits
-
-
Phillip Kuznetsov authored
Fix error reporting in agg tuples to CreateError() instead of trying to call node()->CreateError() which might yield a segfault Summary: @jamesbartlett found this error, I'm fixing it now. If you swapped function with column name in aggs, this error would be triggered. Test Plan: Added a test and fixed the problem Reviewers: jamesbartlett, #engineering, vihang Reviewed By: jamesbartlett, #engineering, vihang Subscribers: jamesbartlett Differential Revision: https://phab.corp.pixielabs.ai/D6886 GitOrigin-RevId: c338c8095ef598cd7b1d3ecd8782927b46eff5b3
-
Yaxiong Zhao authored
Summary: Changing this file wont trigger bpf tests; so have this as a compromise. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6835 GitOrigin-RevId: bc943bd3c66973184954ce87933c9f4d89819f41
-
Omid Azizi authored
Summary: Move table definition to own header file, for consistency. Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Subscribers: zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6880 GitOrigin-RevId: e9b375b905405ce4999b7d3a6fd89b1fcc23a154
-
Yaxiong Zhao authored
Summary: Added an overloaded version of BinaryDecoder::ExtractStringUntil() to accept string_view and pointer. Test Plan: Jenkins Reviewers: oazizi, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6844 GitOrigin-RevId: 1ae3265896503229e9ab5e3bed5112ffc9146c54
-
- 24 Nov, 2020 1 commit
-
-
Vihang Mehta authored
Summary: Remove fluentbit since we now rely on `px debug log` Test Plan: Ran vizier using skaffold, ensured that `px debug log` still worked. Trying to run cloud using skaffold to verify it works too. Reviewers: zasgar, michelle, jamesbartlett, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-2317 Differential Revision: https://phab.corp.pixielabs.ai/D6861 GitOrigin-RevId: 147537b5fc145b73fa080615528b27702f056697
-
- 26 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: For consistency (and less macro use). Test Plan: Existing tests. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6879 GitOrigin-RevId: ca5b5e7dd01183d1c5db19132a991d9527dc036a
-
- 24 Nov, 2020 2 commits
-
-
Michelle Nguyen authored
Summary: this diff implements the actual graphql resolver for getting/updating userSettings. Test Plan: unit tests, ran cloud dev and verified making gql requests from the UI worked as expected Reviewers: nick, vihang, nserrino, zasgar, #engineering Reviewed By: nick, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6858 GitOrigin-RevId: 1eaccbc16738c77a74e082af0717d74cd9e0a9bf
-
Michelle Nguyen authored
Summary: we are adding user settings in our backend, so that we can use usersettings to determine whether or not to show the onboarding overlay. this part updates the profile service to handle getting/updating user settings. this diff: - updates the profile proto with the new rpc methods - updates the profile server to handle the new rpc calls - updates profile datastore to actually get/update the values in the db the last part in the backend is to update the API service to make this call to the profile service. Test Plan: unit tests Reviewers: vihang, nserrino, nick, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6849 GitOrigin-RevId: 649b956e68125348c3cd6e32ce50d65d4d2c40f5
-
- 05 Dec, 2020 2 commits
-
-
Vihang Mehta authored
Summary: It seems like this was used by the code-snippet component which was removed in D5277 Test Plan: `yarn dev` Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6882 GitOrigin-RevId: 9fe87d0faa906e116c2248a001241693b25175a0
-
Omid Azizi authored
Summary: Removing unnecessary links and updating some comments. Test Plan: Existing tests Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6881 GitOrigin-RevId: 39d710a6ae0f27a67d743cdb5eb60b2d5c2a27cf
-
- 06 Dec, 2020 1 commit
-
-
Michelle Nguyen authored
Summary: updated the comments, since this is heavily modified from the version referenced on stack overflow. updated some variable names Test Plan: n/a Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6883 GitOrigin-RevId: 53a352b4405f28d82690e21559cf080a963a01b3
-
- 25 Nov, 2020 12 commits
-
-
Vihang Mehta authored
Summary: We don't actually depend on `highlight.js` directly, so don't install it. Upgrade `@storybook/*` deps so that they pickup newer `highlight.js` Test Plan: `yarn dev` and `yarn storybook` in pixie-components Reviewers: zasgar, michelle, #engineering Reviewed By: michelle, #engineering Subscribers: nick Differential Revision: https://phab.corp.pixielabs.ai/D6869 GitOrigin-RevId: 406b86857320a80a803555c5af26c151ffcacd24
-
Omid Azizi authored
Summary: No point in having different elf_tools/dwarf_tools namespaces. Plus it matches directory structure now. Test Plan: Existing tests Reviewers: yzhao, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6877 GitOrigin-RevId: a14e9d2d688bf4c16673ef18090221ac16724753
-
Vihang Mehta authored
Summary: This adds `cc_library` and `cc_proto_library` rules to lsif-clang Also cleans up some code dupe in the upload script and hides the sourcegraph credentials. Test Plan: Run on jenkins Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6876 GitOrigin-RevId: 50518269806e8d219836797155e3b5eca4ded574
-
Vihang Mehta authored
Summary: `pixie-components` only uses webpack transitively as part of `@storybook` Since storybook uses webpack4, it needs the older version of `html-webpack-plugin` I think I force resolved this because I was doing the webpack 5 upgrade while the stories were in `src/ui` and concurrently was moving stories into `pixie-components` in a separate diff. Not moving stories required this resolution to happen, moving the stories, make the stories made the resolution unstable. Test Plan: `yarn storybook` works in pixie components again. Reviewers: nick, #engineering, zasgar Reviewed By: #engineering, zasgar Differential Revision: https://phab.corp.pixielabs.ai/D6874 GitOrigin-RevId: 5b17e9073ff74b64780dc088b58b8f7f831c3d2a
-
Vihang Mehta authored
Summary: TSIA Depends on D6872 Test Plan: Run it locally Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6875 GitOrigin-RevId: 8600371e98168210f51e557108a92d0774f93767
-
Zain Asgar authored
Summary: LSIF is used for language server features. Test Plan: N/A Reviewers: vihang, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6872 GitOrigin-RevId: 0903de83194c8906824071f6818db5052dcf7c3d
-
Zain Asgar authored
Summary: The files are used for cc_library but not actually used standalone. I think this is actually an issue, but we can work on a better fix. Actually there is probably a cleaner way to accomplish what we are doing with the inl files. Test Plan: Existing + clang-lsif Reviewers: vihang, philkuz, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6873 GitOrigin-RevId: b76c5594048be36b4bd5110816c4e402739cbb5f
-
Vihang Mehta authored
Summary: TSIA Test Plan: N/A Reviewers: zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6871 GitOrigin-RevId: dd30a0792af5b1e8f6dbf1c3dfbb5e88364ab7c1
-
Vihang Mehta authored
Summary: This was used by proc_tracer_bpf_test but didn't get deleted in D6367 Test Plan: N/A Reviewers: oazizi, yzhao, #engineering Reviewed By: oazizi, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6870 GitOrigin-RevId: f821982e3e82eba54ba9d298d1b26227aa1ead6a
-
Michelle Nguyen authored
Summary: cancel being null is causing a white screen when navigating to this page Test Plan: ran yarn dev Reviewers: nick, nserrino, zasgar, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6866 GitOrigin-RevId: 9822f97991d372362106937f9aef7f1ab3519451
-
Michelle Nguyen authored
Summary: I accidentally introduced a flaky test, because of the ordering of maps change. We should just compare the actual pb rather than the unmarshalled bytes Test Plan: ran the test 1000 times Reviewers: nserrino, zasgar, vihang, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6867 GitOrigin-RevId: 30c85cf6d727651e9c6df6cdc620c8d563968d58
-
Vihang Mehta authored
Summary: TSIA. This will collect and upload lsif data for `go` and `typescript` Test Plan: Jenkins Reviewers: zasgar, michelle, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6868 GitOrigin-RevId: f6ddce988ac926a5f2b79fc809028143e9f91983
-
- 23 Nov, 2020 1 commit
-
-
Omid Azizi authored
Summary: Store some information when the connector is created, so that repeated calls to GetUPIDs() doesn't do a bunch of extra work. In stirling_wrapper with a StandaloneContext, this reduces the perf from ~75% CPU to ~20% CPU usage. Likely doesn't affect stirling the AgentContext (i.e. in the PEM) in any significant way, since the AgentMetadataState was already snapshotted in AgentContext. So only expect marginal improvements there. Test Plan: Existing tests. Reviewers: zasgar, yzhao, #engineering Reviewed By: zasgar, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6841 GitOrigin-RevId: 4d5f30fc86a76300f44f2eadd9fe82024767cff0
-
- 24 Nov, 2020 3 commits
-
-
Michelle Nguyen authored
Summary: the condition was wrong, so we were still sending out "Failed" notifications for passing builds Test Plan: n/a Reviewers: vihang, zasgar, #engineering Reviewed By: vihang, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6864 GitOrigin-RevId: 961bc12d1190cf2d0410ea62c1df5b44afa743b3
-
Omid Azizi authored
Summary: Fix some aspects of the test. Still investigating high CPU usage reported by the test. Test Plan: Manual. Not enabled yet. Reviewers: yzhao, #engineering Reviewed By: yzhao, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6839 GitOrigin-RevId: 146af60ce305c7ac8f56362c6a7eba169d7b2814
-
Michelle Nguyen authored
Summary: we are seeing an issue occuring on clusters (especially larger clusters), where the computedSchema grows too large and can no longer be sent to etcd. after some examination, it appears we are hitting a race condition where if an agent is deleted the same time as another is updating its schema, its possible for zombie agents/tables to be left behind in the computed schema. we could add locks, but that would introduce a performance impact since the lock would have to be around a network call to etcd. we are also heavily refactoring the metadata service, so most of this logic will be removed in the future anyway. we decided that a temporary fix, where we periodically clean up the computedSchema, should suffice until our refactor Test Plan: unit test, ran Vizier with skaffold and verified the zombie agent IDs and tables were pruned. also verified that I could still run scripts afterwards Reviewers: nserrino, zasgar, philkuz, #engineering Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6860 GitOrigin-RevId: b34109581979dd58d295f6b4bc57f1cf45987253
-
- 23 Nov, 2020 1 commit
-
-
Nick Lanam authored
Summary: the GraphQL language service (used by plugins for editors and IDEs) marks the entire schema invalid if it detects syntax or semantic errors, making the tool think every query is invalid/unknown. Fixing semantic errors takes care of that. Additionally, we have two schemas with some overlap, which were both being seen by that tooling. Using `.graphqlconfig` file to ignore the one that is a subset of the other takes care of this as well. Both fixes combined allow tooling to recognize valid queries. Notably, this does not change the application's behavior at all: it just makes sure editors and IDEs understand what's happening. Test Plan: Check out the various usages of the `gql` template tag in our TypeScript code, in an editor/IDE that can highlight and inspect the syntax. It should now succeed when trying to do so. The build should be entirely unaffected. Reviewers: nserrino, michelle, vihang, #engineering, zasgar Reviewed By: nserrino, #engineering Differential Revision: https://phab.corp.pixielabs.ai/D6838 GitOrigin-RevId: 5fe4cf6418c5e834f26c2be8f5621df12520ef93
-
- 24 Nov, 2020 1 commit
-
-
Natalie Serrino authored
Summary: This diff adds a stats handler to the metadata service which watches the k8s updates and agent heartbeats and notes the volume received by each. It breaks down the k8s updates by entity type (pod, etc) and the agent heartbeats by agent data info, created processes, and terminated processes. We are adding this in order to better understand the load on the metadata service for a series of stability improvements that we want to make. Also for some reason make gazelle changed an autocomplete BUILD.bazel ordering, so added that too. Test Plan: ran it in my cluster and verified the correct information was printed out Reviewers: michelle, zasgar, #engineering Reviewed By: michelle, #engineering JIRA Issues: PP-2318 Differential Revision: https://phab.corp.pixielabs.ai/D6859 GitOrigin-RevId: 04e3edbc8f4855d7a3b4045b0caa33394978fc41
-