This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 29 Jun, 2022 17 commits
-
-
Vihang Mehta authored
Summary: The `linux_binary` path is relative not `absolute` which breaks the cp. This fixes the same. Test Plan: Relase cli on jenkins Reviewers: michelle Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11719 GitOrigin-RevId: adb23c5c37e44c032f049a6c642cde271c200448
-
Vihang Mehta authored
Summary: TSIA Test Plan: Checked the vars being used. Reviewers: michelle, zasgar Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11718 GitOrigin-RevId: 6335b257d57f72e056ed7f01ba991fe15fa278a8
-
Nick Lanam authored
Summary: Adds details to the existing link to stats, with a tooltip. Tooltip and icon show how many recent runs there are, and how many passed or failed. Green for 100%, yellow for 50%-99%, and red for less than 50%. Uses the old gray icon if there's not enough information to choose one of the others (for instance, if there are no runs on any cluster for that script yet or if every cluster it might have run on isn't available right now for queries). {F188600} Test Plan: Visit `/configure-data-export`. - New Export Status column, contains button linking to history same as before. - Button icon now has a tooltip with a summary for that script. - Button icon now changes to be green/yellow/red depending on pass/fail rate of recent runs. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PP-3427 Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11674 GitOrigin-RevId: 2bc9c90da441284846fe81882d250bfb256298e2
-
Vihang Mehta authored
Summary: TSIA Test Plan: Ran it when there was already a signature file. gpg overwrote it. Reviewers: michelle Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11717 GitOrigin-RevId: f4a16fcc9bc7aa7605d7216e07e5b11414f8121c
-
Vihang Mehta authored
Summary: TSIA Test Plan: Ran the command locally, ensured that signing worked. Reviewers: michelle, zasgar Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11716 GitOrigin-RevId: ab1b35521d93d3e15dc911580279df4fb9aa51fb
-
Ryan Cheng authored
Summary: In https://github.com/pixie-io/pixie/issues/456 and on slack, it was reported by multiple users that Stirling reports rss in terabytes whereas virtual memory is normal. There is a potential integer overflow in `ProcParser::ParseProcPIDStat`. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: oazizi Signed-off-by:
Ryan Cheng <rcheng@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11687 GitOrigin-RevId: 312349f406ddc70ada2608818380d9f55439e807
-
Vihang Mehta authored
Test Plan: bazel built the cli and tried to update it Reviewers: zasgar, michelle Reviewed By: zasgar Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11689 GitOrigin-RevId: c6c1c26c5ff357ac1ef61a3045b3a3967e51133e
-
James Bartlett authored
Summary: Previous diff, didn't change the arg in the `run_bazel_build` branch. Test Plan: Ran with `--run_bazel_build` and it worked. Reviewers: vihang, zasgar Reviewed By: vihang Signed-off-by:
James Bartlett <jamesbartlett@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11710 GitOrigin-RevId: b42234b347f98a03ec8021e802df28d7664434eb
-
Vihang Mehta authored
Summary: To prepare for more potential places that pixie artifacts might be built, add some builder info to versions via xdefs. Test Plan: Built the CLI and ran px version Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11697 GitOrigin-RevId: a3f63b636a39fc0e0aba0d5bdba25bc672415435
-
Michelle Nguyen authored
Summary: We were seeing some issues with db connections. Taking a look at recent plugin code shows a potential area where the connection may not be getting closed properly. Defer in these cases aren't as ideal, since there are multiple db requests in a function. We just need to make sure we close the row if we're returning early due to an error. Test Plan: existing tests pass Reviewers: vihang Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11704 GitOrigin-RevId: 8d650e5e0221f48d678c4974d1cf5f18c5328bfa
-
James Bartlett authored
Summary: We had duplicated the default value for stirling config flags (datastream_buffer_size and datastream_buffer_spike_size) in a lot of places. This diff removes all the additional places the default is specified such that the source of truth is now only the default specified in the stirling code. Test Plan: Using my diff to cut a dev release, I tested that a dev release with the new templated yamls, deploys successfully without the datastream parameters specified on the PEMs. Also tested that passing the flags to the CLI ends up with the correct flags going to the PEM. Reviewers: michelle, vihang Reviewed By: vihang Subscribers: oazizi Signed-off-by:
James Bartlett <jamesbartlett@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11703 GitOrigin-RevId: b7962bff9117ebe7fe39ce5259a41eab04c61785
-
James Bartlett authored
Summary: With our upgrade of bazel and clang, gen_compilation_database.py broke. This upgrade the version of bazel-compilation-database, and adds a patch to get it working again. Test Plan: Tested that compile_commands.json was generated. Reviewers: zasgar, vihang, #third_party_approvers Reviewed By: zasgar, vihang, #third_party_approvers Signed-off-by:
James Bartlett <jamesbartlett@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11705 GitOrigin-RevId: 2618efc175df89abc6c1db7a9e4ed3df9e289484
-
Vihang Mehta authored
Summary: The perf profiler test flakes a lot on main. See: https://bb.corp.pixielabs.ai/tests/?filter=perf_profiler_bpf This disables the flaky bit. Test Plan: main should flake less Reviewers: zasgar, oazizi, jps Reviewed By: oazizi Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11709 GitOrigin-RevId: 470dc0bcc946508c9f86edef16cab5a5599239cb
-
Vihang Mehta authored
Summary: Update some deps to address CVEs. Test Plan: yarn build_prod, yarn test, yarn dev all work Reviewers: nlanam, michelle, #third_party_approvers, zasgar Reviewed By: #third_party_approvers, zasgar Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11706 GitOrigin-RevId: 26edf24450e0aa7a85c429b35cc61b434e03e528
-
Vihang Mehta authored
Summary: There were some errors in the script. This fixes them. Test Plan: Check buildbuddy logs Reviewers: zasgar Reviewed By: zasgar Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11708 GitOrigin-RevId: 1f0c078232fe97abb8fc28f9f684cbcf4d6108e5
-
Zain Asgar authored
Summary: TSIA Test Plan: jenkins Reviewers: michelle, vihang Reviewed By: vihang Signed-off-by:
Zain Asgar <zasgar@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11679 GitOrigin-RevId: ef225ebf6ef077ae3a962958a87c713bff438774
-
James Bartlett authored
Summary: Adds options to ci/vizier_build_release.sh, that allow specifying a custom GCS bucket, and a custom container registry, so anyone can make a dev release that points to a bucket/registry they have access to. This is useful for testing out changes to the YAML templatization without needing prod access, because there's no way to test those changes without cutting a release. Test Plan: Tested by building a dev release pointing to a custom GCS bucket, and then pointing artifact server to that bucket. Successfully deployed vizier with the dev release. Reviewers: zasgar, michelle, vihang Reviewed By: michelle Signed-off-by:
James Bartlett <jamesbartlett@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11701 GitOrigin-RevId: 0d982122a65dc0051117db2db7a95439b4db635a
-
- 28 Jun, 2022 13 commits
-
-
Vihang Mehta authored
Summary: Discovered some small issues when recreating the testing cluster. Test Plan: Deployed cloud to testing Reviewers: michelle Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11702 GitOrigin-RevId: f54857a9f2d355f7e62a7baf4b3926877478d4d7
-
Nick Lanam authored
Summary: If a retention script has an explicit cluster list instead of the default (empty = all clusters), only show those selected clusters when viewing cron history. Test Plan: Go to `/configure-data-export`. Look at the history for a script that has no specific clusters selected, and for one that has at least one selected. The former should let you select any connected cluster for history stats. The latter should only offer the clusters that were selected, even if they're currently disconnected. Reviewers: michelle, vihang Reviewed By: michelle Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11700 GitOrigin-RevId: c4deab9da5168fe0ea97095cf6d88dd25de477fa
-
Vihang Mehta authored
Summary: Fixes a typo in the skylab config and fixes a warning about a deprecated flag.Fixes a typo in the skylab config and fixes a warning about a deprecated flag. Test Plan: Ran the script to create a new skylab cluster. Reviewers: michelle, zasgar Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11698 GitOrigin-RevId: 79035b6d1e86f3752599fe66da5cedf11c4ebc9a
-
Vihang Mehta authored
Summary: Drop `image-webpack-loader` since it's deps are mostly no longer maintained and seem to have lots of CVEs. Instead, just minimize the images and check them im. Disable a couple more extra favicons that were being generated but are unused. Fixup the stars background on the login page. This speeds up the yarn install some amount? and the webpack by a couple of seconds. Test Plan: yarn dev, still words. yarn build_prod still works. Reviewers: zasgar, michelle, nlanam, #third_party_approvers Reviewed By: michelle, nlanam, #third_party_approvers Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11690 GitOrigin-RevId: 1856906d198d43ae47b4f12e06d5bff8ae2a0d1e
-
Taras Priadka authored
Summary: Adding Grafana demo manifests for a quick deployment of demo application. Test Plan: Deploy to your cluster. Look for the grafana service IP, and make sure that everything is running under GRAFANA-IP:3000 Reviewers: vihang Reviewed By: vihang Signed-off-by:
Taras Priadka <tpriadka@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11670 GitOrigin-RevId: 592722ff7e33ba6666442765b18c2eb563254f0b
-
Michelle Nguyen authored
Summary: Currently when a user upgrades a plugin to a new version, the preset scripts are deleted and recreated. This leads to a poor user experience, as a user may have set custom configurations to the preset scripts. This diff updates the plugin upgrade process: 1. Fetch preset scripts from the new plugin version 2. Fetch existing preset scripts the org has configured for the (now) old plugin version 3. Assume if two preset scripts have the same name, they are the same script. Update the contents of an existing preset script with the new version. 4. Create any new preset scripts that don't exist in the old plugin version. 5. Delete any preset scripts from the old version that are not in the new plugin version. Test Plan: unit test Reviewers: vihang, philkuz Reviewed By: philkuz Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11683 GitOrigin-RevId: 252755a2097993a6be7daeb1110292af761d8278
-
Vihang Mehta authored
Summary: At some point the url-loaders started exporting esModules by default instead of commonjs. This broke the stars background. This diff fixes the same. Test Plan: yarn dev, go to a login page, see the background again. Reviewers: michelle, nlanam Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11693 GitOrigin-RevId: 7e3d954f1df105f80c827e52ae99371c49da341d
-
yzhao1012 authored
Test Plan: Added comments, no tests needed Reviewers: #stirling, rcheng Reviewed By: #stirling, rcheng Signed-off-by:
yzhao1012 <yzhao@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11688 GitOrigin-RevId: fd5a1a140a54d6152694b5d6e8971edd405219a7
-
Michelle Nguyen authored
Summary: Currently when a user disables a plugin, we delete all preset and custom scripts. This can be particularly annoying for custom scripts if a user has spent some time writing it. This diff updates the plugin disabling process so that custom scripts are not deleted, just disabled. Note that these scripts are not listed in the UI until the plugin is re-enabled. We can show them so that users may still view their scripts, however this will require some more UI work. For example, to not let the user reenable the script if the plugin is disabled Test Plan: Unit test, deploy to testing cloud and disable/renable a plugin. Reviewers: philkuz, vihang Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11686 GitOrigin-RevId: 52aa3158047c3a9e670f8fb36a02ecae636909ee
-
Vihang Mehta authored
Summary: TSIA Test Plan: Ran yarn build_prod and examined the bundle Reviewers: michelle, nlanam Reviewed By: michelle, nlanam Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11692 GitOrigin-RevId: 646b8c85dd63d33baa9c1492f8321c61ce0818e0
-
Vihang Mehta authored
Summary: TSIA Test Plan: git grep finds no use of these, UI build still works. Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
Vihang Mehta <vihang@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11691 GitOrigin-RevId: 5261cfd124b4fc8d55c4089729199be5faa6483a
-
Phillip Kuznetsov authored
Summary: Ran into an issue while trying to add pxlLib that IR graph changes in the compiler cause some tests to fail because IDs change. We've had this issue for a while and haven't addressed it satsifactorily. This approach is meant to remove the need for accurate IDs in these types of tests and now just verifies that the graphs match structurily. Test Plan: Added tests for this component and update the bad tests to use this. Reviewers: jamesbartlett, nserrino, vihang Reviewed By: jamesbartlett Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11660 GitOrigin-RevId: c360ec52aa81b64f28e7a134c48fcfd6c490a527
-
Michelle Nguyen authored
Summary: There is a new link to the OTel tutorial now. Test Plan: This is a simple URL change, nothing to test Reviewers: nlanam, philkuz Reviewed By: nlanam, philkuz JIRA Issues: PC-1546 Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11685 GitOrigin-RevId: d8c5093cd65eb116f568d69c34aa400207c3fb7c
-
- 27 Jun, 2022 9 commits
-
-
Vikranth Srivatsa authored
Summary: Adds extra types in type gen template. This can be used to try fully generating the constants/types file Test Plan: This will be tested in a later pr by checking if actual packets decoded correctly. Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Signed-off-by:
Vikranth Srivatsa <vsrivatsa@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11669 GitOrigin-RevId: 84d0770209ccd0d2ae49b213252740de74c67031
-
Michelle Nguyen authored
Summary: PodSecurityPolicies have been deprecated as of k8s 1.21, and will be removed in K8s 1.25. We currently include the podSecurityPolicy by default. Most of the time it is ignored, as people need to enable the admission controller. When the admission controller is enabled, the current podSecurityPolicy isn't correct anyway, as we would also need podSecurityPolicies for the operator. In most cases, users have needed some customization around the podSecurityPolicy to best fit their configurations anyway. Fixes #371 Test Plan: built Vizier YAMLs Reviewers: philkuz, vihang Reviewed By: vihang Signed-off-by:
Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11680 GitOrigin-RevId: 17a279c94575bf83e403ee0383db9e6314b8dcff
-
Omid Azizi authored
Summary: Remove flakiness in pgsql_trace_bpf_test by removing a dependence on an external docker image. Instead use the existing postgres container for the client that we need for the tes. Test Plan: This is a test update. Reviewers: #stirling, zasgar Reviewed By: zasgar Signed-off-by:
Omid Azizi <oazizi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11675 GitOrigin-RevId: ec560ecfbcb2fe0d944939d119fc7c95b0d40a75
-
Phillip Kuznetsov authored
Summary: Updated the pxapi pypi page with more links, removing old links, and changing Authors -> Maintainers. Test Plan: uploaded to test pypi Reviewers: vihang, htroisi Reviewed By: htroisi JIRA Issues: PXC-221 Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11673 GitOrigin-RevId: 697d2758987ff31fedba2ee4e21326c92a0ea393
-
Nick Lanam authored
Summary: We were detecting embed state by checking the URL. This is clumsy, and breaks when one embedded view links to another without remembering to check that first. Sorry for the semantic satiation in the following text... With this change: - Embed state is checked by testing if Pixie appears to be in an iframe - Most links and buttons that accounted for embed state don't bother anymore, because... - A top-level conditional redirect now automatically fixes the URL if it doesn't line up (puts `/embed` at the front of the path if embedded, and removes it otherwise) - Routes for embeddable views still need to exist, so those stay. - Trying to reach a route that doesn't have an embedded variant defined while embedded will now go to the 404 page instead of breaking out of embedded mode - If Pixie is incorrectly embedded or if an embed link is accessed directly, it will fix itself before continuing Test Plan: Try a wide variety of links throughout the app: - Access live views normally. Click entity links. Visit credits. Visit admin. Visit `/configure-data-export`. - Try bouncing between plugin page and data export overview and data export details and data export history. - Do the same when Pixie is embedded. - Try embedding without `/embed` in the URL, or going to a `/embed` link in a new tab. Both should correct themselves. - It should no longer be possible to, while embedded, "break out" of this mode - Trying to embed a path that doesn't have a `/embed` version should now 404 instead of loading like it wasn't embedded. For example, try to embed `/credits`. It should try to change that to `/embed/credits`, which will 404. Reviewers: michelle, vihang Reviewed By: michelle Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11650 GitOrigin-RevId: c9033f4e4f8b5b6d9188acbb0a05af16db72b28c
-
Nick Lanam authored
Summary: Scrollbars are not consistent between browsers, operating systems, and settings for either. Customizing scrollbars I even more complex, and makes detection of their dimensions somehow even less consistent. This diff guarantees that `useScrollbarSize` will detect the actual dimensions of the scrollbar (and if it's overlay vs inlay) in Safari, Chrome, and Firefox on macOS, Linux, and Windows, and especially for macOS users who change their system settings for scrollbars (General -> Show scroll bars -> defaults to "When scrolling"). Result is that data tables should no longer fail to reserve space for scrollbars when they should. This diff also deletes a long-unused file that was still laying around. Test Plan: Run any PxL script with tables in Chrome on macOS with system preference of "When scrolling". Do the same in Firefox and also try changing the system setting (reload between changes). Try Firefox and Chrome on Ubuntu as well. In all cases, there should not be any _unexpected_ horizontal scrollbars (tables with too many columns for the space available will still show one). Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1542 Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11657 GitOrigin-RevId: cd96499fcd87f1e99b1f9189aeb51be31ab9c2d4
-
Nick Lanam authored
Summary: The error column already has this information, but now there's an icon on the left to make it easier to notice. This involved adding a new feature to the data tables. {F188519} {F188520} Test Plan: Visit cron history for any given script. Try those with successful runs and those with unsuccessful runs to see both versions. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PP-3426 Signed-off-by:
Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11667 GitOrigin-RevId: 42ee20e58cdeea3e41b1f3e1dd5fec49a7d35da6
-
Phillip Kuznetsov authored
Summary: The styleguide was missing some linked files. We had an internal document with some styles so I figured I would just publish that as the cc and go style guides. I did a brief run through to make sure everything makes sense. Test Plan: Made sure links work and the guide renders correctly. Reviewers: michelle, vihang, zasgar, nserrino, oazizi, yzhao Reviewed By: zasgar Subscribers: htroisi JIRA Issues: PXC-205 Signed-off-by:
Phillip Kuznetsov <pkuznetsov@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11672 GitOrigin-RevId: 6aee975c7405a48599559be2b72de0c1cb1e0d36
-
Tharindu Wijewardane authored
Summary: Track pod labels and adds a UDF to get pod labels given IDs. Fixes #449 Closes #468 Test Plan: Added unit tests Reviewers: zasgar, michelle Reviewed By: michelle Signed-off-by:
Tharindu Wijewardane <tharindu.moratuwa@gmail.com> Differential Revision: https://phab.corp.pixielabs.ai/D11678 GitOrigin-RevId: fd84b4dfbe9bfce8da853232cee604417bdf07a7
-
- 25 Jun, 2022 1 commit
-
-
Zain Asgar authored
Summary: Also enables bpf tests when -b flag is passed to the bazel deps script. Configure BPF tests to make them faster and more stable. Test Plan: Nightly Regressions. Reviewers: oazizi, yzhao, jamesbartlett, vihang Reviewed By: vihang Signed-off-by:
Zain Asgar <zasgar@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11616 GitOrigin-RevId: 5d03e3c912ef3992167359c473060e3e3207bb77
-