This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 19 Nov, 2020 1 commit
    • Vihang Mehta's avatar
      Good riddance text linter · 36f16bff
      Vihang Mehta authored
      Summary: TSIA
      
      Test Plan: No more line length annoyance. Let language linters enfore it.
      
      Reviewers: #engineering, zasgar
      
      Reviewed By: #engineering, zasgar
      
      Subscribers: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6772
      
      GitOrigin-RevId: e725e9ee4f9ba38fca43da45a4554a9769db4b4f
      36f16bff
  2. 18 Nov, 2020 1 commit
    • Omid Azizi's avatar
      GoTLS prep: Create DwarfReader once · ecbdd0c5
      Omid Azizi authored
      Summary: With the GoTLS code, we'll need dwarf_reader as well. Move the creation of dwarf_reader higher up, so it can be shared.
      
      Test Plan: Existing tests
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6765
      
      GitOrigin-RevId: 33187f01ebbd54e49da3e0f9f92913774a6d694d
      ecbdd0c5
  3. 17 Nov, 2020 1 commit
    • Zain Asgar's avatar
      Remove SSD support in jenkinsfile · adb3dfc9
      Zain Asgar authored
      Summary: We are moving everything over to K8s and don't need support for SSD workers anymore. This is just a simplification step.
      
      Test Plan: Jenkins
      
      Reviewers: michelle, vihang, oazizi, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6757
      
      GitOrigin-RevId: 64e3c0c12ec09ca30e041f3d0857d1fc94a6ba8d
      adb3dfc9
  4. 18 Nov, 2020 2 commits
    • Yaxiong Zhao's avatar
      Add StitchFrames() function template as the common interface for stitching... · 8a242ab3
      Yaxiong Zhao authored
      Add StitchFrames() function template as the common interface for stitching requests & responses of all protocols
      
      Summary:
      Also rename ProcessFrames() -> StitchFrames().
      
      This matches the ParseFrame() pattern.
      
      The benefit is that it now is easier to understand the expectation on the ProcessFrames()
      API. Previously, ProcessFrames() is only linked, it was obscure to learn how it's invoked.
      
      In a followup diff, the common interface templates will be moved into one single header file.
      
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6763
      
      GitOrigin-RevId: 2a710bc4c9368645b05eeea2bb7e7d218e5f216d
      8a242ab3
    • Vihang Mehta's avatar
      Enable autoscaling in create_gke_cluster · f8257ef0
      Vihang Mehta authored
      Summary: TSIA. Included a flag to disable autoscaling.
      
      Test Plan: Run the script with `set -x` with and without the `-f` flag
      
      Reviewers: philkuz, zasgar, michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Subscribers: oazizi
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6762
      
      GitOrigin-RevId: 005c9fa435ca0d2ffb6dd7c932d98082ffcdff55
      f8257ef0
  5. 21 Oct, 2020 1 commit
    • Nick Lanam's avatar
      Static Tour Overlay (WIP) · e28f8649
      Nick Lanam authored
      Summary:
      Currently only opens from a new button in the sidebar. A future change can make it appear once automatically per user. The button does not appear on mobile (viewport widths under 960px) as the tour does not fit there and the layout is different anyway.
      
      When it's open:
      {F103838}
      
      Test Plan: Open the profile/admin menu in the bottom left in the sidebar. It should contain a `Tour` item that should open the tour.
      
      Reviewers: nserrino, michelle, zasgar, #engineering
      
      Reviewed By: michelle, #engineering
      
      Subscribers: htroisi
      
      JIRA Issues: PC-426
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6557
      
      GitOrigin-RevId: a8a8670fc811314ff2fc82478d0a2a00295ca2ee
      e28f8649
  6. 18 Nov, 2020 5 commits
    • Yaxiong Zhao's avatar
      Add redis_trace_bpf_test.cc · 1fafcc7c
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6755
      
      GitOrigin-RevId: 58d452091ed4a78c6421e5a6f33887cc1f3cca55
      1fafcc7c
    • Omid Azizi's avatar
      DNS: More tests based on real packet captures · 1317704a
      Omid Azizi authored
      Summary:
      Trying to catch a bug I see in the UI.
      
      This didn't end up revealing catching it, but worth keeping.
      
      Test Plan: This is a test.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6738
      
      GitOrigin-RevId: 91b0008fe9ea7605c2c8aa1ac5020f1adc183541
      1317704a
    • Vihang Mehta's avatar
      Upgrade webpack · b5a77be9
      Vihang Mehta authored
      Summary:
      `storybook` + `html-webpack-plugin` seem to not play nicely with webpack4. https://github.com/storybookjs/storybook/issues/9216
      Force resolving `html-webpack-plugin` to a new alpha version seems to work.
      
      `babel` modules need to be upgraded to address `.mjs` files. https://github.com/babel/babel/issues/8462
      
      `favicons-webpack-plugin` needs to be upgraded to handle API changes for webpack plugins https://github.com/jantimon/favicons-webpack-plugin/issues/222
      Upgrading to the new alpha version seems to work.
      
      A handful of other plugins also don't work due to API changes in webpack but upgrading them to their latest stable versions works.
      
      Test Plan:
      Build time perf for Webpack4:
      ```
      === PHASE SUMMARY INFORMATION ===
      
      Total launch phase time         1.200 s    0.59%
      Total init phase time           0.342 s    0.17%
      Total target pattern evaluation phase time    1.228 s    0.61%
      Total interleaved loading-and-analysis phase time    1.807 s    0.89%
      Total preparation phase time    0.058 s    0.03%
      Total execution phase time    197.507 s   97.70%
      Total finish phase time         0.013 s    0.01%
      ------------------------------------------------
      Total run time                202.157 s  100.00%
      
      Critical path (197.212 s):
             Time Percentage   Description
         91.785 s   46.54%   action 'Generating webpack deps src/ui/ui-deps.tar.gz'
         10.071 s    5.11%   action 'Generating licenses src/ui/npm_licenses.json'
          40.3 ms    0.02%   action 'Executing genrule //tools/licenses all_licenses'
         95.316 s   48.33%   action 'Generating webpack bundle src/ui/ui-bundle.tar.gz'
      ```
      
      Build time perf for Webpack5:
      ```
      === PHASE SUMMARY INFORMATION ===
      
      Total launch phase time         0.020 s    0.01%
      Total init phase time           0.180 s    0.09%
      Total target pattern evaluation phase time    0.118 s    0.06%
      Total interleaved loading-and-analysis phase time    0.145 s    0.07%
      Total preparation phase time    0.007 s    0.00%
      Total execution phase time    207.184 s   99.77%
      Total finish phase time         0.004 s    0.00%
      ------------------------------------------------
      Total run time                207.660 s  100.00%
      
      Critical path (207.116 s):
             Time Percentage   Description
         93.509 s   45.15%   action 'Generating webpack deps src/ui/ui-deps.tar.gz'
         10.430 s    5.04%   action 'Generating licenses src/ui/npm_licenses.json'
          30.0 ms    0.01%   action 'Executing genrule //tools/licenses all_licenses'
        103.148 s   49.80%   action 'Generating webpack bundle src/ui/ui-bundle.tar.gz'
      ```
      
      Reviewers: #engineering, michelle, nick
      
      Reviewed By: #engineering, michelle, nick
      
      Subscribers: nick
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6761
      
      GitOrigin-RevId: 6584b9806e6c35138b721af6e522b6da7a60b36b
      b5a77be9
    • Vihang Mehta's avatar
      Move stories into pixie-components · 4592727b
      Vihang Mehta authored
      Summary:
      storybook addons do not behave well when hoisted so use nohoist to
      ensure they are all located within the components folder.
      As a bonus, now storybook should only be generated when components are changed.
      
      Test Plan: `yarn workspace pixie-compoents storybook` + jenkins
      
      Reviewers: zasgar, nick, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6760
      
      GitOrigin-RevId: 6cf4f3b4154a8342c6bef04da4c57b38dbc82a86
      4592727b
    • Vihang Mehta's avatar
      Replace webpack-archive-plugin · b72c3e69
      Vihang Mehta authored
      Summary:
      This plugin uses deprecated webpack hooks and prevents us from upgrading
      to webpack 5
      
      Test Plan: UI build + test on jenkins should work
      
      Reviewers: zasgar, #engineering
      
      Reviewed By: zasgar, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6758
      
      GitOrigin-RevId: 0faf44042b6d93564c313c6112279d1a8ce24ba3
      b72c3e69
  7. 17 Nov, 2020 2 commits
    • Zain Asgar's avatar
      Add script to find and report build targets · e2f2ba8f
      Zain Asgar authored
      Summary:
      This script reports the Bazel targets for different build configurations.
      The output of this will be used by Jenkins to run targets as necessary.
      
      Test Plan: Tested locally.
      
      Reviewers: michelle, vihang, oazizi, #engineering
      
      Reviewed By: vihang, oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6748
      
      GitOrigin-RevId: dd4d4782705b8acce79f18359e61cb86cc89247b
      e2f2ba8f
    • Omid Azizi's avatar
      DNS Tracing: Add record types and cnames to output · 231827eb
      Omid Azizi authored
      Summary:
      More context for the user.
      
      Now the json output will have the record type (e.g. A vs AAAA).
      
      Also cname records (aliases) are output, similar to nslookup.
      
      Test Plan: Test cases updated.
      
      Reviewers: yzhao, #engineering
      
      Reviewed By: yzhao, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6736
      
      GitOrigin-RevId: 50eb291676fcd4e9b27987bb973ea58903c341fb
      231827eb
  8. 16 Nov, 2020 1 commit
  9. 17 Nov, 2020 1 commit
    • Vihang Mehta's avatar
      Clean up pixie-components · c7addc8c
      Vihang Mehta authored
      Summary:
      - Setup baseUrl and use root relative imports where necessary
      - Setup prettier and format all files
      - TODO: arc lint setup for prettier
      
      Test Plan: `yarn build`
      
      Reviewers: nick, #engineering
      
      Reviewed By: nick, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6751
      
      GitOrigin-RevId: bf4c0818664b5da31dde412edcf040e6ba04097a
      c7addc8c
  10. 02 Nov, 2020 1 commit
    • Nick Lanam's avatar
      Better algorithm for table column resizing and limits · 19408bb8
      Nick Lanam authored
      Summary: Resizing any column should now be substantially more intelligent. Columns will do their best not to change sizes outside of the one being dragged, but they will yield if they need to. The table as a whole shrinks and grows to help with this.
      
      Test Plan: Open a script with a good number of columns like `px/http_data` and play around with resizing columns. Do the same for a table with fewer columns, like `px/agent_status`. See implementation and unit tests for full details on how it should behave. KNOWN ISSUE: For the latter, the first movement jumps all of the column widths to something more uniform. That will be investigated in a future change.
      
      Reviewers: nserrino, michelle, vihang, #engineering
      
      Reviewed By: vihang, #engineering
      
      JIRA Issues: PC-655
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6747
      
      GitOrigin-RevId: 6f8d4828a7b251a35e4ef819ad106aeb7dcc0694
      19408bb8
  11. 16 Nov, 2020 2 commits
  12. 14 Nov, 2020 1 commit
  13. 13 Nov, 2020 1 commit
  14. 14 Nov, 2020 1 commit
    • Natalie Serrino's avatar
      PP-2202: re-enable TSAN test after clang upgrade · c2c25a89
      Natalie Serrino authored
      Summary:
      There was a previous issue with clang where one of our exec graph tests was falsely triggering TSAN.
      With the latest upgrade to clang, this issue no longer appears.
      
      Test Plan: Ran TSAN
      
      Reviewers: vihang, #engineering
      
      Reviewed By: vihang, #engineering
      
      JIRA Issues: PP-2202
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6745
      
      GitOrigin-RevId: 28416580ff59a0acc9f965a05a191d2677dc130c
      c2c25a89
  15. 13 Nov, 2020 5 commits
  16. 12 Nov, 2020 1 commit
  17. 13 Nov, 2020 1 commit
  18. 12 Nov, 2020 1 commit
  19. 13 Nov, 2020 2 commits
    • Vihang Mehta's avatar
      Recreate pixie-conponents and move drawers into it · 94f2531c
      Vihang Mehta authored
      Summary:
      This sets up a pixie-components subpackage and moves the drawer compoenents
      into it.
      
      TODO: Fix styling. It looks like the styles for the drawer components gets overriden
      when used by the pixie app. Should we be exporting unstyled components and let the pixie app
      call the styling hooks?
      
      TODO: Setup linting for components. The top level eslint + tsconfig doesn't play nicely
      with a component with it's own eslint + tsconfig. This linter setup needs some help.
      
      Stories are still in top level pixie to make it easier to debug whether the packaging
      is working, to be moved into subcomponents eventually.
      
      Test Plan: Check `yarn storybook` and `yarn dev`
      
      Reviewers: zasgar, michelle, nick, philkuz, #engineering
      
      Reviewed By: michelle, #engineering
      
      JIRA Issues: PP-1680
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6710
      
      GitOrigin-RevId: cc65338599b74809a5d23ccb1cb12145bea63418
      94f2531c
    • Vihang Mehta's avatar
      Separate go and cc files · a1e0eca1
      Vihang Mehta authored
      Summary:
      `go vet` assumes that colocated `.go` and `.cc` files must be built together
      with `cgo`. In scenarios where we don't need/want to do so, let's move the `.go` source
      into subfolders.
      
      Note: This makes the build rule for the go libs looks a bit weird ... they end in `/go:go_default_library`
      but IMO this is still cleaner than moving the `.cc` and `.h` files.
      
      Test Plan: `bazel build //...` should succeed.
      
      Reviewers: zasgar, michelle, philkuz, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6739
      
      GitOrigin-RevId: c6c80acaa32d203aed6b59d88a20d2c8f50d33b6
      a1e0eca1
  20. 12 Nov, 2020 1 commit
    • Yaxiong Zhao's avatar
      Add Diff() and DiffLines() to diff line-based text · c7f9f5a9
      Yaxiong Zhao authored
      Summary:
      Also updated EqualsProto() to use DiffLines() to report the diffs.
      A sample looks like this:
      
      ```
        deployment_spec {
          path: "src/stirling/obj_tools/testdata/dummy_go_binary_/dummy_go_binary"
        }
        structs {
      l:  name: "out_table_value_t"
      r:  name: "out_table_value2_t"
      ```
      
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6711
      
      GitOrigin-RevId: 0d6fb3b7faaa5e29e9d79cc79677de39df6855f5
      c7f9f5a9
  21. 13 Nov, 2020 1 commit
  22. 12 Nov, 2020 2 commits
    • Omid Azizi's avatar
      Change px.sum of booleans to return int · cddbbaea
      Omid Azizi authored
      Summary:
      This diff changes the behavior of px.sum on booleans to return a sum rather than a logical OR.
      
      We need a consistent definition of what the sum of two booleans means. So I'm leaving this as a preview until we can make that call.
      
      If we decide boolean + boolean = boolean, then this diff is not correct. Note that different languages (or even libraries within languages) have differing approaches.
      
      The right long-term solution is to do this via data type casts. So this could be a temporary workaround until that is supported.
      
      Test Plan: Modified the tests
      
      Reviewers: philkuz, nserrino, #engineering, zasgar
      
      Reviewed By: #engineering, zasgar
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6728
      
      GitOrigin-RevId: 1b0c3a321276b1fb6871991d16d0421edbbec9f9
      cddbbaea
    • Yaxiong Zhao's avatar
      Set probe_type for http2 uprobe data events · c59192a9
      Yaxiong Zhao authored
      Summary: Was using this to debug the duplicate req/resp body bug.
      
      Test Plan: Jenkins
      
      Reviewers: oazizi, #engineering
      
      Reviewed By: oazizi, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6721
      
      GitOrigin-RevId: 16d5261aed012605997b450cefbd218ee02643bd
      c59192a9
  23. 13 Nov, 2020 5 commits
    • Michelle Nguyen's avatar
      PP-2254 Add intercom in live view · 341f6fa1
      Michelle Nguyen authored
      Summary:
      we should have a help icon in the sidebar which opens up the messenger.
      when the user runs into an error, we should have a link that opens up the intercom messenger.
      
      Test Plan:
      gifs:
      {F103061}
      
      {F103062}
      
      {F103063}
      
      Reviewers: zasgar, nick, nserrino, #engineering, vihang
      
      Reviewed By: #engineering, vihang
      
      Subscribers: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6729
      
      GitOrigin-RevId: b7d733961824d061e34720b7ae1c39072fc4ec12
      341f6fa1
    • Michelle Nguyen's avatar
      PC-652 Segment Analytics: Add sitename to signUp Event · f925e252
      Michelle Nguyen authored
      Summary: we used to have this information in the signup event, but it has since disappeared because of some refactoring. it's helpful to have, for joining different tables in bigquery.
      
      Test Plan: unit test
      
      Reviewers: zasgar, nserrino, #engineering, vihang
      
      Reviewed By: #engineering, vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6731
      
      GitOrigin-RevId: 7567c601fc4655362bcbf3f3f7f797766a482155
      f925e252
    • Michelle Nguyen's avatar
      PC-663 Add email to segment identify calls · d36a4f5d
      Michelle Nguyen authored
      Summary: when adding users to the ui_prod table in segment, we also want to capture the emails so that we dont have to do extra joins to get that info in bigquery.
      
      Test Plan: n/a
      
      Reviewers: zasgar, nserrino, nick, vihang, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6732
      
      GitOrigin-RevId: 31d52c0822b193928bef72e3eaa07355f154d98d
      d36a4f5d
    • Phillip Kuznetsov's avatar
      Revert "Support ST_TIME_NS semantic type w/ INT64 as an alternative to TIME64NS in the UI." · 9326e32f
      Phillip Kuznetsov authored
      Summary: This reverts commit 01f74ebb2f608c65ddc0f6954d17c67c679a5190. Part of our decision to keep the time type around and instead make it more comp0atible with arrow.
      
      Test Plan: teseted locally and things still work in normal mode.
      
      Reviewers: nick, nserrino, vihang, zasgar, #engineering
      
      Reviewed By: vihang, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6733
      
      GitOrigin-RevId: 872e49dfc79c8c3d6775d3bdc83ef284fddf07b9
      9326e32f
    • Nick Lanam's avatar
      Revert unnecessary change that broke execution stats in the drawer · 301873ab
      Nick Lanam authored
      Summary: What I thought was a harmless Scout Rule change was, in fact, harmful.
      
      Test Plan: Run `px/cluster` with a long start_time, like an hour. Cancel it before it returns. Then try to run `tcp_retransmits` with fresh tracepoints. The visual loading indicator should stick around for the correct duration. This time, also check that execution stats are retained.
      
      Reviewers: michelle, #engineering
      
      Reviewed By: michelle, #engineering
      
      Differential Revision: https://phab.corp.pixielabs.ai/D6734
      
      GitOrigin-RevId: 0bb50d4e49cd8bee1b7dc5fb47a9c9edcc07c3d1
      301873ab