This project is mirrored from https://gitee.com/cowcomic/pixie.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 30 Apr, 2021 2 commits
-
-
Phillip Kuznetsov authored
PC-878: Moving oss_auth to ory_auth and clarify docs to show that skaffold can run multiple profiles non-exclusively Summary: skaffold lets you run multiple profiles so adjusting that. And renaming the oss_auth stuff to ory_auth Test Plan: deployed dev and ory_auth and it worked as intended. Reviewers: vihang, michelle Reviewed By: vihang JIRA Issues: PC-878 Differential Revision: https://phab.corp.pixielabs.ai/D8477 GitOrigin-RevId: ea737d102c9433f681df04c1d3b5a3aeb2483011
-
Phillip Kuznetsov authored
Summary: This reverts commit 6016cb5af425c12dd03635d39abc9bf3b4a19032. Styling was only useful with the rest of the changes. Test Plan: Tested on yarn dev. Reviewers: michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8479 GitOrigin-RevId: 791605b25aba343f2762d9bfbe85de2882ccbbbf
-
- 29 Apr, 2021 15 commits
-
-
Phillip Kuznetsov authored
Summary: revert Test Plan: Test on yarn dev, no problems. Reviewers: michelle, vihang Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8473 GitOrigin-RevId: e30dd8101d65289d8c2955b9d51a9ad2cc3756ae
-
Vihang Mehta authored
Summary: These scripts should fail on encountering an error. Test Plan: N/A Reviewers: philkuz, zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8475 GitOrigin-RevId: d22eeb178adcd63cc8a4f3f8326741ab803dcba2
-
Michelle Nguyen authored
Summary: this broke when i made my namespace changes. the kelvin's mds_addr flag is now only a part of the actual mds address. this should have been updated to use the fully constructed version above. Test Plan: ran skaffold Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8471 GitOrigin-RevId: f240bb9fc5df6323354cffbfa5053275571b84ca
-
Phillip Kuznetsov authored
Summary: sign up page gutter was leaking off the div. This fixes it. Test Plan: yarn dev, style only change Reviewers: nlanam, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8467 GitOrigin-RevId: 6016cb5af425c12dd03635d39abc9bf3b4a19032
-
Vihang Mehta authored
Summary: TSIA, we overuse aliases especially for the leftover code from when our proto naming was not consistent. Now, we can stop aliasing as many things. Test Plan: Existing build and tests. Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8466 GitOrigin-RevId: 67e26155006bde8146866b08f49ab7e464135259
-
Vihang Mehta authored
Summary: TSIA Test Plan: Ran `make help` Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8463 GitOrigin-RevId: b8b8dc5c409122b324e61511056bfb3e2a3cfea5
-
Vihang Mehta authored
Summary: This should work again. Test Plan: Image builds. Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8462 GitOrigin-RevId: 27c59fd4a6edb879444e6753b2305e3f2c80b4b2
-
Omid Azizi authored
Summary: Remove those trackers ReadyForDestruction from the list of trackers, but wait for enough expired trackers to pay the cost of iteratiing and modifying the map. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: jps, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8411 GitOrigin-RevId: da8e9196ccf4bcc6780eed0abca91d7e7f152d38
-
Omid Azizi authored
Summary: Needs a space. Test Plan: Manual Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8458 GitOrigin-RevId: 75c2dd5335898238e14697c75dde8de652cc7dfb
-
Yaxiong Zhao authored
Summary: --sources is repurposed to accept source names --source_group is added to work as the old --sources flag. Test Plan: Manual run stirling_wrapper Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8438 GitOrigin-RevId: 64308654966efe780996d9d10a76b46a6ee5d18a
-
Yaxiong Zhao authored
Summary: This helps quickly identify the logical connection from k8s entities to records. Test Plan: Manually run Reviewers: #stirling, #engineering, philkuz Reviewed By: #engineering, philkuz Differential Revision: https://phab.corp.pixielabs.ai/D8461 GitOrigin-RevId: f9c8e2d02a555f63f720cfc792d9b0b1d8c18bd1
-
Phillip Kuznetsov authored
Summary: This diff sets up user/password for Auth0. Created a new button, use the [[ https://auth0.com/docs/universal-login | Universal Login flow ]], then also needs a signup-complete page that will be redirected from a user's verification link. Note that we have to add special set up for the auth0 account to make sure this flow is secure. Those are documented in this notion doc: https://www.notion.so/pixielabs/Creating-an-auth0-account-and-setting-up-Pixie-47b6fa663da1495cbad474139c747bea Some design decisions: Because we block sign-up until verificaton, we cover org solution for now. Eventually we will need better support for creating orgs, likely something that will look more like Slack's model. Because of this design issue, we do not yet have support for inviting users who have already signed up for their own org. Test Plan: Tested on dev and prod, was able to create a user, get an email verification scheme, then login. Reviewers: michelle, vjain, nlanam Reviewed By: michelle JIRA Issues: PC-863 Differential Revision: https://phab.corp.pixielabs.ai/D8452 GitOrigin-RevId: 1376f2939a6e5bcb9333b34130dc199fac0592e5
-
Natalie Serrino authored
Summary: load_dev_db.sh was failing. It turns out we try to end the kubectl port-forward process twice, once with a TERM signal and once with a KILL signal. In the event that the TERM signal works, the kill command will fail. This diff makes it so that we only escalate to a kill if the TERM didn't work. Test Plan: ran the script, it now succeeds Reviewers: vihang, michelle, philkuz Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8459 GitOrigin-RevId: 7106408c5d71ca20c801b1e62a2f1351e7852ec0
-
Phillip Kuznetsov authored
Summary: cleanup callback code to be a bit more readable. Test Plan: just reorg to be easier to read Reviewers: michelle, nlanam Reviewed By: nlanam Differential Revision: https://phab.corp.pixielabs.ai/D8451 GitOrigin-RevId: c4c3fd1f96ab3ac55e3843ca3014521e45d78942
-
Omid Azizi authored
Summary: This helps avoid iterating through all trackers. The next diff will present an optimization where we reduce the number of iterations through the more expensive map. Test Plan: Existing tests. Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8430 GitOrigin-RevId: 5d8f7a673d3951a09a16f20333b563d086b02436
-
- 28 Apr, 2021 18 commits
-
-
James Bartlett authored
Summary: Turns out sourcegraph's fork has some required patches, so we have to wait until they fix their package to reenable TS LSIF uploads. Test Plan: N/A Reviewers: vihang Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8454 GitOrigin-RevId: 17721d04c05238404cb7d06ff96dacfaced92ee9
-
Michelle Nguyen authored
Summary: our auth flow for unregistered users is broken, since we default to manual token auth if the initial CLI auth fails. instead, we should show the error if the initial CLI auth is an actual authentication error, such as if the user doesnt exist. this required passing some specific error codes through the whole flow so we can distinguish between errors. Test Plan: deployed to staging, ran `px auth login` with an unregistered user. Reviewers: vihang, philkuz Reviewed By: vihang JIRA Issues: PC-866 Differential Revision: https://phab.corp.pixielabs.ai/D8453 GitOrigin-RevId: f67a06314f84e9f0b3a517d18cf63d775c407432
-
James Bartlett authored
Summary: Adds missing libuuid dependency needed for the ANTLR runtime. Things built locally without it b/c I had it installed locally, so I didn't notice until it ran on Jenkins. Test Plan: N/A Reviewers: michelle, vihang Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8450 GitOrigin-RevId: 153ef54475d342bf60ec6b7d5f55a8093ec6fcae
-
Omid Azizi authored
Summary: Move clearing of the perf buffers to StartDataTransferThread(). While not observed in practice, the old version could have been a source of some flakiness in cases where SetUp() and StartDataTransferThread() were separated by enough time. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8448 GitOrigin-RevId: f0c22fa6c0762ec500368177d5b0894507ea817d
-
Vihang Mehta authored
Summary: In D8416 I added a `private` flag to bundle creation. I realized that we shouldn't need the extra flag and can implicily infer script renaming, so this removes the flag. Test Plan: Rebuilt the bundle. Reviewers: zasgar, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8445 GitOrigin-RevId: f3237d5848ed998df9a05a2464c3fa9e7798ae86
-
Omid Azizi authored
Summary: Cleanup based on the new model. Test Plan: Jenkins Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8444 GitOrigin-RevId: f3a9c3ff4c48e5baf67a6e343a7284792d289c37
-
Omid Azizi authored
Summary: Greatly simplify ConnTrackersManager. Test Plan: Existing tests Reviewers: #stirling, yzhao Reviewed By: #stirling, yzhao Subscribers: yzhao Differential Revision: https://phab.corp.pixielabs.ai/D8429 GitOrigin-RevId: 6ff7f47f13cb672e7d7db406568963ecf4cfcb4a
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8413 GitOrigin-RevId: 16757b2c33f5c8cd6ff1893f482b23445f3a503c
-
Natalie Serrino authored
Summary: It now lives in the pixie-labs/grafana-plugin repo, so we will remove it from our repo. Test Plan: n/a Reviewers: vihang, vjain, zasgar, michelle, #third_party_approvers Reviewed By: vihang, zasgar, #third_party_approvers Differential Revision: https://phab.corp.pixielabs.ai/D8442 GitOrigin-RevId: 926eb92a1b8611fd682a22d56e9dcb87ccfc1444
-
Zain Asgar authored
Summary: TSIA Test Plan: N/A Reviewers: michelle, vihang Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8443 GitOrigin-RevId: a4b0793847056d8cc31431793db8f54ac10c55c0
-
Zain Asgar authored
Summary: This adds the -a option which allows the fix to be automaticall fixed. Test Plan: tested on files manually Reviewers: vihang, michelle Reviewed By: michelle Differential Revision: https://phab.corp.pixielabs.ai/D8441 GitOrigin-RevId: 1dcd71451f7189205899b48e2f849b005659577f
-
Yaxiong Zhao authored
Summary: Not complete yet. These are the ones I am familiar with. Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8435 GitOrigin-RevId: ce0a78d1164dd1af884d84a1f0abd0ba6e6a72c6
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8440 GitOrigin-RevId: a82781927f20e39b57649cbdf9dede5a048040bb
-
James Bartlett authored
Summary: Adds third party dependencies needed for mysql and pgsql parsing including the antlr4 runtime cpp library. And the ANTLR grammar files for MYSQL/PostgreSQL. There are non-trivial patches to the grammar files, needed to a) get them to work with c++ and avoid certain macro terms such as LOG/BENCHMARK etc, and b) optimize them slightly to avoid some ambiguites that were significantly increasing parsing times. Test Plan: All targets build successfully (won't work on jenkins until the chef diff lands with docker changes). Functionality of the grammars is tested in a later diff. Reviewers: #third_party_approvers, vihang Reviewed By: #third_party_approvers, vihang Subscribers: vihang JIRA Issues: PP-2687 Differential Revision: https://phab.corp.pixielabs.ai/D8425 GitOrigin-RevId: 1bf53a89387eb4e79de9478f42c8279509327507
-
Vihang Mehta authored
Summary: This restructures how we create script bundles and what data we store in it. The rest of the changes are to read and write this slighlty new bundle format. Test Plan: Ran dev cloud. Created new script bundles. Tested dev UI and dev cli against dev scripts and dev cloud. Reviewers: zasgar, michelle Reviewed By: zasgar Subscribers: nlanam JIRA Issues: PP-2648 Differential Revision: https://phab.corp.pixielabs.ai/D8416 GitOrigin-RevId: 2878fc7f65806436ee3881560cf69d1fada262f8
-
Michelle Nguyen authored
Summary: now that we allow vizier to run in any namespace, we should update the CLI delete/collectLogs command to detect the vizier namespace rather than relying on the user to pass it in as a flag. it does this by searching for any pods with the vizier label. in the future when we have our CRD, this will be a little cleaner since we can just look for the CRD than some random pod. Test Plan: deployed vizier to a non-pl namespace, ran both CLI delete and collectLogs. Reviewers: vihang, zasgar, nserrino Reviewed By: vihang Differential Revision: https://phab.corp.pixielabs.ai/D8436 GitOrigin-RevId: f0e08d6773dafdaa77086eb993fca6e323fc68d9
-
Michelle Nguyen authored
Summary: We want viziers to be deployable to any namespace. this diff templatizes the vizier YAMLS so that the namespace is configurable. For most of our template values, we use `.Values.templateField`. For namespace, we use `.Release.Namespace` so that it works with Helm chart's `--namespace` flag. As a result, this will break existing CLIs, because the new `.Release` field will confuse the templater. However, we should prefer to follow standard conventions. Test Plan: tested that it works in all of the following cases: 1. updating 0.7.1 -> rc (default, old pl namespace) 2. updating rc -> rc (both pl namespace and new namespace) 3. extract yaml (new namespace) 4. helm chart (new namespace) exciting screenshot: {F154569} Reviewers: vihang, zasgar, nserrino Reviewed By: vihang JIRA Issues: PP-2684 Differential Revision: https://phab.corp.pixielabs.ai/D8433 GitOrigin-RevId: 6f46c975739f69506185fa8fa204aef9103c77f7
-
Vihang Mehta authored
Summary: Managing a "public" and internal version of vizierapipb was causing split brain. Our vizier endpoints should be considered public anyway since folks might want to interact with viziers in other ways beyond what we expose from the go/py API. Test Plan: Existing tests. Upgrade on staging Reviewers: zasgar, michelle Reviewed By: michelle JIRA Issues: PP-2661 Differential Revision: https://phab.corp.pixielabs.ai/D8418 GitOrigin-RevId: 66a4a59329ad8f2f8c3a0fb50e45ed6fef00999a
-
- 27 Apr, 2021 5 commits
-
-
Nick Lanam authored
Summary: Title. We weren't importing it correctly, so it never ran. We also never set up its configuration, so trying to use it also didn't work without extra code. Now, you can do this: ``` const MyComponent = () => (<div>I am a function component!</div>); // This causes console logs whenever MyComponent re-renders for suspicious reasons. // For example, when it re-renders because its props object changed, yet the props themselves did not. MyComponent.whyDidYouRender = true; // Can also do: MyComponent.whyDidYouRender = { customName: 'Short Name' }; // See https://github.com/welldone-software/why-did-you-render for details. ``` Test Plan: Try the above sample on a component that has currently-unresolved performance problems, such as `ScriptContextProvider`. The console will flood with logs showing why it re-renders so frequently. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-867 Differential Revision: https://phab.corp.pixielabs.ai/D8432 ...
-
Vihang Mehta authored
Summary: I failed at pointers and closures in for loops. Sigh. Test Plan: Ran licenses tool, checked manual licenses. Reviewers: jamesbartlett Reviewed By: jamesbartlett Differential Revision: https://phab.corp.pixielabs.ai/D8434 GitOrigin-RevId: 8c61de1c9c75f1dd640b2c72e80c687cacd7c106
-
Michelle Nguyen authored
Summary: now that we're updating vizier so that it can be deployed to any namespace, we should follow helm chart conventions a little better. in general, namespaces are not created in the helm charts. it can be created using the --create-namespace flag on the helm command or should already exist. this diff updates the generated template so that it no longer includes the namespace resource. if theyre deploying through helm, helm will handle the namespace for them. if they're deploying through --extract_yamls, we can probably assume that they know how to create their own namespace first. if deploying through the CLI, we can still create the namespace for them if needed. Note: This will break new Vizier releases for older CLIs, since the old CLIs will still want the namespace YAML! however, more breaking changes are coming in followup diffs, so it's probably not worth extra changes to make sure this doesn't break old CLIs. Test Plan: ran `px deploy` with/without existing pl namespace. Reviewers: vihang, zasgar, nserrino Reviewed By: vihang JIRA Issues: PP-2684 Differential Revision: https://phab.corp.pixielabs.ai/D8431 GitOrigin-RevId: b170e1ed0e4a6a85ba7b081c1309a667225dfeed
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, jps Reviewed By: #stirling, jps Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8415 GitOrigin-RevId: 97e9ec09292da60e577fccecc8d51d43ca004c7e
-
Yaxiong Zhao authored
Test Plan: Jenkins Reviewers: #stirling, oazizi Reviewed By: #stirling, oazizi Subscribers: oazizi Differential Revision: https://phab.corp.pixielabs.ai/D8414 GitOrigin-RevId: d5adb73f9d539633f3b26086fb65cb3acc0b8b4c
-