This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 30 Apr, 2021 2 commits
  2. 29 Apr, 2021 15 commits
  3. 28 Apr, 2021 18 commits
    • James Bartlett's avatar
      Disabling TS sourcegraph upload. · 30826662
      James Bartlett authored
      Summary: Turns out sourcegraph's fork has some required patches, so we have to wait until they fix their package to reenable TS LSIF uploads.
      
      Test Plan: N/A
      
      Reviewers: vihang
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8454
      
      GitOrigin-RevId: 17721d04c05238404cb7d06ff96dacfaced92ee9
      30826662
    • Michelle Nguyen's avatar
      PC-866 Fix auth flow for unregistered users authenticating CLI · a4b486b2
      Michelle Nguyen authored
      Summary:
      our auth flow for unregistered users is broken, since we default to manual token auth if the initial CLI auth fails.
      instead, we should show the error if the initial CLI auth is an actual authentication error, such as if the user doesnt exist.
      this required passing some specific error codes through the whole flow so we can distinguish between errors.
      
      Test Plan: deployed to staging, ran `px auth login` with an unregistered user.
      
      Reviewers: vihang, philkuz
      
      Reviewed By: vihang
      
      JIRA Issues: PC-866
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8453
      
      GitOrigin-RevId: f67a06314f84e9f0b3a517d18cf63d775c407432
      a4b486b2
    • James Bartlett's avatar
      [SQL Normalization] Add missing dependency for ANTLR4 · 4e38b9cc
      James Bartlett authored
      Summary: Adds missing libuuid dependency needed for the ANTLR runtime. Things built locally without it b/c I had it installed locally, so I didn't notice until it ran on Jenkins.
      
      Test Plan: N/A
      
      Reviewers: michelle, vihang
      
      Reviewed By: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8450
      
      GitOrigin-RevId: 153ef54475d342bf60ec6b7d5f55a8093ec6fcae
      4e38b9cc
    • Omid Azizi's avatar
      SocketTraceBPFTest fixture: Timing of perf buffer drain · 43ca4bf9
      Omid Azizi authored
      Summary:
      Move clearing of the perf buffers to StartDataTransferThread().
      
      While not observed in practice, the old version could have been a source of some flakiness
      in cases where SetUp() and StartDataTransferThread() were separated by enough time.
      
      Test Plan: Existing tests
      
      Reviewers: #stirling, yzhao
      
      Reviewed By: #stirling, yzhao
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8448
      
      GitOrigin-RevId: f0c22fa6c0762ec500368177d5b0894507ea817d
      43ca4bf9
    • Vihang Mehta's avatar
      Implicilty infer bundle and script names · a98a96e6
      Vihang Mehta authored
      Summary:
      In D8416 I added a `private` flag to bundle creation. I realized that
      we shouldn't need the extra flag and can implicily infer script renaming, so
      this removes the flag.
      
      Test Plan: Rebuilt the bundle.
      
      Reviewers: zasgar, michelle
      
      Reviewed By: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8445
      
      GitOrigin-RevId: f3237d5848ed998df9a05a2464c3fa9e7798ae86
      a98a96e6
    • Omid Azizi's avatar
      [Cleanup] StartTransferDataThread · 5b8ce87a
      Omid Azizi authored
      Summary: Cleanup based on the new model.
      
      Test Plan: Jenkins
      
      Reviewers: #stirling, yzhao
      
      Reviewed By: #stirling, yzhao
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8444
      
      GitOrigin-RevId: f3a9c3ff4c48e5baf67a6e343a7284792d289c37
      5b8ce87a
    • Omid Azizi's avatar
      SocketTracer: Deprecate old TransferData and remove unused vestiges · 6b4e5266
      Omid Azizi authored
      Summary: Greatly simplify ConnTrackersManager.
      
      Test Plan: Existing tests
      
      Reviewers: #stirling, yzhao
      
      Reviewed By: #stirling, yzhao
      
      Subscribers: yzhao
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8429
      
      GitOrigin-RevId: 6ff7f47f13cb672e7d7db406568963ecf4cfcb4a
      6b4e5266
    • Yaxiong Zhao's avatar
      Change SeqGenConnector to output to multiple data tables · f0fc22eb
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: #stirling, oazizi
      
      Reviewed By: #stirling, oazizi
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8413
      
      GitOrigin-RevId: 16757b2c33f5c8cd6ff1893f482b23445f3a503c
      f0fc22eb
    • Natalie Serrino's avatar
      Remove Grafana plugin from main Pixie repo · cb375316
      Natalie Serrino authored
      Summary: It now lives in the pixie-labs/grafana-plugin repo, so we will remove it from our repo.
      
      Test Plan: n/a
      
      Reviewers: vihang, vjain, zasgar, michelle, #third_party_approvers
      
      Reviewed By: vihang, zasgar, #third_party_approvers
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8442
      
      GitOrigin-RevId: 926eb92a1b8611fd682a22d56e9dcb87ccfc1444
      cb375316
    • Zain Asgar's avatar
      Add s?css support in license checker · 4b81a3c1
      Zain Asgar authored
      Summary: TSIA
      
      Test Plan: N/A
      
      Reviewers: michelle, vihang
      
      Reviewed By: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8443
      
      GitOrigin-RevId: a4b0793847056d8cc31431793db8f54ac10c55c0
      4b81a3c1
    • Zain Asgar's avatar
      Add option to fix file in license checker and fix usage command · 0f293e2b
      Zain Asgar authored
      Summary: This adds the -a option which allows the fix to be automaticall fixed.
      
      Test Plan: tested on files manually
      
      Reviewers: vihang, michelle
      
      Reviewed By: michelle
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8441
      
      GitOrigin-RevId: 1dcd71451f7189205899b48e2f849b005659577f
      0f293e2b
    • Yaxiong Zhao's avatar
      [CLEANUP] Add README.md for source connectors · f8b95ede
      Yaxiong Zhao authored
      Summary: Not complete yet. These are the ones I am familiar with.
      
      Test Plan: Jenkins
      
      Reviewers: #stirling, oazizi
      
      Reviewed By: #stirling, oazizi
      
      Subscribers: oazizi
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8435
      
      GitOrigin-RevId: ce0a78d1164dd1af884d84a1f0abd0ba6e6a72c6
      f8b95ede
    • Yaxiong Zhao's avatar
      Set sampling and push period for source connectors that output to multiple data tables · 4d594ca6
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: #stirling, oazizi
      
      Reviewed By: #stirling, oazizi
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8440
      
      GitOrigin-RevId: a82781927f20e39b57649cbdf9dede5a048040bb
      4d594ca6
    • James Bartlett's avatar
      [SQL Normalization] Add ANTLR parser runtime, and ANTLR grammars for MySQL/PostgreSQL. · 09d607cd
      James Bartlett authored
      Summary:
      Adds third party dependencies needed for mysql and pgsql parsing including the antlr4 runtime cpp library. And the ANTLR grammar files for MYSQL/PostgreSQL.
      There are non-trivial patches to the grammar files, needed to a) get them to work with c++ and avoid certain macro terms such as LOG/BENCHMARK etc, and b) optimize them slightly to avoid some ambiguites that were significantly increasing parsing times.
      
      Test Plan:
      All targets build successfully (won't work on jenkins until the chef diff lands with docker changes).
      Functionality of the grammars is tested in a later diff.
      
      Reviewers: #third_party_approvers, vihang
      
      Reviewed By: #third_party_approvers, vihang
      
      Subscribers: vihang
      
      JIRA Issues: PP-2687
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8425
      
      GitOrigin-RevId: 1bf53a89387eb4e79de9478f42c8279509327507
      09d607cd
    • Vihang Mehta's avatar
      Rename scripts bundles to cleanup some metadata · 1c8f703f
      Vihang Mehta authored
      Summary:
      This restructures how we create script bundles and what data we store
      in it. The rest of the changes are to read and write this slighlty new bundle
      format.
      
      Test Plan:
      Ran dev cloud. Created new script bundles. Tested dev UI and dev cli
      against dev scripts and dev cloud.
      
      Reviewers: zasgar, michelle
      
      Reviewed By: zasgar
      
      Subscribers: nlanam
      
      JIRA Issues: PP-2648
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8416
      
      GitOrigin-RevId: 2878fc7f65806436ee3881560cf69d1fada262f8
      1c8f703f
    • Michelle Nguyen's avatar
      PP-2684 Update CLI delete/collectLogs to detect vizier namespace · b27b4961
      Michelle Nguyen authored
      Summary:
      now that we allow vizier to run in any namespace, we should update the CLI delete/collectLogs command to detect the vizier namespace rather than relying on the user to pass it in as a flag.
      it does this by searching for any pods with the vizier label. in the future when we have our CRD, this will be a little cleaner since we can just look for the CRD than some random pod.
      
      Test Plan: deployed vizier to a non-pl namespace, ran both CLI delete and collectLogs.
      
      Reviewers: vihang, zasgar, nserrino
      
      Reviewed By: vihang
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8436
      
      GitOrigin-RevId: f0e08d6773dafdaa77086eb993fca6e323fc68d9
      b27b4961
    • Michelle Nguyen's avatar
      PP-2684 Update vizier templates to allow deploying in any namespace · 02501f16
      Michelle Nguyen authored
      Summary:
      We want viziers to be deployable to any namespace. this diff templatizes the vizier YAMLS so that the namespace is configurable.
      For most of our template values, we use `.Values.templateField`. For namespace, we use `.Release.Namespace` so that it works with Helm chart's `--namespace` flag.
      As a result, this will break existing CLIs, because the new `.Release` field will confuse the templater. However, we should prefer to follow standard conventions.
      
      Test Plan:
      tested that it works in all of the following cases:
      1. updating 0.7.1 -> rc (default, old pl namespace)
      2. updating rc -> rc (both pl namespace and new namespace)
      3. extract yaml (new namespace)
      4. helm chart (new namespace)
      exciting screenshot:
      {F154569}
      
      Reviewers: vihang, zasgar, nserrino
      
      Reviewed By: vihang
      
      JIRA Issues: PP-2684
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8433
      
      GitOrigin-RevId: 6f46c975739f69506185fa8fa204aef9103c77f7
      02501f16
    • Vihang Mehta's avatar
      Combine public and internal vizier protos into one · b389e759
      Vihang Mehta authored
      Summary:
      Managing a "public" and internal version of vizierapipb was causing
      split brain. Our vizier endpoints should be considered public anyway since folks
      might want to interact with viziers in other ways beyond what we expose
      from the go/py API.
      
      Test Plan: Existing tests. Upgrade on staging
      
      Reviewers: zasgar, michelle
      
      Reviewed By: michelle
      
      JIRA Issues: PP-2661
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8418
      
      GitOrigin-RevId: 66a4a59329ad8f2f8c3a0fb50e45ed6fef00999a
      b389e759
  4. 27 Apr, 2021 5 commits
    • Nick Lanam's avatar
      [PC-867] Fix `why-did-you-render` import · 274da7e3
      Nick Lanam authored
      Summary:
      Title. We weren't importing it correctly, so it never ran. We also never set up its configuration, so trying to use it also didn't work without extra code. Now, you can do this:
      ```
      const MyComponent = () => (<div>I am a function component!</div>);
      // This causes console logs whenever MyComponent re-renders for suspicious reasons.
      // For example, when it re-renders because its props object changed, yet the props themselves did not.
      MyComponent.whyDidYouRender = true;
      // Can also do: MyComponent.whyDidYouRender = { customName: 'Short Name' };
      // See https://github.com/welldone-software/why-did-you-render for details.
      ```
      
      Test Plan: Try the above sample on a component that has currently-unresolved performance problems, such as `ScriptContextProvider`. The console will flood with logs showing why it re-renders so frequently.
      
      Reviewers: michelle, vihang
      
      Reviewed By: michelle
      
      JIRA Issues: PC-867
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8432
      
      ...
      274da7e3
    • Vihang Mehta's avatar
      Fix manual license fetching · a4339fc8
      Vihang Mehta authored
      Summary: I failed at pointers and closures in for loops. Sigh.
      
      Test Plan: Ran licenses tool, checked manual licenses.
      
      Reviewers: jamesbartlett
      
      Reviewed By: jamesbartlett
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8434
      
      GitOrigin-RevId: 8c61de1c9c75f1dd640b2c72e80c687cacd7c106
      a4339fc8
    • Michelle Nguyen's avatar
      PP-2684 Don't include namespace in helm chart/extracted YAMLs · fd1b58c0
      Michelle Nguyen authored
      Summary:
      now that we're updating vizier so that it can be deployed to any namespace, we should follow helm chart conventions a little better.
      in general, namespaces are not created in the helm charts. it can be created using the --create-namespace flag on the helm command or should already exist.
      
      this diff updates the generated template so that it no longer includes the namespace resource. if theyre deploying through helm, helm will handle the namespace for them. if they're deploying through --extract_yamls, we can probably assume that they know how to create their own namespace first.
      
      if deploying through the CLI, we can still create the namespace for them if needed.
      
      Note: This will break new Vizier releases for older CLIs, since the old CLIs will still want the namespace YAML! however, more breaking changes are coming in followup diffs, so it's probably not worth extra changes to make sure this doesn't break old CLIs.
      
      Test Plan: ran `px deploy` with/without existing pl namespace.
      
      Reviewers: vihang, zasgar, nserrino
      
      Reviewed By: vihang
      
      JIRA Issues: PP-2684
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8431
      
      GitOrigin-RevId: b170e1ed0e4a6a85ba7b081c1309a667225dfeed
      fd1b58c0
    • Yaxiong Zhao's avatar
      Change PIDRuntimeConnector to output multiple data tables · 2c5b9ff3
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: #stirling, jps
      
      Reviewed By: #stirling, jps
      
      Subscribers: oazizi
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8415
      
      GitOrigin-RevId: 97e9ec09292da60e577fccecc8d51d43ca004c7e
      2c5b9ff3
    • Yaxiong Zhao's avatar
      Change SystemStatsConnector to output to multiple data tables · 0ccfb8e7
      Yaxiong Zhao authored
      Test Plan: Jenkins
      
      Reviewers: #stirling, oazizi
      
      Reviewed By: #stirling, oazizi
      
      Subscribers: oazizi
      
      Differential Revision: https://phab.corp.pixielabs.ai/D8414
      
      GitOrigin-RevId: d5adb73f9d539633f3b26086fb65cb3acc0b8b4c
      0ccfb8e7