Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://gitee.com/cowcomic/pixie.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 21 Jun, 2022 7 commits
    • Nick Lanam's avatar
      Fix link that breaks out of embed · 13d4fac8
      Nick Lanam authored 
      
Summary: Viewing cron history and then trying the back link was escaping the embed. Now it's a relative link.

Test Plan:
Visit `/configure-data-export`. View a script's history, then click the icon in the top left to go back. It should still do so.
Embed the same view (`/embed/configure-data-export`). Do the same thing. It should work and not break out of the embedded mode.

Reviewers: michelle, vihang

Reviewed By: vihang
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11646

GitOrigin-RevId: 3b76b2b1dcb27aa9041bfdf80014e2d45480b0e7
      13d4fac8
    • Phillip Kuznetsov's avatar
      Improve px/cluster functions based on process_stats · 75c8222b
      Phillip Kuznetsov authored 
      
Summary:
This diff improves the px/cluster process_stats scripts to reduce computation and re-use
a table value.

I discovered these opportunities writing the export script for px/cluster.
The difference is large, from exectime running against staging.
*Before:*
```
+------------+-------------------+----------------------+----------------------+---------------------+------------+
|    NAME    | COMPILATION TIME  | EXEC TIME: EXTERNAL  | EXEC TIME: INTERNAL  |      NUM BYTES      | NUM ERRORS |
+------------+-------------------+----------------------+----------------------+---------------------+------------+
| px/cluster | 37.55ms +/- 2.9ms | 899.09ms +/- 24.11ms | 801.11ms +/- 24.15ms | 77654.80 +/- 435.48 |          0 |
+------------+-------------------+----------------------+----------------------+---------------------+------------+
```
*After:*
```
+------------+--------------------+----------------------+---------------------+---------------------+------------+
|    NAME    |  COMPILATION TIME  | EXEC TIME: EXTERNAL  | EXEC TIME: INTERNAL |      NUM BYTES      | NUM ERRORS |
+------------+--------------------+----------------------+---------------------+---------------------+------------+
| px/cluster | 51.12ms +/- 3.32ms | 395.75ms +/- 10.26ms | 284.5ms +/- 8.52ms  | 78756.50 +/- 325.19 |          0 |
+------------+--------------------+----------------------+---------------------+---------------------+------------+
```

Test Plan:
Ran the changed functions and compared them to the old results to confirm
they lined up results

Reviewers: vihang, michelle, jamesbartlett

Reviewed By: jamesbartlett
Signed-off-by: default avatarPhillip Kuznetsov <pkuznetsov@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11633

GitOrigin-RevId: 01e031aef4d8752b27643b30d41f00f4fb122ec1
      75c8222b
    • Nick Lanam's avatar
      [PC-1543]: Always show tooltips on data table headers · ebc2d4bc
      Nick Lanam authored 
      
Summary: They were previously only showing if the text wasn't already fully visible. This was slightly more confusing than showing them anyway.

Test Plan:
Run any script or look at data export history or the script drawer (anywhere with a `<DataTable>`).
Tooltips should appear on hover of any header cell, even if it's wide enough to already show the full text.
Previously, it would only appear if the text wasn't already fully visible.

Reviewers: michelle, vihang, zasgar

Reviewed By: vihang

JIRA Issues: PC-1543
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11643

GitOrigin-RevId: 5aea3a74effdb7401b82f3010fe768998df4e074
      ebc2d4bc
    • Ryan Cheng's avatar
      Add PL_COVERAGE to failing tests compiled with gcc · 422637e6
      Ryan Cheng authored 
      
Summary: We moved to a deterministic containerized build previously and `PL_COVERAGE` ifdefs were removed in D10602. In D11586, container build was removed. This diff adds back some of the `PL_COVERAGE` to make sure the tests still pass when built with gcc.

Test Plan: Updated tests

Reviewers: #stirling, oazizi

Reviewed By: #stirling, oazizi

Subscribers: oazizi
Signed-off-by: default avatarRyan Cheng <rcheng@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11632

GitOrigin-RevId: dc15bac3013c57e9e07f882a332636c48870ed66
      422637e6
    • Nick Lanam's avatar
      [PP-3380]: Show cron history for export scripts · 9ac7d7ca
      Nick Lanam authored 
      
Summary:
Adds a new view for export scripts to show their recent run history.

{F188001}

Test Plan:
Visit `/configure-data-export`. For various scripts:
- Click the new history icon next to the edit icon to veiw logs
- Try clicking several clusters in the dropdown to see their history
- Loading state should be visible
- Error states should present clearly
- If a cluster has never run the selected script, a message explaining
  such appears
- If a cluster HAS run the selected script, you get a full data table
  with the details
- The top left corner of the page has a back button to return to the
  script list
- The center of the top of the page shows the plugin name and icon as
  weell as the script that you're viewing

Reviewers: michelle, vihang, philkuz

Reviewed By: philkuz

Subscribers: philkuz

JIRA Issues: PP-3380
Signed-off-by: default avatarNick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11610

GitOrigin-RevId: 1a93fb1ce79c26ef1645684b8dd75c62f28b1cce
      9ac7d7ca
    • Pete Stevenson's avatar
      PerfProfiler: enable Java symbolization by default. · fad24f10
      Pete Stevenson authored 
      
Summary: We enable Java symbolization by default, and switch the skaffold profile from 'jsyms' to 'no-jsyms'.

Test Plan: Tested one-off on dev. cluster.

Reviewers: #stirling, oazizi

Reviewed By: #stirling, oazizi
Signed-off-by: default avatarPete Stevenson <jps@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11597

GitOrigin-RevId: 774da6909507cd3e7a73e4159d9b170d07511824
      fad24f10
    • Vihang Mehta's avatar
      Tell OpenSSL to explicitly use SHA256 for the digest · 5087a573
      Vihang Mehta authored 
      
Summary:
openssl defaults to sha1 on some systems and go 1.18 rejects these
certs. So let's be super explicit and request sha256 certs.

Test Plan:
Ran the create_cloud_secrets script and ensured that certs are still
generated as expected.

Reviewers: zasgar, michelle

Reviewed By: michelle
Signed-off-by: default avatarVihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11641

GitOrigin-RevId: 54e8ba703e6a70d6a2bc4e2a5c26be99ba49a25d
      5087a573
  3. 20 Jun, 2022 1 commit
  5. 18 Jun, 2022 5 commits
  7. 17 Jun, 2022 9 commits
  9. 16 Jun, 2022 18 commits

免费DevSecOps平台，让您的项目体验完整的DevSecOps流程，让项目更安全